diff options
| author | Carl Hetherington <cth@carlh.net> | 2021-12-18 15:10:10 +0100 |
|---|---|---|
| committer | Carl Hetherington <cth@carlh.net> | 2021-12-18 15:10:36 +0100 |
| commit | bba9cd814b189f6458dee4a109369a7d4ae0e3ce (patch) | |
| tree | 1cd7ad7f14329fee1cb96184a7da94b54c2fe83e /test | |
| parent | 9ebbeae21efe950c4f18a9f959a8fe9f0be4e8f4 (diff) | |
Cleanup: remove unnecessary parameter to PlayerVideo::force().
Diffstat (limited to 'test')
| -rw-r--r-- | test/butler_test.cc | 3 | ||||
| -rw-r--r-- | test/dcp_playback_test.cc | 5 | ||||
| -rw-r--r-- | test/player_test.cc | 10 |
3 files changed, 10 insertions, 8 deletions
diff --git a/test/butler_test.cc b/test/butler_test.cc index 3d524a3b2..f1ee44643 100644 --- a/test/butler_test.cc +++ b/test/butler_test.cc @@ -32,6 +32,7 @@ using std::make_shared; using std::shared_ptr; +using boost::bind; #if BOOST_VERSION >= 106100 using namespace boost::placeholders; #endif @@ -59,7 +60,7 @@ BOOST_AUTO_TEST_CASE (butler_test1) map.set (i, i, 1); } - Butler butler (film, make_shared<Player>(film, Image::Alignment::COMPACT), map, 6, bind(&PlayerVideo::force, _1, AV_PIX_FMT_RGB24), VideoRange::FULL, Image::Alignment::COMPACT, false, false); + Butler butler (film, make_shared<Player>(film, Image::Alignment::COMPACT), map, 6, bind(&PlayerVideo::force, AV_PIX_FMT_RGB24), VideoRange::FULL, Image::Alignment::COMPACT, false, false); BOOST_CHECK (butler.get_video(Butler::Behaviour::BLOCKING, 0).second == DCPTime()); BOOST_CHECK (butler.get_video(Butler::Behaviour::BLOCKING, 0).second == DCPTime::from_frames(1, 24)); diff --git a/test/dcp_playback_test.cc b/test/dcp_playback_test.cc index 5117be9ed..032d1d90d 100644 --- a/test/dcp_playback_test.cc +++ b/test/dcp_playback_test.cc @@ -29,6 +29,7 @@ using std::make_shared; using std::make_shared; +using boost::bind; #if BOOST_VERSION >= 106100 using namespace boost::placeholders; #endif @@ -48,7 +49,7 @@ BOOST_AUTO_TEST_CASE (dcp_playback_test) make_shared<Player>(film, Image::Alignment::PADDED), AudioMapping(6, 6), 6, - bind(&PlayerVideo::force, _1, AV_PIX_FMT_RGB24), + bind(&PlayerVideo::force, AV_PIX_FMT_RGB24), VideoRange::FULL, Image::Alignment::PADDED, true, @@ -63,6 +64,6 @@ BOOST_AUTO_TEST_CASE (dcp_playback_test) } /* assuming DCP is 24fps/48kHz */ butler->get_audio (Butler::Behaviour::BLOCKING, audio_buffer.data(), 2000); - p.first->image(bind(&PlayerVideo::force, _1, AV_PIX_FMT_RGB24), VideoRange::FULL, true); + p.first->image(bind(&PlayerVideo::force, AV_PIX_FMT_RGB24), VideoRange::FULL, true); } } diff --git a/test/player_test.cc b/test/player_test.cc index cafb14586..79170611c 100644 --- a/test/player_test.cc +++ b/test/player_test.cc @@ -233,7 +233,7 @@ BOOST_AUTO_TEST_CASE (player_seek_test) player->set_always_burn_open_subtitles (); player->set_play_referenced (); - auto butler = std::make_shared<Butler>(film, player, AudioMapping(), 2, bind(PlayerVideo::force, _1, AV_PIX_FMT_RGB24), VideoRange::FULL, Image::Alignment::PADDED, true, false); + auto butler = std::make_shared<Butler>(film, player, AudioMapping(), 2, bind(PlayerVideo::force, AV_PIX_FMT_RGB24), VideoRange::FULL, Image::Alignment::PADDED, true, false); butler->disable_audio(); for (int i = 0; i < 10; ++i) { @@ -241,7 +241,7 @@ BOOST_AUTO_TEST_CASE (player_seek_test) butler->seek (t, true); auto video = butler->get_video(Butler::Behaviour::BLOCKING, 0); BOOST_CHECK_EQUAL(video.second.get(), t.get()); - write_image(video.first->image(bind(PlayerVideo::force, _1, AV_PIX_FMT_RGB24), VideoRange::FULL, true), String::compose("build/test/player_seek_test_%1.png", i)); + write_image(video.first->image(bind(PlayerVideo::force, AV_PIX_FMT_RGB24), VideoRange::FULL, true), String::compose("build/test/player_seek_test_%1.png", i)); /* This 14.08 is empirically chosen (hopefully) to accept changes in rendering between the reference and a test machine (17.10 and 16.04 seem to anti-alias a little differently) but to reject gross errors e.g. missing fonts or missing text altogether. @@ -265,7 +265,7 @@ BOOST_AUTO_TEST_CASE (player_seek_test2) player->set_always_burn_open_subtitles (); player->set_play_referenced (); - auto butler = std::make_shared<Butler>(film, player, AudioMapping(), 2, bind(PlayerVideo::force, _1, AV_PIX_FMT_RGB24), VideoRange::FULL, Image::Alignment::PADDED, true, false); + auto butler = std::make_shared<Butler>(film, player, AudioMapping(), 2, bind(PlayerVideo::force, AV_PIX_FMT_RGB24), VideoRange::FULL, Image::Alignment::PADDED, true, false); butler->disable_audio(); butler->seek(DCPTime::from_seconds(5), true); @@ -276,7 +276,7 @@ BOOST_AUTO_TEST_CASE (player_seek_test2) auto video = butler->get_video(Butler::Behaviour::BLOCKING, 0); BOOST_CHECK_EQUAL(video.second.get(), t.get()); write_image( - video.first->image(bind(PlayerVideo::force, _1, AV_PIX_FMT_RGB24), VideoRange::FULL, true), String::compose("build/test/player_seek_test2_%1.png", i) + video.first->image(bind(PlayerVideo::force, AV_PIX_FMT_RGB24), VideoRange::FULL, true), String::compose("build/test/player_seek_test2_%1.png", i) ); check_image(TestPaths::private_data() / String::compose("player_seek_test2_%1.png", i), String::compose("build/test/player_seek_test2_%1.png", i), 14.08); } @@ -356,7 +356,7 @@ BOOST_AUTO_TEST_CASE (player_trim_crash) auto player = std::make_shared<Player>(film, Image::Alignment::COMPACT); player->set_fast (); - auto butler = std::make_shared<Butler>(film, player, AudioMapping(), 6, bind(&PlayerVideo::force, _1, AV_PIX_FMT_RGB24), VideoRange::FULL, Image::Alignment::COMPACT, true, false); + auto butler = std::make_shared<Butler>(film, player, AudioMapping(), 6, bind(&PlayerVideo::force, AV_PIX_FMT_RGB24), VideoRange::FULL, Image::Alignment::COMPACT, true, false); /* Wait for the butler to fill */ dcpomatic_sleep_seconds (5); |
