diff options
| author | Carl Hetherington <cth@carlh.net> | 2018-07-17 22:03:45 +0000 |
|---|---|---|
| committer | Carl Hetherington <cth@carlh.net> | 2018-07-17 22:03:45 +0000 |
| commit | 46d89e9f754c50712e8983ae5c86bbb0a6cf4362 (patch) | |
| tree | 3ea5ac08be47bc16a21b0df68eb256604c6af6d6 /test | |
| parent | 4f083917cfe9fc15249bfd4b36f723b604173d16 (diff) | |
More test fixes.
Diffstat (limited to 'test')
| m--------- | test/data | 0 | ||||
| -rw-r--r-- | test/image_test.cc | 4 | ||||
| -rw-r--r-- | test/player_test.cc | 5 | ||||
| -rw-r--r-- | test/test.cc | 4 | ||||
| -rw-r--r-- | test/test.h | 2 |
5 files changed, 8 insertions, 7 deletions
diff --git a/test/data b/test/data -Subproject 1ca4c6914264f433f3e76f193828793c0d27a62 +Subproject e5472ceee4b68737cdf10157c6a5d2018c98e66 diff --git a/test/image_test.cc b/test/image_test.cc index 5adc35603..28afbe840 100644 --- a/test/image_test.cc +++ b/test/image_test.cc @@ -174,7 +174,7 @@ alpha_blend_test_one (AVPixelFormat format, string suffix) shared_ptr<Image> save = background->convert_pixel_format (dcp::YUV_TO_RGB_REC709, AV_PIX_FMT_RGB24, false, false); write_image (save, "build/test/image_test_" + suffix + ".png", "RGB"); - check_image ("build/test/image_test_" + suffix + ".png", private_data / ("image_test_" + suffix + ".png")); + check_image ("build/test/image_test_" + suffix + ".png", private_data / ("image_test_" + suffix + ".png"), 0.01); } /** Test Image::alpha_blend */ @@ -265,5 +265,5 @@ BOOST_AUTO_TEST_CASE (crop_scale_window_test) shared_ptr<Image> out = raw->crop_scale_window(Crop(), dcp::Size(1998, 836), dcp::Size(1998, 1080), dcp::YUV_TO_RGB_REC709, AV_PIX_FMT_YUV420P, true, false); shared_ptr<Image> save = out->scale(dcp::Size(1998, 1080), dcp::YUV_TO_RGB_REC709, AV_PIX_FMT_RGB24, false, false); write_image(save, "build/test/crop_scale_window_test.png", "RGB"); - check_image("test/data/crop_scale_window_test.png", "build/test/crop_scale_window_test.png"); + check_image("test/data/crop_scale_window_test.png", "build/test/crop_scale_window_test.png", 0.01); } diff --git a/test/player_test.cc b/test/player_test.cc index e22570bc0..865fbef45 100644 --- a/test/player_test.cc +++ b/test/player_test.cc @@ -227,7 +227,7 @@ BOOST_AUTO_TEST_CASE (player_seek_test) pair<shared_ptr<PlayerVideo>, DCPTime> video = butler->get_video(); BOOST_CHECK_EQUAL(video.second.get(), t.get()); write_image(video.first->image(note_handler, PlayerVideo::always_rgb, false, true), String::compose("build/test/player_seek_test_%1.png", i), "RGB"); - check_image(String::compose("test/data/player_seek_test_%1.png", i), String::compose("build/test/player_seek_test_%1.png", i)); + check_image(String::compose("test/data/player_seek_test_%1.png", i), String::compose("build/test/player_seek_test_%1.png", i), 0.01); } } @@ -256,6 +256,7 @@ BOOST_AUTO_TEST_CASE (player_seek_test2) pair<shared_ptr<PlayerVideo>, DCPTime> video = butler->get_video(); BOOST_CHECK_EQUAL(video.second.get(), t.get()); write_image(video.first->image(note_handler, PlayerVideo::always_rgb, false, true), String::compose("build/test/player_seek_test2_%1.png", i), "RGB"); - check_image(String::compose("test/data/player_seek_test2_%1.png", i), String::compose("build/test/player_seek_test2_%1.png", i)); + /* Differences in font rendering appear here sometimes */ + check_image(String::compose("test/data/player_seek_test2_%1.png", i), String::compose("build/test/player_seek_test2_%1.png", i), 0.015); } } diff --git a/test/test.cc b/test/test.cc index f829a86f6..b0bd0bda7 100644 --- a/test/test.cc +++ b/test/test.cc @@ -231,7 +231,7 @@ check_mxf_audio_file (boost::filesystem::path ref, boost::filesystem::path check } void -check_image (boost::filesystem::path ref, boost::filesystem::path check) +check_image (boost::filesystem::path ref, boost::filesystem::path check, double dist_tolerance) { #ifdef DCPOMATIC_IMAGE_MAGICK using namespace MagickCore; @@ -248,7 +248,7 @@ check_image (boost::filesystem::path ref, boost::filesystem::path check) */ #ifdef DCPOMATIC_ADVANCED_MAGICK_COMPARE double const dist = ref_image.compare(check_image, Magick::RootMeanSquaredErrorMetric); - BOOST_CHECK_MESSAGE (dist < 0.01, ref << " differs from " << check << " " << dist); + BOOST_CHECK_MESSAGE (dist < dist_tolerance, ref << " differs from " << check << " " << dist); #else BOOST_CHECK_MESSAGE (!ref_image.compare(check_image), ref << " differs from " << check); #endif diff --git a/test/test.h b/test/test.h index 78fa26b43..2f2062692 100644 --- a/test/test.h +++ b/test/test.h @@ -36,7 +36,7 @@ extern void check_mxf_audio_file (boost::filesystem::path ref, boost::filesystem extern void check_xml (boost::filesystem::path, boost::filesystem::path, std::list<std::string>); extern void check_file (boost::filesystem::path, boost::filesystem::path); extern void check_ffmpeg (boost::filesystem::path, boost::filesystem::path, int audio_tolerance); -extern void check_image (boost::filesystem::path, boost::filesystem::path); +extern void check_image (boost::filesystem::path, boost::filesystem::path, double dist_tolerance); extern boost::filesystem::path test_film_dir (std::string); extern void write_image (boost::shared_ptr<const Image> image, boost::filesystem::path file, std::string format); boost::filesystem::path dcp_file (boost::shared_ptr<const Film> film, std::string prefix); |
