summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-12-13Fix errors on startup of dcpomatic_kdm on GTK3 platforms.v2.14.47Carl Hetherington
2020-11-28Bump libdcp for verification fix.v2.14.46Carl Hetherington
2020-11-25Fix corrupted image when over-cropping black filler frames.v2.14.45Carl Hetherington
FFmpegDecoder can emit small black frames (128x128 pixels) when it wants to fill in a gap. Image::crop_scale_window would do the wrong thing if we then applied a crop of greater than 128 in either direction; though cropped_size is correctly clamped, the crop value itself was not and is used to calculate the input data pointers. This would result in random frames, usually at the end of DCPs, often made up of blurry colour washes.
2020-11-24Fix the behaviour of FileGroup when seeking too far.Carl Hetherington
Previously, if you did a seek off the end of the file group, the seek would return an error. This is not what fseek() does; it returns no error, and preserves the file pointer (returned by ftell()) as if the seek had been successful. fread()s after a too-far seek return no data, of course. Parsing some files (the example used to find the bug was a H264 MP4) involves a seek which is to the byte after the end of the mp4 file. If this fails the whole header parsing fails and DCP-o-matic refuses to use the file.
2020-11-19Hack to fix image luminance when cropping subsampled images (#1872).v2.14.44Carl Hetherington
Without this the luminance varies slightly as you crop by odd and even amounts (for YUV420 images).
2020-11-19Fix some GTK3 vertical alignment error messages in the player.Carl Hetherington
2020-11-17Test build fixes.v2.14.43crop-fix-v2.14.xCarl Hetherington
2020-11-17Tweak vertical spacing with GTK3.Carl Hetherington
2020-11-17Fix cropping of subsampled images.Carl Hetherington
The calculations for how to crop subsampled components of YUV images were wrong, causing strange effects like misregistration of colour components in cropped images. Should fix #1872.
2020-11-17Add some lrintf() calls to be sure.Carl Hetherington
2020-11-17Use 64-byte alignment for aligned image memory.Carl Hetherington
FFmpeg uses this values if AVX512 is available, and with only 32-byte alignment I am seeing strange scaling effects whereby crop_scale_window_test7 gives black bars down the right side of cropped images (when run on an i7 7700).
2020-11-11Remove assertion checking that rotations are a multiple of 90.v2.14.42Carl Hetherington
This is checked later, anyway (without asserting) and we have seen files in the wild with other rotations (e.g. -135.62) which do not appear to need rotation to be applied. Fixes #1871.
2020-10-28Prevent import of directories as DCPs if they do not have anCarl Hetherington
ASSETMAP{,.xml} in the top level. This should avoid some confusion, as previously DoM would scan the whole directory tree looking for an ASSETMAP. It also prevents people adding a DCP-o-matic project to itself, which I believe is the cause of #1620. Backported-from-commit: 2c74c1534cb563cab4c6c3225ced573619f6a647 Backported-from-branch: v2.15.x
2020-10-26Catch more errors when non-CPLs are loaded as CPLs.v2.14.41Carl Hetherington
2020-10-26GTK3 tweaks for the playback controls.Carl Hetherington
2020-10-26Use wxDC for all drawing of the audio mapping view, removingCarl Hetherington
use of wxGraphicsContext. This seems to fix strange rendering problems on Windows. Backported-from-commit: 3e4f6d59b46e3c09c9d0aba907ff0633bf0bc2e5 Backported-from-branch: v2.15.x
2020-10-26GTK3 KDM window fixes backported from v2.15.x.Carl Hetherington
2020-10-26Fix colour conversion choice on GTK3.Carl Hetherington
2020-10-26Adjust po files through some guesswork for the crop label changes.Carl Hetherington
2020-10-26pot/merge due to changing crop labels.Carl Hetherington
2020-10-26Make the crop controls more like those on the v2.15.x branchCarl Hetherington
for GTK3 so that they are at least vaguely usable.
2020-10-26Backport tiny typo fix from v2.15.x.Carl Hetherington
2020-10-26Allow building and running with wxWidgets 3.1.x as well as 3.0.x.Carl Hetherington
2020-10-25Add Ubuntu 20.10 dependencies.Carl Hetherington
2020-10-25Remove obsolete ubuntu version dependencies.Carl Hetherington
2020-10-14Add test for #1857.v2.14.40Carl Hetherington
Backported-from-commit: 86f855ef96a84ee7e8ad9d71b543e8c06fc91a9e Backported-from-branch: v2.15.x
2020-10-14Don't crash if the first packet in a stream has AV_NOPTS_VALUE;Carl Hetherington
instead, assume it should be at timestamp 0. Backported-from-commit: d7a3d94ec307a03ebe3fcf239ba991e9a3c1b8b8 Backported-from-branch: v2.15.x
2020-10-14Clear out _next_time when seeking, so out-of-date values don'tCarl Hetherington
hang around. Part of the fix for #1857. Backported-from-commit: 9a3df0a97b7962c00726447a75599e34c632cb2b Backported-from-branch: v2.15.x
2020-10-10Bump libdcp (and following libsub) to fix crashes with ASSETMAPsv2.14.39Carl Hetherington
containing files that are not in any PKL (#1855).
2020-09-23A belated happy new year.Carl Hetherington
2020-09-23Fix thinko in previous.Carl Hetherington
2020-09-23Fix potentially unterminated string (#1844).Carl Hetherington
2020-09-23Fix warnings about catching polymorphic types by value (#1843).Carl Hetherington
2020-09-21Fix --standard flag to dcpomatic2_cli (github #9).v2.14.38Carl Hetherington
2020-09-14Don't allow creation of a new film with no name. Otherwise we tryCarl Hetherington
to write metadata to the "create in folder" directory, which throws an uncaught exception if the specified directory is unwriteable. If we have a name then DoM tries to create the directory with that name, which fails more elegantly and with a nicer error. Backported-from-commit: 50aaa3789864c7330ee92e7e89ad5b6cc2155a82 Backported-from-branch: 2.15.x
2020-08-31Build fixes for Boost >= 1.73v2.14.37Carl Hetherington
2020-08-31Fix login denied (67) errors when trying to download certificatesCarl Hetherington
from Dolby. Backported-from-commit: 746e298e214a65ca9151867b2948560e76b45546 Backported-from-branch: v2.15.x
2020-08-03Add unit test for pulldown detection.v2.14.36Carl Hetherington
Backported-from-commit: 23804b8beddd616cef60900d6e51deb7788cbd79 Backported-from-branch: v2.15.x
2020-08-03Fix number of frames in the pulldown check.Carl Hetherington
Backported-from-commit: 5f1fdbafc6eef37523250e0b8542a8939a038823 Backported-from-branch: v2.15.x
2020-08-03Fix incorrect string find logic.Carl Hetherington
Backported-from-commit: d461077cf4f2c1470d2d0d6dbc4f5708411bec65 Backported-from-branch: v2.15.x
2020-08-02Don't terminate if a non-DCP directory is given to Open.Carl Hetherington
Cherry-picked from 591c73b472f0eb74225dbc1b08885f552b8814c4 in v2.15.x.
2020-08-02Recover information about closed caption tracks when loading DCPsCarl Hetherington
so that they can be displayed. Cherry-picked from 09860271bb6d03b3937c08bffb4c672697f6d711 in v2.15.x.
2020-08-02Fix various problems with the closed caption viewer not being updated properly.Carl Hetherington
Cherry-picked from d902160e3c89a9f65f58a2463fac0b1de1d940b1 in v2.15.x.
2020-08-02Detect soft 2:3 pulldown (telecine) files and decode them at 23.976.Carl Hetherington
DVD rips from NTSC DVDs are sometimes (always?) encoded using soft 2:3 pulldown. The video frames are actually 23.976 but FFmpeg detects them as 29.97. With the current approach of the video decoder ignoring most PTSs and assuming a constant frame rate it is vital that the file contains the number of frames per second that the detected frame rate predicts. This fixes large sync errors with NTSC DVD rips (#1790). Cherry-picked from af680761cf7c3e97660e8e55c68f42e90b026bf9 in v2.15.x.
2020-07-29Don't display all possible channel checkboxes while the analysisv2.14.35Carl Hetherington
is running as clicking the higher ones will cause an assertion failure. Cherry-picked from 4b5e05b9845d609524328a88a81011b364e03a8a in v2.15.x.
2020-07-29Fix memory leak which also causes strange flickering in the audioCarl Hetherington
analysis window while the analysis is running. Cherry-picked from 6b1d9adcf6e75fc8e441b61108a2169bda6a6094 in v2.15.x.
2020-07-27Trying to create export audio encoders with between 9 and 15 channelsv2.14.34Carl Hetherington
inclusive fails, at least for AAC. There's probably a way around this with some FFmpeg-cleverness but for now let's just export any project with more than 8 channels as 16. You could argue that we should offer choices to, for example export 7.1/HI/VN as 7.1 but that sounds fiddly. Fixes #1786.
2020-07-27Fix export of projects with fewer than 6 channels.Carl Hetherington
2020-05-22Fix some tab/space problems in cscript.Carl Hetherington
2020-05-14Follow-up fix for GTK2 and GTK3 WX backends.v2.14.33Carl Hetherington