summaryrefslogtreecommitdiff
path: root/src/lib/reel_writer.cc
AgeCommit message (Collapse)Author
2023-04-05Don't add fonts to SMPTE closed caption MXFs (#2505).Carl Hetherington
2023-03-29Write the correct MCA subdescriptors depending on active channels.Carl Hetherington
2023-03-29Always make 16-channel MXFs.Carl Hetherington
2023-03-03Add option to limit DCP output to the "Bv2.0 profile" (#2470).v2.16.45Carl Hetherington
I'm far from convinced about the point/sense of all these "profiles" (rather than just implementing or at least tolerating the standard) but lots of people are having problems with "QC" processes failing their DCPs with complaints related to MCASubDescriptors. It seems to make sense to have an option to turn them off - at least for now, until either the "QC" situation settles down or any bugs in DCP-o-matic are found and fixed.
2023-02-27Support the 2014 version of SMPTE 428-7 in render_text.cc and use itCarl Hetherington
when placing subtitles (e.g. SRT). Also default to outputting 2014-era alignment.
2023-01-16Write dummy subtitles also to empty Interop reels (#2421).Carl Hetherington
2022-11-21Fix subtitle vertical position (#2367).Carl Hetherington
Previously we would not account for the differences in what vertical position means between Interop and SMPTE. For interop, vertical position is the distance from the reference point to the text baseline, whereas for SMPTE it is the distance from the reference point to the top/middle/bottom of the subtitle (depending on the reference). This caused differences between the preview and the DCP for some cases (notably, using SRT/SSA and making Interop DCPs, or converting Interop DCP subs to SMPTE, or vice versa).
2022-11-03Bump libdcp for subtitle Z-position fixes (#2356).Carl Hetherington
2022-09-27Use EnumIndexedVector in ReelWriter.Carl Hetherington
2022-09-15Fix some spelling mistakes (mostly in comments).Carl Hetherington
2022-07-14Fix build.Carl Hetherington
2022-07-14More error message improvements.Carl Hetherington
2022-07-14Log a couple of errors more thoroughly.Carl Hetherington
2022-06-07Rearrange subtitle font management.Carl Hetherington
With this change each subtitle coming out of the player has a reference to a dcpomatic::Font that belongs to the TextContent. This hopefully solves a few problems which all basically stemmed from the fact that previously the decoders/player were deciding what the font ID in the output DCP would be - they can't do that properly.
2022-06-07Fix incorrect extension on interop subtitle files (#2270).Carl Hetherington
2022-06-03Make subtitle asset filename obey custom settings (#2260).Carl Hetherington
2022-05-05Use dcp::File in DCP-o-matic (#2231).Carl Hetherington
2022-04-29Move Image::as_png() out to image_as_png().Carl Hetherington
2022-04-21Tidying.Carl Hetherington
2022-03-25Bump libdcp for fix to remove erroneous <EntryPoint> and <Duration> markers ↵Carl Hetherington
from <MainMarkers> (#2215).
2021-10-17Basic and slightly inaccurate support for <Space> in subtitles (#2103).v2.15.170Carl Hetherington
Adding horizontal space to a Pango layout is hard, and I think this change probably gets it slightly wrong, but it's a step in the right direction.
2021-08-12White space.Carl Hetherington
2021-08-12Add comment.Carl Hetherington
2021-08-12Don't write empty <Text> nodes in subtitles/closed captions.Carl Hetherington
2021-06-01Put audio language back in the Film.Carl Hetherington
It feels neat to have audio language in the audio tab, to match the subtitle language in the subtitle tab. It also avoids the potential confusion of there being an audio language setting in the DCP metadata but no subtitle language setting. However: - I am yet to find a need to describe multiple audio languages in the same DCP (all previous users of Film::audio_languages() were just taking the first language off the list). - As Carsten points out it's fiddly to have to set the audio language for 5 separate-channel WAV files, for example (you wouldn't actually have had to do this, but it would have felt like you did). I think subtitle language remains neater where it is (per-content) as there is this additional subtitle language metadata and it makes much more sense (and is much more likely) that there are multiple subtitle languages in a DCP than it does multiple audio languages.
2021-05-01C++11 tidying.Carl Hetherington
2021-04-21Make digest calculations interruptible.Carl Hetherington
2021-04-12Bump libdcp for some API improvements.Carl Hetherington
2021-04-09Make DCP text track language properly optional and ignore bad values on ↵Carl Hetherington
imported DCPs (#1950).
2021-04-06Remove out-of-date Film::_audio_language.Carl Hetherington
2021-03-31Put subtitle language back into content from the film (#1930).Carl Hetherington
This also adds the main/additional language flag. Of all the considerations about how to specify subtitle language, the most important seems to be that the language specification happens for the content where the language is; i.e. in the content text tab.
2021-03-26Bump libdcp for MCA tag fixes.Carl Hetherington
2021-03-20Tidy up HMSF handling in a few places.Carl Hetherington
2021-03-16Split subtitles at reel boundaries (#1918).Carl Hetherington
2021-03-15Use period when adding text subs, like we do with image ones.Carl Hetherington
2021-02-23Don't create empty SMPTE subtitles files with empty <SubtitleList>Carl Hetherington
Files like this fail validation against the XSD. Perhaps the XSD is wrong; for now though, create an empty 1-second-long subtitle in such files.
2021-01-31More enum class additions.Carl Hetherington
2021-01-21Adapt for libdcp use of enum class.Carl Hetherington
2021-01-20Bump libdcp for better verification, and make API adjustments.Carl Hetherington
2021-01-07BOOST_FOREACH.Carl Hetherington
2021-01-07std::shared_ptrCarl Hetherington
2020-12-22Pass fonts from content around as FontData.Carl Hetherington
i.e. as a block of memory rather than a file. Also, get the fonts from the decoder rather than the content. Together, these changes allow us to use fonts from SMPTE DCPs added as content. Before, fonts would be messed up in those cases (#1885).
2020-12-22Fix crash on working out hints for content with subtitles.Carl Hetherington
Probably introduced in cadca6e4f8c1d844f1b5fb9375023e627c674fa9
2020-12-08In a DCP with any subs/ccaps, make sure every reel has them (#1340).Carl Hetherington
2020-12-08Factor out empty_text_asset() method.Carl Hetherington
2020-12-08Write subtitles and closed captions to a test DCP in the hints thread,Carl Hetherington
then check the result for Bv2.1 violations (part of #1800).
2020-12-08Make Writer take an output DCP path rather than getting it from theCarl Hetherington
film itself.
2020-12-08Use a weak_ptr<Film> in ReelWriter.Carl Hetherington
2020-12-08Split create_reel() up into some separate bits.Carl Hetherington
2020-12-06Remove a pointless parameter that the callee can calculate.Carl Hetherington