| Age | Commit message (Collapse) | Author |
|
This is needed because the DCPDecoder ends up needing it when it reads
reel information from CPLs.
Maybe all that stuff should be in our metadata.
|
|
|
|
|
|
|
|
The subtitle XML refers to a font with no corresponding <LoadFont>.
|
|
This is at the expense of forward compatibility, and the need to
re-examine subtitle content (losing custom fonts as we do so).
But it does mean that the code is simpler, and there's not this weird
growth of IDs where a DCP gets imported with some font, and then the ID
becomes 0_font, and if you do it again it's 0_0_font, and so on.
|
|
builds without release version tags.
So that last_written_by_earlier_than() always returns true,
check_font_ids() happens when it doesn't really need to.
|
|
|
|
Previously this was all changed so that for subs we add the default
font in a cleaner way (in db22f81ccce9e1a5f205e6d8b3c0631fc039a173).
I can't see why we shouldn't treat ccaps the same way, and indeed
not doing it causes an error as shown by the included test.
|
|
|
|
Previously we used an empty font ID as the default for when a subtitle
has no Font, but in #2721 we saw a DCP with an empty font ID which
raised an assertion (because we'd already added our default font with
the empty ID).
Here we try to fix this (and also make the default font correctly be
that from the first <LoadFont>).
|
|
It's not just subtitle files with no <LoadFont> that can have
subtitles without a specified font. In particular, DoM makes a
single space subtitle with no font spec when it creates filler
subtitles in multi-reel DCPs.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
for DCPs that contain subtitle files without <Font> tags.
|
|
font declarations / tags (#2339).
|
|
I'm not sure if this goes far enough - it seems impossible to find all
the font IDs used in a FFmpeg file without scanning it. I don't know
if (for example) SSA-format font IDs make it through to DoM when decoded
by FFmpeg.
|
|
|
|
|