| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
It should be the main UI's responsibility to set up dcpomatic_log, maybe
writing it to the film's directory if it wants to.
|
|
Commit 045a8b15b19ec7f872fb01cfb986faeaa26cb8bb changed how AC3/EAC3
decoders in FFmpeg are flushed, and this caused a considerable change to
the audio result in this test (in particular, the audio is about 3db
louder after the FFmpeg change). I'm assuming the previous result was
just wrong.
|
|
In ffmpeg commit af6d52eec66961f6a502b0f2f390c12226d087cd the precision
of XYZ/RGB conversion was improved from 12- to 16-bit, and this changes
the outputs of these tests.
|
|
|
|
|
|
|
|
|
|
|
|
It turns out that FFmpeg decoders (e.g. flv, see FFmpeg
25faaa311a74efdfdc4fed56996d7338ed807488) check stream IDs and sometimes
create new streams if they see one that they didn't see before. If we
change stream IDs we break this.
Here we try to use stream indices in cases where the IDs are duplicated.
We also account for the case where a new stream appears during
examination. This wasn't covered by tests until the FFmpeg commit
mentioned above, were the flv decoder creates a new stream during
examination of boon_telly.mkv.
|
|
|
|
|
|
|
|
This seems to fix problems where letters were scaled individually, but
their spacing didn't change (when x scale was applied).
Big thanks to user1768761
https://stackoverflow.com/questions/58528024/pangocairo-shows-cluttered-text-when-cairo-context-is-scaled
|
|
There's a few things going on here:
1. Improve the regression test for 3042. Previously we made a DCP from
the reporter's _original_ prores file (before they converted it to XYZ)
and compared the result to a reference J2K file of uncertain origin.
This seems wrong because:
a) We never got confirmation from the reporter that the fix worked for
them, so any arbitrary reference is dubious.
b) It doesn't seem to reflect their actual complaint, which was that
they got a different result when making a DCP from XYZ TIFFs compared
to their "XYZ" Prores.
The new test makes a DCP from their TIFFs and "XYZ" Prores and compares
the result.
2. Revert to the old approach to "no conversion" handling. In the good
old days we did everything -> RGB48LE except XYZ12LE -> XYZ12LE, and
that's what we do again here.
3. Change the YUV->RGB conversion from Rec.601 to Rec.709 for the
"no conversion" case. This fixes the 3042 regression test.
The supposed "XYZ" Prores is yuv444p12le according to ffprobe. So I
think what we have here is actually a file that was converted to XYZ
and then back to YUV by Resolve. I experimented with using the raw
YUV values and considering them as XYZ but this was clearly wrong.
I think 3 is probably what I should have done in the first place.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
For a long time we would keep XYZ12LE, if that's what we have, otherwise
ask FFmpeg to switch to RGB48LE.
Then in 1d5c211dadb9a9dc2318adce86ca9c31b367cabe I tried to fix the case
of an XYZ source mis-tagged as YUV. I changed things so that with no
colour conversion we'd always ask FFmpeg to convert to XYZ. This meant
that RGB sources with no colour conversion would get treatment by FFmpeg
due to the RGB -> XYZ switch.
Here we're going back to the more-or-less the "long time" behaviour when
there is a conversion (keep XYZ12LE but otherwise convert to RGB48).
When there's no conversion, keep RGB (to avoid the FFmpeg conversion
from RGB -> XYZ) but convert everything else to XYZ.
|
|
This was removed in df9b4676aba8b941f124b174393988cad21677e1 and
surrounding commits, but it turns out we need it after all.
|
|
|
|
|
|
This inadvertently fixes a bug where multiple pieces of caption content
would be added to the project sequentially, but then immediately
re-arranged to be at the same time.
|
|
|
|
time_calculation_test.cc
|
|
With interop there can be only one font, and we need to make sure it's
not one that isn't even being used.
|
|
Previously you couldn't map these things if you were using a processor.
|
|
sed -i "/include.*compose.hpp/d;" src/lib/*.cc src/wx/*.cc src/wx/*.h src/tools/*.cc src/lib/*.h test/*.cc
|
|
sed -i "/Plural-Forms/n;/%100/n;/scanf/n;s/%[123456789]/{}/g" src/lib/*.cc src/lib/*.h src/wx/*.cc src/tools/*.cc src/lib/po/*.po src/wx/po/*.po src/tools/po/*.po test/*.cc
sed -i "s/String::compose */fmt::format/g" src/lib/*.cc src/lib/*.h src/wx/*.cc src/tools/*.cc test/*.cc
|
|
|
|
|
|
|
|
|
|
Once again the KDM gets its timezone from the cinema.
|
|
|
|
|
|
(#3038).
|
|
|
|
AV_PIX_FMT_XYZ12LE.
Prepare the image for where it is going to next. I don't understand the difference
in this situation between XYZ12LE and RGB48LE (it seems they are both 16-bit-per-channel)
but there you go.
|
|
Before the previous commit Ubuntu 22.04 would give slightly different
results to 24.04 when burning subtitles. I think this was because
DoM was erroneously using the system copy of Liberation Sans, which
I presume was changed.
After the previous commit we are always using the in-tree Liberation
Sans, which means that we can update the test references for Ubuntu
24.04 and use them also for 22.04.
|
|
In particular, prefer not to use lots of fallback attempts. It seems
that something funny is going on with how we find Liberation Sans on
Linux, meaning that we were sometimes using the OS copy of the font when
we didn't mean to.
|
|
|
|
|
|
|
|
|
