From f395c664aedb5bf022ddcde91c6e0c6531209a5d Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Wed, 2 Oct 2024 10:50:56 +0200 Subject: Fix crash on Windows (#2874). As discussed in https://groups.google.com/g/wx-dev/c/RCK_1m5Emzo " _() macro when used with wxNO_IMPLICIT_WXSTRING_ENCODING will expand to wxGetTranslation(wxASCII_STR(s)) which is going to be broken for any strings that are not ASCII or are wide char. So this will mean you cannot use anything non-ASCII in your base language. " --- src/wx/metadata_dialog.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wx/metadata_dialog.cc b/src/wx/metadata_dialog.cc index 9b2aa99eb..70f6e8c39 100644 --- a/src/wx/metadata_dialog.cc +++ b/src/wx/metadata_dialog.cc @@ -330,7 +330,7 @@ MetadataDialog::setup_advanced (wxPanel* panel, wxSizer* sizer) sizer->Add (s, 1, wxEXPAND); } - _luminance_unit->add_entry(_("candela per m²")); + _luminance_unit->add_entry(wxGetTranslation(wxString::FromUTF8("candela per m²"))); _luminance_unit->add_entry(_("foot lambert")); } -- cgit v1.2.3