From 89ee4cc6019036fa4fc0a6e07e052ffdc3b136ac Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Thu, 25 Jun 2015 11:58:12 +0100 Subject: Make player decide whether subtitles should be burnt based on content settings rather than using the film's settings. Remove film property of burn-subtitles. --- src/lib/player_video.cc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'src/lib/player_video.cc') diff --git a/src/lib/player_video.cc b/src/lib/player_video.cc index 7b6ea574e..765896a0e 100644 --- a/src/lib/player_video.cc +++ b/src/lib/player_video.cc @@ -89,7 +89,7 @@ PlayerVideo::set_subtitle (PositionImage image) } shared_ptr -PlayerVideo::image (AVPixelFormat pixel_format, bool burn_subtitle, dcp::NoteHandler note) const +PlayerVideo::image (AVPixelFormat pixel_format, dcp::NoteHandler note) const { shared_ptr im = _in->image (optional (note)); @@ -118,7 +118,7 @@ PlayerVideo::image (AVPixelFormat pixel_format, bool burn_subtitle, dcp::NoteHan shared_ptr out = im->crop_scale_window (total_crop, _inter_size, _out_size, yuv_to_rgb, pixel_format, true); - if (burn_subtitle && _subtitle) { + if (_subtitle) { out->alpha_blend (_subtitle->image, _subtitle->position); } @@ -130,7 +130,7 @@ PlayerVideo::image (AVPixelFormat pixel_format, bool burn_subtitle, dcp::NoteHan } void -PlayerVideo::add_metadata (xmlpp::Node* node, bool send_subtitles) const +PlayerVideo::add_metadata (xmlpp::Node* node) const { node->add_child("Time")->add_child_text (raw_convert (_time.get ())); _crop.as_xml (node); @@ -147,7 +147,7 @@ PlayerVideo::add_metadata (xmlpp::Node* node, bool send_subtitles) const if (_colour_conversion) { _colour_conversion.get().as_xml (node); } - if (send_subtitles && _subtitle) { + if (_subtitle) { node->add_child ("SubtitleWidth")->add_child_text (raw_convert (_subtitle->image->size().width)); node->add_child ("SubtitleHeight")->add_child_text (raw_convert (_subtitle->image->size().height)); node->add_child ("SubtitleX")->add_child_text (raw_convert (_subtitle->position.x)); @@ -156,10 +156,10 @@ PlayerVideo::add_metadata (xmlpp::Node* node, bool send_subtitles) const } void -PlayerVideo::send_binary (shared_ptr socket, bool send_subtitles) const +PlayerVideo::send_binary (shared_ptr socket) const { _in->send_binary (socket); - if (send_subtitles && _subtitle) { + if (_subtitle) { _subtitle->image->write_to_socket (socket); } } -- cgit v1.2.3