From c88a8a6ec6b396dc90d40a4843160d616a45db76 Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Wed, 2 Jul 2014 18:10:58 +0100 Subject: Hopefully improve subtitle decoder seeking etc. --- src/lib/subtitle_decoder.cc | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'src/lib/subtitle_decoder.cc') diff --git a/src/lib/subtitle_decoder.cc b/src/lib/subtitle_decoder.cc index 1b789fdab..b8cb3e5c8 100644 --- a/src/lib/subtitle_decoder.cc +++ b/src/lib/subtitle_decoder.cc @@ -51,20 +51,23 @@ template list SubtitleDecoder::get (list const & subs, ContentTimePeriod period) { - if (!has_subtitle_during (period)) { + /* Get the full periods of the subtitles that are showing during the specified period */ + list sp = subtitles_during (period); + if (sp.empty ()) { + /* Nothing in this period */ return list (); } - if (subs.empty() || period.from < subs.front().period().from || period.to > (subs.back().period().to + ContentTime::from_seconds (10))) { - /* Either we have no decoded data, or what we do have is a long way from what we want: seek */ - seek (period.from, true); + /* Seek if what we want is before what we have, or more than a reasonable amount after */ + if (subs.empty() || sp.back().to < subs.front().period().from || sp.front().from > (subs.back().period().to + ContentTime::from_seconds (5))) { + seek (sp.front().from, true); } /* Now enough pass() calls will either: * (a) give us what we want, or * (b) hit the end of the decoder. */ - while (!pass() && (subs.empty() || (subs.front().period().from > period.from || period.to < subs.back().period().to))) {} + while (!pass() && (subs.empty() || (subs.back().period().to < sp.back().to))) {} /* Now look for what we wanted in the data we have collected */ /* XXX: inefficient */ -- cgit v1.2.3