From 86a866d5f3f5bf2fec67d1c813524479c6727eab Mon Sep 17 00:00:00 2001
From: Carl Hetherington <cth@carlh.net>
Date: Tue, 19 Nov 2019 17:07:35 +0100
Subject: Clean up access to stuff from Film.

---
 src/lib/film.cc     |  7 +++++++
 src/lib/film.h      |  7 +++++++
 src/lib/playlist.cc | 11 ++++++++++-
 src/lib/playlist.h  |  2 ++
 4 files changed, 26 insertions(+), 1 deletion(-)

(limited to 'src/lib')

diff --git a/src/lib/film.cc b/src/lib/film.cc
index 2a50e8c81..aa71834a1 100644
--- a/src/lib/film.cc
+++ b/src/lib/film.cc
@@ -169,6 +169,7 @@ Film::Film (optional<boost::filesystem::path> dir)
 	_playlist_change_connection = _playlist->Change.connect (bind (&Film::playlist_change, this, _1));
 	_playlist_order_changed_connection = _playlist->OrderChanged.connect (bind (&Film::playlist_order_changed, this));
 	_playlist_content_change_connection = _playlist->ContentChange.connect (bind (&Film::playlist_content_change, this, _1, _2, _3, _4));
+	_playlist_length_change_connection = _playlist->LengthChange.connect (bind(&Film::playlist_length_change, this));
 
 	if (dir) {
 		/* Make state.directory a complete path without ..s (where possible)
@@ -1292,6 +1293,12 @@ Film::playlist_content_change (ChangeType type, weak_ptr<Content> c, int p, bool
 	}
 }
 
+void
+Film::playlist_length_change ()
+{
+	LengthChange ();
+}
+
 void
 Film::playlist_change (ChangeType type)
 {
diff --git a/src/lib/film.h b/src/lib/film.h
index 68f8b5334..c72251880 100644
--- a/src/lib/film.h
+++ b/src/lib/film.h
@@ -390,6 +390,11 @@ public:
 	/** Emitted when some property of our content has changed */
 	mutable boost::signals2::signal<void (ChangeType, boost::weak_ptr<Content>, int, bool)> ContentChange;
 
+	/** Emitted when the film's length might have changed; this is not like a normal
+	    property as its value is derived from the playlist, so it has its own signal.
+	*/
+	mutable boost::signals2::signal<void ()> LengthChange;
+
 	/** Emitted when we have something important to tell the user */
 	boost::signals2::signal<void (std::string)> Message;
 
@@ -409,6 +414,7 @@ private:
 	void playlist_change (ChangeType);
 	void playlist_order_changed ();
 	void playlist_content_change (ChangeType type, boost::weak_ptr<Content>, int, bool frequent);
+	void playlist_length_change ();
 	void maybe_add_content (boost::weak_ptr<Job>, boost::weak_ptr<Content>, bool disable_audio_analysis);
 	void audio_analysis_finished ();
 	void check_settings_consistency ();
@@ -486,6 +492,7 @@ private:
 	boost::signals2::scoped_connection _playlist_change_connection;
 	boost::signals2::scoped_connection _playlist_order_changed_connection;
 	boost::signals2::scoped_connection _playlist_content_change_connection;
+	boost::signals2::scoped_connection _playlist_length_change_connection;
 	std::list<boost::signals2::connection> _job_connections;
 	std::list<boost::signals2::connection> _audio_analysis_connections;
 
diff --git a/src/lib/playlist.cc b/src/lib/playlist.cc
index 9e96c693a..73a3214d3 100644
--- a/src/lib/playlist.cc
+++ b/src/lib/playlist.cc
@@ -113,6 +113,9 @@ Playlist::content_change (weak_ptr<const Film> weak_film, ChangeType type, weak_
 			if (changed) {
 				OrderChanged ();
 			}
+
+			/* The length might have changed, and that's good enough for this signal */
+			LengthChange ();
 		}
 	}
 
@@ -281,6 +284,8 @@ Playlist::add (shared_ptr<const Film> film, shared_ptr<Content> c)
 	}
 
 	Change (CHANGE_TYPE_DONE);
+
+	LengthChange ();
 }
 
 void
@@ -312,6 +317,8 @@ Playlist::remove (shared_ptr<Content> c)
 	}
 
 	/* This won't change order, so it does not need a sort */
+
+	LengthChange ();
 }
 
 void
@@ -334,9 +341,11 @@ Playlist::remove (ContentList c)
 		}
 	}
 
+	Change (CHANGE_TYPE_DONE);
+
 	/* This won't change order, so it does not need a sort */
 
-	Change (CHANGE_TYPE_DONE);
+	LengthChange ();
 }
 
 class FrameRateCandidate
diff --git a/src/lib/playlist.h b/src/lib/playlist.h
index d7db75d0f..b6e23b4a5 100644
--- a/src/lib/playlist.h
+++ b/src/lib/playlist.h
@@ -78,6 +78,8 @@ public:
 	/** Emitted when content has been added to or removed from the playlist; implies OrderChanged */
 	mutable boost::signals2::signal<void (ChangeType)> Change;
 	mutable boost::signals2::signal<void ()> OrderChanged;
+	/** Emitted when the length might have changed; may sometimes be emitted when it has not */
+	mutable boost::signals2::signal<void ()> LengthChange;
 
 	mutable boost::signals2::signal<void (ChangeType, boost::weak_ptr<Content>, int, bool)> ContentChange;
 
-- 
cgit v1.2.3