From fc10e39ac88ee16a711d1d643f863e84dcd8157d Mon Sep 17 00:00:00 2001
From: Carl Hetherington <cth@carlh.net>
Date: Sun, 2 Jul 2023 22:03:28 +0200
Subject: Don't insert incorrect <Effect> nodes into metadata (#2581).

Previously we would add assume Effect=none (i.e. force all subtitles
to have no effect) if neither of the legacy tags Border or Shadow
were present in the metadata.  In this case we should just leave
Effect as unset.
---
 src/lib/text_content.cc | 2 --
 1 file changed, 2 deletions(-)

(limited to 'src/lib')

diff --git a/src/lib/text_content.cc b/src/lib/text_content.cc
index e4cbc601a..92a35b822 100644
--- a/src/lib/text_content.cc
+++ b/src/lib/text_content.cc
@@ -148,8 +148,6 @@ TextContent::TextContent (Content* parent, cxml::ConstNodePtr node, int version,
 		_effect = dcp::Effect::BORDER;
 	} else if (node->optional_bool_child("Shadow").get_value_or(false)) {
 		_effect = dcp::Effect::SHADOW;
-	} else {
-		_effect = dcp::Effect::NONE;
 	}
 
 	auto effect = node->optional_string_child("Effect");
-- 
cgit v1.2.3