From 00948a5f283ba60b53632749f8d5684c0f3236cd Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Tue, 25 Jul 2023 11:04:30 +0200 Subject: Write 8 or 16 audio channels to SMPTE DCP MXFs, as appropriate (#2443). --- src/lib/reel_writer.cc | 3 +-- src/lib/writer.cc | 7 +++++-- 2 files changed, 6 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/lib/reel_writer.cc b/src/lib/reel_writer.cc index e8db82fbb..f9a110ed1 100644 --- a/src/lib/reel_writer.cc +++ b/src/lib/reel_writer.cc @@ -179,8 +179,7 @@ ReelWriter::ReelWriter ( _sound_asset = make_shared ( dcp::Fraction(film()->video_frame_rate(), 1), film()->audio_frame_rate(), - /* Always make 16-channel sound assets for SMPTE; libdcp will pad unused channels for us */ - standard == dcp::Standard::SMPTE ? MAX_DCP_AUDIO_CHANNELS : film()->audio_channels(), + audio_channels_to_write_to_mxf(film()), lang ? *lang : dcp::LanguageTag("en-US"), standard ); diff --git a/src/lib/writer.cc b/src/lib/writer.cc index 71e9d579d..573e9da26 100644 --- a/src/lib/writer.cc +++ b/src/lib/writer.cc @@ -653,9 +653,12 @@ Writer::finish (boost::filesystem::path output_dcp) field = dcp::MCASoundField::FIVE_POINT_ONE; } - dcp::MainSoundConfiguration msc(field, MAX_DCP_AUDIO_CHANNELS); + auto const audio_channels = audio_channels_to_write_to_mxf(film()); + dcp::MainSoundConfiguration msc(field, audio_channels); for (auto i: film()->mapped_audio_channels()) { - msc.set_mapping(i, static_cast(i)); + if (i < audio_channels) { + msc.set_mapping(i, static_cast(i)); + } } cpl->set_main_sound_configuration(msc); -- cgit v1.2.3