From 070986191180139cbd0db632ca0d49e19f96fba8 Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Fri, 9 Jan 2026 01:35:59 +0100 Subject: Don't keep a shared_ptr to the Job for the whole of the ::go() method. This fixes a number of weird segfaults/crashes in tests that I didn't get to the bottom of. --- src/lib/dcp_film_encoder.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src') diff --git a/src/lib/dcp_film_encoder.cc b/src/lib/dcp_film_encoder.cc index a818c9b4c..6e56b88c8 100644 --- a/src/lib/dcp_film_encoder.cc +++ b/src/lib/dcp_film_encoder.cc @@ -95,8 +95,7 @@ DCPFilmEncoder::~DCPFilmEncoder() void DCPFilmEncoder::go() { - auto job = _job.lock(); - _writer.reset(new Writer(_film, job, _film->dir(_film->dcp_name()))); + _writer.reset(new Writer(_film, _job, _film->dir(_film->dcp_name()))); switch (_film->video_encoding()) { case VideoEncoding::JPEG2000: -- cgit v1.2.3