From d6e8b54b2b60f70f1a8837183bc184809977be67 Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Thu, 27 Jun 2024 20:14:31 +0200 Subject: Fix error when importing bad subtitle file (#2838). The subtitle XML refers to a font with no corresponding . --- test/data | 2 +- test/subtitle_font_id_test.cc | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) (limited to 'test') diff --git a/test/data b/test/data index 4cb08962b..6a4fa8b7c 160000 --- a/test/data +++ b/test/data @@ -1 +1 @@ -Subproject commit 4cb08962ba07e99c442cb12091c0347d84d8fd89 +Subproject commit 6a4fa8b7c13e4f09fcee995191a2c86e1eff9d6d diff --git a/test/subtitle_font_id_test.cc b/test/subtitle_font_id_test.cc index bc09a9cf1..12d804d20 100644 --- a/test/subtitle_font_id_test.cc +++ b/test/subtitle_font_id_test.cc @@ -302,3 +302,17 @@ BOOST_AUTO_TEST_CASE(no_error_with_ccap_that_mentions_no_font) while (!player.pass()) {} } + +BOOST_AUTO_TEST_CASE(cope_with_unloaded_font_id) +{ + /* This file has a with an ID that corresponds to no */ + auto subs = content_factory("test/data/unloaded_font.xml")[0]; + auto film = new_test_film2("cope_with_unloaded_font_id", { subs }); + make_and_verify_dcp( + film, + { + dcp::VerificationNote::Code::MISSING_SUBTITLE_LANGUAGE, + dcp::VerificationNote::Code::MISSING_CPL_METADATA, + }); +} + -- cgit v1.2.3