From f19abd2f18c890018269d95c345b507c6cb9d315 Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Thu, 1 Dec 2022 22:30:58 +0100 Subject: Move UTC offset for KDMs from the cinema to the point of KDM creation (#2300). --- test/config_test.cc | 2 +- test/kdm_cli_test.cc | 41 +++++++++++++++++++++++++++++++++++++++-- test/kdm_naming_test.cc | 26 ++++++++++---------------- 3 files changed, 50 insertions(+), 19 deletions(-) (limited to 'test') diff --git a/test/config_test.cc b/test/config_test.cc index a43bb5ff6..00adb7b09 100644 --- a/test/config_test.cc +++ b/test/config_test.cc @@ -246,7 +246,7 @@ BOOST_AUTO_TEST_CASE (config_keep_cinemas_if_making_new_config) Config::instance()->write(); - Config::instance()->add_cinema(make_shared("My Great Cinema", vector(), "", 0, 0)); + Config::instance()->add_cinema(make_shared("My Great Cinema", vector(), "")); Config::instance()->write(); boost::filesystem::copy_file (dir / "cinemas.xml", dir / "backup_for_test.xml"); diff --git a/test/kdm_cli_test.cc b/test/kdm_cli_test.cc index 4114cebd4..96424cfee 100644 --- a/test/kdm_cli_test.cc +++ b/test/kdm_cli_test.cc @@ -85,13 +85,13 @@ setup_test_config() auto config = Config::instance(); auto const cert = dcp::Certificate(dcp::file_to_string("test/data/cert.pem")); - auto cinema_a = std::make_shared("Dean's Screens", vector(), "", 0, 0); + auto cinema_a = std::make_shared("Dean's Screens", vector(), ""); cinema_a->add_screen(std::make_shared("Screen 1", "", cert, boost::none, std::vector())); cinema_a->add_screen(std::make_shared("Screen 2", "", cert, boost::none, std::vector())); cinema_a->add_screen(std::make_shared("Screen 3", "", cert, boost::none, std::vector())); config->add_cinema(cinema_a); - auto cinema_b = std::make_shared("Floyd's Celluloid", vector(), "", 0, 0); + auto cinema_b = std::make_shared("Floyd's Celluloid", vector(), ""); cinema_b->add_screen(std::make_shared("Foo", "", cert, boost::none, std::vector())); cinema_b->add_screen(std::make_shared("Bar", "", cert, boost::none, std::vector())); config->add_cinema(cinema_b); @@ -195,3 +195,40 @@ BOOST_AUTO_TEST_CASE(kdm_cli_specify_cinemas_file) BOOST_CHECK_EQUAL(output[2], "Great ()"); } + +BOOST_AUTO_TEST_CASE(kdm_cli_time) +{ + ConfigRestorer cr; + + setup_test_config(); + + boost::filesystem::path kdm_filename = "build/test/KDM_Test_FTR-1_F-133_XX-XX_MOS_2K_20220109_SMPTE_OV_Deans_Screens_Screen_2.xml"; + + boost::system::error_code ec; + boost::filesystem::remove(kdm_filename, ec); + + dcp::LocalTime now; + now.add_days(2); + + vector args = { + "kdm_cli", + "--verbose", + "--valid-from", now.as_string(), + "--valid-duration", "2 weeks", + "-c", "Dean's Screens", + "-S", "Screen 2", + "-o", "build/test", + "test/data/dkdm.xml" + }; + + vector output; + auto error = run(args, output); + BOOST_CHECK(!error); + + BOOST_REQUIRE_EQUAL(output.size(), 2U); + BOOST_CHECK(boost::algorithm::starts_with(output[0], "Making KDMs valid from")); + BOOST_CHECK_EQUAL(output[1], "Wrote 1 KDM files to build/test"); + + BOOST_CHECK(boost::filesystem::exists(kdm_filename)); +} + diff --git a/test/kdm_naming_test.cc b/test/kdm_naming_test.cc index 32500553e..0f44fe2ea 100644 --- a/test/kdm_naming_test.cc +++ b/test/kdm_naming_test.cc @@ -59,16 +59,14 @@ BOOST_AUTO_TEST_CASE (single_kdm_naming_test) auto crypt_cert = c->decryption_chain()->leaf(); - /* Cinema A: UTC +4:30 */ - auto cinema_a = make_shared("Cinema A", vector(), "", 4, 30); + auto cinema_a = make_shared("Cinema A", vector(), ""); cinema_a_screen_1 = std::make_shared("Screen 1", "", crypt_cert, boost::none, vector()); cinema_a->add_screen (cinema_a_screen_1); cinema_a_screen_2 = std::make_shared("Screen 2", "", crypt_cert, boost::none, vector()); cinema_a->add_screen (cinema_a_screen_2); c->add_cinema (cinema_a); - /* Cinema B: UTC -1:00 */ - auto cinema_b = make_shared("Cinema B", vector(), "", -1, 0); + auto cinema_b = make_shared("Cinema B", vector(), ""); cinema_b_screen_x = std::make_shared("Screen X", "", crypt_cert, boost::none, vector()); cinema_b->add_screen (cinema_b_screen_x); cinema_b_screen_y = std::make_shared("Screen Y", "", crypt_cert, boost::none, vector()); @@ -90,14 +88,13 @@ BOOST_AUTO_TEST_CASE (single_kdm_naming_test) auto sign_cert = c->signer_chain()->leaf(); - dcp::LocalTime from (sign_cert.not_before()); + dcp::LocalTime from = sign_cert.not_before(); + from.set_offset({ 4, 30 }); from.add_months (2); - dcp::LocalTime until (sign_cert.not_after()); + dcp::LocalTime until = sign_cert.not_after(); + until.set_offset({ 4, 30 }); until.add_months (-2); - auto const from_string = from.date() + " " + from.time_of_day(true, false); - auto const until_string = until.date() + " " + until.time_of_day(true, false); - std::vector period_checks; auto cpl = cpls.front().cpl_file; @@ -107,8 +104,8 @@ BOOST_AUTO_TEST_CASE (single_kdm_naming_test) auto kdm = kdm_for_screen ( make_kdm, cinema_a_screen_1, - boost::posix_time::time_from_string(from_string), - boost::posix_time::time_from_string(until_string), + from, + until, dcp::Formulation::MODIFIED_TRANSITIONAL_1, false, optional(), @@ -157,9 +154,6 @@ BOOST_AUTO_TEST_CASE (directory_kdm_naming_test, * boost::unit_test::depends_on( dcp::LocalTime until (sign_cert.not_after()); until.add_months (-2); - string const from_string = from.date() + " " + from.time_of_day(true, false); - string const until_string = until.date() + " " + until.time_of_day(true, false); - vector> screens = { cinema_a_screen_2, cinema_b_screen_x, cinema_a_screen_1, (cinema_b_screen_z) }; @@ -178,8 +172,8 @@ BOOST_AUTO_TEST_CASE (directory_kdm_naming_test, * boost::unit_test::depends_on( auto kdm = kdm_for_screen ( make_kdm, i, - boost::posix_time::time_from_string(from_string), - boost::posix_time::time_from_string(until_string), + from, + until, dcp::Formulation::MODIFIED_TRANSITIONAL_1, false, optional(), -- cgit v1.2.3