From 7e6ac6046293cb85d4ee2bdc1fba9b3750712723 Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Thu, 21 Apr 2022 23:19:27 +0200 Subject: Revert "Adjust handling of -Wsuggest-override" This reverts commit e7e4af869f7144fa9a265ccf1e15c7b2f182ac2c. I misunderstood what was going on, and we were just missing some DCPOMATIC_{DIS,EN}ABLE_WARNINGS calls. --- wscript | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'wscript') diff --git a/wscript b/wscript index 994f1b6f3..4ccadf6fd 100644 --- a/wscript +++ b/wscript @@ -109,6 +109,7 @@ def configure(conf): '-Wall', '-Wextra', '-Wwrite-strings', + '-Wsuggest-override', '-Wno-error=deprecated', # I tried and failed to ignore these with _Pragma '-Wno-ignored-qualifiers', @@ -126,10 +127,6 @@ def configure(conf): if int(gcc[0]) >= 8: # I tried and failed to ignore these with _Pragma conf.env.append_value('CXXFLAGS', ['-Wno-cast-function-type']) - if int(gcc[0]) >= 9: - # I can't get #pragma GCC diagnostic ignored "-Wsuggest-override" to work on older GCCs, - # so only enable this if we're on a newer one - conf.env.append_value('CXXFLAGS', '-Wsuggest-override') have_c11 = int(gcc[0]) >= 4 and int(gcc[1]) >= 8 and int(gcc[2]) >= 1 # Most gccs still give these warnings from boost::optional conf.env.append_value('CXXFLAGS', ['-Wno-maybe-uninitialized']) -- cgit v1.2.3