1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
|
/*
Copyright (C) 2022 Carl Hetherington <cth@carlh.net>
This file is part of DCP-o-matic.
DCP-o-matic is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
DCP-o-matic is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with DCP-o-matic. If not, see <http://www.gnu.org/licenses/>.
*/
#include "lib/content_factory.h"
#include "lib/dcp_content.h"
#include "lib/film.h"
#include "lib/font.h"
#include "lib/text_content.h"
#include "lib/util.h"
#include <dcp/cpl.h>
#include <dcp/dcp.h>
#include <dcp/reel.h>
#include <dcp/reel_subtitle_asset.h>
#include <dcp/smpte_subtitle_asset.h>
#include "test.h"
#include <boost/test/unit_test.hpp>
using std::make_shared;
BOOST_AUTO_TEST_CASE(full_dcp_subtitle_font_id_test)
{
auto dcp = make_shared<DCPContent>(TestPaths::private_data() / "JourneyToJah_TLR-1_F_EN-DE-FR_CH_51_2K_LOK_20140225_DGL_SMPTE_OV");
auto film = new_test_film2("full_dcp_subtitle_font_id_test", { dcp });
auto content = film->content();
BOOST_REQUIRE_EQUAL(content.size(), 1U);
auto text = content[0]->only_text();
BOOST_REQUIRE(text);
/* There's the font from the DCP and also a dummy one with an empty ID */
BOOST_REQUIRE_EQUAL(text->fonts().size(), 2U);
auto font = text->fonts().front();
BOOST_CHECK_EQUAL(font->id(), "0_theFontId");
BOOST_REQUIRE(font->data());
BOOST_CHECK_EQUAL(font->data()->size(), 367112);
}
BOOST_AUTO_TEST_CASE(dcp_subtitle_font_id_test)
{
auto subs = content_factory(TestPaths::private_data() / "JourneyToJah_TLR-1_F_EN-DE-FR_CH_51_2K_LOK_20140225_DGL_SMPTE_OV" / "8b48f6ae-c74b-4b80-b994-a8236bbbad74_sub.mxf");
auto film = new_test_film2("dcp_subtitle_font_id_test", subs);
auto content = film->content();
BOOST_REQUIRE_EQUAL(content.size(), 1U);
auto text = content[0]->only_text();
BOOST_REQUIRE(text);
/* There's the font from the DCP and also a dummy one with an empty ID */
BOOST_REQUIRE_EQUAL(text->fonts().size(), 2U);
auto font = text->fonts().front();
BOOST_CHECK_EQUAL(font->id(), "theFontId");
BOOST_REQUIRE(font->data());
BOOST_CHECK_EQUAL(font->data()->size(), 367112);
}
BOOST_AUTO_TEST_CASE(make_dcp_with_subs_from_interop_dcp)
{
auto dcp = make_shared<DCPContent>("test/data/Iopsubs_FTR-1_F_XX-XX_MOS_2K_20220710_IOP_OV");
auto film = new_test_film2("make_dcp_with_subs_from_interop_dcp", { dcp });
dcp->text.front()->set_use(true);
make_and_verify_dcp(
film,
{
dcp::VerificationNote::Code::MISSING_SUBTITLE_LANGUAGE,
dcp::VerificationNote::Code::INVALID_SUBTITLE_FIRST_TEXT_TIME
}
);
}
BOOST_AUTO_TEST_CASE(make_dcp_with_subs_from_smpte_dcp)
{
Cleanup cl;
auto dcp = make_shared<DCPContent>(TestPaths::private_data() / "JourneyToJah_TLR-1_F_EN-DE-FR_CH_51_2K_LOK_20140225_DGL_SMPTE_OV");
auto film = new_test_film2("make_dcp_with_subs_from_smpte_dcp", { dcp }, &cl);
dcp->text.front()->set_use(true);
make_and_verify_dcp(film);
cl.run();
}
BOOST_AUTO_TEST_CASE(make_dcp_with_subs_from_mkv)
{
auto subs = content_factory(TestPaths::private_data() / "clapperboard_with_subs.mkv");
auto film = new_test_film2("make_dcp_with_subs_from_mkv", subs);
subs[0]->text.front()->set_use(true);
subs[0]->text.front()->set_language(dcp::LanguageTag("en-US"));
make_and_verify_dcp(film, { dcp::VerificationNote::Code::INVALID_PICTURE_FRAME_RATE_FOR_2K });
}
BOOST_AUTO_TEST_CASE(make_dcp_with_subs_without_font_tag)
{
auto subs = content_factory("test/data/no_font.xml");
auto film = new_test_film2("make_dcp_with_subs_without_font_tag", { subs });
subs[0]->text.front()->set_use(true);
make_and_verify_dcp(
film,
{
dcp::VerificationNote::Code::MISSING_SUBTITLE_LANGUAGE,
dcp::VerificationNote::Code::INVALID_SUBTITLE_FIRST_TEXT_TIME,
dcp::VerificationNote::Code::MISSING_CPL_METADATA
});
auto check_file = subtitle_file(film);
dcp::SMPTESubtitleAsset check_asset(check_file);
BOOST_CHECK_EQUAL(check_asset.load_font_nodes().size(), 1U);
auto check_font_data = check_asset.font_data();
BOOST_CHECK_EQUAL(check_font_data.size(), 1U);
BOOST_CHECK(check_font_data.begin()->second == dcp::ArrayData(default_font_file()));
}
BOOST_AUTO_TEST_CASE(make_dcp_with_subs_in_dcp_without_font_tag)
{
/* Make a DCP with some subs in */
auto source_subs = content_factory("test/data/short.srt");
auto source = new_test_film2("make_dcp_with_subs_in_dcp_without_font_tag_source", { source_subs });
source->set_interop(true);
make_and_verify_dcp(
source,
{
dcp::VerificationNote::Code::MISSING_SUBTITLE_LANGUAGE,
dcp::VerificationNote::Code::INVALID_SUBTITLE_FIRST_TEXT_TIME,
dcp::VerificationNote::Code::MISSING_CPL_METADATA,
dcp::VerificationNote::Code::INVALID_STANDARD
});
/* Find the ID of the subs */
dcp::DCP source_dcp(source->dir(source->dcp_name()));
source_dcp.read();
BOOST_REQUIRE(!source_dcp.cpls().empty());
BOOST_REQUIRE(!source_dcp.cpls()[0]->reels().empty());
BOOST_REQUIRE(source_dcp.cpls()[0]->reels()[0]->main_subtitle());
auto const id = source_dcp.cpls()[0]->reels()[0]->main_subtitle()->asset()->id();
/* Graft in some bad subs with no <Font> tag */
auto source_subtitle_file = subtitle_file(source);
#if BOOST_VERSION >= 107400
boost::filesystem::copy_file("test/data/no_font.xml", source_subtitle_file, boost::filesystem::copy_options::overwrite_existing);
#else
boost::filesystem::copy_file("test/data/no_font.xml", source_subtitle_file, boost::filesystem::copy_option::overwrite_if_exists);
#endif
/* Fix the <Id> tag */
{
Editor editor(source_subtitle_file);
editor.replace("4dd8ee05-5986-4c67-a6f8-bbeac62e21db", id);
}
/* Now make a project which imports that DCP and makes another DCP from it */
auto dcp_content = make_shared<DCPContent>(source->dir(source->dcp_name()));
auto film = new_test_film2("make_dcp_with_subs_without_font_tag", { dcp_content });
BOOST_REQUIRE(!dcp_content->text.empty());
dcp_content->text.front()->set_use(true);
make_and_verify_dcp(
film,
{
dcp::VerificationNote::Code::MISSING_SUBTITLE_LANGUAGE,
dcp::VerificationNote::Code::INVALID_SUBTITLE_FIRST_TEXT_TIME,
dcp::VerificationNote::Code::MISSING_CPL_METADATA
});
auto check_file = subtitle_file(film);
dcp::SMPTESubtitleAsset check_asset(check_file);
BOOST_CHECK_EQUAL(check_asset.load_font_nodes().size(), 1U);
auto check_font_data = check_asset.font_data();
BOOST_CHECK_EQUAL(check_font_data.size(), 1U);
BOOST_CHECK(check_font_data.begin()->second == dcp::ArrayData(default_font_file()));
}
BOOST_AUTO_TEST_CASE(filler_subtitle_reels_have_load_font_tags)
{
auto const name = boost::unit_test::framework::current_test_case().full_name();
auto subs = content_factory("test/data/short.srt")[0];
auto video1 = content_factory("test/data/flat_red.png")[0];
auto video2 = content_factory("test/data/flat_red.png")[0];
auto film = new_test_film2(name, { video1, video2, subs });
film->set_reel_type(ReelType::BY_VIDEO_CONTENT);
make_and_verify_dcp(
film,
{
dcp::VerificationNote::Code::MISSING_SUBTITLE_LANGUAGE,
dcp::VerificationNote::Code::INVALID_SUBTITLE_FIRST_TEXT_TIME,
dcp::VerificationNote::Code::INVALID_SUBTITLE_SPACING,
dcp::VerificationNote::Code::MISSING_CPL_METADATA
});
}
BOOST_AUTO_TEST_CASE(subtitle_with_no_font_test)
{
auto const name_base = boost::unit_test::framework::current_test_case().full_name();
auto video1 = content_factory("test/data/flat_red.png")[0];
auto video2 = content_factory("test/data/flat_red.png")[0];
auto subs = content_factory("test/data/short.srt")[0];
auto bad_film = new_test_film2(name_base + "_bad", { video1, video2, subs });
bad_film->set_reel_type(ReelType::BY_VIDEO_CONTENT);
video2->set_position(bad_film, video1->end(bad_film));
subs->set_position(bad_film, video1->end(bad_film));
subs->text[0]->add_font(make_shared<dcpomatic::Font>("foo", "test/data/LiberationSans-Regular.ttf"));
make_and_verify_dcp(
bad_film,
{
dcp::VerificationNote::Code::MISSING_SUBTITLE_LANGUAGE,
dcp::VerificationNote::Code::INVALID_SUBTITLE_FIRST_TEXT_TIME
});
/* When this test was written, this DCP would have one reel whose subtitles had <LoadFont>s
* but the subtitles specified no particular font. This triggers bug #2649, which this test
* is intended to trigger. First, make sure that the DCP has the required characteristics,
* to guard against a case where for some reason the DCP here is different enough that it
* doesn't trigger the bug.
*/
dcp::DCP check(bad_film->dir(bad_film->dcp_name()));
check.read();
BOOST_REQUIRE_EQUAL(check.cpls().size(), 1U);
auto cpl = check.cpls()[0];
BOOST_REQUIRE_EQUAL(cpl->reels().size(), 2U);
auto check_subs_reel = cpl->reels()[0]->main_subtitle();
BOOST_REQUIRE(check_subs_reel);
auto check_subs = check_subs_reel->asset();
BOOST_REQUIRE(check_subs);
BOOST_CHECK_EQUAL(check_subs->font_data().size(), 1U);
BOOST_REQUIRE_EQUAL(check_subs->subtitles().size(), 1U);
BOOST_CHECK(!std::dynamic_pointer_cast<const dcp::SubtitleString>(check_subs->subtitles()[0])->font().has_value());
auto check_film = new_test_film2(name_base + "_check", { make_shared<DCPContent>(bad_film->dir(bad_film->dcp_name())) });
make_and_verify_dcp(check_film);
}
|
