libdcp, branch v1.8.74 DCP handling library https://git.carlh.net/cgit/libdcp/atom?h=v1.8.74 2023-06-28T23:25:46Z Add asset_hashes_can_differ option to the equality checks. 2023-06-28T23:25:46Z Carl Hetherington cth@carlh.net 2023-06-28T21:00:57Z urn:sha1:b3b70e6d7c2ec6787d0b492442bb4f7537b4b580 Before recent changes Asset::_hash would be empty when the equality checks were run (and Asset::equals() compares them directly). This mean that differences in asset hash were being ignored, but are no longer; so now we need this option to restore that behaviour where required. When reading a DCP set up asset hashes from the CPL/PKL, not by digesting the actual asset. 2023-06-28T23:25:40Z Carl Hetherington cth@carlh.net 2023-06-26T22:11:43Z urn:sha1:e702623781c8d5853b79a29ca8c5f495d0ade3d1 Previously when reading a DCP we would recalculate asset hashes. This meant that corrupted DCPs could be loaded in and their hashes re-written (if nobody checked the new hashes against the ones in the PKL/CPL). It seems better to take the hashes from the metadata. Then if the assets are corrupted and the DCP is re-written the PKL/CPL hashes will be preserved, showing rather than hiding the corruption. Add Asset::unset_hash(). 2023-06-26T22:10:58Z Carl Hetherington cth@carlh.net 2023-06-26T22:06:14Z urn:sha1:d305bb807a686fd7850257a724f46a77977fe491 Cleanup: remove unnecessary namespace. 2023-06-26T22:10:57Z Carl Hetherington cth@carlh.net 2023-06-26T22:05:55Z urn:sha1:9219b9c77f3ce283eb6551a484ee4a6592ccfa30 Fix tests that were writing assets with the same filename to different reels. 2023-06-26T22:10:56Z Carl Hetherington cth@carlh.net 2023-06-26T22:05:38Z urn:sha1:55c83a0ec5e4b74d9c5b33514b3c18489595c083 Cleanup: sorting. 2023-06-26T22:10:55Z Carl Hetherington cth@carlh.net 2023-06-26T00:13:22Z urn:sha1:5fa31cd1ed5ebc1446008150f052cceab8d09efe Move Editor class from verify_test.cc to test.cc 2023-06-26T22:10:53Z Carl Hetherington cth@carlh.net 2023-06-25T23:56:07Z urn:sha1:113f1062f131577cb169fe1516d49d1f79fa16cf Add verifier check for the actual asset file's ID not being the same as the one in the asset map. 2023-06-26T22:09:54Z Carl Hetherington cth@carlh.net 2023-06-25T23:45:17Z urn:sha1:c72e832423ceb81f30e8ca19bfeb87fca26298c1 Cleanup: better variable names. 2023-06-26T22:07:44Z Carl Hetherington cth@carlh.net 2023-06-25T23:20:34Z urn:sha1:54617cea2d186bd62eb44b07292b8722fe59ed4e Cleanup: const. 2023-06-26T22:06:51Z Carl Hetherington cth@carlh.net 2023-06-25T23:18:06Z urn:sha1:868ee4db539fe07542699836b76d5e51892b39ed