libdcp/src/sound_asset.h, branch v1.8.72DCP handling libraryhttps://git.carlh.net/cgit/libdcp/atom?h=v1.8.722023-05-28T21:01:32ZAdd SoundAsset::active_channels().2023-05-28T21:01:32ZCarl Hetheringtoncth@carlh.net2023-05-28T21:01:32Zurn:sha1:7de292067e73b0b96fa07f8d192689d844fcb270Allow specification of channels that need a MCASubDescriptor.2023-03-20T23:37:12ZCarl Hetheringtoncth@carlh.net2023-03-20T23:37:12Zurn:sha1:c047da0a3ee78f8066ef65cdbcd978cdd67fb42eRemove the bools and default parameters from SoundAsset::start_write().2023-03-20T15:41:02ZCarl Hetheringtoncth@carlh.net2023-03-17T12:33:08Zurn:sha1:870f02f07ee51ee478006260e2c3b683e591b0c9
They were more confusing than they were worth.
Add include_mca_subdescriptors flag to SoundAsset writer.2023-03-01T18:44:25ZCarl Hetheringtoncth@carlh.net2023-03-01T18:44:25Zurn:sha1:c76095e572fdf85e42db834c9bdb84f2bdb6fee3Add channels parameter to simple_audio().2023-01-23T23:54:25ZCarl Hetheringtoncth@carlh.net2023-01-23T23:54:25Zurn:sha1:b489c7ad24303799a32412e160fe27c4e9eddb29Fix problems when adding KDMs to a VF, before adding the OV.2021-10-08T10:48:43ZCarl Hetheringtoncth@carlh.net2021-10-08T10:08:10Zurn:sha1:aab6630b945371038cc49e456a766ae45cab1f47
If we have a KDM which contains keys for all the assets referred
to by a VF (even the ones in the OV) we would previously throw
an exception because we tried to give the KDM to the resolved
assets when it was given to the Reel.
Here we change things so that the addition of KDMs to assets can
be deferred if the asset is not yet resolved.
Fix/hide some warnings.2021-04-13T23:00:05ZCarl Hetheringtoncth@carlh.net2021-04-13T23:00:05Zurn:sha1:274dd30f2b11fe8ea563a2ac7436c9d463865b0bMake sound asset language optional.2021-04-08T22:02:09ZCarl Hetheringtoncth@carlh.net2021-04-08T22:02:09Zurn:sha1:45525875fef67ec1885968c0c5692307b16a279bWrite MCA tags based on the specified sound field.2021-03-25T23:09:15ZCarl Hetheringtoncth@carlh.net2021-03-25T23:09:15Zurn:sha1:b9c5e3f74550917676e14324791d6ba4d0c07cac
I had previously assumed that one should write MCA information into
the sound MXF based on what channels actually contain sound rather
than silence.
However a previous example of a stereo DCP gives a verification error
in EasyDCP (see DoM bug #1935) which is solved by adding MCA tags
for each channel in the specified sound field (e.g. at least 6 tags
for a file which is marked as 5.1) even if the audio is really stereo.
This commit removes the "active channels" stuff and makes sure
that if we say a file is 5.1 we write at least 6 MCA tags (and
similarly for 7.1).
Tidying.2021-01-24T03:15:26ZCarl Hetheringtoncth@carlh.net2021-01-24T03:15:26Zurn:sha1:ceaf7bc52712cb60708ed5eb5c62c5e463dd8e89