libdcp/src/verify.cc, branch bv2.1-verify

Fix strange crash in verify().

2021-01-20T22:34:54Z

This appears to be necessary to stop the first write to state.subtitle_language from segfaulting. It looks like the optional<> is in some uninitialised / indeterminate state. I could only reproduce this crash when running verify() from DoM, not from the `dcpverify` tool. And some simple test programs suggest that even doing State state; should call the constructors of anything in State.

Cleanup: rename some check_ prefixes to verify_.

2021-01-19T23:54:22Z

Cleanup: some more use of initialiser lists.

2021-01-19T23:41:09Z

VerificationNote message tidying.

2021-01-19T23:31:41Z

Tidy up parameters in VerificationNote.

2021-01-19T22:36:27Z

Fix tests to actually check the results in several cases.

2021-01-19T19:32:18Z

Cleanup: remove lots of unnecessary namespace qualifiers.

2021-01-19T00:30:26Z

Cleanup: tidy enum names for verification codes.

2021-01-19T00:27:23Z

Bv2.1 10.1: if any asset is encrypted they all must be.

2021-01-18T23:33:14Z

Rename encrypted() to any_encrypted() and add all_encrypted().

2021-01-18T23:32:53Z