libdcp/test/dcp_test.cc, branch v1.8.73 DCP handling library https://git.carlh.net/cgit/libdcp/atom?h=v1.8.73 2023-03-20T15:41:02Z Use an enum instead of a bool in PictureAsset::start_write(). 2023-03-20T15:41:02Z Carl Hetherington cth@carlh.net 2023-03-17T13:11:34Z urn:sha1:20e3e4c2a7a91e45740987a702f5d4c1ea2f9030 Remove the bools and default parameters from SoundAsset::start_write(). 2023-03-20T15:41:02Z Carl Hetherington cth@carlh.net 2023-03-17T12:33:08Z urn:sha1:870f02f07ee51ee478006260e2c3b683e591b0c9 They were more confusing than they were worth. Specify number of channels in the data passed to SoundAssetWriter, and pad channels that aren't there. 2023-03-16T18:52:06Z Carl Hetherington cth@carlh.net 2023-03-16T18:51:27Z urn:sha1:c1d296b163ddf88a5b387f98e7e77988a242a996 Tidy up write_xml() API a little. 2022-04-25T21:31:13Z Carl Hetherington cth@carlh.net 2022-04-25T21:31:13Z urn:sha1:ef9671811920cbef50f0f01d063eab418de8925e C++11 tidying. 2022-04-22T10:26:59Z Carl Hetherington cth@carlh.net 2022-04-22T09:54:15Z urn:sha1:a9e6681c3b383cadbd05de188670f7f51f05a2cd Fix some macOS signed/unsigned warnings. 2022-04-22T10:22:44Z Carl Hetherington cth@carlh.net 2022-04-22T09:08:54Z urn:sha1:ed1f39dc5664d642f0f5af1a606e2e7aebd5e5f4 Add a test for DCP::add() for KDMs. 2022-04-20T18:06:46Z Carl Hetherington cth@carlh.net 2022-01-03T23:27:37Z urn:sha1:fbf4e083ac834a94167d5d0e3d715206cb736a23 C++11 tidying. 2021-04-11T23:22:10Z Carl Hetherington cth@carlh.net 2021-04-11T20:25:21Z urn:sha1:2c5e61891e7975f4c2d33a5f2ed144645e3078f9 Specify CPL standard on construction. 2021-04-11T23:22:10Z Carl Hetherington cth@carlh.net 2021-04-11T20:24:44Z urn:sha1:498806d76160a6b1fa0af58e7734c0f553abf12b Then choose which standard DCP should use based on the CPL(s). Write MCA tags based on the specified sound field. 2021-03-25T23:09:15Z Carl Hetherington cth@carlh.net 2021-03-25T23:09:15Z urn:sha1:b9c5e3f74550917676e14324791d6ba4d0c07cac I had previously assumed that one should write MCA information into the sound MXF based on what channels actually contain sound rather than silence. However a previous example of a stereo DCP gives a verification error in EasyDCP (see DoM bug #1935) which is solved by adding MCA tags for each channel in the specified sound field (e.g. at least 6 tags for a file which is marked as 5.1) even if the audio is really stereo. This commit removes the "active channels" stuff and makes sure that if we say a file is 5.1 we write at least 6 MCA tags (and similarly for 7.1).