libdcp/test/mca_test.cc, branch cpp17 DCP handling library https://git.carlh.net/cgit/libdcp/atom?h=cpp17 2024-03-22T14:18:55Z Bump asdcplib to dcpomatic-2.13.0 branch. 2024-03-22T14:18:55Z Carl Hetherington cth@carlh.net 2024-03-20T22:21:25Z urn:sha1:cb4759c178e3229796e8139f3f21a230532a7499 Pass MainSoundConfiguration object rather than a string. 2023-04-04T21:37:15Z Carl Hetherington cth@carlh.net 2023-04-02T21:10:24Z urn:sha1:2da55dbe6da21975612584365db17db2ae9935b8 I guess originally it was a string mostly because it's not very well defined, and Interop seemingly does whatever it wants. This basic change also means that things are checked more carefully, and so we must be more relaxed with some things seen in the wild that I can't find contradictions for in the standard (and also with the case of channel IDs, which does seem to be mentioned in the standard). Allow specification of channels that need a MCASubDescriptor. 2023-03-20T23:37:12Z Carl Hetherington cth@carlh.net 2023-03-20T23:37:12Z urn:sha1:c047da0a3ee78f8066ef65cdbcd978cdd67fb42e Remove the bools and default parameters from SoundAsset::start_write(). 2023-03-20T15:41:02Z Carl Hetherington cth@carlh.net 2023-03-17T12:33:08Z urn:sha1:870f02f07ee51ee478006260e2c3b683e591b0c9 They were more confusing than they were worth. Specify number of channels in the data passed to SoundAssetWriter, and pad channels that aren't there. 2023-03-16T18:52:06Z Carl Hetherington cth@carlh.net 2023-03-16T18:51:27Z urn:sha1:c1d296b163ddf88a5b387f98e7e77988a242a996 C++11 tidying. 2021-07-14T00:02:17Z Carl Hetherington cth@carlh.net 2021-07-14T00:02:17Z urn:sha1:96d6f783b7dfac04af8a7d77033a3d05e31cfc10 Fix/hide some warnings. 2021-04-13T23:00:05Z Carl Hetherington cth@carlh.net 2021-04-13T23:00:05Z urn:sha1:274dd30f2b11fe8ea563a2ac7436c9d463865b0b C++11 tidying. 2021-04-11T23:22:10Z Carl Hetherington cth@carlh.net 2021-04-11T20:25:21Z urn:sha1:2c5e61891e7975f4c2d33a5f2ed144645e3078f9 Specify CPL standard on construction. 2021-04-11T23:22:10Z Carl Hetherington cth@carlh.net 2021-04-11T20:24:44Z urn:sha1:498806d76160a6b1fa0af58e7734c0f553abf12b Then choose which standard DCP should use based on the CPL(s). Write MCA tags based on the specified sound field. 2021-03-25T23:09:15Z Carl Hetherington cth@carlh.net 2021-03-25T23:09:15Z urn:sha1:b9c5e3f74550917676e14324791d6ba4d0c07cac I had previously assumed that one should write MCA information into the sound MXF based on what channels actually contain sound rather than silence. However a previous example of a stereo DCP gives a verification error in EasyDCP (see DoM bug #1935) which is solved by adding MCA tags for each channel in the specified sound field (e.g. at least 6 tags for a file which is marked as 5.1) even if the audio is really stereo. This commit removes the "active channels" stuff and makes sure that if we say a file is 5.1 we write at least 6 MCA tags (and similarly for 7.1).