summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCarl Hetherington <cth@carlh.net>2019-01-14 15:32:58 +0000
committerCarl Hetherington <cth@carlh.net>2019-01-14 15:32:58 +0000
commit0176ce02863f89315774cc2907f5beb33c21360f (patch)
treef2503804c46bf20b2b97d4fc9e8a659105ff076a
parent7e4e6be3628308b7b16c015e2f87b27e729258dc (diff)
Speculative removal of call to xmlSecKeySetName when signing, on
the basis that I can't see what it's for and opendcp doesn't do it. Chasing Sony no-validate bug.
-rw-r--r--src/certificate_chain.cc5
1 files changed, 0 insertions, 5 deletions
diff --git a/src/certificate_chain.cc b/src/certificate_chain.cc
index 0e032a85..6b4216b5 100644
--- a/src/certificate_chain.cc
+++ b/src/certificate_chain.cc
@@ -639,11 +639,6 @@ CertificateChain::add_signature_value (xmlpp::Node* parent, string ns) const
throw runtime_error ("could not read private key");
}
- /* XXX: set key name to the PEM string: this can't be right! */
- if (xmlSecKeySetName (signature_context->signKey, reinterpret_cast<const xmlChar *> (_key->c_str())) < 0) {
- throw MiscError ("could not set key name");
- }
-
int const r = xmlSecDSigCtxSign (signature_context, parent->cobj ());
if (r < 0) {
throw MiscError (String::compose ("could not sign (%1)", r));