diff options
| author | Carl Hetherington <cth@carlh.net> | 2026-03-29 22:11:20 +0200 |
|---|---|---|
| committer | Carl Hetherington <cth@carlh.net> | 2026-04-01 23:43:00 +0200 |
| commit | c8720ce0fe32088df1c1d50c42c2e7434b142a68 (patch) | |
| tree | 1f1f39b64cf05b1e20d725b443f2ed99e486d2f9 | |
| parent | 443efdefec2f72a4188d8d277e6145f745375fe3 (diff) | |
INCORRECT_LFOC: note -> time.
| -rw-r--r-- | src/verify.cc | 4 | ||||
| -rw-r--r-- | src/verify.h | 2 | ||||
| -rw-r--r-- | test/verify_test.cc | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/src/verify.cc b/src/verify.cc index 92da919c..2b67d7c1 100644 --- a/src/verify.cc +++ b/src/verify.cc @@ -1736,7 +1736,7 @@ verify_cpl(Context& context, shared_ptr<const CPL> cpl) } else { auto lfoc_time = lfoc->second.as_editable_units_ceil(lfoc->second.tcr); if (lfoc_time != (cpl->reels().back()->duration() - 1)) { - context.add_note(VerificationNote::Code::INCORRECT_LFOC, fmt::to_string(lfoc_time)); + context.add_note(VerificationNote(VerificationNote::Code::INCORRECT_LFOC).set_time(lfoc->second)); } } @@ -2094,7 +2094,7 @@ dcp::note_to_string(VerificationNote note, function<string (string)> process_str case VerificationNote::Code::INCORRECT_FFOC: return compose("The FFOC marker is %1 instead of 1", note.time()->as_string(dcp::Standard::SMPTE)); case VerificationNote::Code::INCORRECT_LFOC: - return compose("The LFOC marker is %1 instead of 1 less than the duration of the last reel.", note.note().get()); + return compose("The LFOC marker is %1 instead of 1 less than the duration of the last reel.", note.time()->as_string(dcp::Standard::SMPTE)); case VerificationNote::Code::MISSING_CPL_METADATA: return compose("The CPL %1 has no <CompositionMetadataAsset> tag.", note.cpl_id().get()); case VerificationNote::Code::MISSING_CPL_METADATA_VERSION_NUMBER: diff --git a/src/verify.h b/src/verify.h index 6ee8e5f0..0222eb41 100644 --- a/src/verify.h +++ b/src/verify.h @@ -353,7 +353,7 @@ public: */ INCORRECT_FFOC, /** The LFOC marker should be the last frame in the reel - * note contains the incorrect value + * time contains the incorrect time */ INCORRECT_LFOC, /** There must be a _<CompositionMetadataAsset>_ diff --git a/test/verify_test.cc b/test/verify_test.cc index 1add49d0..e7d4f5ef 100644 --- a/test/verify_test.cc +++ b/test/verify_test.cc @@ -4158,7 +4158,7 @@ BOOST_AUTO_TEST_CASE (verify_markers) { dcp::Marker::LFOC, dcp::Time(18, 24, 24) } }, { - { VC::INCORRECT_LFOC, string("18") } + { VN(VC::INCORRECT_LFOC).set_time(dcp::Time(18, 24, 24)) } }); } |