diff options
| author | Carl Hetherington <cth@carlh.net> | 2023-02-02 01:03:40 +0100 |
|---|---|---|
| committer | Carl Hetherington <cth@carlh.net> | 2023-02-02 01:37:16 +0100 |
| commit | e0b3f0dec29dfe2952a8bdf445295e8445a8ecd9 (patch) | |
| tree | 64e308a8e049ddb8b2770b6a4536ca3774ed9dba | |
| parent | b424b9d40a472c00d2ddbe2218375dcbd3d947fc (diff) | |
In Deluxe's "Specifications for Digital Cinema Source and DCP Content Delivery"v1.8.55
they say that subtitle <IssueDate> must be of the form yyyy-mm-ddThh:mm:ss
They don't explain it, and the standards don't say this (as far as I can see)
but as usual their QC fails <IssueDates> that don't meet this "spec" so here
we are.
See also:
https://dcpomatic.com/forum/viewtopic.php?t=2069
| -rw-r--r-- | src/smpte_subtitle_asset.cc | 2 | ||||
| -rw-r--r-- | test/smpte_subtitle_test.cc | 8 |
2 files changed, 5 insertions, 5 deletions
diff --git a/src/smpte_subtitle_asset.cc b/src/smpte_subtitle_asset.cc index 9d728cc6..375bae0a 100644 --- a/src/smpte_subtitle_asset.cc +++ b/src/smpte_subtitle_asset.cc @@ -351,7 +351,7 @@ SMPTESubtitleAsset::xml_as_string () const if (_annotation_text) { root->add_child("AnnotationText")->add_child_text(_annotation_text.get()); } - root->add_child("IssueDate")->add_child_text(_issue_date.as_string(true)); + root->add_child("IssueDate")->add_child_text(_issue_date.as_string(false, false)); if (_reel_number) { root->add_child("ReelNumber")->add_child_text(raw_convert<string>(_reel_number.get())); } diff --git a/test/smpte_subtitle_test.cc b/test/smpte_subtitle_test.cc index 67265271..f8412daa 100644 --- a/test/smpte_subtitle_test.cc +++ b/test/smpte_subtitle_test.cc @@ -264,7 +264,7 @@ BOOST_AUTO_TEST_CASE (write_smpte_subtitle_test) "<SubtitleReel xmlns=\"http://www.smpte-ra.org/schemas/428-7/2010/DCST\" xmlns:xs=\"http://www.w3.org/2001/XMLSchema\">\n" " <Id>urn:uuid:a6c58cff-3e1e-4b38-acec-a42224475ef6</Id>\n" " <ContentTitleText>Test</ContentTitleText>\n" - " <IssueDate>2016-04-01T03:52:00.000+00:00</IssueDate>\n" + " <IssueDate>2016-04-01T03:52:00</IssueDate>\n" " <ReelNumber>1</ReelNumber>\n" " <Language>en</Language>\n" " <EditRate>24 1</EditRate>\n" @@ -462,7 +462,7 @@ BOOST_AUTO_TEST_CASE (write_smpte_subtitle_test2) "<SubtitleReel xmlns=\"http://www.smpte-ra.org/schemas/428-7/2010/DCST\" xmlns:xs=\"http://www.w3.org/2001/XMLSchema\">\n" " <Id>urn:uuid:a6c58cff-3e1e-4b38-acec-a42224475ef6</Id>\n" " <ContentTitleText>Test</ContentTitleText>\n" - " <IssueDate>2016-04-01T03:52:00.000+00:00</IssueDate>\n" + " <IssueDate>2016-04-01T03:52:00</IssueDate>\n" " <ReelNumber>1</ReelNumber>\n" " <Language>en</Language>\n" " <EditRate>24 1</EditRate>\n" @@ -602,7 +602,7 @@ BOOST_AUTO_TEST_CASE (write_subtitles_in_vertical_order_with_top_alignment) "<SubtitleReel xmlns=\"http://www.smpte-ra.org/schemas/428-7/2010/DCST\" xmlns:xs=\"http://www.w3.org/2001/XMLSchema\">\n" " <Id>urn:uuid:a6c58cff-3e1e-4b38-acec-a42224475ef6</Id>\n" " <ContentTitleText>Test</ContentTitleText>\n" - " <IssueDate>2016-04-01T03:52:00.000+00:00</IssueDate>\n" + " <IssueDate>2016-04-01T03:52:00</IssueDate>\n" " <ReelNumber>1</ReelNumber>\n" " <Language>en</Language>\n" " <EditRate>24 1</EditRate>\n" @@ -690,7 +690,7 @@ BOOST_AUTO_TEST_CASE (write_subtitles_in_vertical_order_with_bottom_alignment) "<SubtitleReel xmlns=\"http://www.smpte-ra.org/schemas/428-7/2010/DCST\" xmlns:xs=\"http://www.w3.org/2001/XMLSchema\">\n" " <Id>urn:uuid:a6c58cff-3e1e-4b38-acec-a42224475ef6</Id>\n" " <ContentTitleText>Test</ContentTitleText>\n" - " <IssueDate>2016-04-01T03:52:00.000+00:00</IssueDate>\n" + " <IssueDate>2016-04-01T03:52:00</IssueDate>\n" " <ReelNumber>1</ReelNumber>\n" " <Language>en</Language>\n" " <EditRate>24 1</EditRate>\n" |