summaryrefslogtreecommitdiff
path: root/src/asset_factory.h
diff options
context:
space:
mode:
authorCarl Hetherington <cth@carlh.net>2021-04-22 21:56:38 +0200
committerCarl Hetherington <cth@carlh.net>2021-04-22 21:56:38 +0200
commit5e1ce36be463bfc48663d4697860340649060d01 (patch)
treeb05b203e023a3ec1932f2a73ff4ea9d5dcfd7ffd /src/asset_factory.h
parentba27603d5b53231607bc8fe41b201d8811b22b4f (diff)
Don't give an error on verifying Interop DCPs with possibly-incorrectly
marked 3D assets. This also adds a warning into the verification output. I don't know if this is actually a standard violation but they have been seen in the wild made by "reputable" DCP creation software. DoM bug #1976.
Diffstat (limited to 'src/asset_factory.h')
-rw-r--r--src/asset_factory.h8
1 files changed, 7 insertions, 1 deletions
diff --git a/src/asset_factory.h b/src/asset_factory.h
index 2dd04559..0e60de03 100644
--- a/src/asset_factory.h
+++ b/src/asset_factory.h
@@ -47,7 +47,13 @@ namespace dcp {
class Asset;
-std::shared_ptr<Asset> asset_factory (boost::filesystem::path path, bool ignore_incorrect_picture_mxf_type);
+/** Create an Asset from a file.
+ * @param ignore_incorrect_picture_mxf_type true to ignore cases where a stereo picture asset is marked
+ * as 2D; if this is false an exception will be thrown in that case.
+ * @param ignored_incorrect_picture_mxf_type if this is non-null it will be set to true if a 3D asset was
+ * marked as 2D, otherwise it will be left alone.
+ */
+std::shared_ptr<Asset> asset_factory (boost::filesystem::path path, bool ignore_incorrect_picture_mxf_type, bool* found_threed_marked_as_twod = nullptr);
}