diff options
| author | Carl Hetherington <cth@carlh.net> | 2021-03-15 01:36:51 +0100 |
|---|---|---|
| committer | Carl Hetherington <cth@carlh.net> | 2021-03-15 01:36:51 +0100 |
| commit | 2c1faeb15715794525f48110c2b8a9df96b387c1 (patch) | |
| tree | c03b560ca0302d3d51fc0a9252f2574100e01f0b /src/verify.h | |
| parent | f80f5f533ab09f64a022314380b2969b6ef88ec3 (diff) | |
Fix various bugs in subtitle/ccap verification.
Check that subtitles don't overlap reel boundaries, and fix a few
tests that trip this check.
Fix confusion when calculating subtitle timings during verification
where the picture asset frame rate was being used rather than the
subtitle asset's edit rate.
Do the subtitle timing verification for Interop as well as SMPTE
subtitles.
Take <StartTime> tags into account when checking subtitles, even
though Bv2.1 says they should be set to 0.
Rename Time::as_editable_units to Time::as_editable_units_ceil
and add a _floor variant, then use that to round down when checking
reel boundary overlaps.
Diffstat (limited to 'src/verify.h')
| -rw-r--r-- | src/verify.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/verify.h b/src/verify.h index f96fd4d2..16700127 100644 --- a/src/verify.h +++ b/src/verify.h @@ -214,6 +214,8 @@ public: INVALID_SUBTITLE_DURATION, /** At least one pair of subtitles are separated by less than the the minimum of 2 frames suggested by [Bv2.1_7.2.5] */ INVALID_SUBTITLE_SPACING, + /** A subtitle lasts for longer than the reel which contains it */ + SUBTITLE_OVERLAPS_REEL_BOUNDARY, /** There are more than 3 subtitle lines in at least one place [Bv2.1_7.2.7] */ INVALID_SUBTITLE_LINE_COUNT, /** There are more than 52 characters in at least one subtitle line [Bv2.1_7.2.7] */ |