Add wrappers around boost::filesystem methods that handle the

required mangling of long filenames on Windows.

Also wrap lots of missing places (e.g. calls to asdcplib, libxml++,
libcxml etc.) in dcp::filesystem::fix_long_path().

The idea is to keep paths un-mangled until they we call some
filesystem-related API and mangle them at that point.  Otherwise
we end up serialising mangled names, which seems like it will
not end well.

Should fix DoM #2623.

1 files changed, 59 insertions, 0 deletions

diff --git a/test/long_filenames_test.cc b/test/long_filenames_test.cc
new file mode 100644
index 00000000..f8189884
--- /dev/null
+++ b/test/long_filenames_test.cc
@@ -0,0 +1,59 @@
+/*
+    Copyright (C) 2023 Carl Hetherington <cth@carlh.net>
+
+    This file is part of libdcp.
+
+    libdcp is free software; you can redistribute it and/or modify
+    it under the terms of the GNU General Public License as published by
+    the Free Software Foundation; either version 2 of the License, or
+    (at your option) any later version.
+
+    libdcp is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU General Public License for more details.
+
+    You should have received a copy of the GNU General Public License
+    along with libdcp.  If not, see <http://www.gnu.org/licenses/>.
+
+    In addition, as a special exception, the copyright holders give
+    permission to link the code of portions of this program with the
+    OpenSSL library under certain conditions as described in each
+    individual source file, and distribute linked combinations
+    including the two.
+
+    You must obey the GNU General Public License in all respects
+    for all of the code used other than OpenSSL.  If you modify
+    file(s) with this exception, you may extend this exception to your
+    version of the file(s), but you are not obligated to do so.  If you
+    do not wish to do so, delete this exception statement from your
+    version.  If you delete this exception statement from all source
+    files in the program, then also delete it here.
+*/
+
+
+#include "dcp.h"
+#include "filesystem.h"
+#include <boost/filesystem.hpp>
+#include <boost/test/unit_test.hpp>
+
+
+BOOST_AUTO_TEST_CASE(load_dcp_with_long_filename)
+{
+	boost::filesystem::path long_name = "build/test";
+	for (int i = 0; i < 27; ++i) {
+		long_name /= "letsmakeitlong";
+	}
+
+	dcp::filesystem::remove_all(long_name);
+	dcp::filesystem::create_directories(long_name);
+	for (auto file: dcp::filesystem::directory_iterator("test/ref/DCP/dcp_test1")) {
+		dcp::filesystem::copy(file.path(), long_name / file.path().filename());
+	}
+
+	dcp::DCP dcp(long_name);
+	BOOST_CHECK_NO_THROW(dcp.read());
+}
+
+
+