diff options
| author | Carl Hetherington <cth@carlh.net> | 2021-03-26 00:09:15 +0100 |
|---|---|---|
| committer | Carl Hetherington <cth@carlh.net> | 2021-03-26 00:09:15 +0100 |
| commit | b9c5e3f74550917676e14324791d6ba4d0c07cac (patch) | |
| tree | 4e3264a68c365af195f682b548186f6c973246b7 /test/test.cc | |
| parent | c7208194515e93f85441c76d78d11a47d79b36e1 (diff) | |
Write MCA tags based on the specified sound field.
I had previously assumed that one should write MCA information into
the sound MXF based on what channels actually contain sound rather
than silence.
However a previous example of a stereo DCP gives a verification error
in EasyDCP (see DoM bug #1935) which is solved by adding MCA tags
for each channel in the specified sound field (e.g. at least 6 tags
for a file which is marked as 5.1) even if the audio is really stereo.
This commit removes the "active channels" stuff and makes sure
that if we say a file is 5.1 we write at least 6 MCA tags (and
similarly for 7.1).
Diffstat (limited to 'test/test.cc')
| -rw-r--r-- | test/test.cc | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/test/test.cc b/test/test.cc index 1f12bee4..79706bf8 100644 --- a/test/test.cc +++ b/test/test.cc @@ -293,9 +293,7 @@ simple_sound (boost::filesystem::path path, string suffix, dcp::MXFMetadata mxf_ shared_ptr<dcp::SoundAsset> ms (new dcp::SoundAsset(dcp::Fraction(24, 1), sample_rate, channels, dcp::LanguageTag("en-US"), dcp::Standard::SMPTE)); ms->_language = language; ms->set_metadata (mxf_meta); - vector<dcp::Channel> active_channels; - active_channels.push_back (dcp::Channel::LEFT); - shared_ptr<dcp::SoundAssetWriter> sound_writer = ms->start_write (path / dcp::String::compose("audio%1.mxf", suffix), active_channels); + shared_ptr<dcp::SoundAssetWriter> sound_writer = ms->start_write (path / dcp::String::compose("audio%1.mxf", suffix)); int const samples_per_frame = sample_rate / 24; |