summaryrefslogtreecommitdiff
path: root/test/write_subtitle_test.cc
diff options
context:
space:
mode:
authorCarl Hetherington <cth@carlh.net>2020-11-20 00:40:35 +0100
committerCarl Hetherington <cth@carlh.net>2020-11-20 00:40:35 +0100
commitf614b4526cd06a4d28b46bd2d98a55d56b97b14f (patch)
tree1eaf03b5e145a0cb7d8a42a37c1b8e6240c6ac23 /test/write_subtitle_test.cc
parentd989a83517fd77aa241c1423ac00cfed62d567fe (diff)
Tidy up handling of language metadata for subtitles.
Tried to normalise the idea that subtitle languages are stored as strings but set as LanguageTags. This may be too defensive; perhaps SMPTE language metadata is always right, or perhaps even if it isn't we should throw errors.
Diffstat (limited to 'test/write_subtitle_test.cc')
-rw-r--r--test/write_subtitle_test.cc10
1 files changed, 5 insertions, 5 deletions
diff --git a/test/write_subtitle_test.cc b/test/write_subtitle_test.cc
index 1f5ded21..c3217dbc 100644
--- a/test/write_subtitle_test.cc
+++ b/test/write_subtitle_test.cc
@@ -407,7 +407,7 @@ BOOST_AUTO_TEST_CASE (write_smpte_subtitle_test)
{
dcp::SMPTESubtitleAsset c;
c.set_reel_number (1);
- c.set_language ("EN");
+ c.set_language (dcp::LanguageTag("en"));
c.set_content_title_text ("Test");
c.set_issue_date (dcp::LocalTime ("2016-04-01T03:52:00+00:00"));
@@ -472,7 +472,7 @@ BOOST_AUTO_TEST_CASE (write_smpte_subtitle_test)
"<dcst:ContentTitleText>Test</dcst:ContentTitleText>"
"<dcst:IssueDate>2016-04-01T03:52:00.000+00:00</dcst:IssueDate>"
"<dcst:ReelNumber>1</dcst:ReelNumber>"
- "<dcst:Language>EN</dcst:Language>"
+ "<dcst:Language>en</dcst:Language>"
"<dcst:EditRate>24 1</dcst:EditRate>"
"<dcst:TimeCodeRate>24</dcst:TimeCodeRate>"
"<dcst:SubtitleList>"
@@ -500,7 +500,7 @@ BOOST_AUTO_TEST_CASE (write_smpte_subtitle_test2)
{
dcp::SMPTESubtitleAsset c;
c.set_reel_number (1);
- c.set_language ("EN");
+ c.set_language (dcp::LanguageTag("en"));
c.set_content_title_text ("Test");
c.set_issue_date (dcp::LocalTime ("2016-04-01T03:52:00+00:00"));
@@ -670,7 +670,7 @@ BOOST_AUTO_TEST_CASE (write_smpte_subtitle_test2)
"<dcst:ContentTitleText>Test</dcst:ContentTitleText>"
"<dcst:IssueDate>2016-04-01T03:52:00.000+00:00</dcst:IssueDate>"
"<dcst:ReelNumber>1</dcst:ReelNumber>"
- "<dcst:Language>EN</dcst:Language>"
+ "<dcst:Language>en</dcst:Language>"
"<dcst:EditRate>24 1</dcst:EditRate>"
"<dcst:TimeCodeRate>24</dcst:TimeCodeRate>"
"<dcst:SubtitleList>"
@@ -699,7 +699,7 @@ BOOST_AUTO_TEST_CASE (write_smpte_subtitle_test3)
{
dcp::SMPTESubtitleAsset c;
c.set_reel_number (1);
- c.set_language ("EN");
+ c.set_language (dcp::LanguageTag("en"));
c.set_content_title_text ("Test");
c.add (