Change libdcp::Time to allow sub-second units to be anything, so that

we can support SMPTE subtitles which use TimeCodeRate as the base rather
than the arbitrary "ticks" (4ms) of Interop.

3 files changed, 183 insertions, 133 deletions

diff --git a/test/data/subs3.xml b/test/data/subs3.xml
new file mode 100644
index 00000000..4e331f9a
--- /dev/null
+++ b/test/data/subs3.xml
@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<SubtitleReel xmlns="http://www.smpte-ra.org/schemas/428-7/2010/DCST">
+<Id>urn:uuid:d351291b-a133-88f7-caca-e7ed2ee6cc69</Id>
+<ContentTitleText>Test</ContentTitleText>
+<AnnotationText>Test</AnnotationText>
+<IssueDate>2014-11-21T18:10:50+01:00</IssueDate>
+<ReelNumber>1</ReelNumber>
+<Language>en</Language>
+<EditRate>25 1</EditRate>
+<TimeCodeRate>25</TimeCodeRate>
+<StartTime>00:00:00:00</StartTime>
+<SubtitleList>
+<Font ID="Arial" Color="FFFFFFFF" Weight="normal" Size="42" Effect="border" EffectColor="FF000000" AspectAdjust="1.00">
+<Subtitle SpotNumber="1" TimeIn="00:00:4:21" TimeOut="00:00:6:5" FadeUpTime="00:00:00:00" FadeDownTime="00:00:00:00">
+<Text Hposition="0.0" Halign="center" Valign="bottom" Vposition="8.0" Direction="ltr">Hello world</Text>
+</Subtitle>
+</Font>
+</SubtitleList>
+</SubtitleReel>
diff --git a/test/dcp_time_test.cc b/test/dcp_time_test.cc
index 52ff43c6..0ebddb29 100644
--- a/test/dcp_time_test.cc
+++ b/test/dcp_time_test.cc
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2013 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2013-2015 Carl Hetherington <cth@carlh.net>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -23,65 +23,69 @@
 /** Check that libdcp::Time works */
 BOOST_AUTO_TEST_CASE (dcp_time)
 {
-	libdcp::Time t (977143, 24);
+	/* tcr of 250 makes the editable event length the same as an Interop `tick' */
+	libdcp::Time t (977143, 24, 250);
 
-	BOOST_CHECK_EQUAL (t.t, 73);
+	BOOST_CHECK_EQUAL (t.e, 73);
 	BOOST_CHECK_EQUAL (t.s, 34);
 	BOOST_CHECK_EQUAL (t.m, 18);
 	BOOST_CHECK_EQUAL (t.h, 11);
 	BOOST_CHECK_EQUAL (t.to_string(), "11:18:34:73");
-	BOOST_CHECK_EQUAL (t.to_ticks(), 10178573);
 
-	libdcp::Time a (3, 2, 3, 4);
-	libdcp::Time b (2, 3, 4, 5);
+	/* Use a tcr of 24 so that the editable event is a frame */
+	libdcp::Time a (3, 2, 3, 4, 24);
+	libdcp::Time b (2, 3, 4, 5, 24);
 
 	libdcp::Time r = a - b;
 	BOOST_CHECK_EQUAL (r.h, 0);
 	BOOST_CHECK_EQUAL (r.m, 58);
 	BOOST_CHECK_EQUAL (r.s, 58);
-	BOOST_CHECK_EQUAL (r.t, 249);
-	BOOST_CHECK_EQUAL (r.to_string(), "0:58:58:249");
-	BOOST_CHECK_EQUAL (r.to_ticks(), 884749);
+	BOOST_CHECK_EQUAL (r.e, 23);
+	BOOST_CHECK_EQUAL (r.to_string(), "0:58:58:23");
 
-	a = libdcp::Time (1, 58, 56, 240);
-	b = libdcp::Time (1, 7, 12, 120);
+	/* Different tcr (25) */
+	a = libdcp::Time (1, 58, 56, 2, 25);
+	b = libdcp::Time (1, 7, 12, 1, 25);
 	r = a + b;
 	BOOST_CHECK_EQUAL (r.h, 3);
 	BOOST_CHECK_EQUAL (r.m, 6);
-	BOOST_CHECK_EQUAL (r.s, 9);
-	BOOST_CHECK_EQUAL (r.t, 110);
-	BOOST_CHECK_EQUAL (r.to_string(), "3:6:9:110");
-	BOOST_CHECK_EQUAL (r.to_ticks(), 2792360);
+	BOOST_CHECK_EQUAL (r.s, 8);
+	BOOST_CHECK_EQUAL (r.e, 3);
+	BOOST_CHECK_EQUAL (r.to_string(), "3:6:8:3");
 
-	a = libdcp::Time (24, 12, 6, 3);
-	b = libdcp::Time (16, 8, 4, 2);
+	/* Another arbitrary tcr (30) */
+	a = libdcp::Time (24, 12, 6, 3, 30);
+	b = libdcp::Time (16, 8, 4, 2, 30);
 	BOOST_CHECK_CLOSE (a / b, 1.5, 1e-5);
 
-	BOOST_CHECK_EQUAL (libdcp::Time (4128391203LL).to_ticks(), 4128391203LL);
-	BOOST_CHECK_EQUAL (libdcp::Time (60000).to_ticks(), 60000);
-
-	a = libdcp::Time (3600 * 24, 24);
+	a = libdcp::Time (3600 * 24, 24, 250);
 	BOOST_CHECK_EQUAL (a.h, 1);
 	BOOST_CHECK_EQUAL (a.m, 0);
 	BOOST_CHECK_EQUAL (a.s, 0);
-	BOOST_CHECK_EQUAL (a.t, 0);
+	BOOST_CHECK_EQUAL (a.e, 0);
 
-	a = libdcp::Time (60 * 24, 24);
+	a = libdcp::Time (60 * 24, 24, 250);
 	BOOST_CHECK_EQUAL (a.h, 0);
 	BOOST_CHECK_EQUAL (a.m, 1);
 	BOOST_CHECK_EQUAL (a.s, 0);
-	BOOST_CHECK_EQUAL (a.t, 0);
+	BOOST_CHECK_EQUAL (a.e, 0);
 
 	/* Check rounding; 3424 is 142.666666666... seconds or 0.166666666... ticks */
-	a = libdcp::Time (3424, 24);
+	a = libdcp::Time (3424, 24, 250);
 	BOOST_CHECK_EQUAL (a.h, 0);
 	BOOST_CHECK_EQUAL (a.m, 2);
 	BOOST_CHECK_EQUAL (a.s, 22);
-	BOOST_CHECK_EQUAL (a.t, 167);
+	BOOST_CHECK_EQUAL (a.e, 167);
 
-	a = libdcp::Time (3425, 24);
+	a = libdcp::Time (3425, 24, 250);
 	BOOST_CHECK_EQUAL (a.h, 0);
 	BOOST_CHECK_EQUAL (a.m, 2);
 	BOOST_CHECK_EQUAL (a.s, 22);
-	BOOST_CHECK_EQUAL (a.t, 177);
+	BOOST_CHECK_EQUAL (a.e, 177);
+
+	/* Check addition of times with different tcrs */
+	a = libdcp::Time (0, 0, 0, 3, 24);
+	b = libdcp::Time (0, 0, 0, 4, 48);
+	r = a + b;
+	BOOST_CHECK_EQUAL (r, libdcp::Time (0, 0, 0, 240, 1152));
 }
diff --git a/test/subtitle_tests.cc b/test/subtitle_tests.cc
index 0994f329..835ae960 100644
--- a/test/subtitle_tests.cc
+++ b/test/subtitle_tests.cc
@@ -30,91 +30,91 @@ BOOST_AUTO_TEST_CASE (subtitles1)
 
 	BOOST_CHECK_EQUAL (subs.language(), "French");
 
-	list<shared_ptr<libdcp::Subtitle> > s = subs.subtitles_during (libdcp::Time (0, 0, 6, 1), libdcp::Time (0, 0, 6, 2));
+	list<shared_ptr<libdcp::Subtitle> > s = subs.subtitles_during (libdcp::Time (0, 0, 6, 1, 250), libdcp::Time (0, 0, 6, 2, 250));
 	BOOST_CHECK_EQUAL (s.size(), 1);
 	BOOST_CHECK_EQUAL (*(s.front().get()), libdcp::Subtitle (
 				   "Arial",
 				   false,
 				   libdcp::Color (255, 255, 255),
 				   39,
-				   libdcp::Time (0, 0, 5, 198),
-				   libdcp::Time (0, 0, 7, 115),
+				   libdcp::Time (0, 0, 5, 198, 250),
+				   libdcp::Time (0, 0, 7, 115, 250),
 				   15,
 				   libdcp::BOTTOM,
 				   "My jacket was Idi Amin's",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 1),
-				   libdcp::Time (0, 0, 0, 1)
+				   libdcp::Time (0, 0, 0, 1, 250),
+				   libdcp::Time (0, 0, 0, 1, 250)
 				   ));
 							 
-	s = subs.subtitles_during (libdcp::Time (0, 0, 7, 190), libdcp::Time (0, 0, 7, 191));
+	s = subs.subtitles_during (libdcp::Time (0, 0, 7, 190, 250), libdcp::Time (0, 0, 7, 191, 250));
 	BOOST_CHECK_EQUAL (s.size(), 2);
 	BOOST_CHECK_EQUAL (*(s.front().get()), libdcp::Subtitle (
 				   "Arial",
 				   true,
 				   libdcp::Color (255, 255, 255),
 				   39,
-				   libdcp::Time (0, 0, 7, 177),
-				   libdcp::Time (0, 0, 11, 31),
+				   libdcp::Time (0, 0, 7, 177, 250),
+				   libdcp::Time (0, 0, 11, 31, 250),
 				   21,
 				   libdcp::BOTTOM,
 				   "My corset was H.M. The Queen's",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 1),
-				   libdcp::Time (0, 0, 0, 1)
+				   libdcp::Time (0, 0, 0, 1, 250),
+				   libdcp::Time (0, 0, 0, 1, 250)
 				   ));
 	BOOST_CHECK_EQUAL (*(s.back().get()), libdcp::Subtitle (
 				   "Arial",
 				   false,
 				   libdcp::Color (255, 255, 255),
 				   39,
-				   libdcp::Time (0, 0, 7, 177),
-				   libdcp::Time (0, 0, 11, 31),
+				   libdcp::Time (0, 0, 7, 177, 250),
+				   libdcp::Time (0, 0, 11, 31, 250),
 				   15,
 				   libdcp::BOTTOM,
 				   "My large wonderbra",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 1),
-				   libdcp::Time (0, 0, 0, 1)
+				   libdcp::Time (0, 0, 0, 1, 250),
+				   libdcp::Time (0, 0, 0, 1, 250)
 				   ));
 
-	s = subs.subtitles_during (libdcp::Time (0, 0, 11, 95), libdcp::Time (0, 0, 11, 96));
+	s = subs.subtitles_during (libdcp::Time (0, 0, 11, 95, 250), libdcp::Time (0, 0, 11, 96, 250));
 	BOOST_CHECK_EQUAL (s.size(), 1);
 	BOOST_CHECK_EQUAL (*(s.back().get()), libdcp::Subtitle (
 				   "Arial",
 				   false,
 				   libdcp::Color (255, 255, 255),
 				   39,
-				   libdcp::Time (0, 0, 11, 94),
-				   libdcp::Time (0, 0, 13, 63),
+				   libdcp::Time (0, 0, 11, 94, 250),
+				   libdcp::Time (0, 0, 13, 63, 250),
 				   15,
 				   libdcp::BOTTOM,
 				   "Once belonged to the Shah",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 1),
-				   libdcp::Time (0, 0, 0, 1)
+				   libdcp::Time (0, 0, 0, 1, 250),
+				   libdcp::Time (0, 0, 0, 1, 250)
 				   ));
 
-	s = subs.subtitles_during (libdcp::Time (0, 0, 14, 42), libdcp::Time (0, 0, 14, 43));
+	s = subs.subtitles_during (libdcp::Time (0, 0, 14, 42, 250), libdcp::Time (0, 0, 14, 43, 250));
 	BOOST_CHECK_EQUAL (s.size(), 1);
 	BOOST_CHECK_EQUAL (*(s.back().get()), libdcp::Subtitle (
 				   "Arial",
 				   false,
 				   libdcp::Color (255, 255, 255),
 				   39,
-				   libdcp::Time (0, 0, 13, 104),
-				   libdcp::Time (0, 0, 15, 177),
+				   libdcp::Time (0, 0, 13, 104, 250),
+				   libdcp::Time (0, 0, 15, 177, 250),
 				   15,
 				   libdcp::BOTTOM,
 				   "And these are Roy Hattersley's jeans",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 1),
-				   libdcp::Time (0, 0, 0, 1)
+				   libdcp::Time (0, 0, 0, 1, 250),
+				   libdcp::Time (0, 0, 0, 1, 250)
 				   ));
 }
 
@@ -123,300 +123,327 @@ BOOST_AUTO_TEST_CASE (subtitles2)
 {
 	libdcp::SubtitleAsset subs ("test/data", "subs2.xml");
 
-	list<shared_ptr<libdcp::Subtitle> > s = subs.subtitles_during (libdcp::Time (0, 0, 42, 100), libdcp::Time (0, 0, 42, 101));
+	list<shared_ptr<libdcp::Subtitle> > s = subs.subtitles_during (libdcp::Time (0, 0, 42, 100, 250), libdcp::Time (0, 0, 42, 101, 250));
 	BOOST_CHECK_EQUAL (s.size(), 2);
 	BOOST_CHECK_EQUAL (*(s.front().get()), libdcp::Subtitle (
 				   "Arial",
 				   true,
 				   libdcp::Color (255, 255, 255),
 				   42,
-				   libdcp::Time (0, 0, 41, 62),
-				   libdcp::Time (0, 0, 43, 52),
+				   libdcp::Time (0, 0, 41, 62, 250),
+				   libdcp::Time (0, 0, 43, 52, 250),
 				   89,
 				   libdcp::TOP,
 				   "At afternoon tea with John Peel",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0)
+				   libdcp::Time (0, 0, 0, 0, 250),
+				   libdcp::Time (0, 0, 0, 0, 250)
 				   ));
 	BOOST_CHECK_EQUAL (*(s.back().get()), libdcp::Subtitle (
 				   "Arial",
 				   true,
 				   libdcp::Color (255, 255, 255),
 				   42,
-				   libdcp::Time (0, 0, 41, 62),
-				   libdcp::Time (0, 0, 43, 52),
+				   libdcp::Time (0, 0, 41, 62, 250),
+				   libdcp::Time (0, 0, 43, 52, 250),
 				   95,
 				   libdcp::TOP,
 				   "I enquired if his accent was real",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0)
+				   libdcp::Time (0, 0, 0, 0, 250),
+				   libdcp::Time (0, 0, 0, 0, 250)
 				   ));
 
-	s = subs.subtitles_during (libdcp::Time (0, 0, 50, 50), libdcp::Time (0, 0, 50, 51));
+	s = subs.subtitles_during (libdcp::Time (0, 0, 50, 50, 250), libdcp::Time (0, 0, 50, 51, 250));
 	BOOST_CHECK_EQUAL (s.size(), 2);
 	BOOST_CHECK_EQUAL (*(s.front().get()), libdcp::Subtitle (
 				   "Arial",
 				   true,
 				   libdcp::Color (255, 255, 255),
 				   42,
-				   libdcp::Time (0, 0, 50, 42),
-				   libdcp::Time (0, 0, 52, 21),
+				   libdcp::Time (0, 0, 50, 42, 250),
+				   libdcp::Time (0, 0, 52, 21, 250),
 				   89,
 				   libdcp::TOP,
 				   "He said \"out of the house",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0)
+				   libdcp::Time (0, 0, 0, 0, 250),
+				   libdcp::Time (0, 0, 0, 0, 250)
 				   ));
 	BOOST_CHECK_EQUAL (*(s.back().get()), libdcp::Subtitle (
 				   "Arial",
 				   true,
 				   libdcp::Color (255, 255, 255),
 				   42,
-				   libdcp::Time (0, 0, 50, 42),
-				   libdcp::Time (0, 0, 52, 21),
+				   libdcp::Time (0, 0, 50, 42, 250),
+				   libdcp::Time (0, 0, 52, 21, 250),
 				   95,
 				   libdcp::TOP,
 				   "I'm incredibly scouse",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0)
+				   libdcp::Time (0, 0, 0, 0, 250),
+				   libdcp::Time (0, 0, 0, 0, 250)
 				   ));
 
-	s = subs.subtitles_during (libdcp::Time (0, 1, 2, 300), libdcp::Time (0, 1, 2, 301));
+	s = subs.subtitles_during (libdcp::Time (0, 1, 2, 300, 250), libdcp::Time (0, 1, 2, 301, 250));
 	BOOST_CHECK_EQUAL (s.size(), 2);
 	BOOST_CHECK_EQUAL (*(s.front().get()), libdcp::Subtitle (
 				   "Arial",
 				   true,
 				   libdcp::Color (255, 255, 255),
 				   42,
-				   libdcp::Time (0, 1, 2, 208),
-				   libdcp::Time (0, 1, 4, 10),
+				   libdcp::Time (0, 1, 2, 208, 250),
+				   libdcp::Time (0, 1, 4, 10, 250),
 				   89,
 				   libdcp::TOP,
 				   "At home it depends how I feel.\"",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0)
+				   libdcp::Time (0, 0, 0, 0, 250),
+				   libdcp::Time (0, 0, 0, 0, 250)
 				   ));
 	BOOST_CHECK_EQUAL (*(s.back().get()), libdcp::Subtitle (
 				   "Arial",
 				   true,
 				   libdcp::Color (255, 255, 255),
 				   42,
-				   libdcp::Time (0, 1, 2, 208),
-				   libdcp::Time (0, 1, 4, 10),
+				   libdcp::Time (0, 1, 2, 208, 250),
+				   libdcp::Time (0, 1, 4, 10, 250),
 				   95,
 				   libdcp::TOP,
 				   "I spent a long weekend in Brighton",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0)
+				   libdcp::Time (0, 0, 0, 0, 250),
+				   libdcp::Time (0, 0, 0, 0, 250)
 				   ));
 
-	s = subs.subtitles_during (libdcp::Time (0, 1, 15, 50), libdcp::Time (0, 1, 15, 51));
+	s = subs.subtitles_during (libdcp::Time (0, 1, 15, 50, 250), libdcp::Time (0, 1, 15, 51, 250));
 	BOOST_CHECK_EQUAL (s.size(), 2);
 	BOOST_CHECK_EQUAL (*(s.front().get()), libdcp::Subtitle (
 				   "Arial",
 				   true,
 				   libdcp::Color (255, 255, 255),
 				   42,
-				   libdcp::Time (0, 1, 15, 42),
-				   libdcp::Time (0, 1, 16, 42),
+				   libdcp::Time (0, 1, 15, 42, 250),
+				   libdcp::Time (0, 1, 16, 42, 250),
 				   89,
 				   libdcp::TOP,
 				   "With the legendary Miss Enid Blyton",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0)
+				   libdcp::Time (0, 0, 0, 0, 250),
+				   libdcp::Time (0, 0, 0, 0, 250)
 				   ));
 	BOOST_CHECK_EQUAL (*(s.back().get()), libdcp::Subtitle (
 				   "Arial",
 				   true,
 				   libdcp::Color (255, 255, 255),
 				   42,
-				   libdcp::Time (0, 1, 15, 42),
-				   libdcp::Time (0, 1, 16, 42),
+				   libdcp::Time (0, 1, 15, 42, 250),
+				   libdcp::Time (0, 1, 16, 42, 250),
 				   95,
 				   libdcp::TOP,
 				   "She said \"you be Noddy",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0)
+				   libdcp::Time (0, 0, 0, 0, 250),
+				   libdcp::Time (0, 0, 0, 0, 250)
 				   ));
 
-	s = subs.subtitles_during (libdcp::Time (0, 1, 27, 200), libdcp::Time (0, 1, 27, 201));
+	s = subs.subtitles_during (libdcp::Time (0, 1, 27, 200, 250), libdcp::Time (0, 1, 27, 201, 250));
 	BOOST_CHECK_EQUAL (s.size(), 2);
 	BOOST_CHECK_EQUAL (*(s.front().get()), libdcp::Subtitle (
 				   "Arial",
 				   true,
 				   libdcp::Color (255, 255, 255),
 				   42,
-				   libdcp::Time (0, 1, 27, 115),
-				   libdcp::Time (0, 1, 28, 208),
+				   libdcp::Time (0, 1, 27, 115, 250),
+				   libdcp::Time (0, 1, 28, 208, 250),
 				   89,
 				   libdcp::TOP,
 				   "That curious creature the Sphinx",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0)
+				   libdcp::Time (0, 0, 0, 0, 250),
+				   libdcp::Time (0, 0, 0, 0, 250)
 				   ));
 	BOOST_CHECK_EQUAL (*(s.back().get()), libdcp::Subtitle (
 				   "Arial",
 				   true,
 				   libdcp::Color (255, 255, 255),
 				   42,
-				   libdcp::Time (0, 1, 27, 115),
-				   libdcp::Time (0, 1, 28, 208),
+				   libdcp::Time (0, 1, 27, 115, 250),
+				   libdcp::Time (0, 1, 28, 208, 250),
 				   95,
 				   libdcp::TOP,
 				   "Is smarter than anyone thinks",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0)
+				   libdcp::Time (0, 0, 0, 0, 250),
+				   libdcp::Time (0, 0, 0, 0, 250)
 				   ));
 
-	s = subs.subtitles_during (libdcp::Time (0, 1, 42, 300), libdcp::Time (0, 1, 42, 301));
+	s = subs.subtitles_during (libdcp::Time (0, 1, 42, 300, 250), libdcp::Time (0, 1, 42, 301, 250));
 	BOOST_CHECK_EQUAL (s.size(), 2);
 	BOOST_CHECK_EQUAL (*(s.front().get()), libdcp::Subtitle (
 				   "Arial",
 				   false,
 				   libdcp::Color (255, 255, 255),
 				   42,
-				   libdcp::Time (0, 1, 42, 229),
-				   libdcp::Time (0, 1, 45, 62),
+				   libdcp::Time (0, 1, 42, 229, 250),
+				   libdcp::Time (0, 1, 45, 62, 250),
 				   89,
 				   libdcp::TOP,
 				   "It sits there and smirks",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0)
+				   libdcp::Time (0, 0, 0, 0, 250),
+				   libdcp::Time (0, 0, 0, 0, 250)
 				   ));
 	BOOST_CHECK_EQUAL (*(s.back().get()), libdcp::Subtitle (
 				   "Arial",
 				   false,
 				   libdcp::Color (255, 255, 255),
 				   42,
-				   libdcp::Time (0, 1, 42, 229),
-				   libdcp::Time (0, 1, 45, 62),
+				   libdcp::Time (0, 1, 42, 229, 250),
+				   libdcp::Time (0, 1, 45, 62, 250),
 				   95,
 				   libdcp::TOP,
 				   "And you don't think it works",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0)
+				   libdcp::Time (0, 0, 0, 0, 250),
+				   libdcp::Time (0, 0, 0, 0, 250)
 				   ));
 
-	s = subs.subtitles_during (libdcp::Time (0, 1, 45, 200), libdcp::Time (0, 1, 45, 201));
+	s = subs.subtitles_during (libdcp::Time (0, 1, 45, 200, 250), libdcp::Time (0, 1, 45, 201, 250));
 	BOOST_CHECK_EQUAL (s.size(), 2);
 	BOOST_CHECK_EQUAL (*(s.front().get()), libdcp::Subtitle (
 				   "Arial",
 				   false,
 				   libdcp::Color (255, 255, 255),
 				   42,
-				   libdcp::Time (0, 1, 45, 146),
-				   libdcp::Time (0, 1, 47, 94),
+				   libdcp::Time (0, 1, 45, 146, 250),
+				   libdcp::Time (0, 1, 47, 94, 250),
 				   89,
 				   libdcp::TOP,
 				   "Then when you're not looking, it winks.",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0)
+				   libdcp::Time (0, 0, 0, 0, 250),
+				   libdcp::Time (0, 0, 0, 0, 250)
 				   ));
 	BOOST_CHECK_EQUAL (*(s.back().get()), libdcp::Subtitle (
 				   "Arial",
 				   false,
 				   libdcp::Color (255, 255, 255),
 				   42,
-				   libdcp::Time (0, 1, 45, 146),
-				   libdcp::Time (0, 1, 47, 94),
+				   libdcp::Time (0, 1, 45, 146, 250),
+				   libdcp::Time (0, 1, 47, 94, 250),
 				   95,
 				   libdcp::TOP,
 				   "When it snows you will find Sister Sledge",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0)
+				   libdcp::Time (0, 0, 0, 0, 250),
+				   libdcp::Time (0, 0, 0, 0, 250)
 				   ));
 
-	s = subs.subtitles_during (libdcp::Time (0, 1, 47, 249), libdcp::Time (0, 1, 47, 250));
+	s = subs.subtitles_during (libdcp::Time (0, 1, 47, 249, 250), libdcp::Time (0, 1, 47, 250, 250));
 	BOOST_CHECK_EQUAL (s.size(), 2);
 	BOOST_CHECK_EQUAL (*(s.front().get()), libdcp::Subtitle (
 				   "Arial",
 				   false,
 				   libdcp::Color (255, 255, 255),
 				   42,
-				   libdcp::Time (0, 1, 47, 146),
-				   libdcp::Time (0, 1, 48, 167),
+				   libdcp::Time (0, 1, 47, 146, 250),
+				   libdcp::Time (0, 1, 48, 167, 250),
 				   89,
 				   libdcp::TOP,
 				   "Out mooning, at night, on the ledge",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0)
+				   libdcp::Time (0, 0, 0, 0, 250),
+				   libdcp::Time (0, 0, 0, 0, 250)
 				   ));
 	BOOST_CHECK_EQUAL (*(s.back().get()), libdcp::Subtitle (
 				   "Arial",
 				   false,
 				   libdcp::Color (255, 255, 255),
 				   42,
-				   libdcp::Time (0, 1, 47, 146),
-				   libdcp::Time (0, 1, 48, 167),
+				   libdcp::Time (0, 1, 47, 146, 250),
+				   libdcp::Time (0, 1, 48, 167, 250),
 				   95,
 				   libdcp::TOP,
 				   "One storey down",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0)
+				   libdcp::Time (0, 0, 0, 0, 250),
+				   libdcp::Time (0, 0, 0, 0, 250)
 				   ));
 
-	s = subs.subtitles_during (libdcp::Time (0, 2, 6, 210), libdcp::Time (0, 2, 6, 211));
+	s = subs.subtitles_during (libdcp::Time (0, 2, 6, 210, 250), libdcp::Time (0, 2, 6, 211, 250));
 	BOOST_CHECK_EQUAL (s.size(), 2);
 	BOOST_CHECK_EQUAL (*(s.front().get()), libdcp::Subtitle (
 				   "Arial",
 				   true,
 				   libdcp::Color (255, 255, 255),
 				   42,
-				   libdcp::Time (0, 2, 5, 208),
-				   libdcp::Time (0, 2, 7, 31),
+				   libdcp::Time (0, 2, 5, 208, 250),
+				   libdcp::Time (0, 2, 7, 31, 250),
 				   89,
 				   libdcp::TOP,
 				   "HELLO",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0)
+				   libdcp::Time (0, 0, 0, 0, 250),
+				   libdcp::Time (0, 0, 0, 0, 250)
 				   ));
 	BOOST_CHECK_EQUAL (*(s.back().get()), libdcp::Subtitle (
 				   "Arial",
 				   true,
 				   libdcp::Color (255, 255, 255),
 				   42,
-				   libdcp::Time (0, 2, 5, 208),
-				   libdcp::Time (0, 2, 7, 31),
+				   libdcp::Time (0, 2, 5, 208, 250),
+				   libdcp::Time (0, 2, 7, 31, 250),
 				   95,
 				   libdcp::TOP,
 				   "WORLD",
 				   libdcp::BORDER,
 				   libdcp::Color (0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0),
-				   libdcp::Time (0, 0, 0, 0)
+				   libdcp::Time (0, 0, 0, 0, 250),
+				   libdcp::Time (0, 0, 0, 0, 250)
 				   ));
 }
+
+/* A very simple SMPTE one */
+BOOST_AUTO_TEST_CASE (subtitles3)
+{
+	libdcp::SubtitleAsset subs ("test/data", "subs3.xml");
+
+	list<shared_ptr<libdcp::Subtitle> > s = subs.subtitles_during (libdcp::Time (0, 0, 0, 0, 25), libdcp::Time (0, 0, 7, 0, 25));
+
+	BOOST_REQUIRE_EQUAL (s.size(), 1);
+	BOOST_CHECK_EQUAL (*(s.front().get()), libdcp::Subtitle (
+				   "",
+				   false,
+				   libdcp::Color (255, 255, 255),
+				   42,
+				   libdcp::Time (0, 0, 4, 21, 25),
+				   libdcp::Time (0, 0, 6, 5, 25),
+				   8,
+				   libdcp::BOTTOM,
+				   "Hello world",
+				   libdcp::BORDER,
+				   libdcp::Color (0, 0, 0),
+				   libdcp::Time (0, 0, 0, 0, 25),
+				   libdcp::Time (0, 0, 0, 0, 25)
+				   ));
+
+
+}