summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-02-12Pass certificate validity length into the constructor.v1.8.7Carl Hetherington
2022-02-12Cleanup: use dcp::LocalTime for certificate validity times.Carl Hetherington
Before we were using struct tm but not filling it all in, which seems quite unpleasant.
2022-01-17Use optional for ReelAsset _annotation_text.v1.8.6Carl Hetherington
Not only is this tag optional in Interop and SMPTE, but it would appear that if it is present but empty a DCP will not play back on Sony SRX320 / LMT3000 systems (DoM bug #2124). Here we use optional<>, as seems to make sense, and also refuse to write empty tags (instead omitting the tag entirely).
2021-11-09Fix off-by-one in verification of closed caption line length.v1.8.5Carl Hetherington
2021-10-25Message tweak.Carl Hetherington
2021-10-24Order subtitles in the XML according to their vertical position (DoM bug #2106).v1.8.4Carl Hetherington
2021-10-24Allow specification of valign when writing verify tests.Carl Hetherington
2021-10-18Remove some unused using statements.Carl Hetherington
2021-10-13Basic implementation of <Space> tag in subtitles.v1.8.3Carl Hetherington
2021-10-10Remove some unused using commands.Carl Hetherington
2021-10-08Fix problems when adding KDMs to a VF, before adding the OV.v1.8.2Carl Hetherington
If we have a KDM which contains keys for all the assets referred to by a VF (even the ones in the OV) we would previously throw an exception because we tried to give the KDM to the resolved assets when it was given to the Reel. Here we change things so that the addition of KDMs to assets can be deferred if the asset is not yet resolved.
2021-10-06Fix incorrect error code (2K when it should be 4K).v1.8.1Carl Hetherington
2021-10-06Tweak comments for the DoM manual.Carl Hetherington
2021-10-05Remove an unnecessary using.Carl Hetherington
2021-10-03Build with libcxml 0.17.2.v1.8.0Carl Hetherington
2021-10-03Make the former dcst namespace default for SMPTE subtitles.Carl Hetherington
In DoM bug #2061 it is reported that Easy DCP gives the error "XML Document has default root namespace prefix: dcst. Default namespace should not use prefix for root or root namespace child nodes." with SMPTE subtitle files written by DCP-o-matic, and that the correct fix is to make the former dcst: namespace the default and then remove the dcst: qualifiers from everything. I'm not sure I agree with the error; AFAICS the subtitle files written by previous versions did not have a default root namespace prefix, since it was specified by xmlns:dcst and not just xmlns alone, so I think they were valid. However, using a default NS also seems fine, slightly simplifies the code and produces more compact subtitle files, so we change that here. It should also stop Easy DCP complaining, which is always marginally preferable to sticking to our guns and getting the blame for it.
2021-10-03Add .cache.Carl Hetherington
2021-08-22Add some missing LIBDCP_RESOURCES.Carl Hetherington
2021-08-11Improve message on verify test failure.Carl Hetherington
2021-08-11Add verify check for empty <Text> nodes in timed text.Carl Hetherington
2021-08-09Rename verify_text_timing -> verify_text_details.Carl Hetherington
2021-08-04Add support for writing CPL metadata about sign language video tracks (DoM ↵Carl Hetherington
#2062).
2021-08-04C++11 tidying.Carl Hetherington
2021-08-04Add a belt-and-braces check.Carl Hetherington
2021-08-04Don't bother checking the return of node_child as it can never be nullCarl Hetherington
2021-08-04Make adding extension metadata items more generic.Carl Hetherington
2021-08-04Fix tests after previous commit.Carl Hetherington
2021-07-15Fix incorrect channel assigment (DoM bug #2062).Carl Hetherington
2021-07-14C++11 tidying.Carl Hetherington
2021-06-26C++11 cleanup.Carl Hetherington
2021-06-24Add issuer() and creator() getters to CPL.Carl Hetherington
2021-06-18Fix tests after changes to language tags.Carl Hetherington
2021-06-18Remove count at start of language files that wasn't being read.Carl Hetherington
2021-06-18Fix strange python 3 incompatibilities.Carl Hetherington
2021-06-12Fix update-language-subtags to include all descriptions for a particular code.Carl Hetherington
This avoids, e.g. "nl" being labelled as only Flemish and not also Dutch.
2021-06-04Add option to ignore mismatched HMACs when reading MXFs.Carl Hetherington
2021-06-04Missing finalize() in dcpdecryptmxf.Carl Hetherington
2021-06-04Improve dcpdecryptmxf in various ways.Carl Hetherington
2021-06-04Fix up dcpdecryptmxf start script in various ways.Carl Hetherington
2021-06-04Add missing LIBDCP_RESOURCES to script.Carl Hetherington
2021-06-02Test churn from adding make_uuid() into CPL.Carl Hetherington
2021-06-02Improve output when a test fails.Carl Hetherington
2021-06-02Reduce test flakyness a bit.Carl Hetherington
2021-06-02Pass through CompositionMetadataAsset correctly.Carl Hetherington
We weren't saving Id, and were not quite handling FullContentText correctly.
2021-05-27Make similar changes to the previous commit for _xml_id.Carl Hetherington
This is also unavailable if the asset is encrypted.
2021-05-27Tidy handling of _raw_xml.Carl Hetherington
Before this if we tried to get the XML of an encrypted asset we would just get an empty string. Now we get a boost::none which means the verifier can avoid trying to check details of the XML (and instead raise a warning that you are trying to verify data that it cannot decrypt).
2021-05-27Fix bug causing failure to decrypt SMPTE subtitles.Carl Hetherington
2021-05-27C++11 cleanup.Carl Hetherington
2021-05-27Read the bits we can from the MXF header even when it is encrypted.Carl Hetherington
2021-05-27Sort notes when checking verifications.Carl Hetherington
So that the lists in the tests don't have to be in the right order.