| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
|
|
In DoM bug #2061 it is reported that Easy DCP gives the error
"XML Document has default root namespace prefix: dcst.
Default namespace should not use prefix for root or root namespace child nodes."
with SMPTE subtitle files written by DCP-o-matic, and that the correct
fix is to make the former dcst: namespace the default and then remove
the dcst: qualifiers from everything.
I'm not sure I agree with the error; AFAICS the subtitle files written
by previous versions did not have a default root namespace prefix,
since it was specified by xmlns:dcst and not just xmlns alone, so I
think they were valid.
However, using a default NS also seems fine, slightly simplifies the
code and produces more compact subtitle files, so we change that here.
It should also stop Easy DCP complaining, which is always marginally
preferable to sticking to our guns and getting the blame for it.
|
|
When reading/writing the XML for image subtitles, we assumed that
the content of the <Image> tag is just the ID of the PNG in the MXF,
without any prefix.
DoM bug #1965 mentions a DCP where this is not the case, and SMPTE
429-5-2009 has an example where there is urn:uuid: in the XML.
This change makes DoM write this urn:uuid: prefix, and accept it if
it's present (but not complain if it's not).
If the urn:uuid: _is_ required in the field, it's a bit surprising
that nobody has complained up to this point. Maybe nobody noticed,
or nobody reported it.
|
|
Check that subtitles don't overlap reel boundaries, and fix a few
tests that trip this check.
Fix confusion when calculating subtitle timings during verification
where the picture asset frame rate was being used rather than the
subtitle asset's edit rate.
Do the subtitle timing verification for Interop as well as SMPTE
subtitles.
Take <StartTime> tags into account when checking subtitles, even
though Bv2.1 says they should be set to 0.
Rename Time::as_editable_units to Time::as_editable_units_ceil
and add a _floor variant, then use that to round down when checking
reel boundary overlaps.
|
|
|
|
|
|
|
|
|
|
indices). Basic and untested SMPTE image subtitle support.
|
|
|
|
|
|
|
|
in-line font changes (#952).
|
