| Age | Commit message (Collapse) | Author |
|
|
|
Not only is this tag optional in Interop and SMPTE, but it would
appear that if it is present but empty a DCP will not play back
on Sony SRX320 / LMT3000 systems (DoM bug #2124).
Here we use optional<>, as seems to make sense, and also refuse
to write empty tags (instead omitting the tag entirely).
|
|
|
|
I had previously assumed that one should write MCA information into
the sound MXF based on what channels actually contain sound rather
than silence.
However a previous example of a stereo DCP gives a verification error
in EasyDCP (see DoM bug #1935) which is solved by adding MCA tags
for each channel in the specified sound field (e.g. at least 6 tags
for a file which is marked as 5.1) even if the audio is really stereo.
This commit removes the "active channels" stuff and makes sure
that if we say a file is 5.1 we write at least 6 MCA tags (and
similarly for 7.1).
|
|
|
|
when writing it out again, rather than creating a new one each time.
Also there is the associated test churn here from removing a call
to make_uuid().
|
|
stopping test reference churn.
|
|
in tests.
Also fix tests to reflect <AnnotationText> no longer being filled in with a default
value.
|
|
|
|
default content version label text as it's a bit confusing.
|
|
|
|
|
|
|
|
|
|
|