summaryrefslogtreecommitdiff
path: root/test/smpte_subtitle_test.cc
AgeCommit message (Collapse)Author
2022-04-22Fix some macOS signed/unsigned warnings.Carl Hetherington
2022-03-20Nearly pretty-print subtitle XML (though not in <Text> nodes).v1.8.12Carl Hetherington
This is an attempt to fix DoM bug #2205.
2021-10-24Order subtitles in the XML according to their vertical position (DoM bug #2106).v1.8.4Carl Hetherington
2021-10-13Basic implementation of <Space> tag in subtitles.v1.8.3Carl Hetherington
2021-10-03Make the former dcst namespace default for SMPTE subtitles.Carl Hetherington
In DoM bug #2061 it is reported that Easy DCP gives the error "XML Document has default root namespace prefix: dcst. Default namespace should not use prefix for root or root namespace child nodes." with SMPTE subtitle files written by DCP-o-matic, and that the correct fix is to make the former dcst: namespace the default and then remove the dcst: qualifiers from everything. I'm not sure I agree with the error; AFAICS the subtitle files written by previous versions did not have a default root namespace prefix, since it was specified by xmlns:dcst and not just xmlns alone, so I think they were valid. However, using a default NS also seems fine, slightly simplifies the code and produces more compact subtitle files, so we change that here. It should also stop Easy DCP complaining, which is always marginally preferable to sticking to our guns and getting the blame for it.
2021-04-14Improve handling of image subtitle IDs in XML (DoM bug #1965)Carl Hetherington
When reading/writing the XML for image subtitles, we assumed that the content of the <Image> tag is just the ID of the PNG in the MXF, without any prefix. DoM bug #1965 mentions a DCP where this is not the case, and SMPTE 429-5-2009 has an example where there is urn:uuid: in the XML. This change makes DoM write this urn:uuid: prefix, and accept it if it's present (but not complain if it's not). If the urn:uuid: _is_ required in the field, it's a bit surprising that nobody has complained up to this point. Maybe nobody noticed, or nobody reported it.
2021-04-14Move some tests from write_subtitle_test to smpte_subtitle_test.Carl Hetherington
2021-04-14Merge read_smpte_subtitle_test with smpte_subtitle_test.Carl Hetherington
2021-01-21Use enum class for the things in types.hCarl Hetherington
2021-01-08std::shared_ptrCarl Hetherington
2018-07-07SubtitleString -> shared_ptr<Subtitle>Carl Hetherington
2018-02-12Use a different ID for the XML inside a SMPTE subtitle MXF than theCarl Hetherington
ID for the MXF itself. Apparently not doing so is an error (according to Doremi's release notes for 2.8.18).
2015-06-08Rename some tests.Carl Hetherington
2015-06-05Rename some stuff Content -> Asset.Carl Hetherington
2015-01-03Add support for reading non-MXF-wrapped SMPTE subtitle files.Carl Hetherington