summaryrefslogtreecommitdiff
path: root/test/verify_test.cc
AgeCommit message (Collapse)Author
2023-02-16Change how whitespace in subtitles is handled.Carl Hetherington
Previously we would discard any whitespace subtitle content we found. This had the side-effect of making a verification test fail (checking that at least one subtitle is in each reel; blank subtitles are often used to avoid this warning). Here we take any subtitle content, whitespace or not, inside a <Text> or <Image> node which I think is a little more correct.
2023-02-12Add --no-asset-hash-check and --asset-hash-check-maximum-size (DoM #2444).v1.8.56Carl Hetherington
2023-02-02Check IssueDate for Deluxe complaint.Carl Hetherington
2023-01-16Fix tests.v1.8.51Carl Hetherington
2023-01-15Check that Interop subtitle files have at least one subtitle.Carl Hetherington
It was reported on the forum that files without any <Font> or <Subtitle> tags fail validation on EasyDCP 3.0.1 and crash Qubemaster Pro 3.0.15.
2023-01-07Check for multiple asset IDs in an ASSETMAP during verify.Carl Hetherington
2023-01-07Check for multiple asset IDs in a PKL during verify.Carl Hetherington
2022-12-22Write OriginalFileName tags in PKL (DoM #2394).Carl Hetherington
Without these it EasyDCP gives errors like "Id field in PKL must match uuid in asset" "Each Id used in the PKL files must be unique or reference the same file" which seem wrong but, as usual, here we are.
2022-12-16Verify that main picture active area is valid (even, and not too big) (#2392).v1.8.40Carl Hetherington
2022-12-15Tidy up find_cpl() and add find_pkl().Carl Hetherington
2022-12-15Some more details when verification results fail.Carl Hetherington
2022-12-15Add delete_lines_after to the Editor.Carl Hetherington
2022-12-15Add some line spacing in the editor.Carl Hetherington
2022-12-15Tidy the Editor class up a little.Carl Hetherington
2022-12-04Fix some ambiguous shared_ptrs, seen on Arch Linux.Carl Hetherington
2022-11-03Add Z position to subtitles; existing tests pass.Carl Hetherington
2022-09-03Properly support ContentKind scope attribute.v1.8.26Carl Hetherington
2022-05-04Make some tests repeatable across platforms.Carl Hetherington
2022-05-04Allow tests to be run on Windows.Carl Hetherington
2022-04-25Tidy up write_xml() API a little.Carl Hetherington
2022-04-21Fix unsigned/signed warning on macOS.Carl Hetherington
2022-04-12Add and use new File class.merged-to-mainCarl Hetherington
It was always a bit troubling that fopen_boost wasn't exception safe, and this also fixes a leak where load_ratings_list would never close the ratings file.
2022-03-24Add verify test to check for erroneous <EntryPoint> and <Duration>v1.8.132215-markersCarl Hetherington
tags inside <MainMarkers>
2022-03-24Remove <EntryPoint> and <Duration> from <ReelMarkerAsset> tags.Carl Hetherington
They should not be there: "EntryPoint" ... "This element shall only be present when the Asset refers to an external resource such as a Track File". Fixes DoM bug #2215.
2022-03-20Nearly pretty-print subtitle XML (though not in <Text> nodes).v1.8.12Carl Hetherington
This is an attempt to fix DoM bug #2205.
2022-01-17Use optional for ReelAsset _annotation_text.v1.8.6Carl Hetherington
Not only is this tag optional in Interop and SMPTE, but it would appear that if it is present but empty a DCP will not play back on Sony SRX320 / LMT3000 systems (DoM bug #2124). Here we use optional<>, as seems to make sense, and also refuse to write empty tags (instead omitting the tag entirely).
2021-11-09Fix off-by-one in verification of closed caption line length.v1.8.5Carl Hetherington
2021-10-24Order subtitles in the XML according to their vertical position (DoM bug #2106).v1.8.4Carl Hetherington
2021-10-24Allow specification of valign when writing verify tests.Carl Hetherington
2021-10-13Basic implementation of <Space> tag in subtitles.v1.8.3Carl Hetherington
2021-10-08Fix problems when adding KDMs to a VF, before adding the OV.v1.8.2Carl Hetherington
If we have a KDM which contains keys for all the assets referred to by a VF (even the ones in the OV) we would previously throw an exception because we tried to give the KDM to the resolved assets when it was given to the Reel. Here we change things so that the addition of KDMs to assets can be deferred if the asset is not yet resolved.
2021-10-03Make the former dcst namespace default for SMPTE subtitles.Carl Hetherington
In DoM bug #2061 it is reported that Easy DCP gives the error "XML Document has default root namespace prefix: dcst. Default namespace should not use prefix for root or root namespace child nodes." with SMPTE subtitle files written by DCP-o-matic, and that the correct fix is to make the former dcst: namespace the default and then remove the dcst: qualifiers from everything. I'm not sure I agree with the error; AFAICS the subtitle files written by previous versions did not have a default root namespace prefix, since it was specified by xmlns:dcst and not just xmlns alone, so I think they were valid. However, using a default NS also seems fine, slightly simplifies the code and produces more compact subtitle files, so we change that here. It should also stop Easy DCP complaining, which is always marginally preferable to sticking to our guns and getting the blame for it.
2021-08-11Improve message on verify test failure.Carl Hetherington
2021-08-11Add verify check for empty <Text> nodes in timed text.Carl Hetherington
2021-08-04Add a belt-and-braces check.Carl Hetherington
2021-08-04Fix tests after previous commit.Carl Hetherington
2021-06-02Improve output when a test fails.Carl Hetherington
2021-06-02Reduce test flakyness a bit.Carl Hetherington
2021-05-27Sort notes when checking verifications.Carl Hetherington
So that the lists in the tests don't have to be in the right order.
2021-04-22Don't give an error on verifying Interop DCPs with possibly-incorrectlyCarl Hetherington
marked 3D assets. This also adds a warning into the verification output. I don't know if this is actually a standard violation but they have been seen in the wild made by "reputable" DCP creation software. DoM bug #1976.
2021-04-14Improve handling of image subtitle IDs in XML (DoM bug #1965)Carl Hetherington
When reading/writing the XML for image subtitles, we assumed that the content of the <Image> tag is just the ID of the PNG in the MXF, without any prefix. DoM bug #1965 mentions a DCP where this is not the case, and SMPTE 429-5-2009 has an example where there is urn:uuid: in the XML. This change makes DoM write this urn:uuid: prefix, and accept it if it's present (but not complain if it's not). If the urn:uuid: _is_ required in the field, it's a bit surprising that nobody has complained up to this point. Maybe nobody noticed, or nobody reported it.
2021-04-12Split ReelClosedCaptionAsset into Interop and SMPTE parts.Carl Hetherington
2021-04-12C++11 tidying.Carl Hetherington
2021-04-12Specify CPL standard on construction.Carl Hetherington
Then choose which standard DCP should use based on the CPL(s).
2021-04-12Split ReelSubtitleAsset into Interop and SMPTE classes.Carl Hetherington
2021-04-09Add check for Bv2.1 10.4.3 - container duration vs reel duration in timed text.Carl Hetherington
2021-04-08Verify that SMPTE subtitle IDs are handled properly (DoM #1962).Carl Hetherington
2021-04-06Don't try to verify encrypted JPEG2000 bitstreams.Carl Hetherington
2021-04-06Hide dump_notes() again.Carl Hetherington
2021-04-06Call verify_j2k when verifying DCPs.Carl Hetherington
generated by cgit v1.2.3 (git 2.46.0) at 2026-04-09 08:04:14 +0000