| Age | Commit message (Collapse) | Author | |
|---|---|---|---|
| 2023-05-11 | Check that all <Font> tags have a corresponding <LoadFont> in the verifier. | Carl Hetherington | |
| 2023-04-19 | Add test for too many subtitle namespaces. | Carl Hetherington | |
| 2023-04-19 | Remove xmlns:xs namespace from subtitle XML (DoM #2498). | Carl Hetherington | |
| 2023-04-16 | Check for tile parts being too big in the verifier (DoM #2450). | Carl Hetherington | |
| 2023-04-13 | Add check for Interop font assets being present (in the ASSETMAP and on disk). | Carl Hetherington | |
| 2023-04-11 | Fix typos in comments. | Carl Hetherington | |
| 2023-04-04 | Add check for mismatch between sound asset and MainSoundConfiguration.v1.8.66 | Carl Hetherington | |
| 2023-04-04 | Add check for mismatched sound channel counts. | Carl Hetherington | |
| 2023-04-04 | Pass MainSoundConfiguration object rather than a string. | Carl Hetherington | |
| I guess originally it was a string mostly because it's not very well defined, and Interop seemingly does whatever it wants. This basic change also means that things are checked more carefully, and so we must be more relaxed with some things seen in the wild that I can't find contradictions for in the standard (and also with the case of channel IDs, which does seem to be mentioned in the standard). | |||
| 2023-04-04 | Add some missing sound field specifiers to tests. | Carl Hetherington | |
| 2023-03-20 | Use an enum instead of a bool in PictureAsset::start_write(). | Carl Hetherington | |
| 2023-02-16 | Change how whitespace in subtitles is handled. | Carl Hetherington | |
| Previously we would discard any whitespace subtitle content we found. This had the side-effect of making a verification test fail (checking that at least one subtitle is in each reel; blank subtitles are often used to avoid this warning). Here we take any subtitle content, whitespace or not, inside a <Text> or <Image> node which I think is a little more correct. | |||
| 2023-02-12 | Add --no-asset-hash-check and --asset-hash-check-maximum-size (DoM #2444).v1.8.56 | Carl Hetherington | |
| 2023-02-02 | Check IssueDate for Deluxe complaint. | Carl Hetherington | |
| 2023-01-16 | Fix tests.v1.8.51 | Carl Hetherington | |
| 2023-01-15 | Check that Interop subtitle files have at least one subtitle. | Carl Hetherington | |
| It was reported on the forum that files without any <Font> or <Subtitle> tags fail validation on EasyDCP 3.0.1 and crash Qubemaster Pro 3.0.15. | |||
| 2023-01-07 | Check for multiple asset IDs in an ASSETMAP during verify. | Carl Hetherington | |
| 2023-01-07 | Check for multiple asset IDs in a PKL during verify. | Carl Hetherington | |
| 2022-12-22 | Write OriginalFileName tags in PKL (DoM #2394). | Carl Hetherington | |
| Without these it EasyDCP gives errors like "Id field in PKL must match uuid in asset" "Each Id used in the PKL files must be unique or reference the same file" which seem wrong but, as usual, here we are. | |||
| 2022-12-16 | Verify that main picture active area is valid (even, and not too big) (#2392).v1.8.40 | Carl Hetherington | |
| 2022-12-15 | Tidy up find_cpl() and add find_pkl(). | Carl Hetherington | |
| 2022-12-15 | Some more details when verification results fail. | Carl Hetherington | |
| 2022-12-15 | Add delete_lines_after to the Editor. | Carl Hetherington | |
| 2022-12-15 | Add some line spacing in the editor. | Carl Hetherington | |
| 2022-12-15 | Tidy the Editor class up a little. | Carl Hetherington | |
| 2022-12-04 | Fix some ambiguous shared_ptrs, seen on Arch Linux. | Carl Hetherington | |
| 2022-11-03 | Add Z position to subtitles; existing tests pass. | Carl Hetherington | |
| 2022-09-03 | Properly support ContentKind scope attribute.v1.8.26 | Carl Hetherington | |
| 2022-05-04 | Make some tests repeatable across platforms. | Carl Hetherington | |
| 2022-05-04 | Allow tests to be run on Windows. | Carl Hetherington | |
| 2022-04-25 | Tidy up write_xml() API a little. | Carl Hetherington | |
| 2022-04-21 | Fix unsigned/signed warning on macOS. | Carl Hetherington | |
| 2022-04-12 | Add and use new File class.merged-to-main | Carl Hetherington | |
| It was always a bit troubling that fopen_boost wasn't exception safe, and this also fixes a leak where load_ratings_list would never close the ratings file. | |||
| 2022-03-24 | Add verify test to check for erroneous <EntryPoint> and <Duration>v1.8.132215-markers | Carl Hetherington | |
| tags inside <MainMarkers> | |||
| 2022-03-24 | Remove <EntryPoint> and <Duration> from <ReelMarkerAsset> tags. | Carl Hetherington | |
| They should not be there: "EntryPoint" ... "This element shall only be present when the Asset refers to an external resource such as a Track File". Fixes DoM bug #2215. | |||
| 2022-03-20 | Nearly pretty-print subtitle XML (though not in <Text> nodes).v1.8.12 | Carl Hetherington | |
| This is an attempt to fix DoM bug #2205. | |||
| 2022-01-17 | Use optional for ReelAsset _annotation_text.v1.8.6 | Carl Hetherington | |
| Not only is this tag optional in Interop and SMPTE, but it would appear that if it is present but empty a DCP will not play back on Sony SRX320 / LMT3000 systems (DoM bug #2124). Here we use optional<>, as seems to make sense, and also refuse to write empty tags (instead omitting the tag entirely). | |||
| 2021-11-09 | Fix off-by-one in verification of closed caption line length.v1.8.5 | Carl Hetherington | |
| 2021-10-24 | Order subtitles in the XML according to their vertical position (DoM bug #2106).v1.8.4 | Carl Hetherington | |
| 2021-10-24 | Allow specification of valign when writing verify tests. | Carl Hetherington | |
| 2021-10-13 | Basic implementation of <Space> tag in subtitles.v1.8.3 | Carl Hetherington | |
| 2021-10-08 | Fix problems when adding KDMs to a VF, before adding the OV.v1.8.2 | Carl Hetherington | |
| If we have a KDM which contains keys for all the assets referred to by a VF (even the ones in the OV) we would previously throw an exception because we tried to give the KDM to the resolved assets when it was given to the Reel. Here we change things so that the addition of KDMs to assets can be deferred if the asset is not yet resolved. | |||
| 2021-10-03 | Make the former dcst namespace default for SMPTE subtitles. | Carl Hetherington | |
| In DoM bug #2061 it is reported that Easy DCP gives the error "XML Document has default root namespace prefix: dcst. Default namespace should not use prefix for root or root namespace child nodes." with SMPTE subtitle files written by DCP-o-matic, and that the correct fix is to make the former dcst: namespace the default and then remove the dcst: qualifiers from everything. I'm not sure I agree with the error; AFAICS the subtitle files written by previous versions did not have a default root namespace prefix, since it was specified by xmlns:dcst and not just xmlns alone, so I think they were valid. However, using a default NS also seems fine, slightly simplifies the code and produces more compact subtitle files, so we change that here. It should also stop Easy DCP complaining, which is always marginally preferable to sticking to our guns and getting the blame for it. | |||
| 2021-08-11 | Improve message on verify test failure. | Carl Hetherington | |
| 2021-08-11 | Add verify check for empty <Text> nodes in timed text. | Carl Hetherington | |
| 2021-08-04 | Add a belt-and-braces check. | Carl Hetherington | |
| 2021-08-04 | Fix tests after previous commit. | Carl Hetherington | |
| 2021-06-02 | Improve output when a test fails. | Carl Hetherington | |
| 2021-06-02 | Reduce test flakyness a bit. | Carl Hetherington | |
| 2021-05-27 | Sort notes when checking verifications. | Carl Hetherington | |
| So that the lists in the tests don't have to be in the right order. | |||
