| Age | Commit message (Collapse) | Author | |
|---|---|---|---|
| 2021-10-08 | Fix problems when adding KDMs to a VF, before adding the OV.v1.8.2 | Carl Hetherington | |
| If we have a KDM which contains keys for all the assets referred to by a VF (even the ones in the OV) we would previously throw an exception because we tried to give the KDM to the resolved assets when it was given to the Reel. Here we change things so that the addition of KDMs to assets can be deferred if the asset is not yet resolved. | |||
| 2021-10-03 | Make the former dcst namespace default for SMPTE subtitles. | Carl Hetherington | |
| In DoM bug #2061 it is reported that Easy DCP gives the error "XML Document has default root namespace prefix: dcst. Default namespace should not use prefix for root or root namespace child nodes." with SMPTE subtitle files written by DCP-o-matic, and that the correct fix is to make the former dcst: namespace the default and then remove the dcst: qualifiers from everything. I'm not sure I agree with the error; AFAICS the subtitle files written by previous versions did not have a default root namespace prefix, since it was specified by xmlns:dcst and not just xmlns alone, so I think they were valid. However, using a default NS also seems fine, slightly simplifies the code and produces more compact subtitle files, so we change that here. It should also stop Easy DCP complaining, which is always marginally preferable to sticking to our guns and getting the blame for it. | |||
| 2021-08-11 | Improve message on verify test failure. | Carl Hetherington | |
| 2021-08-11 | Add verify check for empty <Text> nodes in timed text. | Carl Hetherington | |
| 2021-08-04 | Add support for writing CPL metadata about sign language video tracks (DoM ↵ | Carl Hetherington | |
| #2062). | |||
| 2021-08-04 | C++11 tidying. | Carl Hetherington | |
| 2021-08-04 | Add a belt-and-braces check. | Carl Hetherington | |
| 2021-08-04 | Fix tests after previous commit. | Carl Hetherington | |
| 2021-07-14 | C++11 tidying. | Carl Hetherington | |
| 2021-06-26 | C++11 cleanup. | Carl Hetherington | |
| 2021-06-18 | Fix tests after changes to language tags. | Carl Hetherington | |
| 2021-06-02 | Test churn from adding make_uuid() into CPL. | Carl Hetherington | |
| 2021-06-02 | Improve output when a test fails. | Carl Hetherington | |
| 2021-06-02 | Reduce test flakyness a bit. | Carl Hetherington | |
| 2021-06-02 | Pass through CompositionMetadataAsset correctly. | Carl Hetherington | |
| We weren't saving Id, and were not quite handling FullContentText correctly. | |||
| 2021-05-27 | Fix bug causing failure to decrypt SMPTE subtitles. | Carl Hetherington | |
| 2021-05-27 | C++11 cleanup. | Carl Hetherington | |
| 2021-05-27 | Sort notes when checking verifications. | Carl Hetherington | |
| So that the lists in the tests don't have to be in the right order. | |||
| 2021-04-22 | Don't give an error on verifying Interop DCPs with possibly-incorrectly | Carl Hetherington | |
| marked 3D assets. This also adds a warning into the verification output. I don't know if this is actually a standard violation but they have been seen in the wild made by "reputable" DCP creation software. DoM bug #1976. | |||
| 2021-04-14 | Improve handling of image subtitle IDs in XML (DoM bug #1965) | Carl Hetherington | |
| When reading/writing the XML for image subtitles, we assumed that the content of the <Image> tag is just the ID of the PNG in the MXF, without any prefix. DoM bug #1965 mentions a DCP where this is not the case, and SMPTE 429-5-2009 has an example where there is urn:uuid: in the XML. This change makes DoM write this urn:uuid: prefix, and accept it if it's present (but not complain if it's not). If the urn:uuid: _is_ required in the field, it's a bit surprising that nobody has complained up to this point. Maybe nobody noticed, or nobody reported it. | |||
| 2021-04-14 | Rename write_subtitle_test -> shared_subtitle_test | Carl Hetherington | |
| 2021-04-14 | Move some tests from write_subtitle_test into interop_subtitle_test. | Carl Hetherington | |
| 2021-04-14 | Rename read_interop_subtitle_test -> interop_subtitle_test. | Carl Hetherington | |
| 2021-04-14 | Move some tests from write_subtitle_test to smpte_subtitle_test. | Carl Hetherington | |
| 2021-04-14 | Merge read_smpte_subtitle_test with smpte_subtitle_test. | Carl Hetherington | |
| 2021-04-14 | C++11 tidying. | Carl Hetherington | |
| 2021-04-14 | Fix/hide some warnings. | Carl Hetherington | |
| 2021-04-12 | Split ReelClosedCaptionAsset into Interop and SMPTE parts. | Carl Hetherington | |
| 2021-04-12 | C++11 tidying. | Carl Hetherington | |
| 2021-04-12 | Specify CPL standard on construction. | Carl Hetherington | |
| Then choose which standard DCP should use based on the CPL(s). | |||
| 2021-04-12 | Split ReelSubtitleAsset into Interop and SMPTE classes. | Carl Hetherington | |
| 2021-04-11 | Small bits of tidying up. | Carl Hetherington | |
| 2021-04-09 | Add check for Bv2.1 10.4.3 - container duration vs reel duration in timed text. | Carl Hetherington | |
| 2021-04-08 | Verify that SMPTE subtitle IDs are handled properly (DoM #1962). | Carl Hetherington | |
| 2021-04-06 | Don't try to verify encrypted JPEG2000 bitstreams. | Carl Hetherington | |
| 2021-04-06 | Hide dump_notes() again. | Carl Hetherington | |
| 2021-04-06 | Call verify_j2k when verifying DCPs. | Carl Hetherington | |
| 2021-03-26 | Write MCA tags based on the specified sound field. | Carl Hetherington | |
| I had previously assumed that one should write MCA information into the sound MXF based on what channels actually contain sound rather than silence. However a previous example of a stereo DCP gives a verification error in EasyDCP (see DoM bug #1935) which is solved by adding MCA tags for each channel in the specified sound field (e.g. at least 6 tags for a file which is marked as 5.1) even if the audio is really stereo. This commit removes the "active channels" stuff and makes sure that if we say a file is 5.1 we write at least 6 MCA tags (and similarly for 7.1). | |||
| 2021-03-19 | Missing library for static build. | Carl Hetherington | |
| 2021-03-19 | Fix static test buid. | Carl Hetherington | |
| 2021-03-18 | Tidy how we're finding the tags and xsd directories. | Carl Hetherington | |
| 2021-03-17 | Fix combining when two DCPs both contain copies of the same asset. | Carl Hetherington | |
| 2021-03-15 | Fix various bugs in subtitle/ccap verification. | Carl Hetherington | |
| Check that subtitles don't overlap reel boundaries, and fix a few tests that trip this check. Fix confusion when calculating subtitle timings during verification where the picture asset frame rate was being used rather than the subtitle asset's edit rate. Do the subtitle timing verification for Interop as well as SMPTE subtitles. Take <StartTime> tags into account when checking subtitles, even though Bv2.1 says they should be set to 0. Rename Time::as_editable_units to Time::as_editable_units_ceil and add a _floor variant, then use that to round down when checking reel boundary overlaps. | |||
| 2021-02-20 | Don't give a verification error if there are closed caption tracks with ↵ | Carl Hetherington | |
| different languages (DoM bug #1907). | |||
| 2021-02-06 | Basic analysis (verification) of J2K codestreams. | Carl Hetherington | |
| 2021-02-06 | Don't use flat_red.j2c for the simple DCP test as it's only 8-bit. | Carl Hetherington | |
| 2021-02-06 | Rename j2k.{cc,h} => j2k_transcode.{cc,h} | Carl Hetherington | |
| 2021-01-22 | Assorted c++11 cleanups. | Carl Hetherington | |
| 2021-01-21 | Move all ostream operator<< into some test-only stream_operators.{cc,h} files. | Carl Hetherington | |
| 2021-01-21 | Some more use of enum class. | Carl Hetherington | |
