From 8efd6f75450037e685d78cc29dcebd82fe922741 Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Thu, 20 Mar 2025 22:00:15 +0100 Subject: Rename MainSoundConfiguration::to_string() -> as_string(). Trying to be consistent with the rule that to_string is a method which converts a parameter to a string (implying processing) whereas as_string is a class member which returns a string representation of the thing. --- src/cpl.cc | 4 ++-- src/main_sound_configuration.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/cpl.cc b/src/cpl.cc index f3e8f6dc..8576bae3 100644 --- a/src/cpl.cc +++ b/src/cpl.cc @@ -318,7 +318,7 @@ CPL::read_composition_metadata_asset(cxml::ConstNodePtr node, vectorto_string()), + fmt::format("{} could not be parsed", _main_sound_configuration->as_string()), *_file ).set_cpl_id(_id) ); @@ -539,7 +539,7 @@ CPL::maybe_write_composition_metadata_asset(xmlpp::Element* node, bool include_m } if (_main_sound_configuration) { - cxml::add_child(meta, "MainSoundConfiguration", string("meta"))->add_child_text(_main_sound_configuration->to_string()); + cxml::add_child(meta, "MainSoundConfiguration", string("meta"))->add_child_text(_main_sound_configuration->as_string()); } cxml::add_child(meta, "MainSoundSampleRate", string("meta"))->add_child_text(fmt::to_string(*_main_sound_sample_rate) + " 1"); diff --git a/src/main_sound_configuration.h b/src/main_sound_configuration.h index 1f9c18e9..b1fb9b77 100644 --- a/src/main_sound_configuration.h +++ b/src/main_sound_configuration.h @@ -65,7 +65,7 @@ class MainSoundConfiguration public: /** Set up a MainSoundConfiguration from a string. If the string is valid, valid() will * subsequently return true and all accessors can be called. Otherwise, all accessors - * except to_string() will throw a MainSoundConfigurationError and to_string() will + * except as_string() will throw a MainSoundConfigurationError and as_string() will * return the original invalid string. */ explicit MainSoundConfiguration(std::string); @@ -84,7 +84,7 @@ public: boost::optional mapping (int index) const; void set_mapping (int index, Channel channel); - std::string to_string() const { + std::string as_string() const { return _configuration; } -- cgit v1.2.3