From a8d449a0a35f205833b446aeae66564aa2464736 Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Mon, 20 Oct 2025 21:16:49 +0200 Subject: Remove ASDCPErrorSuspender. I think it's not possible to do this thread-safely without quite noisy changes to asdcplib: DefaultLogSink() refers a reference which can be deleted by ASDCPErrorSuspender before it is used. DefaultLogSink() could return a shared_ptr but there's a lot of callsites. --- test/sound_frame_test.cc | 5 +---- test/verify_test.cc | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) (limited to 'test') diff --git a/test/sound_frame_test.cc b/test/sound_frame_test.cc index a8060bd4..e406cb38 100644 --- a/test/sound_frame_test.cc +++ b/test/sound_frame_test.cc @@ -87,10 +87,7 @@ BOOST_AUTO_TEST_CASE (sound_frame_test) BOOST_AUTO_TEST_CASE (sound_frame_test2) { - { - dcp::ASDCPErrorSuspender sus; - BOOST_CHECK_THROW (dcp::SoundAsset("frobozz"), dcp::FileError); - } + BOOST_CHECK_THROW(dcp::SoundAsset("frobozz"), dcp::FileError); dcp::SoundAsset asset ( private_test / diff --git a/test/verify_test.cc b/test/verify_test.cc index 8395aaa1..2cc08b10 100644 --- a/test/verify_test.cc +++ b/test/verify_test.cc @@ -519,7 +519,6 @@ BOOST_AUTO_TEST_CASE (verify_incorrect_picture_sound_hash) BOOST_REQUIRE (fwrite (&x, sizeof(x), 1, mod) == 1); fclose (mod); - dcp::ASDCPErrorSuspender sus; check_verify_result ( { dir }, {}, -- cgit v1.2.3