openjpeg/src/bin/jp2/convertbmp.c, branch master

Fix some typos (found by `codespell` and `typos`)

2024-02-28T15:23:43Z

Signed-off-by: Stefan Weil

API: deprecate 'bpp' member in favor of 'prec'

2021-10-21T12:13:58Z

in opj_image_comp and opj_image_comptparm structures. bpp was redundant with prec, and almost never set by the library, except by opj_image_create(). This change should hopefully not impact existing, working, users of the API, which should already have used prec to get things working. Fixes #1379

bmp_read_rle4_data(): avoid potential infinite loop

2019-04-15T08:10:18Z

convertbmp: detect invalid file dimensions early

2019-04-15T08:10:18Z

width/length dimensions read from bmp headers are not necessarily valid. For instance they may have been maliciously set to very large values with the intention to cause DoS (large memory allocation, stack overflow). In these cases we want to detect the invalid size as early as possible. This commit introduces a counter which verifies that the number of written bytes corresponds to the advertized width/length. See commit 8ee335227bbc for details. Signed-off-by: Young Xiao

convertbmp: detect invalid file dimensions early

2018-12-14T04:10:35Z

Fix some potential overflow issues (#1161)

2018-10-31T19:44:30Z

* Fix some potential overflow issues Put sizeof to the beginning of the multiplication to enforce that size_t instead of smaller integer types is used for the calculation. This fixes warnings from LGTM: Multiplication result may overflow 'unsigned int' before it is converted to 'unsigned long'. It also allows removing some type casts. Signed-off-by: Stefan Weil * Fix code indentation Signed-off-by: Stefan Weil

convertbmp: fix issues with zero bitmasks

2018-09-22T18:51:50Z

In the case where a BMP file declares compression 3 (BI_BITFIELDS) with header size <= 56, all bitmask values keep their initialization value 0. This may lead to various undefined behavior later e.g. when doing 1 << (l_comp->prec - 1). This issue does not affect files with bit count 16 because of a check added in 16240e2 which sets default values to the color masks if they are all 0. This commit adds similar checks for the 32 bit case. Also, if a BMP file declares compression 3 with header size >= 56 and intentional 0 bitmasks, the same issue will be triggered in both the 16 and 32 bit count case. This commit adds checks to bmp_read_info_header() rejecting BMP files with "intentional" 0 bitmasks. These checks might be removed in the future when proper handling of zero bitmasks will be available in openjpeg2. fixes #1057 (CVE-2018-5785)

bmp_read_rle8_data(): avoid potential infinite loop (#996)

2017-08-18T08:16:38Z

bmp_read_info_header(): reject bmp files with biBitCount == 0 (#983)

2017-08-14T15:26:58Z

imagetobmp: avoid shift by -1 (relates to #811)

2017-08-09T07:42:30Z