openjpeg/src/bin/jp2, branch v2.3.1

convertbmp: detect invalid file dimensions early

2018-12-14T04:10:35Z

width/length dimensions read from bmp headers are not necessarily valid. For instance they may have been maliciously set to very large values with the intention to cause DoS (large memory allocation, stack overflow). In these cases we want to detect the invalid size as early as possible. This commit introduces a counter which verifies that the number of written bytes corresponds to the advertized width/length. Fixes #1059 (CVE-2018-6616).

Merge pull request #1160 from hlef/master

2018-11-16T08:42:19Z

jp3d/jpwl convert: fix write stack buffer overflow

jp2: convert: fix null pointer dereference

2018-11-07T17:53:18Z

Tile components in a JP2 image might have null data pointer by defining a zero component size (for example using large horizontal or vertical sampling periods). This null data pointer leads to null image component data pointer, causing crash when dereferenced without != null check in imagetopnm. Add != null check. This commit addresses #1152 (CVE-2018-18088).

Fix some potential overflow issues (#1161)

2018-10-31T19:44:30Z

* Fix some potential overflow issues Put sizeof to the beginning of the multiplication to enforce that size_t instead of smaller integer types is used for the calculation. This fixes warnings from LGTM: Multiplication result may overflow 'unsigned int' before it is converted to 'unsigned long'. It also allows removing some type casts. Signed-off-by: Stefan Weil * Fix code indentation Signed-off-by: Stefan Weil

Fix several memory and resource leaks

2018-10-31T15:16:22Z

Signed-off-by: Nikola Forró

Merge pull request #1148 from hlef/master

2018-09-22T21:54:12Z

CVE-2018-5785: fix issues with zero bitmasks

Merge pull request #1128 from stweil/typos

2018-09-22T20:55:33Z

Fix some typos in code comments and documentation

convertbmp: fix issues with zero bitmasks

2018-09-22T18:51:50Z

In the case where a BMP file declares compression 3 (BI_BITFIELDS) with header size <= 56, all bitmask values keep their initialization value 0. This may lead to various undefined behavior later e.g. when doing 1 << (l_comp->prec - 1). This issue does not affect files with bit count 16 because of a check added in 16240e2 which sets default values to the color masks if they are all 0. This commit adds similar checks for the 32 bit case. Also, if a BMP file declares compression 3 with header size >= 56 and intentional 0 bitmasks, the same issue will be triggered in both the 16 and 32 bit count case. This commit adds checks to bmp_read_info_header() rejecting BMP files with "intentional" 0 bitmasks. These checks might be removed in the future when proper handling of zero bitmasks will be available in openjpeg2. fixes #1057 (CVE-2018-5785)

Fix some typos in code comments and documentation

2018-09-05T18:01:10Z

All typos were found by Codespell. Signed-off-by: Stefan Weil

Changes in pnmtoimage if image data are missing

2018-08-31T14:24:41Z