summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2018-09-22convertbmp: fix issues with zero bitmasksHugo Lefeuvre
In the case where a BMP file declares compression 3 (BI_BITFIELDS) with header size <= 56, all bitmask values keep their initialization value 0. This may lead to various undefined behavior later e.g. when doing 1 << (l_comp->prec - 1). This issue does not affect files with bit count 16 because of a check added in 16240e2 which sets default values to the color masks if they are all 0. This commit adds similar checks for the 32 bit case. Also, if a BMP file declares compression 3 with header size >= 56 and intentional 0 bitmasks, the same issue will be triggered in both the 16 and 32 bit count case. This commit adds checks to bmp_read_info_header() rejecting BMP files with "intentional" 0 bitmasks. These checks might be removed in the future when proper handling of zero bitmasks will be available in openjpeg2. fixes #1057 (CVE-2018-5785)
2018-09-05openjp2/jp2: Fix two format stringsStefan Weil
Compiler warnings: src/lib/openjp2/jp2.c:1008:35: warning: too many arguments for format [-Wformat-extra-args] src/lib/openjp2/j2k.c:1928:73: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘OPJ_OFF_T {aka long int}’ [-Wformat=] Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-09-05Fix some typos in code comments and documentationStefan Weil
All typos were found by Codespell. Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-08-31Changes in pnmtoimage if image data are missingszukw000
2018-08-27Cast on uint ceildivRobert Everson
2018-06-20Avoid assertion when running opj_j2k_merge_ppt() several time due to ↵Even Rouault
e6674f7ed66abdb32a0be5944f618722b6a7b5d5 revert. Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=2785
2018-06-20Revert "Avoid assertion in opj_j2k_merge_ppt() in case premature EOC is ↵Even Rouault
encountered in opj_j2k_read_tile_header(). Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=2785. Credit to OSS Fuzz" (fixes #1120) This reverts commit 9906fbf737692486cebabe98169988d818e2e66a. which broke decoding of images where TNsot == 0
2018-06-18Use local type declaration for POSIX standard type only for MS compilerStefan Weil
ssize_t is a POSIX type which is declared in POSIX include files. Mingw-w64 provides it also for Windows. Use the local declaration only with MS compilers. Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-06-16opj_compress: try to make help message of -c switch clearer (fixes #1117)Even Rouault
2018-03-12opj_compress: fix help message regarding default precinct sizeEven Rouault
2018-03-04Merge pull request #1094 from kbabioch/fix/missing-format-string-parameterEven Rouault
mj2: Add missing variable to format string in fprintf() invocation in meta_out.c
2018-03-04Merge pull request #1096 from kbabioch/fix/opj_mj2_extract-helpEven Rouault
opj_mj2_extract: Rename output_location to output_prefix
2018-03-03jp3d: Replace sprintf() by snprintf() in volumetobin()Karol Babioch
This replaces the unsafe sprintf() invocation by the safer snprintf() one, with the correct buffer size to prevent buffer overflows. This fixes #1085.
2018-03-02opj_mj2_extract: Rename output_location to output_prefixKarol Babioch
This renames the argument in the help output, as the latter better describes the the purpose of this argument.
2018-03-02mj2: Add missing variable to format string in fprintf() invocation in meta_out.cKarol Babioch
This adds the appropriate variables to the invocation of fprintf(). They were specified in the format string, but were missing in the actual call. This fixes #1074 and #1075.
2018-02-25openjp3d: Convert ISO-8859 to UTF-8Stefan Weil
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-02-25jp3d: Convert ISO-8859 to UTF-8Stefan Weil
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-02-25Merge pull request #1080 from setharnold/patch-1Even Rouault
fix unchecked integer multiplication overflow
2018-02-18bench_dwt: fix wrong index in iteration (issue found by Fethi Migaou)Even Rouault
2018-02-14fix unchecked integer multiplication overflowsetharnold
Hello, this fixes an unchecked integer multiplication overflow. Thanks.
2018-02-11Avoid out-of-bounds write overflow due to uint32 overflow computation on ↵Even Rouault
images with huge dimensions. Credit to Google Autofuzz project for providing test case
2018-01-18Note that seek uses SEEK_SET behavior.Campbell Barton
2018-01-08opj_t2_encode_packet(): disable setting empty packet header bit to 1 when ↵Even Rouault
there is an empty packet This effectively reverts commit 2609fb8077125b5b31f1bcc2f98c12ff1e6572d7 since it has been reported that such packets cause decoding issues with cinema J2K hardware decoders: https://groups.google.com/forum/#!topic/openjpeg/M7M_fLX_Bco
2017-12-15Fix resource leak (CID 179466)Stefan Weil
Coverity report: CID 179466 (#1 of 1): Resource leak (RESOURCE_LEAK) 93. leaked_storage: Variable name going out of scope leaks the storage it points to. Signed-off-by: Stefan Weil <sw@weilnetz.de>
2017-11-30opj_j2k_read_cod: remove check for 'No more than one COD marker per tile' ↵Even Rouault
(fixes #1043) This check was added per https://github.com/uclouvain/openjpeg/commit/daed8cc9195555e101ab708a501af2dfe6d5e001 to fix https://github.com/uclouvain/openjpeg/issues/476 , but it does not seem to be necessary with latest master (issue476.jp2 doesn't cause memory issues), and breaks reading legit files.
2017-11-30Fix typo in commentsEven Rouault
2017-11-14Changed cmake version test to allow for cmake 2.8.11.xAndrew Murray
2017-10-20Add missing fclose() statement in error condition.Gregory Fiumara
2017-10-12opj_j2k_set_threads(): add sanity check to error out if called after ↵Even Rouault
opj_read_header()
2017-10-12Improve doc of opj_codec_set_threads()Even Rouault
2017-10-09Unix build: fix regression of 2.3.0 where a shared-only or static-only build ↵Even Rouault
lacks the installation target for the library (#1019, fixes regression introduced by 3dfc6ca2bcf06fd1adb6b6b4cecc6c092f08ba0b)
2017-10-06opj_decompress -h: document -threads ALL_CPUSEven Rouault
2017-09-26Merge pull request #1022 from rouault/partial_component_decodingAntonin Descampe
Add capability to decode only a subset of all components of an image.
2017-09-21Add missing newline at end of fileStefan Weil
This fixes warnings from the clang compiler: /openjpeg/src/lib/openjp2/sparse_array.h:141:32: warning: no newline at end of file [-Wnewline-eof] Signed-off-by: Stefan Weil <sw@weilnetz.de>
2017-09-21Add assertionEven Rouault
2017-09-21Comment dead code (Coverity CID 94681)Even Rouault
2017-09-21Workaround Coverity CID 113061Even Rouault
2017-09-21Workaround Coverity CID 169392Even Rouault
2017-09-21opj_j2k_get_default_thread_count(): validate value of OPJ_NUM_THREADS to fix ↵Even Rouault
Coverity 179465 and 179463
2017-09-21Fix copy&paste error (Coverity CID 169394)Even Rouault
2017-09-20opj_decompress: add a warning when -d and -t are used together (#693)Even Rouault
2017-09-20Use a #define J2K_MAX_POCS 32 to avoid hard-coded constant (#349)Even Rouault
2017-09-20Avoid index-out-of-bounds access when invoking opj_compress with -n 11 or ↵Even Rouault
higher. But not a proper fix itself (refs #493)
2017-09-19Avoid relying on operator precedence (raised by cppcheck)Even Rouault
2017-09-19Workaroudn cppcheck (correct) warning about same code in then and else branchesEven Rouault
2017-09-19Fix badly named variable in function prototype (raised by cppcheck)Even Rouault
2017-09-19Remove redundant test (raised by cppcheck)Even Rouault
2017-09-19Replace C++ style comments by C onesEven Rouault
2017-09-19Replace C++ style comments by C onesEven Rouault
2017-09-19opj_set_decoded_components(): add a provision for a apply_color_transforms ↵Even Rouault
parameter in case we support it in the future
generated by cgit v1.2.3 (git 2.46.0) at 2026-04-08 00:46:05 +0000