forward-port from 2.X commits 5827-6000 including
[ardour.git] / gtk2_ardour / editor.cc
index 4b97ceea2df2ab6c855276d7eddbfa70bb26d6a0..cbeaae98868cb503d89aec2959b5f5e4251b33a5 100644 (file)
@@ -220,6 +220,27 @@ show_me_the_size (Requisition* r, const char* what)
        cerr << "size of " << what << " = " << r->width << " x " << r->height << endl;
 }
 
+#ifdef GTKOSX
+static void
+pane_size_watcher (Paned* pane)
+{
+       /* if the handle of a pane vanishes into (at least) the tabs of a notebook,
+          it is no longer accessible. so stop that. this doesn't happen on X11,
+          just the quartz backend.
+
+          ugh.
+       */
+
+       int max_width_of_lhs = GTK_WIDGET(pane->gobj())->allocation.width - 25;
+
+       gint pos = pane->get_position ();
+
+       if (pos > max_width_of_lhs) {
+               pane->set_position (max_width_of_lhs);
+       }
+}
+#endif
+
 Editor::Editor ()
        : _join_object_range_state (JOIN_OBJECT_RANGE_NONE)
 
@@ -304,7 +325,6 @@ Editor::Editor ()
        last_autoscroll_y = 0;
        autoscroll_active = false;
        autoscroll_timeout_tag = -1;
-       interthread_progress_window = 0;
        logo_item = 0;
 
        analysis_window = 0;
@@ -319,6 +339,7 @@ Editor::Editor ()
 
        have_pending_keyboard_selection = false;
        _follow_playhead = true;
+        _stationary_playhead = false;
        _xfade_visibility = true;
        editor_ruler_menu = 0;
        no_ruler_shown_update = false;
@@ -588,7 +609,10 @@ Editor::Editor ()
        edit_pane.pack2 (the_notebook, false, true);
 
        edit_pane.signal_size_allocate().connect (sigc::bind (sigc::mem_fun(*this, &Editor::pane_allocation_handler), static_cast<Paned*> (&edit_pane)));
-
+#ifdef GTKOSX
+        Glib::PropertyProxy<int> proxy = edit_pane.property_position();
+        proxy.signal_changed().connect (bind (sigc::ptr_fun (pane_size_watcher), static_cast<Paned*> (&edit_pane)));
+#endif
        top_hbox.pack_start (toolbar_frame, false, true);
 
        HBox *hbox = manage (new HBox);
@@ -627,7 +651,7 @@ Editor::Editor ()
        _playlist_selector = new PlaylistSelector();
        _playlist_selector->signal_delete_event().connect (sigc::bind (sigc::ptr_fun (just_hide_it), static_cast<Window *> (_playlist_selector)));
 
-       RegionView::RegionViewGoingAway.connect (*this, ui_bind (&Editor::catch_vanishing_regionview, this, _1), gui_context());
+       RegionView::RegionViewGoingAway.connect (*this, invalidator (*this),  ui_bind (&Editor::catch_vanishing_regionview, this, _1), gui_context());
 
        /* nudge stuff */
 
@@ -674,19 +698,19 @@ Editor::Editor ()
 
        /* allow external control surfaces/protocols to do various things */
 
-       ControlProtocol::ZoomToSession.connect (*this, boost::bind (&Editor::temporal_zoom_session, this), gui_context());
-       ControlProtocol::ZoomIn.connect (*this, boost::bind (&Editor::temporal_zoom_step, this, false), gui_context());
-       ControlProtocol::ZoomOut.connect (*this, boost::bind (&Editor::temporal_zoom_step, this, true), gui_context());
-       ControlProtocol::ScrollTimeline.connect (*this, ui_bind (&Editor::control_scroll, this, _1), gui_context());
-       BasicUI::AccessAction.connect (*this, ui_bind (&Editor::access_action, this, _1, _2), gui_context());
+       ControlProtocol::ZoomToSession.connect (*this, invalidator (*this), boost::bind (&Editor::temporal_zoom_session, this), gui_context());
+       ControlProtocol::ZoomIn.connect (*this, invalidator (*this), boost::bind (&Editor::temporal_zoom_step, this, false), gui_context());
+       ControlProtocol::ZoomOut.connect (*this, invalidator (*this), boost::bind (&Editor::temporal_zoom_step, this, true), gui_context());
+       ControlProtocol::ScrollTimeline.connect (*this, invalidator (*this), ui_bind (&Editor::control_scroll, this, _1), gui_context());
+       BasicUI::AccessAction.connect (*this, invalidator (*this), ui_bind (&Editor::access_action, this, _1, _2), gui_context());
        
        /* problematic: has to return a value and thus cannot be x-thread */
 
        Session::AskAboutPlaylistDeletion.connect_same_thread (*this, boost::bind (&Editor::playlist_deletion_dialog, this, _1));
 
-       Config->ParameterChanged.connect (*this, ui_bind (&Editor::parameter_changed, this, _1), gui_context());
+       Config->ParameterChanged.connect (*this, invalidator (*this), ui_bind (&Editor::parameter_changed, this, _1), gui_context());
 
-       TimeAxisView::CatchDeletion.connect (*this, ui_bind (&Editor::timeaxisview_deleted, this, _1), gui_context());
+       TimeAxisView::CatchDeletion.connect (*this, invalidator (*this), ui_bind (&Editor::timeaxisview_deleted, this, _1), gui_context());
 
        _last_normalization_value = 0;
 
@@ -1067,22 +1091,22 @@ Editor::set_session (Session *t)
           but use Gtkmm2ext::UI::instance()->call_slot();
        */
 
-       _session->TransportStateChange.connect (_session_connections, boost::bind (&Editor::map_transport_state, this), gui_context());
-       _session->PositionChanged.connect (_session_connections, ui_bind (&Editor::map_position_change, this, _1), gui_context());
-       _session->RouteAdded.connect (_session_connections, ui_bind (&Editor::handle_new_route, this, _1), gui_context());
-       _session->DurationChanged.connect (_session_connections, boost::bind (&Editor::handle_new_duration, this), gui_context());
-       _session->DirtyChanged.connect (_session_connections, boost::bind (&Editor::update_title, this), gui_context());
-       _session->TimecodeOffsetChanged.connect (_session_connections, boost::bind (&Editor::update_just_timecode, this), gui_context());
-       _session->tempo_map().PropertyChanged.connect (_session_connections, ui_bind (&Editor::tempo_map_changed, this, _1), gui_context());
-       _session->Located.connect (_session_connections, boost::bind (&Editor::located, this), gui_context());
-       _session->config.ParameterChanged.connect (_session_connections, ui_bind (&Editor::parameter_changed, this, _1), gui_context());
-       _session->StateSaved.connect (_session_connections, ui_bind (&Editor::session_state_saved, this, _1), gui_context());
-       _session->locations()->added.connect (_session_connections, ui_bind (&Editor::add_new_location, this, _1), gui_context());
-       _session->locations()->removed.connect (_session_connections, ui_bind (&Editor::location_gone, this, _1), gui_context());
-       _session->locations()->changed.connect (_session_connections, boost::bind (&Editor::refresh_location_display, this), gui_context());
-       _session->locations()->StateChanged.connect (_session_connections, ui_bind (&Editor::refresh_location_display_s, this, _1), gui_context());
-       _session->locations()->end_location()->changed.connect (_session_connections, ui_bind (&Editor::end_location_changed, this, _1), gui_context());
-       _session->history().Changed.connect (_session_connections, boost::bind (&Editor::history_changed, this), gui_context());
+       _session->TransportStateChange.connect (_session_connections, invalidator (*this), boost::bind (&Editor::map_transport_state, this), gui_context());
+       _session->PositionChanged.connect (_session_connections, invalidator (*this), ui_bind (&Editor::map_position_change, this, _1), gui_context());
+       _session->RouteAdded.connect (_session_connections, invalidator (*this), ui_bind (&Editor::handle_new_route, this, _1), gui_context());
+       _session->DurationChanged.connect (_session_connections, invalidator (*this), boost::bind (&Editor::handle_new_duration, this), gui_context());
+       _session->DirtyChanged.connect (_session_connections, invalidator (*this), boost::bind (&Editor::update_title, this), gui_context());
+       _session->TimecodeOffsetChanged.connect (_session_connections, invalidator (*this), boost::bind (&Editor::update_just_timecode, this), gui_context());
+       _session->tempo_map().PropertyChanged.connect (_session_connections, invalidator (*this), ui_bind (&Editor::tempo_map_changed, this, _1), gui_context());
+       _session->Located.connect (_session_connections, invalidator (*this), boost::bind (&Editor::located, this), gui_context());
+       _session->config.ParameterChanged.connect (_session_connections, invalidator (*this), ui_bind (&Editor::parameter_changed, this, _1), gui_context());
+       _session->StateSaved.connect (_session_connections, invalidator (*this), ui_bind (&Editor::session_state_saved, this, _1), gui_context());
+       _session->locations()->added.connect (_session_connections, invalidator (*this), ui_bind (&Editor::add_new_location, this, _1), gui_context());
+       _session->locations()->removed.connect (_session_connections, invalidator (*this), ui_bind (&Editor::location_gone, this, _1), gui_context());
+       _session->locations()->changed.connect (_session_connections, invalidator (*this), boost::bind (&Editor::refresh_location_display, this), gui_context());
+       _session->locations()->StateChanged.connect (_session_connections, invalidator (*this), ui_bind (&Editor::refresh_location_display_s, this, _1), gui_context());
+       _session->locations()->end_location()->changed.connect (_session_connections, invalidator (*this), ui_bind (&Editor::end_location_changed, this, _1), gui_context());
+       _session->history().Changed.connect (_session_connections, invalidator (*this), boost::bind (&Editor::history_changed, this), gui_context());
 
        if (Profile->get_sae()) {
                BBT_Time bbt;
@@ -1730,6 +1754,8 @@ Editor::add_region_context_items (StreamView* sv, boost::shared_ptr<Region> regi
                region_mute_item->set_active();
                fooc.block (false);
        }
+        
+        items.push_back (MenuElem (_("Transpose"), mem_fun(*this, &Editor::pitch_shift_regions)));
 
        if (!Profile->get_sae()) {
                items.push_back (CheckMenuElem (_("Opaque")));
@@ -2243,7 +2269,8 @@ Editor::set_state (const XMLNode& node, int /*version*/)
        move (x, y);
 
        if (_session && (prop = node.property ("playhead"))) {
-               nframes64_t pos = atol (prop->value().c_str());
+               nframes64_t pos;
+                sscanf (prop->value().c_str(), "%" PRIi64, &pos);
                playhead_cursor->set_position (pos);
        } else {
                playhead_cursor->set_position (0);
@@ -2341,6 +2368,18 @@ Editor::set_state (const XMLNode& node, int /*version*/)
                }
        }
 
+        if ((prop = node.property ("stationary-playhead"))) {
+                bool yn = (prop->value() == "yes");
+                set_stationary_playhead (yn);
+                RefPtr<Action> act = ActionManager::get_action (X_("Editor"), X_("toggle-stationary-playhead"));
+                if (act) {
+                        RefPtr<ToggleAction> tact = RefPtr<ToggleAction>::cast_dynamic(act);
+                        if (tact->get_active() != yn) {
+                                tact->set_active (yn);
+                        }
+                }
+        }
+        
        if ((prop = node.property ("region-list-sort-type"))) {
                RegionListSortType st;
                _regions->reset_sort_type ((RegionListSortType) string_2_enum (prop->value(), st), true);
@@ -2383,6 +2422,13 @@ Editor::set_state (const XMLNode& node, int /*version*/)
                }
        }
 
+       if ((prop = node.property (X_("editor-list-page")))) {
+               the_notebook.set_current_page (atoi (prop->value ()));
+       }
+
+       if ((prop = node.property (X_("editor-pane-position")))) {
+               edit_pane.set_position (atoi (prop->value ()));
+       }
 
        return 0;
 }
@@ -2447,6 +2493,7 @@ Editor::get_state ()
        node->add_property ("show-waveforms-recording", _show_waveforms_recording ? "yes" : "no");
        node->add_property ("show-measures", _show_measures ? "yes" : "no");
        node->add_property ("follow-playhead", _follow_playhead ? "yes" : "no");
+        node->add_property ("stationary-playhead", _stationary_playhead ? "yes" : "no");
        node->add_property ("xfades-visible", _xfade_visibility ? "yes" : "no");
        node->add_property ("region-list-sort-type", enum_2_string (_regions->sort_type ()));
        node->add_property ("mouse-mode", enum2str(mouse_mode));
@@ -2465,6 +2512,12 @@ Editor::get_state ()
                node->add_property (X_("show-editor-list"), tact->get_active() ? "yes" : "no");
        }
 
+       snprintf (buf, sizeof (buf), "%d", the_notebook.get_current_page ());
+       node->add_property (X_("editor-list-page"), buf);
+
+       snprintf (buf, sizeof (buf), "%d", edit_pane.get_position ());
+       node->add_property (X_("editor-pane-position"), buf);
+
        return *node;
 }
 
@@ -2785,22 +2838,22 @@ Editor::setup_toolbar ()
        mode_box->pack_start (edit_mode_selector);
        mode_box->pack_start (*mouse_mode_button_box);
 
-       mouse_mode_tearoff = manage (new TearOff (*mode_box));
-       mouse_mode_tearoff->set_name ("MouseModeBase");
-       mouse_mode_tearoff->tearoff_window().signal_key_press_event().connect (sigc::bind (sigc::ptr_fun (relay_key_press), &mouse_mode_tearoff->tearoff_window()), false);
+       _mouse_mode_tearoff = manage (new TearOff (*mode_box));
+       _mouse_mode_tearoff->set_name ("MouseModeBase");
+       _mouse_mode_tearoff->tearoff_window().signal_key_press_event().connect (sigc::bind (sigc::ptr_fun (relay_key_press), &_mouse_mode_tearoff->tearoff_window()), false);
 
        if (Profile->get_sae()) {
-               mouse_mode_tearoff->set_can_be_torn_off (false);
+               _mouse_mode_tearoff->set_can_be_torn_off (false);
        }
 
-       mouse_mode_tearoff->Detach.connect (sigc::bind (sigc::mem_fun(*this, &Editor::detach_tearoff), static_cast<Box*>(&toolbar_hbox),
-                                                 &mouse_mode_tearoff->tearoff_window()));
-       mouse_mode_tearoff->Attach.connect (sigc::bind (sigc::mem_fun(*this, &Editor::reattach_tearoff), static_cast<Box*> (&toolbar_hbox),
-                                                 &mouse_mode_tearoff->tearoff_window(), 1));
-       mouse_mode_tearoff->Hidden.connect (sigc::bind (sigc::mem_fun(*this, &Editor::detach_tearoff), static_cast<Box*>(&toolbar_hbox),
-                                                 &mouse_mode_tearoff->tearoff_window()));
-       mouse_mode_tearoff->Visible.connect (sigc::bind (sigc::mem_fun(*this, &Editor::reattach_tearoff), static_cast<Box*> (&toolbar_hbox),
-                                                  &mouse_mode_tearoff->tearoff_window(), 1));
+       _mouse_mode_tearoff->Detach.connect (sigc::bind (sigc::mem_fun(*this, &Editor::detach_tearoff), static_cast<Box*>(&toolbar_hbox),
+                                                         &_mouse_mode_tearoff->tearoff_window()));
+       _mouse_mode_tearoff->Attach.connect (sigc::bind (sigc::mem_fun(*this, &Editor::reattach_tearoff), static_cast<Box*> (&toolbar_hbox),
+                                                         &_mouse_mode_tearoff->tearoff_window(), 1));
+       _mouse_mode_tearoff->Hidden.connect (sigc::bind (sigc::mem_fun(*this, &Editor::detach_tearoff), static_cast<Box*>(&toolbar_hbox),
+                                                         &_mouse_mode_tearoff->tearoff_window()));
+       _mouse_mode_tearoff->Visible.connect (sigc::bind (sigc::mem_fun(*this, &Editor::reattach_tearoff), static_cast<Box*> (&toolbar_hbox),
+                                                          &_mouse_mode_tearoff->tearoff_window(), 1));
 
        mouse_move_button.set_mode (false);
        mouse_select_button.set_mode (false);
@@ -2914,28 +2967,28 @@ Editor::setup_toolbar ()
        HBox* hbox = manage (new HBox);
        hbox->set_spacing(10);
 
-       tools_tearoff = manage (new TearOff (*hbox));
-       tools_tearoff->set_name ("MouseModeBase");
-       tools_tearoff->tearoff_window().signal_key_press_event().connect (sigc::bind (sigc::ptr_fun (relay_key_press), &tools_tearoff->tearoff_window()), false);
-
+       _tools_tearoff = manage (new TearOff (*hbox));
+       _tools_tearoff->set_name ("MouseModeBase");
+       _tools_tearoff->tearoff_window().signal_key_press_event().connect (sigc::bind (sigc::ptr_fun (relay_key_press), &_tools_tearoff->tearoff_window()), false);
+        
        if (Profile->get_sae()) {
-               tools_tearoff->set_can_be_torn_off (false);
+               _tools_tearoff->set_can_be_torn_off (false);
        }
 
-       tools_tearoff->Detach.connect (sigc::bind (sigc::mem_fun(*this, &Editor::detach_tearoff), static_cast<Box*>(&toolbar_hbox),
-                                            &tools_tearoff->tearoff_window()));
-       tools_tearoff->Attach.connect (sigc::bind (sigc::mem_fun(*this, &Editor::reattach_tearoff), static_cast<Box*> (&toolbar_hbox),
-                                            &tools_tearoff->tearoff_window(), 0));
-       tools_tearoff->Hidden.connect (sigc::bind (sigc::mem_fun(*this, &Editor::detach_tearoff), static_cast<Box*>(&toolbar_hbox),
-                                            &tools_tearoff->tearoff_window()));
-       tools_tearoff->Visible.connect (sigc::bind (sigc::mem_fun(*this, &Editor::reattach_tearoff), static_cast<Box*> (&toolbar_hbox),
-                                             &tools_tearoff->tearoff_window(), 0));
+       _tools_tearoff->Detach.connect (sigc::bind (sigc::mem_fun(*this, &Editor::detach_tearoff), static_cast<Box*>(&toolbar_hbox),
+                                                    &_tools_tearoff->tearoff_window()));
+       _tools_tearoff->Attach.connect (sigc::bind (sigc::mem_fun(*this, &Editor::reattach_tearoff), static_cast<Box*> (&toolbar_hbox),
+                                                    &_tools_tearoff->tearoff_window(), 0));
+       _tools_tearoff->Hidden.connect (sigc::bind (sigc::mem_fun(*this, &Editor::detach_tearoff), static_cast<Box*>(&toolbar_hbox),
+                                                    &_tools_tearoff->tearoff_window()));
+       _tools_tearoff->Visible.connect (sigc::bind (sigc::mem_fun(*this, &Editor::reattach_tearoff), static_cast<Box*> (&toolbar_hbox),
+                                                     &_tools_tearoff->tearoff_window(), 0));
 
        toolbar_hbox.set_spacing (10);
        toolbar_hbox.set_border_width (1);
 
-       toolbar_hbox.pack_start (*mouse_mode_tearoff, false, false);
-       toolbar_hbox.pack_start (*tools_tearoff, false, false);
+       toolbar_hbox.pack_start (*_mouse_mode_tearoff, false, false);
+       toolbar_hbox.pack_start (*_tools_tearoff, false, false);
 
        hbox->pack_start (snap_box, false, false);
        hbox->pack_start (*nudge_box, false, false);
@@ -3130,7 +3183,7 @@ Editor::map_transport_state ()
 {
        ENSURE_GUI_THREAD (*this, &Editor::map_transport_state)
 
-       if (_session->transport_stopped()) {
+       if (_session && _session->transport_stopped()) {
                have_pending_keyboard_selection = false;
        }
 
@@ -3643,10 +3696,7 @@ Editor::pane_allocation_handler (Allocation &alloc, Paned* which)
 void
 Editor::detach_tearoff (Box* /*b*/, Window* /*w*/)
 {
-       cerr << "remove tearoff\n";
-
-       if (tools_tearoff->torn_off() &&
-           mouse_mode_tearoff->torn_off()) {
+       if (_tools_tearoff->torn_off() && _mouse_mode_tearoff->torn_off()) {
                top_hbox.remove (toolbar_frame);
        }
 }
@@ -3654,7 +3704,6 @@ Editor::detach_tearoff (Box* /*b*/, Window* /*w*/)
 void
 Editor::reattach_tearoff (Box* /*b*/, Window* /*w*/, int32_t /*n*/)
 {
-       cerr << "reattach tearoff\n";
        if (toolbar_frame.get_parent() == 0) {
                top_hbox.pack_end (toolbar_frame);
        }
@@ -3697,6 +3746,29 @@ Editor::set_follow_playhead (bool yn)
        }
 }
 
+void
+Editor::toggle_stationary_playhead ()
+{
+       RefPtr<Action> act = ActionManager::get_action (X_("Editor"), X_("toggle-stationary-playhead"));
+       if (act) {
+               RefPtr<ToggleAction> tact = RefPtr<ToggleAction>::cast_dynamic(act);
+               set_stationary_playhead (tact->get_active());
+       }
+}
+
+void
+Editor::set_stationary_playhead (bool yn)
+{
+       if (_stationary_playhead != yn) {
+               if ((_stationary_playhead = yn) == true) {
+                       /* catch up */
+                       // FIXME need a 3.0 equivalent of this 2.X call
+                       // update_current_screen ();
+               }
+               instant_save ();
+       }
+}
+
 void
 Editor::toggle_xfade_active (boost::weak_ptr<Crossfade> wxfade)
 {
@@ -3945,8 +4017,8 @@ Editor::session_state_saved (string snap_name)
 void
 Editor::maximise_editing_space ()
 {
-       mouse_mode_tearoff->set_visible (false);
-       tools_tearoff->set_visible (false);
+       _mouse_mode_tearoff->set_visible (false);
+       _tools_tearoff->set_visible (false);
 
        pre_maximal_pane_position = edit_pane.get_position();
        pre_maximal_editor_width = this->get_width();
@@ -3976,8 +4048,8 @@ Editor::restore_editing_space ()
 
        unfullscreen();
 
-       mouse_mode_tearoff->set_visible (true);
-       tools_tearoff->set_visible (true);
+       _mouse_mode_tearoff->set_visible (true);
+       _tools_tearoff->set_visible (true);
        post_maximal_editor_width = this->get_width();
 
        edit_pane.set_position (pre_maximal_pane_position + abs(this->get_width() - pre_maximal_editor_width));
@@ -4119,10 +4191,11 @@ Editor::undo_visual_state ()
                return;
        }
 
+       redo_visual_stack.push_back (current_visual_state());
+
        VisualState* vs = undo_visual_stack.back();
        undo_visual_stack.pop_back();
        use_visual_state (*vs);
-       redo_visual_stack.push_back (vs);
 }
 
 void
@@ -4132,10 +4205,11 @@ Editor::redo_visual_state ()
                return;
        }
 
+       undo_visual_stack.push_back (current_visual_state());
+
        VisualState* vs = redo_visual_stack.back();
        redo_visual_stack.pop_back();
        use_visual_state (*vs);
-       undo_visual_stack.push_back (vs);
 }
 
 void
@@ -4640,7 +4714,7 @@ Editor::first_idle ()
 
        if (track_views.size() > 1) {
                dialog = new MessageDialog (*this,
-                                           _("Please wait while Ardour loads visual data"),
+                                           string_compose (_("Please wait while %1 loads visual data"), PROGRAM_NAME),
                                            true,
                                            Gtk::MESSAGE_INFO,
                                            Gtk::BUTTONS_NONE);
@@ -4660,8 +4734,8 @@ Editor::first_idle ()
        _have_idled = true;
 }
 
-static gboolean
-_idle_resizer (gpointer arg)
+gboolean
+Editor::_idle_resize (gpointer arg)
 {
        return ((Editor*)arg)->idle_resize ();
 }
@@ -4670,7 +4744,7 @@ void
 Editor::add_to_idle_resize (TimeAxisView* view, int32_t h)
 {
        if (resize_idle_id < 0) {
-               resize_idle_id = g_idle_add (_idle_resizer, this);
+               resize_idle_id = g_idle_add (_idle_resize, this);
                _pending_resize_amount = 0;
        }
 
@@ -4716,6 +4790,7 @@ Editor::idle_resize ()
                }
        }
 
+        _pending_resize_amount = 0;
        flush_canvas ();
        _group_tabs->set_dirty ();
        resize_idle_id = -1;
@@ -4792,7 +4867,7 @@ Editor::handle_new_route (RouteList& routes)
        for (RouteList::iterator x = routes.begin(); x != routes.end(); ++x) {
                boost::shared_ptr<Route> route = (*x);
 
-               if (route->is_hidden()) {
+               if (route->is_hidden() || route->is_monitor()) {
                        continue;
                }
 
@@ -4969,9 +5044,9 @@ Editor::hide_a_region (boost::shared_ptr<Region> r)
 }
 
 void
-Editor::remove_a_region (boost::shared_ptr<Region> r)
+Editor::show_a_region (boost::shared_ptr<Region> r)
 {
-       // _session->remove_region_from_region_list (r);
+       r->set_hidden (false);
 }
 
 void
@@ -4986,6 +5061,12 @@ Editor::hide_region_from_region_list ()
        _regions->selection_mapover (sigc::mem_fun (*this, &Editor::hide_a_region));
 }
 
+void
+Editor::show_region_in_region_list ()
+{
+       _regions->selection_mapover (sigc::mem_fun (*this, &Editor::show_a_region));
+}
+
 void
 Editor::start_step_editing ()
 {
@@ -5121,33 +5202,33 @@ Editor::super_rapid_screen_update ()
                        playhead_cursor->set_position (frame);
                }
 
-#undef CONTINUOUS_SCROLL
-#ifndef CONTINUOUS_SCROLL              
-
-               if (!_dragging_playhead && _follow_playhead && _session->requested_return_frame() < 0) {
-                       reset_x_origin_to_follow_playhead ();
-               }
+                if (!_stationary_playhead) {
 
-#else  // CONTINUOUS_SCROLL
-                               
-               /* don't do continuous scroll till the new position is in the rightmost quarter of the
-                  editor canvas
-               */
-               
-               double target = ((double)frame - (double)current_page_frames()/2.0) / frames_per_unit;
-               if (target <= 0.0) {
-                       target = 0.0;
-               }
-               if (fabs(target - current) < current_page_frames() / frames_per_unit) {
-                       target = (target * 0.15) + (current * 0.85);
-               } else {
-                       /* relax */
-               }
-               
-               current = target;
-               horizontal_adjustment.set_value (current);
+                        if (!_dragging_playhead && _follow_playhead && _session->requested_return_frame() < 0) {
+                                reset_x_origin_to_follow_playhead ();
+                        }
 
-#endif // CONTINUOUS_SCROLL
+                } else {
+                       
+                        /* don't do continuous scroll till the new position is in the rightmost quarter of the
+                           editor canvas
+                        */
+#if 0                        
+                        // FIXME DO SOMETHING THAT WORKS HERE - this is 2.X code                         
+                        double target = ((double)frame - (double)current_page_frames()/2.0) / frames_per_unit;
+                        if (target <= 0.0) {
+                                target = 0.0;
+                        }
+                        if (fabs(target - current) < current_page_frames() / frames_per_unit) {
+                                target = (target * 0.15) + (current * 0.85);
+                        } else {
+                                /* relax */
+                        }
+                        
+                        current = target;
+                        horizontal_adjustment.set_value (current);
+#endif
+                }
                
        }
 }