Make the close button in the config info dialog work.
[ardour.git] / gtk2_ardour / editor.cc
index 89729800112f511e0d89d098d9f11ba5e4c2a7a2..d77296b07e2b9d9f45d477f65423ed926cff7fdd 100644 (file)
@@ -43,6 +43,7 @@
 #include "pbd/enumwriter.h"
 #include "pbd/memento_command.h"
 #include "pbd/unknown_type.h"
+#include "pbd/unwind.h"
 
 #include <glibmm/miscutils.h>
 #include <gtkmm/image.h>
@@ -58,7 +59,6 @@
 #include "gtkmm2ext/choice.h"
 #include "gtkmm2ext/cell_renderer_pixbuf_toggle.h"
 
-#include "ardour/audio_diskstream.h"
 #include "ardour/audio_track.h"
 #include "ardour/audioplaylist.h"
 #include "ardour/audioregion.h"
 
 #include "control_protocol/control_protocol.h"
 
+#include "actions.h"
+#include "actions.h"
+#include "analysis_window.h"
 #include "audio_clock.h"
-#include "editor.h"
-#include "debug.h"
-#include "keyboard.h"
-#include "marker.h"
-#include "playlist_selector.h"
 #include "audio_region_view.h"
-#include "rgb_macros.h"
-#include "selection.h"
 #include "audio_streamview.h"
-#include "time_axis_view.h"
 #include "audio_time_axis.h"
-#include "utils.h"
-#include "crossfade_view.h"
+#include "automation_time_axis.h"
+#include "bundle_manager.h"
+#include "button_joiner.h"
 #include "canvas-noevent-text.h"
-#include "editing.h"
-#include "public_editor.h"
-#include "crossfade_edit.h"
 #include "canvas_impl.h"
-#include "actions.h"
-#include "sfdb_ui.h"
-#include "gui_thread.h"
-#include "simpleline.h"
-#include "rhythm_ferret.h"
-#include "actions.h"
-#include "tempo_lines.h"
-#include "analysis_window.h"
-#include "bundle_manager.h"
-#include "global_port_matrix.h"
+#include "crossfade_edit.h"
+#include "crossfade_view.h"
+#include "debug.h"
+#include "editing.h"
+#include "editor.h"
+#include "editor_cursors.h"
 #include "editor_drag.h"
 #include "editor_group_tabs.h"
-#include "automation_time_axis.h"
-#include "editor_routes.h"
-#include "midi_time_axis.h"
-#include "mixer_strip.h"
-#include "editor_route_groups.h"
-#include "editor_regions.h"
 #include "editor_locations.h"
+#include "editor_regions.h"
+#include "editor_route_groups.h"
+#include "editor_routes.h"
 #include "editor_snapshots.h"
 #include "editor_summary.h"
-#include "region_layering_order_editor.h"
+#include "global_port_matrix.h"
+#include "gui_object.h"
+#include "gui_thread.h"
+#include "keyboard.h"
+#include "marker.h"
+#include "midi_time_axis.h"
+#include "mixer_strip.h"
+#include "mixer_ui.h"
 #include "mouse_cursors.h"
-#include "editor_cursors.h"
+#include "playlist_selector.h"
+#include "public_editor.h"
+#include "region_layering_order_editor.h"
+#include "rgb_macros.h"
+#include "rhythm_ferret.h"
+#include "selection.h"
+#include "sfdb_ui.h"
+#include "simpleline.h"
+#include "tempo_lines.h"
+#include "time_axis_view.h"
+#include "utils.h"
 
 #include "i18n.h"
 
@@ -148,6 +151,8 @@ static const gchar *_snap_type_strings[] = {
        N_("Timecode Minutes"),
        N_("Seconds"),
        N_("Minutes"),
+       N_("Beats/128"),
+       N_("Beats/64"),
        N_("Beats/32"),
        N_("Beats/28"),
        N_("Beats/24"),
@@ -261,15 +266,13 @@ Editor::Editor ()
 
          /* tool bar related */
 
-       , zoom_range_clock (new AudioClock (X_("zoomrange"), false, X_("ZoomRangeClock"), true, false, true))
+       , zoom_range_clock (new AudioClock (X_("zoomrange"), false, X_("zoom range"), true, false, true))
 
        , toolbar_selection_clock_table (2,3)
 
        , automation_mode_button (_("mode"))
-       , global_automation_button (_("automation"))
 
        , _toolbar_viewport (*manage (new Gtk::Adjustment (0, 0, 1e10)), *manage (new Gtk::Adjustment (0, 0, 1e10)))
-       , midi_panic_button (_("Panic"))
 
 #ifdef WITH_CMT
        , image_socket_listener(0)
@@ -277,13 +280,14 @@ Editor::Editor ()
 
          /* nudge */
 
-       , nudge_clock (new AudioClock (X_("nudge"), false, X_("NudgeClock"), true, false, true))
+       , nudge_clock (new AudioClock (X_("nudge"), false, X_("nudge"), true, false, true))
        , meters_running(false)
        , _pending_locate_request (false)
        , _pending_initial_locate (false)
        , _last_cut_copy_source_track (0)
 
        , _region_selection_change_updates_region_list (true)
+       , _following_mixer_selection (false)
 {
        constructed = false;
 
@@ -305,7 +309,6 @@ Editor::Editor ()
         pre_press_cursor = 0;
        _drags = new DragManager (this);
        current_mixer_strip = 0;
-       current_bbt_points = 0;
        tempo_lines = 0;
 
        snap_type_strings =  I18N (_snap_type_strings);
@@ -331,8 +334,8 @@ Editor::Editor ()
 
        current_interthread_info = 0;
        _show_measures = true;
+       _maximised = false;
        show_gain_after_trim = false;
-       last_item_entered = 0;
 
        have_pending_keyboard_selection = false;
        _follow_playhead = true;
@@ -367,6 +370,7 @@ Editor::Editor ()
        layering_order_editor = 0;
        no_save_visual = false;
        resize_idle_id = -1;
+       within_track_canvas = false;
 
        scrubbing_direction = 0;
 
@@ -556,10 +560,6 @@ Editor::Editor ()
        _the_notebook.set_tab_pos (Gtk::POS_RIGHT);
        _the_notebook.show_all ();
 
-       post_maximal_editor_width = 0;
-       post_maximal_horizontal_pane_position = 0;
-       post_maximal_editor_height = 0;
-       post_maximal_vertical_pane_position = 0;
        _notebook_shrunk = false;
 
        editor_summary_pane.pack1(edit_packer);
@@ -637,9 +637,12 @@ Editor::Editor ()
        /* register actions now so that set_state() can find them and set toggles/checks etc */
 
        register_actions ();
+       /* when we start using our own keybinding system for the editor, this
+        * will be uncommented
+        */
+       // load_bindings ();
 
        setup_toolbar ();
-       setup_midi_toolbar ();
 
        _snap_type = SnapToBeat;
        set_snap_to (_snap_type);
@@ -647,6 +650,10 @@ Editor::Editor ()
        set_snap_mode (_snap_mode);
        set_mouse_mode (MouseObject, true);
         pre_internal_mouse_mode = MouseObject;
+        pre_internal_snap_type = _snap_type;
+        pre_internal_snap_mode = _snap_mode;
+        internal_snap_type = _snap_type;
+        internal_snap_mode = _snap_mode;
        set_edit_point_preference (EditAtMouse, true);
 
        _playlist_selector = new PlaylistSelector();
@@ -703,6 +710,7 @@ Editor::Editor ()
        ControlProtocol::ZoomIn.connect (*this, invalidator (*this), boost::bind (&Editor::temporal_zoom_step, this, false), gui_context());
        ControlProtocol::ZoomOut.connect (*this, invalidator (*this), boost::bind (&Editor::temporal_zoom_step, this, true), gui_context());
        ControlProtocol::ScrollTimeline.connect (*this, invalidator (*this), ui_bind (&Editor::control_scroll, this, _1), gui_context());
+       ControlProtocol::SelectByRID.connect (*this, invalidator (*this), ui_bind (&Editor::control_select, this, _1), gui_context());
        BasicUI::AccessAction.connect (*this, invalidator (*this), ui_bind (&Editor::access_action, this, _1, _2), gui_context());
 
        /* problematic: has to return a value and thus cannot be x-thread */
@@ -870,6 +878,7 @@ Editor::show_window ()
 
                if (current_mixer_strip) {
                        current_mixer_strip->hide_things ();
+                       current_mixer_strip->parameter_changed ("mixer-strip-visibility");
                }
        }
 
@@ -910,6 +919,32 @@ Editor::zoom_adjustment_changed ()
        temporal_zoom (fpu);
 }
 
+void
+Editor::control_select (uint32_t rid) 
+{
+       /* handles the (static) signal from the ControlProtocol class that
+        * requests setting the selected track to a given RID
+        */
+        
+       if (!_session) {
+               return;
+       }
+
+       boost::shared_ptr<Route> r = _session->route_by_remote_id (rid);
+
+       if (!r) {
+               return;
+       }
+
+       TimeAxisView* tav = axis_view_from_route (r);
+
+       if (tav) {
+               selection->set (tav);
+       } else {
+               selection->clear_tracks ();
+       }
+}
+
 void
 Editor::control_scroll (float fraction)
 {
@@ -1110,6 +1145,44 @@ Editor::set_session (Session *t)
 
        compute_fixed_ruler_scale ();
 
+       /* Make sure we have auto loop and auto punch ranges */
+
+       Location* loc = _session->locations()->auto_loop_location();
+       if (loc == 0) {
+               loc = new Location (*_session, 0, _session->current_end_frame(), _("Loop"),(Location::Flags) (Location::IsAutoLoop | Location::IsHidden));
+
+               if (loc->start() == loc->end()) {
+                       loc->set_end (loc->start() + 1);
+               }
+
+               _session->locations()->add (loc, false);
+               _session->set_auto_loop_location (loc);
+       } else {
+               // force name
+               loc->set_name (_("Loop"));
+       }
+
+       loc = _session->locations()->auto_punch_location();
+
+       if (loc == 0) {
+               loc = new Location (*_session, 0, _session->current_end_frame(), _("Punch"), (Location::Flags) (Location::IsAutoPunch | Location::IsHidden));
+
+               if (loc->start() == loc->end()) {
+                       loc->set_end (loc->start() + 1);
+               }
+
+               _session->locations()->add (loc, false);
+               _session->set_auto_punch_location (loc);
+       } else {
+               // force name
+               loc->set_name (_("Punch"));
+       }
+
+       refresh_location_display ();
+
+       /* This must happen after refresh_location_display(), as (amongst other things) we restore
+          the selected Marker; this needs the LocationMarker list to be available.
+       */
        XMLNode* node = ARDOUR_UI::instance()->editor_settings();
        set_state (*node, Stateful::loading_state_version);
 
@@ -1147,51 +1220,19 @@ Editor::set_session (Session *t)
                bbt.ticks = 120;
                framepos_t pos = _session->tempo_map().bbt_duration_at (0, bbt, 1);
                nudge_clock->set_mode(AudioClock::BBT);
-               nudge_clock->set (pos, true, 0, AudioClock::BBT);
+               nudge_clock->set (pos, true);
 
        } else {
-               nudge_clock->set (_session->frame_rate() * 5, true, 0, AudioClock::Timecode); // default of 5 seconds
+               nudge_clock->set_mode (AudioClock::Timecode);
+               nudge_clock->set (_session->frame_rate() * 5, true);
        }
 
        playhead_cursor->canvas_item.show ();
 
-       Location* loc = _session->locations()->auto_loop_location();
-       if (loc == 0) {
-               loc = new Location (*_session, 0, _session->current_end_frame(), _("Loop"),(Location::Flags) (Location::IsAutoLoop | Location::IsHidden));
-
-               if (loc->start() == loc->end()) {
-                       loc->set_end (loc->start() + 1);
-               }
-
-               _session->locations()->add (loc, false);
-               _session->set_auto_loop_location (loc);
-       } else {
-               // force name
-               loc->set_name (_("Loop"));
-       }
-
-       loc = _session->locations()->auto_punch_location();
-
-       if (loc == 0) {
-               loc = new Location (*_session, 0, _session->current_end_frame(), _("Punch"), (Location::Flags) (Location::IsAutoPunch | Location::IsHidden));
-
-               if (loc->start() == loc->end()) {
-                       loc->set_end (loc->start() + 1);
-               }
-
-               _session->locations()->add (loc, false);
-               _session->set_auto_punch_location (loc);
-       } else {
-               // force name
-               loc->set_name (_("Punch"));
-       }
-
        boost::function<void (string)> pc (boost::bind (&Editor::parameter_changed, this, _1));
        Config->map_parameters (pc);
        _session->config.map_parameters (pc);
 
-       refresh_location_display ();
-
        restore_ruler_visibility ();
        //tempo_map_changed (PropertyChange (0));
        _session->tempo_map().apply_with_metrics (*this, &Editor::draw_metric_marks);
@@ -1217,7 +1258,7 @@ Editor::set_session (Session *t)
        }
 
        /* register for undo history */
-       _session->register_with_memento_command_factory(_id, this);
+       _session->register_with_memento_command_factory(id(), this);
 
        ActionManager::ui_manager->signal_pre_activate().connect (sigc::mem_fun (*this, &Editor::action_pre_activated));
 
@@ -1685,7 +1726,7 @@ Editor::build_track_selection_context_menu ()
  * @param edit_items List to add the items to.
  */
 void
-Editor::add_crossfade_context_items (AudioStreamView* /*view*/, boost::shared_ptr<Crossfade> xfade, Menu_Helpers::MenuList& edit_items, bool many)
+Editor::add_crossfade_context_items (AudioStreamView* view, boost::shared_ptr<Crossfade> xfade, Menu_Helpers::MenuList& edit_items, bool many)
 {
        using namespace Menu_Helpers;
        Menu     *xfade_menu = manage (new Menu);
@@ -1699,8 +1740,13 @@ Editor::add_crossfade_context_items (AudioStreamView* /*view*/, boost::shared_pt
                str = _("Unmute");
        }
 
-       items.push_back (MenuElem (str, sigc::bind (sigc::mem_fun(*this, &Editor::toggle_xfade_active), boost::weak_ptr<Crossfade> (xfade))));
-       items.push_back (MenuElem (_("Edit..."), sigc::bind (sigc::mem_fun(*this, &Editor::edit_xfade), boost::weak_ptr<Crossfade> (xfade))));
+       items.push_back (
+               MenuElem (str, sigc::bind (sigc::mem_fun (*this, &Editor::toggle_xfade_active), &view->trackview(), boost::weak_ptr<Crossfade> (xfade)))
+               );
+       
+       items.push_back (
+               MenuElem (_("Edit..."), sigc::bind (sigc::mem_fun (*this, &Editor::edit_xfade), boost::weak_ptr<Crossfade> (xfade)))
+               );
 
        if (xfade->can_follow_overlap()) {
 
@@ -1710,7 +1756,9 @@ Editor::add_crossfade_context_items (AudioStreamView* /*view*/, boost::shared_pt
                        str = _("Convert to Full");
                }
 
-               items.push_back (MenuElem (str, sigc::bind (sigc::mem_fun(*this, &Editor::toggle_xfade_length), xfade)));
+               items.push_back (
+                       MenuElem (str, sigc::bind (sigc::mem_fun (*this, &Editor::toggle_xfade_length), &view->trackview(), xfade))
+                       );
        }
 
        if (many) {
@@ -1772,18 +1820,11 @@ Editor::add_region_context_items (Menu_Helpers::MenuList& edit_items, boost::sha
                _popup_region_menu_item->set_label (menu_item_name);
        }
 
-       /* Use the mouse position rather than the edit point to decide whether to show the `choose top region'
-          dialogue.  If we use the edit point it gets a bit messy because the user still has to click over
-          *some* region in order to get the region context menu stuff to be displayed at all.
-       */
-
-       framepos_t mouse;
-       bool ignored;
-       mouse_frame (mouse, ignored);
+       const framepos_t position = get_preferred_edit_position (false, true);
 
        edit_items.push_back (*_popup_region_menu_item);
-       if (track->playlist()->count_regions_at (mouse) > 1 && (layering_order_editor == 0 || !layering_order_editor->is_visible ())) {
-               edit_items.push_back (*manage (_region_actions->get_action ("choose-top-region")->create_menu_item ()));
+       if (track->playlist()->count_regions_at (position) > 1 && (layering_order_editor == 0 || !layering_order_editor->is_visible ())) {
+               edit_items.push_back (*manage (_region_actions->get_action ("choose-top-region-context-menu")->create_menu_item ()));
        }
        edit_items.push_back (SeparatorElem());
 }
@@ -1856,7 +1897,7 @@ Editor::add_selection_context_items (Menu_Helpers::MenuList& edit_items)
        edit_items.push_back (MenuElem (_("Consolidate Range With Processing"), sigc::bind (sigc::mem_fun(*this, &Editor::bounce_range_selection), true, true)));
        edit_items.push_back (MenuElem (_("Bounce Range to Region List"), sigc::bind (sigc::mem_fun(*this, &Editor::bounce_range_selection), false, false)));
        edit_items.push_back (MenuElem (_("Bounce Range to Region List With Processing"), sigc::bind (sigc::mem_fun(*this, &Editor::bounce_range_selection), false, true)));
-       edit_items.push_back (MenuElem (_("Export Range"), sigc::mem_fun(*this, &Editor::export_selection)));
+       edit_items.push_back (MenuElem (_("Export Range..."), sigc::mem_fun(*this, &Editor::export_selection)));
 }
 
 
@@ -1911,7 +1952,7 @@ Editor::add_dstream_context_items (Menu_Helpers::MenuList& edit_items)
 
        cutnpaste_items.push_back (MenuElem (_("Cut"), sigc::mem_fun(*this, &Editor::cut)));
        cutnpaste_items.push_back (MenuElem (_("Copy"), sigc::mem_fun(*this, &Editor::copy)));
-       cutnpaste_items.push_back (MenuElem (_("Paste"), sigc::bind (sigc::mem_fun(*this, &Editor::paste), 1.0f)));
+       cutnpaste_items.push_back (MenuElem (_("Paste"), sigc::bind (sigc::mem_fun(*this, &Editor::paste), 1.0f, true)));
 
        cutnpaste_items.push_back (SeparatorElem());
 
@@ -1982,7 +2023,7 @@ Editor::add_bus_context_items (Menu_Helpers::MenuList& edit_items)
 
        cutnpaste_items.push_back (MenuElem (_("Cut"), sigc::mem_fun(*this, &Editor::cut)));
        cutnpaste_items.push_back (MenuElem (_("Copy"), sigc::mem_fun(*this, &Editor::copy)));
-       cutnpaste_items.push_back (MenuElem (_("Paste"), sigc::bind (sigc::mem_fun(*this, &Editor::paste), 1.0f)));
+       cutnpaste_items.push_back (MenuElem (_("Paste"), sigc::bind (sigc::mem_fun(*this, &Editor::paste), 1.0f, true)));
 
        Menu *nudge_menu = manage (new Menu());
        MenuList& nudge_items = nudge_menu->items();
@@ -2030,6 +2071,8 @@ Editor::set_snap_to (SnapType st)
        instant_save ();
 
        switch (_snap_type) {
+       case SnapToBeatDiv128:
+       case SnapToBeatDiv64:
        case SnapToBeatDiv32:
        case SnapToBeatDiv28:
        case SnapToBeatDiv24:
@@ -2133,9 +2176,7 @@ Editor::set_state (const XMLNode& node, int /*version*/)
        int x, y;
        Gdk::Geometry g;
 
-       if ((prop = node.property ("id")) != 0) {
-               _id = prop->value ();
-       }
+       set_id (node);
 
        g.base_width = default_width;
        g.base_height = default_height;
@@ -2190,7 +2231,7 @@ Editor::set_state (const XMLNode& node, int /*version*/)
        }
 
        if ((prop = node.property ("zoom-focus"))) {
-               set_zoom_focus ((ZoomFocus) atoi (prop->value()));
+               set_zoom_focus ((ZoomFocus) string_2_enum (prop->value(), zoom_focus));
        }
 
        if ((prop = node.property ("zoom"))) {
@@ -2200,11 +2241,27 @@ Editor::set_state (const XMLNode& node, int /*version*/)
        }
 
        if ((prop = node.property ("snap-to"))) {
-               set_snap_to ((SnapType) atoi (prop->value()));
+               set_snap_to ((SnapType) string_2_enum (prop->value(), _snap_type));
        }
 
        if ((prop = node.property ("snap-mode"))) {
-               set_snap_mode ((SnapMode) atoi (prop->value()));
+               set_snap_mode ((SnapMode) string_2_enum (prop->value(), _snap_mode));
+       }
+
+       if ((prop = node.property ("internal-snap-to"))) {
+               internal_snap_type = (SnapType) string_2_enum (prop->value(), internal_snap_type);
+       }
+
+       if ((prop = node.property ("internal-snap-mode"))) {
+               internal_snap_mode = (SnapMode) string_2_enum (prop->value(), internal_snap_mode);
+       }
+
+       if ((prop = node.property ("pre-internal-snap-to"))) {
+               pre_internal_snap_type = (SnapType) string_2_enum (prop->value(), pre_internal_snap_type);
+       }
+
+       if ((prop = node.property ("pre-internal-snap-mode"))) {
+               pre_internal_snap_mode = (SnapMode) string_2_enum (prop->value(), pre_internal_snap_mode);
        }
 
        if ((prop = node.property ("mouse-mode"))) {
@@ -2217,6 +2274,9 @@ Editor::set_state (const XMLNode& node, int /*version*/)
        if ((prop = node.property ("left-frame")) != 0) {
                framepos_t pos;
                if (sscanf (prop->value().c_str(), "%" PRId64, &pos) == 1) {
+                       if (pos < 0) {
+                               pos = 0;
+                       }
                        reset_x_origin (pos);
                }
        }
@@ -2236,7 +2296,7 @@ Editor::set_state (const XMLNode& node, int /*version*/)
        }
 
        if ((prop = node.property ("join-object-range"))) {
-               join_object_range_button.set_active (string_is_affirmative (prop->value ()));
+               ActionManager::set_toggle_action ("MouseMode", "set-mouse-mode-object-range", string_is_affirmative (prop->value ()));
        }
 
        if ((prop = node.property ("edit-point"))) {
@@ -2268,7 +2328,7 @@ Editor::set_state (const XMLNode& node, int /*version*/)
        }
 
        if ((prop = node.property ("stationary-playhead"))) {
-               bool yn = (prop->value() == "yes");
+               bool yn = string_is_affirmative (prop->value());
                set_stationary_playhead (yn);
                RefPtr<Action> act = ActionManager::get_action (X_("Editor"), X_("toggle-stationary-playhead"));
                if (act) {
@@ -2338,6 +2398,13 @@ Editor::set_state (const XMLNode& node, int /*version*/)
                _regions->set_state (**i);
        }
 
+       if ((prop = node.property ("maximised"))) {
+               bool yn = string_is_affirmative (prop->value());
+               if (yn) {
+                       ActionManager::do_action ("Common", "ToggleMaximalEditor");
+               }
+       }
+
        return 0;
 }
 
@@ -2347,7 +2414,7 @@ Editor::get_state ()
        XMLNode* node = new XMLNode ("Editor");
        char buf[32];
 
-       _id.print (buf, sizeof (buf));
+       id().print (buf, sizeof (buf));
        node->add_property ("id", buf);
 
        if (is_realized()) {
@@ -2370,8 +2437,6 @@ Editor::get_state ()
                snprintf(buf,sizeof(buf), "%d",gtk_paned_get_position (static_cast<Paned*>(&edit_pane)->gobj()));
                geometry->add_property("edit-horizontal-pane-pos", string(buf));
                geometry->add_property("notebook-shrunk", _notebook_shrunk ? "1" : "0");
-               snprintf(buf,sizeof(buf), "%d",pre_maximal_horizontal_pane_position);
-               geometry->add_property("pre-maximal-horizontal-pane-position", string(buf));
                snprintf(buf,sizeof(buf), "%d",gtk_paned_get_position (static_cast<Paned*>(&editor_summary_pane)->gobj()));
                geometry->add_property("edit-vertical-pane-pos", string(buf));
 
@@ -2380,15 +2445,15 @@ Editor::get_state ()
 
        maybe_add_mixer_strip_width (*node);
 
-       snprintf (buf, sizeof(buf), "%d", (int) zoom_focus);
-       node->add_property ("zoom-focus", buf);
+       node->add_property ("zoom-focus", enum_2_string (zoom_focus));
        snprintf (buf, sizeof(buf), "%f", frames_per_unit);
        node->add_property ("zoom", buf);
-       snprintf (buf, sizeof(buf), "%d", (int) _snap_type);
-       node->add_property ("snap-to", buf);
-       snprintf (buf, sizeof(buf), "%d", (int) _snap_mode);
-       node->add_property ("snap-mode", buf);
-
+       node->add_property ("snap-to", enum_2_string (_snap_type));
+       node->add_property ("snap-mode", enum_2_string (_snap_mode));
+       node->add_property ("internal-snap-to", enum_2_string (internal_snap_type));
+       node->add_property ("internal-snap-mode", enum_2_string (internal_snap_mode));
+       node->add_property ("pre-internal-snap-to", enum_2_string (pre_internal_snap_type));
+       node->add_property ("pre-internal-snap-mode", enum_2_string (pre_internal_snap_mode));
        node->add_property ("edit-point", enum_2_string (_edit_point));
 
        snprintf (buf, sizeof (buf), "%" PRIi64, playhead_cursor->current_frame);
@@ -2399,13 +2464,14 @@ Editor::get_state ()
        node->add_property ("y-origin", buf);
 
        node->add_property ("show-measures", _show_measures ? "yes" : "no");
+       node->add_property ("maximised", _maximised ? "yes" : "no");
        node->add_property ("follow-playhead", _follow_playhead ? "yes" : "no");
        node->add_property ("stationary-playhead", _stationary_playhead ? "yes" : "no");
        node->add_property ("xfades-visible", _xfade_visibility ? "yes" : "no");
        node->add_property ("region-list-sort-type", enum_2_string (_regions->sort_type ()));
        node->add_property ("mouse-mode", enum2str(mouse_mode));
        node->add_property ("internal-edit", _internal_editing ? "yes" : "no");
-       node->add_property ("join-object-range", join_object_range_button.get_active () ? "yes" : "no");
+       node->add_property ("join-object-range", smart_mode_action->get_active () ? "yes" : "no");
 
        Glib::RefPtr<Action> act = ActionManager::get_action (X_("Editor"), X_("show-editor-mixer"));
        if (act) {
@@ -2441,14 +2507,14 @@ Editor::get_state ()
 /** @param y y offset from the top of all trackviews.
  *  @return pair: TimeAxisView that y is over, layer index.
  *  TimeAxisView may be 0.  Layer index is the layer number if the TimeAxisView is valid and is
- *  in stacked region display mode, otherwise 0.
+ *  in stacked or expanded region display mode, otherwise 0.
  */
-std::pair<TimeAxisView *, layer_t>
+std::pair<TimeAxisView *, double>
 Editor::trackview_by_y_position (double y)
 {
        for (TrackViewList::iterator iter = track_views.begin(); iter != track_views.end(); ++iter) {
 
-               std::pair<TimeAxisView*, int> const r = (*iter)->covers_y_position (y);
+               std::pair<TimeAxisView*, double> const r = (*iter)->covers_y_position (y);
                if (r.first) {
                        return r;
                }
@@ -2594,6 +2660,12 @@ Editor::snap_to_internal (framepos_t& start, int32_t direction, bool for_mark)
                start = _session->tempo_map().round_to_beat (start, direction);
                break;
 
+       case SnapToBeatDiv128:
+               start = _session->tempo_map().round_to_beat_subdivision (start, 128, direction);
+               break;
+       case SnapToBeatDiv64:
+               start = _session->tempo_map().round_to_beat_subdivision (start, 64, direction);
+               break;
        case SnapToBeatDiv32:
                start = _session->tempo_map().round_to_beat_subdivision (start, 32, direction);
                break;
@@ -2726,27 +2798,57 @@ Editor::setup_toolbar ()
        mode_box->set_border_width (2);
        mode_box->set_spacing(4);
 
-       /* table containing mode buttons */
-
-       HBox* mouse_mode_button_box = manage (new HBox ());
-
-       if (Profile->get_sae()) {
-               mouse_mode_button_box->pack_start (mouse_move_button);
-       } else {
-               mouse_mode_button_box->pack_start (mouse_move_button);
-               mouse_mode_button_box->pack_start (join_object_range_button);
-               mouse_mode_button_box->pack_start (mouse_select_button);
-       }
-
-       mouse_mode_button_box->pack_start (mouse_zoom_button);
-
-       if (!Profile->get_sae()) {
-               mouse_mode_button_box->pack_start (mouse_gain_button);
-       }
-
-       mouse_mode_button_box->pack_start (mouse_timefx_button);
-       mouse_mode_button_box->pack_start (mouse_audition_button);
-       mouse_mode_button_box->pack_start (internal_edit_button);
+       HBox* mouse_mode_box = manage (new HBox);
+       HBox* mouse_mode_hbox1 = manage (new HBox);
+       HBox* mouse_mode_hbox2 = manage (new HBox);
+       VBox* mouse_mode_vbox1 = manage (new VBox);
+       VBox* mouse_mode_vbox2 = manage (new VBox);
+       Alignment* mouse_mode_align1 = manage (new Alignment);
+       Alignment* mouse_mode_align2 = manage (new Alignment);
+
+       Glib::RefPtr<SizeGroup> mouse_mode_size_group = SizeGroup::create (SIZE_GROUP_BOTH);
+       mouse_mode_size_group->add_widget (mouse_move_button);
+       mouse_mode_size_group->add_widget (mouse_select_button);
+       mouse_mode_size_group->add_widget (mouse_zoom_button);
+       mouse_mode_size_group->add_widget (mouse_gain_button);
+       mouse_mode_size_group->add_widget (mouse_timefx_button);
+       mouse_mode_size_group->add_widget (mouse_audition_button);
+       mouse_mode_size_group->add_widget (mouse_draw_button);
+       mouse_mode_size_group->add_widget (internal_edit_button);
+
+       /* make them just a bit bigger */
+       mouse_move_button.set_size_request (-1, 25);
+
+       smart_mode_joiner = manage (new ButtonJoiner ("mouse mode button", mouse_move_button, mouse_select_button));
+       smart_mode_joiner->set_related_action (smart_mode_action);
+
+       mouse_move_button.set_elements (ArdourButton::Element (ArdourButton::Body|ArdourButton::Text));
+       mouse_select_button.set_elements (ArdourButton::Element (ArdourButton::Body|ArdourButton::Text));
+
+       mouse_move_button.set_rounded_corner_mask (0x1); // upper left only 
+       mouse_select_button.set_rounded_corner_mask (0x2); // upper right only 
+
+       mouse_mode_hbox2->set_spacing (2);
+       mouse_mode_box->set_spacing (2);
+
+       mouse_mode_hbox1->pack_start (*smart_mode_joiner, false, false);
+       mouse_mode_hbox2->pack_start (mouse_zoom_button, false, false);
+       mouse_mode_hbox2->pack_start (mouse_gain_button, false, false);
+       mouse_mode_hbox2->pack_start (mouse_timefx_button, false, false);
+       mouse_mode_hbox2->pack_start (mouse_audition_button, false, false);
+       mouse_mode_hbox2->pack_start (mouse_draw_button, false, false);
+       mouse_mode_hbox2->pack_start (internal_edit_button, false, false);
+
+       mouse_mode_vbox1->pack_start (*mouse_mode_hbox1, false, false);
+       mouse_mode_vbox2->pack_start (*mouse_mode_hbox2, false, false);
+
+       mouse_mode_align1->add (*mouse_mode_vbox1);
+       mouse_mode_align1->set (0.5, 1.0, 0.0, 0.0);
+       mouse_mode_align2->add (*mouse_mode_vbox2);
+       mouse_mode_align2->set (0.5, 1.0, 0.0, 0.0);
+
+       mouse_mode_box->pack_start (*mouse_mode_align1, false, false);
+       mouse_mode_box->pack_start (*mouse_mode_align2, false, false);
 
        edit_mode_strings.push_back (edit_mode_to_string (Slide));
        if (!Profile->get_sae()) {
@@ -2755,11 +2857,11 @@ Editor::setup_toolbar ()
        edit_mode_strings.push_back (edit_mode_to_string (Lock));
 
        edit_mode_selector.set_name ("EditModeSelector");
-       set_popdown_strings (edit_mode_selector, edit_mode_strings, true);
+       set_popdown_strings (edit_mode_selector, edit_mode_strings);
        edit_mode_selector.signal_changed().connect (sigc::mem_fun(*this, &Editor::edit_mode_selection_done));
 
-       mode_box->pack_start (edit_mode_selector);
-       mode_box->pack_start (*mouse_mode_button_box);
+       mode_box->pack_start (edit_mode_selector, false, false);
+       mode_box->pack_start (*mouse_mode_box, false, false);
 
        _mouse_mode_tearoff = manage (new TearOff (*mode_box));
        _mouse_mode_tearoff->set_name ("MouseModeBase");
@@ -2778,64 +2880,46 @@ Editor::setup_toolbar ()
        _mouse_mode_tearoff->Visible.connect (sigc::bind (sigc::mem_fun(*this, &Editor::reattach_tearoff), static_cast<Box*> (&toolbar_hbox),
                                                          &_mouse_mode_tearoff->tearoff_window(), 1));
 
-       mouse_move_button.set_mode (false);
-       mouse_select_button.set_mode (false);
-       mouse_gain_button.set_mode (false);
-       mouse_zoom_button.set_mode (false);
-       mouse_timefx_button.set_mode (false);
-       mouse_audition_button.set_mode (false);
-       join_object_range_button.set_mode (false);
-
-       mouse_move_button.set_name ("MouseModeButton");
-       mouse_select_button.set_name ("MouseModeButton");
-       mouse_gain_button.set_name ("MouseModeButton");
-       mouse_zoom_button.set_name ("MouseModeButton");
-       mouse_timefx_button.set_name ("MouseModeButton");
-       mouse_audition_button.set_name ("MouseModeButton");
-       internal_edit_button.set_name ("MouseModeButton");
-       join_object_range_button.set_name ("MouseModeButton");
-
-       mouse_move_button.unset_flags (CAN_FOCUS);
-       mouse_select_button.unset_flags (CAN_FOCUS);
-       mouse_gain_button.unset_flags (CAN_FOCUS);
-       mouse_zoom_button.unset_flags (CAN_FOCUS);
-       mouse_timefx_button.unset_flags (CAN_FOCUS);
-       mouse_audition_button.unset_flags (CAN_FOCUS);
-       internal_edit_button.unset_flags (CAN_FOCUS);
-       join_object_range_button.unset_flags (CAN_FOCUS);
-
        /* Zoom */
 
-       _zoom_box.set_spacing (1);
-       _zoom_box.set_border_width (0);
+       _zoom_box.set_spacing (2);
+       _zoom_box.set_border_width (2);
+
+       RefPtr<Action> act;
 
-       zoom_in_button.set_name ("EditorTimeButton");
-       zoom_in_button.set_image (*(manage (new Image (::get_icon ("zoom_in")))));
-       zoom_in_button.signal_clicked().connect (sigc::bind (sigc::mem_fun(*this, &Editor::temporal_zoom_step), false));
+       zoom_in_button.set_name ("zoom button");
+       zoom_in_button.set_image (::get_icon ("zoom_in"));
+       zoom_in_button.set_tweaks (ArdourButton::ShowClick);
+       act = ActionManager::get_action (X_("Editor"), X_("temporal-zoom-in"));
+       zoom_in_button.set_related_action (act);
 
-       zoom_out_button.set_name ("EditorTimeButton");
-       zoom_out_button.set_image (*(manage (new Image (::get_icon ("zoom_out")))));
-       zoom_out_button.signal_clicked().connect (sigc::bind (sigc::mem_fun(*this, &Editor::temporal_zoom_step), true));
+       zoom_out_button.set_name ("zoom button");
+       zoom_out_button.set_image (::get_icon ("zoom_out"));
+       zoom_out_button.set_tweaks (ArdourButton::ShowClick);
+       act = ActionManager::get_action (X_("Editor"), X_("temporal-zoom-out"));
+       zoom_out_button.set_related_action (act);
 
-       zoom_out_full_button.set_name ("EditorTimeButton");
-       zoom_out_full_button.set_image (*(manage (new Image (::get_icon ("zoom_full")))));
-       zoom_out_full_button.signal_clicked().connect (sigc::mem_fun(*this, &Editor::temporal_zoom_session));
+       zoom_out_full_button.set_name ("zoom button");
+       zoom_out_full_button.set_image (::get_icon ("zoom_full"));
+       zoom_out_full_button.set_tweaks (ArdourButton::ShowClick);
+       act = ActionManager::get_action (X_("Editor"), X_("zoom-to-session"));
+       zoom_out_full_button.set_related_action (act);
 
        zoom_focus_selector.set_name ("ZoomFocusSelector");
-       set_popdown_strings (zoom_focus_selector, zoom_focus_strings, true);
+       set_popdown_strings (zoom_focus_selector, zoom_focus_strings);
        zoom_focus_selector.signal_changed().connect (sigc::mem_fun(*this, &Editor::zoom_focus_selection_done));
 
        _zoom_box.pack_start (zoom_out_button, false, false);
        _zoom_box.pack_start (zoom_in_button, false, false);
        _zoom_box.pack_start (zoom_out_full_button, false, false);
 
-       _zoom_box.pack_start (zoom_focus_selector);
+       _zoom_box.pack_start (zoom_focus_selector, false, false);
 
        /* Track zoom buttons */
        tav_expand_button.set_name ("TrackHeightButton");
        tav_expand_button.set_size_request (-1, 20);
        tav_expand_button.add (*(manage (new Image (::get_icon ("tav_exp")))));
-       RefPtr<Action> act = ActionManager::get_action (X_("Editor"), X_("expand-tracks"));
+       act = ActionManager::get_action (X_("Editor"), X_("expand-tracks"));
        act->connect_proxy (tav_expand_button);
 
        tav_shrink_button.set_name ("TrackHeightButton");
@@ -2862,15 +2946,15 @@ Editor::setup_toolbar ()
        snap_box.set_border_width (2);
 
        snap_type_selector.set_name ("SnapTypeSelector");
-       set_popdown_strings (snap_type_selector, snap_type_strings, true);
+       set_popdown_strings (snap_type_selector, snap_type_strings);
        snap_type_selector.signal_changed().connect (sigc::mem_fun(*this, &Editor::snap_type_selection_done));
 
        snap_mode_selector.set_name ("SnapModeSelector");
-       set_popdown_strings (snap_mode_selector, snap_mode_strings, true);
+       set_popdown_strings (snap_mode_selector, snap_mode_strings);
        snap_mode_selector.signal_changed().connect (sigc::mem_fun(*this, &Editor::snap_mode_selection_done));
 
        edit_point_selector.set_name ("EditPointSelector");
-       set_popdown_strings (edit_point_selector, edit_point_strings, true);
+       set_popdown_strings (edit_point_selector, edit_point_strings);
        edit_point_selector.signal_changed().connect (sigc::mem_fun(*this, &Editor::edit_point_selection_done));
 
        snap_box.pack_start (snap_mode_selector, false, false);
@@ -2880,7 +2964,7 @@ Editor::setup_toolbar ()
        /* Nudge */
 
        HBox *nudge_box = manage (new HBox);
-       nudge_box->set_spacing(1);
+       nudge_box->set_spacing (2);
        nudge_box->set_border_width (2);
 
        nudge_forward_button.signal_button_release_event().connect (sigc::mem_fun(*this, &Editor::nudge_forward_release), false);
@@ -2940,19 +3024,19 @@ Editor::setup_toolbar ()
        toolbar_frame.set_shadow_type (SHADOW_OUT);
        toolbar_frame.set_name ("BaseFrame");
        toolbar_frame.add (_toolbar_viewport);
-
-        DPIReset.connect (sigc::mem_fun (*this, &Editor::resize_text_widgets));
 }
 
 void
 Editor::setup_tooltips ()
 {
        ARDOUR_UI::instance()->set_tip (mouse_move_button, _("Select/Move Objects"));
+       ARDOUR_UI::instance()->set_tip (mouse_select_button, _("Select/Move Ranges"));
+       ARDOUR_UI::instance()->set_tip (mouse_draw_button, _("Draw/Edit MIDI Notes"));
        ARDOUR_UI::instance()->set_tip (mouse_gain_button, _("Draw Region Gain"));
        ARDOUR_UI::instance()->set_tip (mouse_zoom_button, _("Select Zoom Range"));
        ARDOUR_UI::instance()->set_tip (mouse_timefx_button, _("Stretch/Shrink Regions and MIDI Notes"));
        ARDOUR_UI::instance()->set_tip (mouse_audition_button, _("Listen to Specific Regions"));
-       ARDOUR_UI::instance()->set_tip (join_object_range_button, _("Select/Move Objects or Ranges"));
+       ARDOUR_UI::instance()->set_tip (smart_mode_joiner, _("Smart Mode (Select/Move Objects + Ranges)"));
        ARDOUR_UI::instance()->set_tip (internal_edit_button, _("Edit Region Contents (e.g. notes)"));
        ARDOUR_UI::instance()->set_tip (*_group_tabs, _("Groups: click to (de)activate\nContext-click for other operations"));
        ARDOUR_UI::instance()->set_tip (nudge_forward_button, _("Nudge Region/Selection Forwards"));
@@ -2966,38 +3050,8 @@ Editor::setup_tooltips ()
        ARDOUR_UI::instance()->set_tip (snap_type_selector, _("Snap/Grid Units"));
        ARDOUR_UI::instance()->set_tip (snap_mode_selector, _("Snap/Grid Mode"));
        ARDOUR_UI::instance()->set_tip (edit_point_selector, _("Edit point"));
-       ARDOUR_UI::instance()->set_tip (midi_sound_notes, _("Sound Notes"));
-       ARDOUR_UI::instance()->set_tip (midi_panic_button, _("Send note off and reset controller messages on all MIDI channels"));
        ARDOUR_UI::instance()->set_tip (edit_mode_selector, _("Edit Mode"));
-}
-
-void
-Editor::midi_panic ()
-{
-       cerr << "MIDI panic\n";
-
-       if (_session) {
-               _session->midi_panic();
-       }
-}
-
-void
-Editor::setup_midi_toolbar ()
-{
-       RefPtr<Action> act;
-
-       /* Midi sound notes */
-       midi_sound_notes.add (*(manage (new Image (::get_icon("midi_sound_notes")))));
-       midi_sound_notes.unset_flags (CAN_FOCUS);
-
-       /* Panic */
-
-       act = ActionManager::get_action (X_("MIDI"), X_("panic"));
-       midi_panic_button.set_name("MidiPanicButton");
-       act->connect_proxy (midi_panic_button);
-
-       panic_box.pack_start (midi_sound_notes , true, true);
-       panic_box.pack_start (midi_panic_button, true, true);
+       ARDOUR_UI::instance()->set_tip (nudge_clock, _("Nudge Clock\n(controls distance used to nudge regions and selections)"));
 }
 
 int
@@ -3172,9 +3226,9 @@ Editor::history_changed ()
 
        if (undo_action && _session) {
                if (_session->undo_depth() == 0) {
-                       label = _("Undo");
+                       label = S_("Command|Undo");
                } else {
-                       label = string_compose(_("Undo (%1)"), _session->next_undo());
+                       label = string_compose(S_("Command|Undo (%1)"), _session->next_undo());
                }
                undo_action->property_label() = label;
        }
@@ -3328,6 +3382,10 @@ Editor::snap_type_selection_done ()
                snaptype = SnapToBeatDiv28;
        } else if (choice == _("Beats/32")) {
                snaptype = SnapToBeatDiv32;
+       } else if (choice == _("Beats/64")) {
+               snaptype = SnapToBeatDiv64;
+       } else if (choice == _("Beats/128")) {
+               snaptype = SnapToBeatDiv128;
        } else if (choice == _("Beats")) {
                snaptype = SnapToBeat;
        } else if (choice == _("Bars")) {
@@ -3527,10 +3585,6 @@ Editor::pane_allocation_handler (Allocation &alloc, Paned* which)
                        _notebook_shrunk = string_is_affirmative (prop->value ());
                }
 
-               if (geometry && (prop = geometry->property ("pre-maximal-horizontal-pane-position"))) {
-                       pre_maximal_horizontal_pane_position = atoi (prop->value ());
-               }
-
                if (!geometry || (prop = geometry->property ("edit-horizontal-pane-pos")) == 0) {
                        /* initial allocation is 90% to canvas, 10% to notebook */
                        pos = (int) floor (alloc.get_width() * 0.90f);
@@ -3541,9 +3595,6 @@ Editor::pane_allocation_handler (Allocation &alloc, Paned* which)
 
                if (GTK_WIDGET(edit_pane.gobj())->allocation.width > pos) {
                        edit_pane.set_position (pos);
-                       if (pre_maximal_horizontal_pane_position == 0) {
-                               pre_maximal_horizontal_pane_position = pos;
-                       }
                }
 
                done = (Pane) (done | Horizontal);
@@ -3559,12 +3610,12 @@ Editor::pane_allocation_handler (Allocation &alloc, Paned* which)
                        pos = (int) floor (alloc.get_height() * 0.90f);
                        snprintf (buf, sizeof(buf), "%d", pos);
                } else {
+
                        pos = atoi (prop->value());
                }
 
                if (GTK_WIDGET(editor_summary_pane.gobj())->allocation.height > pos) {
                        editor_summary_pane.set_position (pos);
-                       pre_maximal_vertical_pane_position = pos;
                }
 
                done = (Pane) (done | Vertical);
@@ -3574,7 +3625,9 @@ Editor::pane_allocation_handler (Allocation &alloc, Paned* which)
 void
 Editor::detach_tearoff (Box* /*b*/, Window* /*w*/)
 {
-       if (_tools_tearoff->torn_off() && _mouse_mode_tearoff->torn_off()) {
+       if ((_tools_tearoff->torn_off() || !_tools_tearoff->visible()) && 
+           (_mouse_mode_tearoff->torn_off() || !_mouse_mode_tearoff->visible()) && 
+           (_zoom_tearoff->torn_off() || !_zoom_tearoff->visible())) {
                top_hbox.remove (toolbar_frame);
        }
 }
@@ -3651,21 +3704,50 @@ Editor::set_stationary_playhead (bool yn)
 }
 
 void
-Editor::toggle_xfade_active (boost::weak_ptr<Crossfade> wxfade)
+Editor::toggle_xfade_active (RouteTimeAxisView* tv, boost::weak_ptr<Crossfade> wxfade)
 {
        boost::shared_ptr<Crossfade> xfade (wxfade.lock());
-       if (xfade) {
-               xfade->set_active (!xfade->active());
+       if (!xfade) {
+               return;
        }
+
+       vector<boost::shared_ptr<Crossfade> > all = get_equivalent_crossfades (*tv, xfade, ARDOUR::Properties::edit.property_id);
+
+       _session->begin_reversible_command (_("Change crossfade active state"));
+       
+       for (vector<boost::shared_ptr<Crossfade> >::iterator i = all.begin(); i != all.end(); ++i) {
+               (*i)->clear_changes ();
+               (*i)->set_active (!(*i)->active());
+               _session->add_command (new StatefulDiffCommand (*i));
+       }
+       
+       _session->commit_reversible_command ();
 }
 
 void
-Editor::toggle_xfade_length (boost::weak_ptr<Crossfade> wxfade)
+Editor::toggle_xfade_length (RouteTimeAxisView* tv, boost::weak_ptr<Crossfade> wxfade)
 {
        boost::shared_ptr<Crossfade> xfade (wxfade.lock());
-       if (xfade) {
-               xfade->set_follow_overlap (!xfade->following_overlap());
+       if (!xfade) {
+               return;
        }
+       
+       vector<boost::shared_ptr<Crossfade> > all = get_equivalent_crossfades (*tv, xfade, ARDOUR::Properties::edit.property_id);
+
+       /* This can't be a StatefulDiffCommand as the fade shapes are not
+          managed by the Stateful properties system.
+       */
+       _session->begin_reversible_command (_("Change crossfade length"));
+       
+       for (vector<boost::shared_ptr<Crossfade> >::iterator i = all.begin(); i != all.end(); ++i) {
+               XMLNode& before = (*i)->get_state ();
+               (*i)->set_follow_overlap (!(*i)->following_overlap());
+               XMLNode& after = (*i)->get_state ();
+       
+               _session->add_command (new MementoCommand<Crossfade> (*i->get(), &before, &after));
+       }
+       
+       _session->commit_reversible_command ();
 }
 
 void
@@ -3711,6 +3793,12 @@ Editor::get_grid_type_as_beats (bool& success, framepos_t position)
                return 1.0;
                break;
 
+       case SnapToBeatDiv128:
+               return 1.0/128.0;
+               break;
+       case SnapToBeatDiv64:
+               return 1.0/64.0;
+               break;
        case SnapToBeatDiv32:
                return 1.0/32.0;
                break;
@@ -3759,7 +3847,7 @@ Editor::get_grid_type_as_beats (bool& success, framepos_t position)
 
        case SnapToBar:
                if (_session) {
-                       return _session->tempo_map().meter_at (position).beats_per_bar();
+                       return _session->tempo_map().meter_at (position).divisions_per_bar();
                }
                break;
 
@@ -3913,74 +4001,40 @@ Editor::session_state_saved (string)
 void
 Editor::maximise_editing_space ()
 {
-       _mouse_mode_tearoff->set_visible (false);
-       _tools_tearoff->set_visible (false);
-       _zoom_tearoff->set_visible (false);
-
-       pre_maximal_horizontal_pane_position = edit_pane.get_position ();
-       pre_maximal_vertical_pane_position = editor_summary_pane.get_position ();
-       pre_maximal_editor_width = this->get_width ();
-       pre_maximal_editor_height = this->get_height ();
-
-       if (post_maximal_horizontal_pane_position == 0) {
-               post_maximal_horizontal_pane_position = edit_pane.get_width();
-       }
-
-       if (post_maximal_vertical_pane_position == 0) {
-               post_maximal_vertical_pane_position = editor_summary_pane.get_height();
+       if (_maximised) {
+               return;
        }
 
        fullscreen ();
 
-       if (post_maximal_editor_width) {
-               edit_pane.set_position (post_maximal_horizontal_pane_position -
-                       abs(post_maximal_editor_width - pre_maximal_editor_width));
-       } else {
-               edit_pane.set_position (post_maximal_horizontal_pane_position);
-       }
-
-       if (post_maximal_editor_height) {
-               editor_summary_pane.set_position (post_maximal_vertical_pane_position -
-                       abs(post_maximal_editor_height - pre_maximal_editor_height));
-       } else {
-               editor_summary_pane.set_position (post_maximal_vertical_pane_position);
-       }
-
-       if (Config->get_keep_tearoffs()) {
-               _mouse_mode_tearoff->set_visible (true);
-               _tools_tearoff->set_visible (true);
-               if (Config->get_show_zoom_tools ()) {
-                       _zoom_tearoff->set_visible (true);
-               }
+       if (!Config->get_keep_tearoffs()) {
+               /* these calls will leave each tearoff visible *if* it is torn off, 
+                  but invisible otherwise.
+               */
+               _mouse_mode_tearoff->set_visible (false);
+               _tools_tearoff->set_visible (false);
+               _zoom_tearoff->set_visible (false);
        }
 
+       _maximised = true;
 }
 
 void
 Editor::restore_editing_space ()
 {
-       // user changed width/height of panes during fullscreen
-
-       if (post_maximal_horizontal_pane_position != edit_pane.get_position()) {
-               post_maximal_horizontal_pane_position = edit_pane.get_position();
-       }
-
-       if (post_maximal_vertical_pane_position != editor_summary_pane.get_position()) {
-               post_maximal_vertical_pane_position = editor_summary_pane.get_position();
+       if (!_maximised) {
+               return;
        }
 
        unfullscreen();
 
-       _mouse_mode_tearoff->set_visible (true);
-       _tools_tearoff->set_visible (true);
-       if (Config->get_show_zoom_tools ()) {
+       if (!Config->get_keep_tearoffs()) {
+               _mouse_mode_tearoff->set_visible (true);
+               _tools_tearoff->set_visible (true);
                _zoom_tearoff->set_visible (true);
        }
-       post_maximal_editor_width = this->get_width();
-       post_maximal_editor_height = this->get_height();
 
-       edit_pane.set_position (pre_maximal_horizontal_pane_position + abs(this->get_width() - pre_maximal_editor_width));
-       editor_summary_pane.set_position (pre_maximal_vertical_pane_position + abs(this->get_height() - pre_maximal_editor_height));
+       _maximised = false;
 }
 
 /**
@@ -4093,19 +4147,27 @@ Editor::reposition_and_zoom (framepos_t frame, double fpu)
        }
 }
 
+Editor::VisualState::VisualState (bool with_tracks)
+       : gui_state (with_tracks ? new GUIObjectState : 0)
+{
+}
+
+Editor::VisualState::~VisualState ()
+{
+       delete gui_state;
+}
+
 Editor::VisualState*
 Editor::current_visual_state (bool with_tracks)
 {
-       VisualState* vs = new VisualState;
+       VisualState* vs = new VisualState (with_tracks);
        vs->y_position = vertical_adjustment.get_value();
        vs->frames_per_unit = frames_per_unit;
        vs->leftmost_frame = leftmost_frame;
        vs->zoom_focus = zoom_focus;
 
-       if (with_tracks) {
-               for (TrackViewList::iterator i = track_views.begin(); i != track_views.end(); ++i) {
-                       vs->track_states.push_back (TAVState ((*i), &(*i)->get_state()));
-               }
+       if (with_tracks) {      
+               *vs->gui_state = *ARDOUR_UI::instance()->gui_object_state;
        }
 
        return vs;
@@ -4118,10 +4180,12 @@ Editor::undo_visual_state ()
                return;
        }
 
-       redo_visual_stack.push_back (current_visual_state());
-
        VisualState* vs = undo_visual_stack.back();
        undo_visual_stack.pop_back();
+
+
+       redo_visual_stack.push_back (current_visual_state (vs ? vs->gui_state != 0 : false));
+
        use_visual_state (*vs);
 }
 
@@ -4132,10 +4196,11 @@ Editor::redo_visual_state ()
                return;
        }
 
-       undo_visual_stack.push_back (current_visual_state());
-
        VisualState* vs = redo_visual_stack.back();
        redo_visual_stack.pop_back();
+
+       undo_visual_stack.push_back (current_visual_state (vs ? vs->gui_state != 0 : false));
+
        use_visual_state (*vs);
 }
 
@@ -4152,7 +4217,7 @@ Editor::swap_visual_state ()
 void
 Editor::use_visual_state (VisualState& vs)
 {
-       no_save_visual = true;
+       PBD::Unwinder<bool> nsv (no_save_visual, true);
 
        _routes->suspend_redisplay ();
 
@@ -4160,25 +4225,17 @@ Editor::use_visual_state (VisualState& vs)
 
        set_zoom_focus (vs.zoom_focus);
        reposition_and_zoom (vs.leftmost_frame, vs.frames_per_unit);
-
-       for (list<TAVState>::iterator i = vs.track_states.begin(); i != vs.track_states.end(); ++i) {
-               TrackViewList::iterator t;
-
-               /* check if the track still exists - it could have been deleted */
-
-               if ((t = find (track_views.begin(), track_views.end(), i->first)) != track_views.end()) {
-                       (*t)->set_state (*(i->second), Stateful::loading_state_version);
+       
+       if (vs.gui_state) {
+               *ARDOUR_UI::instance()->gui_object_state = *vs.gui_state;
+               
+               for (TrackViewList::iterator i = track_views.begin(); i != track_views.end(); ++i) {    
+                       (*i)->reset_visual_state ();
                }
        }
 
-
-       if (!vs.track_states.empty()) {
-               _routes->update_visibility ();
-       }
-
+       _routes->update_visibility ();
        _routes->resume_redisplay ();
-
-       no_save_visual = false;
 }
 
 void
@@ -4303,6 +4360,7 @@ Editor::idle_visual_changer ()
                */
 
                leftmost_frame = pending_visual_change.time_origin;
+               assert (leftmost_frame >= 0);
        }
 
        if (p & VisualChange::ZoomLevel) {
@@ -4339,24 +4397,23 @@ struct EditorOrderTimeAxisSorter {
 };
 
 void
-Editor::sort_track_selection (TrackViewList* sel)
+Editor::sort_track_selection (TrackViewList& sel)
 {
        EditorOrderTimeAxisSorter cmp;
-
-       if (sel) {
-               sel->sort (cmp);
-       } else {
-               selection->tracks.sort (cmp);
-       }
+       sel.sort (cmp);
 }
 
 framepos_t
-Editor::get_preferred_edit_position (bool ignore_playhead)
+Editor::get_preferred_edit_position (bool ignore_playhead, bool from_context_menu)
 {
        bool ignored;
        framepos_t where = 0;
        EditPoint ep = _edit_point;
 
+       if (from_context_menu && (ep == EditAtMouse)) {
+               return  event_frame (&context_click_event, 0, 0);
+       }
+
        if (entered_marker) {
                 DEBUG_TRACE (DEBUG::CutNPaste, string_compose ("GPEP: use entered marker @ %1\n", entered_marker->position()));
                return entered_marker->position();
@@ -4483,17 +4540,15 @@ Editor::get_regions_at (RegionSelection& rs, framepos_t where, const TrackViewLi
 
                        if ((tr = rtv->track()) && ((pl = tr->playlist()))) {
 
-                               Playlist::RegionList* regions = pl->regions_at (
+                               boost::shared_ptr<RegionList> regions = pl->regions_at (
                                                (framepos_t) floor ( (double) where * tr->speed()));
 
-                               for (Playlist::RegionList::iterator i = regions->begin(); i != regions->end(); ++i) {
+                               for (RegionList::iterator i = regions->begin(); i != regions->end(); ++i) {
                                        RegionView* rv = rtv->view()->find_view (*i);
                                        if (rv) {
                                                rs.add (rv);
                                        }
                                }
-
-                               delete regions;
                        }
                }
        }
@@ -4518,10 +4573,10 @@ Editor::get_regions_after (RegionSelection& rs, framepos_t where, const TrackVie
 
                        if ((tr = rtv->track()) && ((pl = tr->playlist()))) {
 
-                               Playlist::RegionList* regions = pl->regions_touched (
+                               boost::shared_ptr<RegionList> regions = pl->regions_touched (
                                        (framepos_t) floor ( (double)where * tr->speed()), max_framepos);
 
-                               for (Playlist::RegionList::iterator i = regions->begin(); i != regions->end(); ++i) {
+                               for (RegionList::iterator i = regions->begin(); i != regions->end(); ++i) {
 
                                        RegionView* rv = rtv->view()->find_view (*i);
 
@@ -4529,8 +4584,6 @@ Editor::get_regions_after (RegionSelection& rs, framepos_t where, const TrackVie
                                                rs.push_back (rv);
                                        }
                                }
-
-                               delete regions;
                        }
                }
        }
@@ -4677,13 +4730,13 @@ void
 Editor::first_idle ()
 {
        MessageDialog* dialog = 0;
-
+       
        if (track_views.size() > 1) {
-               dialog = new MessageDialog (*this,
-                                           string_compose (_("Please wait while %1 loads visual data"), PROGRAM_NAME),
-                                           true,
-                                           Gtk::MESSAGE_INFO,
-                                           Gtk::BUTTONS_NONE);
+               dialog = new MessageDialog (
+                       *this,
+                       string_compose (_("Please wait while %1 loads visual data."), PROGRAM_NAME),
+                       true
+                       );
                dialog->present ();
                ARDOUR_UI::instance()->flush_pending ();
        }
@@ -4696,7 +4749,6 @@ Editor::first_idle ()
        _routes->redisplay ();
 
        delete dialog;
-
        _have_idled = true;
 }
 
@@ -4840,9 +4892,11 @@ Editor::handle_new_route (RouteList& routes)
                DataType dt = route->input()->default_type();
 
                if (dt == ARDOUR::DataType::AUDIO) {
-                       rtv = new AudioTimeAxisView (*this, _session, route, *track_canvas);
+                       rtv = new AudioTimeAxisView (*this, _session, *track_canvas);
+                       rtv->set_route (route);
                } else if (dt == ARDOUR::DataType::MIDI) {
-                       rtv = new MidiTimeAxisView (*this, _session, route, *track_canvas);
+                       rtv = new MidiTimeAxisView (*this, _session, *track_canvas);
+                       rtv->set_route (route);
                } else {
                        throw unknown_type();
                }
@@ -4984,7 +5038,7 @@ Editor::foreach_time_axis_view (sigc::slot<void,TimeAxisView&> theslot)
 
 /** Find a RouteTimeAxisView by the ID of its route */
 RouteTimeAxisView*
-Editor::get_route_view_by_route_id (PBD::ID& id) const
+Editor::get_route_view_by_route_id (const PBD::ID& id) const
 {
        RouteTimeAxisView* v;
 
@@ -5158,32 +5212,33 @@ Editor::reset_x_origin_to_follow_playhead ()
 
                } else {
 
+                       framepos_t l = 0;
+                       
                        if (frame < leftmost_frame) {
                                /* moving left */
-                               framepos_t l = 0;
                                if (_session->transport_rolling()) {
                                        /* rolling; end up with the playhead at the right of the page */
                                        l = frame - current_page_frames ();
                                } else {
-                                       /* not rolling: end up with the playhead 3/4 of the way along the page */
-                                       l = frame - (3 * current_page_frames() / 4);
-                               }
-
-                               if (l < 0) {
-                                       l = 0;
+                                       /* not rolling: end up with the playhead 1/4 of the way along the page */
+                                       l = frame - current_page_frames() / 4;
                                }
-
-                               center_screen_internal (l + (current_page_frames() / 2), current_page_frames ());
                        } else {
                                /* moving right */
                                if (_session->transport_rolling()) {
                                        /* rolling: end up with the playhead on the left of the page */
-                                       center_screen_internal (frame + (current_page_frames() / 2), current_page_frames ());
+                                       l = frame;
                                } else {
-                                       /* not rolling: end up with the playhead 1/4 of the way along the page */
-                                       center_screen_internal (frame + (current_page_frames() / 4), current_page_frames ());
+                                       /* not rolling: end up with the playhead 3/4 of the way along the page */
+                                       l = frame - 3 * current_page_frames() / 4;
                                }
                        }
+
+                       if (l < 0) {
+                               l = 0;
+                       }
+                       
+                       center_screen_internal (l + (current_page_frames() / 2), current_page_frames ());
                }
        }
 }
@@ -5325,8 +5380,7 @@ Editor::session_going_away ()
        hide_measures ();
        clear_marker_display ();
 
-       delete current_bbt_points;
-       current_bbt_points = 0;
+       current_bbt_points_begin = current_bbt_points_end;
 
        /* get rid of any existing editor mixer strip */
 
@@ -5350,9 +5404,9 @@ Editor::show_editor_list (bool yn)
 }
 
 void
-Editor::change_region_layering_order ()
+Editor::change_region_layering_order (bool from_context_menu)
 {
-       framepos_t const position = get_preferred_edit_position ();
+       const framepos_t position = get_preferred_edit_position (false, from_context_menu);
 
        if (!clicked_routeview) {
                if (layering_order_editor) {
@@ -5374,10 +5428,11 @@ Editor::change_region_layering_order ()
        }
 
        if (layering_order_editor == 0) {
-               layering_order_editor = new RegionLayeringOrderEditor(*this);
+               layering_order_editor = new RegionLayeringOrderEditor (*this);
+               layering_order_editor->set_position (WIN_POS_MOUSE);
        }
 
-       layering_order_editor->set_context (clicked_routeview->name(), _session, pl, position);
+       layering_order_editor->set_context (clicked_routeview->name(), _session, clicked_routeview, pl, position);
        layering_order_editor->maybe_present ();
 }
 
@@ -5385,7 +5440,7 @@ void
 Editor::update_region_layering_order_editor ()
 {
        if (layering_order_editor && layering_order_editor->is_visible ()) {
-               change_region_layering_order ();
+               change_region_layering_order (true);
        }
 }
 
@@ -5416,16 +5471,6 @@ Editor::action_menu_item (std::string const & name)
        return *manage (a->create_menu_item ());
 }
 
-void
-Editor::resize_text_widgets ()
-{
-        set_size_request_to_display_given_text (edit_mode_selector, edit_mode_strings, COMBO_FUDGE+10, 15);
-        set_size_request_to_display_given_text (zoom_focus_selector, zoom_focus_strings, COMBO_FUDGE+10, 15);
-        set_size_request_to_display_given_text (snap_type_selector, snap_type_strings, COMBO_FUDGE+10, 15);
-        set_size_request_to_display_given_text (snap_mode_selector, snap_mode_strings, COMBO_FUDGE+10, 15);
-        set_size_request_to_display_given_text (edit_point_selector, edit_point_strings, COMBO_FUDGE+10, 15);
-}
-
 void
 Editor::add_notebook_page (string const & name, Gtk::Widget& widget)
 {
@@ -5450,10 +5495,16 @@ Editor::notebook_tab_clicked (GdkEventButton* ev, Gtk::Widget* page)
                /* double-click on a notebook tab shrinks or expands the notebook */
 
                if (_notebook_shrunk) {
-                       edit_pane.set_position (pre_maximal_horizontal_pane_position);
+                       if (pre_notebook_shrink_pane_width) {
+                               edit_pane.set_position (*pre_notebook_shrink_pane_width);
+                       }
                        _notebook_shrunk = false;
                } else {
-                       pre_maximal_horizontal_pane_position = edit_pane.get_position ();
+                       pre_notebook_shrink_pane_width = edit_pane.get_position();
+
+                       /* this expands the LHS of the edit pane to cover the notebook
+                          PAGE but leaves the tabs visible.
+                        */
                        edit_pane.set_position (edit_pane.get_position() + page->get_width());
                        _notebook_shrunk = true;
                }
@@ -5462,3 +5513,20 @@ Editor::notebook_tab_clicked (GdkEventButton* ev, Gtk::Widget* page)
        return true;
 }
 
+void
+Editor::popup_control_point_context_menu (ArdourCanvas::Item* item, GdkEvent* event)
+{
+       using namespace Menu_Helpers;
+       
+       MenuList& items = _control_point_context_menu.items ();
+       items.clear ();
+       
+       items.push_back (MenuElem (_("Edit..."), sigc::bind (sigc::mem_fun (*this, &Editor::edit_control_point), item)));
+       items.push_back (MenuElem (_("Delete"), sigc::bind (sigc::mem_fun (*this, &Editor::remove_control_point), item)));
+       if (!can_remove_control_point (item)) {
+               items.back().set_sensitive (false);
+       }
+
+       _control_point_context_menu.popup (event->button.button, event->button.time);
+}
+