part two of allow markup to be used in BoolOption items in an option editor
[ardour.git] / gtk2_ardour / editor_mouse.cc
index 011374f9511ac0077652ed99f43a4041c9158c9e..ba0e75bb5ff7f5fbaffd8a548f9b204d9da7f1de 100644 (file)
@@ -199,6 +199,10 @@ Editor::which_grabber_cursor ()
                case MouseTimeFX:
                        c = _cursors->midi_resize;
                        break;
+                       
+               case MouseRange:
+                       c = _cursors->grabber_note;
+                       break;
 
                default:
                        break;
@@ -250,6 +254,9 @@ Editor::set_canvas_cursor ()
        switch (mouse_mode) {
        case MouseRange:
                current_canvas_cursor = _cursors->selector;
+               if (_internal_editing) {
+                       current_canvas_cursor = which_grabber_cursor();
+               }
                break;
 
        case MouseObject:
@@ -281,19 +288,21 @@ Editor::set_canvas_cursor ()
                break;
        }
 
-       switch (_join_object_range_state) {
-       case JOIN_OBJECT_RANGE_NONE:
-               break;
-       case JOIN_OBJECT_RANGE_OBJECT:
-               current_canvas_cursor = which_grabber_cursor ();
-               break;
-       case JOIN_OBJECT_RANGE_RANGE:
-               current_canvas_cursor = _cursors->selector;
-               break;
+       if (!_internal_editing) {
+               switch (_join_object_range_state) {
+               case JOIN_OBJECT_RANGE_NONE:
+                       break;
+               case JOIN_OBJECT_RANGE_OBJECT:
+                       current_canvas_cursor = which_grabber_cursor ();
+                       break;
+               case JOIN_OBJECT_RANGE_RANGE:
+                       current_canvas_cursor = _cursors->selector;
+                       break;
+               }
        }
 
        /* up-down cursor as a cue that automation can be dragged up and down when in join object/range mode */
-       if (smart_mode_action->get_active()) {
+       if (!_internal_editing && get_smart_mode() ) {
                double x, y;
                get_pointer_position (x, y);
                ArdourCanvas::Item* i = track_canvas->get_item_at (x, y);
@@ -308,6 +317,21 @@ Editor::set_canvas_cursor ()
        set_canvas_cursor (current_canvas_cursor, true);
 }
 
+void
+Editor::mouse_mode_object_range_toggled()
+{
+       MouseMode m = mouse_mode;
+       
+       Glib::RefPtr<Action> act = ActionManager::get_action (X_("MouseMode"), X_("set-mouse-mode-range"));
+       assert (act);
+       Glib::RefPtr<ToggleAction> tact = Glib::RefPtr<ToggleAction>::cast_dynamic (act);
+       assert (tact);
+       if (tact->get_active())
+               m = MouseObject;  //Smart mode turned to ON, force editing to Object mode
+       
+       set_mouse_mode(m, true);  //call this so the button styles can get updated
+}
+
 void
 Editor::set_mouse_mode (MouseMode m, bool force)
 {
@@ -360,7 +384,7 @@ Editor::set_mouse_mode (MouseMode m, bool force)
        tact->set_active (false);
        tact->set_active (true);
 
-       MouseModeChanged (); /* EMIT SIGNAL */
+       //NOTE:  this will result in a call to mouse_mode_toggled which does the heavy lifting
 }
 
 void
@@ -421,34 +445,36 @@ Editor::mouse_mode_toggled (MouseMode m)
        default:
                break;
        }
+       
+       if (_session && mouse_mode == MouseAudition) {
+               /* stop transport and reset default speed to avoid oddness with
+                  auditioning */
+               _session->request_transport_speed (0.0, true);
+       }
 
        mouse_mode = m;
 
        instant_save ();
 
-       if (!internal_editing()) {
-               if (mouse_mode != MouseRange && mouse_mode != MouseGain && _join_object_range_state == JOIN_OBJECT_RANGE_NONE) {
-
-                       /* in all modes except range, gain and joined object/range, hide the range selection,
-                          show the object (region) selection.
-                       */
-
-                       for (TrackViewList::iterator i = track_views.begin(); i != track_views.end(); ++i) {
-                               (*i)->hide_selection ();
-                       }
-
-               } else {
-
-                       /*
-                         in range or object/range mode, show the range selection.
-                       */
-
-                       for (TrackSelection::iterator i = selection->tracks.begin(); i != selection->tracks.end(); ++i) {
-                               (*i)->show_selection (selection->time);
-                       }
+       //TODO:  set button styles for smart buttons
+/*
+       if ( smart_mode_action->get_active() ) {
+               if( mouse_mode == MouseObject ) { //smart active and object active
+                       smart_mode_button.set_active(1);
+                       smart_mode_button.set_name("smart mode button");
+                       mouse_move_button.set_name("smart mode button");
+               } else {  //smart active but object inactive
+                       smart_mode_button.set_active(0);
+                       smart_mode_button.set_name("smart mode button");
+                       mouse_move_button.set_name("mouse mode button");
                }
+       } else {
+               smart_mode_button.set_active(0);
+               smart_mode_button.set_name("mouse mode button");
+               mouse_move_button.set_name("mouse mode button");
        }
-
+*/
+       
        set_canvas_cursor ();
        set_gain_envelope_visibility ();
 
@@ -554,11 +580,9 @@ Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemTyp
        */
 
        if (((mouse_mode != MouseObject) &&
-            (_join_object_range_state != JOIN_OBJECT_RANGE_OBJECT) &&
             (mouse_mode != MouseAudition || item_type != RegionItem) &&
             (mouse_mode != MouseTimeFX || item_type != RegionItem) &&
             (mouse_mode != MouseGain) &&
-            (mouse_mode != MouseRange) &&
             (mouse_mode != MouseDraw)) ||
            ((event->type != GDK_BUTTON_PRESS && event->type != GDK_BUTTON_RELEASE) || event->button.button > 3) ||
            (internal_editing() && mouse_mode != MouseTimeFX)) {
@@ -583,19 +607,23 @@ Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemTyp
 
        switch (item_type) {
        case RegionItem:
-               if (!doing_range_stuff()) {
-                       set_selected_regionview_from_click (press, op);
-               }
-               
-               if (press) {
-                       if (doing_range_stuff()) {
-                               /* don't change the selection unless the
-                                  clicked track is not currently selected. if
-                                  so, "collapse" the selection to just this
-                                  track
-                               */
-                               if (!selection->selected (clicked_axisview)) {
-                                       set_selected_track_as_side_effect (Selection::Set);
+               if (!get_smart_mode() || (_join_object_range_state == JOIN_OBJECT_RANGE_OBJECT)) {
+                       if (press) {
+                               if (mouse_mode != MouseRange) {
+                                       set_selected_regionview_from_click (press, op);
+                               } else {
+                                       /* don't change the selection unless the
+                                          clicked track is not currently selected. if
+                                          so, "collapse" the selection to just this
+                                          track
+                                       */
+                                       if (!selection->selected (clicked_axisview)) {
+                                               set_selected_track_as_side_effect (Selection::Set);
+                                       }
+                               }
+                       } else {
+                               if (mouse_mode != MouseRange) {
+                                       set_selected_regionview_from_click (press, op);
                                }
                        }
                }
@@ -605,7 +633,7 @@ Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemTyp
        case RegionViewName:
        case LeftFrameHandle:
        case RightFrameHandle:
-               if (doing_object_stuff() || (mouse_mode != MouseRange && mouse_mode != MouseObject)) {
+               if ( mouse_mode != MouseRange ) {
                        set_selected_regionview_from_click (press, op);
                } else if (event->type == GDK_BUTTON_PRESS) {
                        set_selected_track_as_side_effect (op);
@@ -618,7 +646,7 @@ Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemTyp
        case FadeOutItem:
        case StartCrossFadeItem:
        case EndCrossFadeItem:
-               if (doing_object_stuff() || (mouse_mode != MouseRange && mouse_mode != MouseObject)) {
+               if ( mouse_mode != MouseRange ) {
                        set_selected_regionview_from_click (press, op);
                } else if (event->type == GDK_BUTTON_PRESS) {
                        set_selected_track_as_side_effect (op);
@@ -627,7 +655,7 @@ Editor::button_selection (ArdourCanvas::Item* /*item*/, GdkEvent* event, ItemTyp
 
        case ControlPointItem:
                set_selected_track_as_side_effect (op);
-               if (doing_object_stuff() || (mouse_mode != MouseRange && mouse_mode != MouseObject)) {
+               if ( mouse_mode != MouseRange ) {
                        set_selected_control_point_from_click (press, op);
                }
                break;
@@ -783,9 +811,7 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                        break;
 
                case SelectionItem:
-                       if (Keyboard::modifier_state_contains
-                           (event->button.state, Keyboard::ModifierMask(Keyboard::PrimaryModifier))) {
-                               // contains and not equals because I can't use alt as a modifier alone.
+                       if (Keyboard::modifier_state_contains (event->button.state, Keyboard::ModifierMask(Keyboard::PrimaryModifier|Keyboard::SecondaryModifier))) {
                                start_selection_grab (item, event);
                        } else if (Keyboard::modifier_state_equals (event->button.state, Keyboard::SecondaryModifier)) {
                                /* grab selection for moving */
@@ -795,7 +821,7 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                pair<TimeAxisView*, int> tvp = trackview_by_y_position (y);
                                if (tvp.first) {
                                        AutomationTimeAxisView* atv = dynamic_cast<AutomationTimeAxisView*> (tvp.first);
-                                       if (smart_mode_action->get_active() && atv) {
+                                       if ( get_smart_mode() && atv) {
                                                /* smart "join" mode: drag automation */
                                                _drags->set (new AutomationRangeDrag (this, atv, selection->time), event, _cursors->up_down);
                                        } else {
@@ -814,23 +840,18 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                        return true;
                                } 
                        } else {
-                               _drags->set (new SelectionDrag (this, item, SelectionDrag::CreateSelection), event);
+                               if (Keyboard::modifier_state_equals (event->button.state, Keyboard::RangeSelectModifier)) {
+                                       _drags->set (new SelectionDrag (this, item, SelectionDrag::SelectionExtend), event);
+                               } else {
+                                       _drags->set (new SelectionDrag (this, item, SelectionDrag::CreateSelection), event);
+                               }
                                return true;
                        }
                        break;
 
                case RegionViewNameHighlight:
                        if (!clicked_regionview->region()->locked()) {
-                               RegionSelection s = get_equivalent_regions (selection->regions, Properties::edit.property_id);
-                               _drags->set (new TrimDrag (this, item, clicked_regionview, s.by_layer()), event);
-                               return true;
-                       }
-                       break;
-
-               case LeftFrameHandle:
-               case RightFrameHandle:
-                       if (!internal_editing() && doing_object_stuff() && !clicked_regionview->region()->locked()) {
-                               RegionSelection s = get_equivalent_regions (selection->regions, Properties::edit.property_id);
+                               RegionSelection s = get_equivalent_regions (selection->regions, Properties::select.property_id);
                                _drags->set (new TrimDrag (this, item, clicked_regionview, s.by_layer()), event);
                                return true;
                        }
@@ -838,7 +859,11 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
                default:
                        if (!internal_editing()) {
-                               _drags->set (new SelectionDrag (this, item, SelectionDrag::CreateSelection), event);
+                               if (Keyboard::modifier_state_equals (event->button.state, Keyboard::RangeSelectModifier)) {
+                                       _drags->set (new SelectionDrag (this, item, SelectionDrag::SelectionExtend), event);
+                               } else {
+                                       _drags->set (new SelectionDrag (this, item, SelectionDrag::CreateSelection), event);
+                               }
                        }
                }
                return true;
@@ -858,6 +883,14 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                return true;
                        }
                        break;
+               case StreamItem:
+                       if (internal_editing()) {
+                               if (dynamic_cast<MidiTimeAxisView*> (clicked_axisview)) {
+                                       _drags->set (new RegionCreateDrag (this, item, clicked_axisview), event);
+                               }
+                               return true;
+                       }
+                       break;
 
                default:
                        break;
@@ -892,24 +925,26 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                        switch (item_type) {
                        case FadeInHandleItem:
                        {
-                               RegionSelection s = get_equivalent_regions (selection->regions, Properties::edit.property_id);
+                               RegionSelection s = get_equivalent_regions (selection->regions, Properties::select.property_id);
                                _drags->set (new FadeInDrag (this, item, reinterpret_cast<RegionView*> (item->get_data("regionview")), s), event, _cursors->fade_in);
                                return true;
                        }
 
                        case FadeOutHandleItem:
                        {
-                               RegionSelection s = get_equivalent_regions (selection->regions, Properties::edit.property_id);
+                               RegionSelection s = get_equivalent_regions (selection->regions, Properties::select.property_id);
                                _drags->set (new FadeOutDrag (this, item, reinterpret_cast<RegionView*> (item->get_data("regionview")), s), event, _cursors->fade_out);
                                return true;
                        }
 
                        case StartCrossFadeItem:
-                               _drags->set (new CrossfadeEdgeDrag (this, reinterpret_cast<AudioRegionView*>(item->get_data("regionview")), item, true), event, 0);
-                               break;
-
                        case EndCrossFadeItem:
-                               _drags->set (new CrossfadeEdgeDrag (this, reinterpret_cast<AudioRegionView*>(item->get_data("regionview")), item, false), event, 0);
+                               /* we might allow user to grab inside the fade to trim a region with preserve_fade_anchor.  for not this is not fully implemented */ 
+//                             if (!clicked_regionview->region()->locked()) {
+//                                     RegionSelection s = get_equivalent_regions (selection->regions, Properties::edit.property_id);
+//                                     _drags->set (new TrimDrag (this, item, clicked_regionview, s.by_layer(), true), event);
+//                                     return true;
+//                             }
                                break;
 
                        case FeatureLineItem:
@@ -950,9 +985,9 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                }
 
 
-                               if (!internal_editing() && (_join_object_range_state == JOIN_OBJECT_RANGE_RANGE && !selection->regions.empty())) {
-                                       _drags->add (new SelectionDrag (this, clicked_axisview->get_selection_rect (clicked_selection)->rect, SelectionDrag::SelectionMove));
-                               }
+//                             if (!internal_editing() && (_join_object_range_state == JOIN_OBJECT_RANGE_RANGE && !selection->regions.empty())) {
+//                                     _drags->add (new SelectionDrag (this, clicked_axisview->get_selection_rect (clicked_selection)->rect, SelectionDrag::SelectionMove));
+//                             }
 
                                _drags->start_grab (event);
                                break;
@@ -961,7 +996,7 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                        case LeftFrameHandle:
                         case RightFrameHandle:
                                if (!clicked_regionview->region()->locked()) {
-                                       RegionSelection s = get_equivalent_regions (selection->regions, Properties::edit.property_id);
+                                       RegionSelection s = get_equivalent_regions (selection->regions, Properties::select.property_id);
                                        _drags->set (new TrimDrag (this, item, clicked_regionview, s.by_layer()), event);
                                        return true;
                                }
@@ -970,7 +1005,7 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                        case RegionViewName:
                        {
                                /* rename happens on edit clicks */
-                               RegionSelection s = get_equivalent_regions (selection->regions, Properties::edit.property_id);
+                               RegionSelection s = get_equivalent_regions (selection->regions, Properties::select.property_id);
                                _drags->set (new TrimDrag (this, clicked_regionview->get_name_highlight(), clicked_regionview, s.by_layer()), event);
                                return true;
                                break;
@@ -1029,7 +1064,7 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
 
                        case SelectionItem:
                        {
-                               if (smart_mode_action->get_active()) {
+                               if ( get_smart_mode() ) {
                                        /* we're in "smart" joined mode, and we've clicked on a Selection */
                                        double const y = event->button.y + vertical_adjustment.get_value() - canvas_timebars_vsize;
                                        pair<TimeAxisView*, int> tvp = trackview_by_y_position (y);
@@ -1043,7 +1078,7 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                                /* if we're over a track and a region, and in the `object' part of a region,
                                                   put a selection around the region and drag both
                                                */
-                                               RouteTimeAxisView* rtv = dynamic_cast<RouteTimeAxisView*> (tvp.first);
+/*                                             RouteTimeAxisView* rtv = dynamic_cast<RouteTimeAxisView*> (tvp.first);
                                                if (rtv && _join_object_range_state == JOIN_OBJECT_RANGE_OBJECT) {
                                                        boost::shared_ptr<Track> t = boost::dynamic_pointer_cast<Track> (rtv->route ());
                                                        if (t) {
@@ -1064,6 +1099,7 @@ Editor::button_press_handler_1 (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                                                                }
                                                        }
                                                }
+*/
                                        }
                                }
                                break;
@@ -1284,8 +1320,6 @@ Editor::button_press_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemTyp
                return true;
        }
 
-
-
        if (internal_editing()) {
                bool leave_internal_edit_mode = false;
 
@@ -1309,14 +1343,11 @@ Editor::button_press_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemTyp
                case RangeMarkerBarItem:
                case CdMarkerBarItem:
                case TransportMarkerBarItem:
+               case StreamItem:
                        /* button press on these events never does anything to
                           change the editing mode.
                        */
                        break;
-                       
-               case StreamItem:
-                       leave_internal_edit_mode = true;
-                       break;
 
                default:
                        break;
@@ -1338,6 +1369,13 @@ Editor::button_press_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemTyp
                return true;
        }
 
+       //not rolling, range mode click + join_play_range :  locate the PH here
+       if ( !_drags->active () && !_session->transport_rolling() && ( effective_mouse_mode() == MouseRange ) && Config->get_always_play_range() ) {
+               framepos_t where = event_frame (event, 0, 0);
+               snap_to(where);
+               _session->request_locate (where, false);
+       }
+
        switch (event->button.button) {
        case 1:
                return button_press_handler_1 (item, event, item_type);
@@ -1409,7 +1447,7 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                were_dragging = true;
        }
 
-        update_region_layering_order_editor ();
+    update_region_layering_order_editor ();
 
        /* edit events get handled here */
 
@@ -1438,8 +1476,12 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
                        break;
 
                case NoteItem:
-                       edit_note (item);
+               {
+                       ArdourCanvas::CanvasNoteEvent* e = dynamic_cast<ArdourCanvas::CanvasNoteEvent*> (item);
+                       assert (e);
+                       edit_notes (e->region_view().selection ());
                        break;
+               }
 
                default:
                        break;
@@ -1448,7 +1490,6 @@ Editor::button_release_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemT
        }
 
        /* context menu events get handled here */
-
        if (Keyboard::is_context_menu_event (&event->button)) {
 
                context_click_event = *event;
@@ -1803,7 +1844,7 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
                break;
 
        case RegionViewNameHighlight:
-               if (is_drawable() && doing_object_stuff() && entered_regionview) {
+               if (is_drawable() && effective_mouse_mode() == MouseObject && entered_regionview) {
                        set_canvas_cursor_for_region_view (event->crossing.x, entered_regionview);
                        _over_region_trim_target = true;
                }
@@ -1811,7 +1852,7 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
 
        case LeftFrameHandle:
        case RightFrameHandle:
-               if (is_drawable() && doing_object_stuff() && !internal_editing() && entered_regionview) {
+               if (is_drawable() && effective_mouse_mode() == MouseObject && !internal_editing() && entered_regionview) {
                        set_canvas_cursor_for_region_view (event->crossing.x, entered_regionview);
                }
                 break;
@@ -1937,7 +1978,7 @@ Editor::enter_handler (ArdourCanvas::Item* item, GdkEvent* event, ItemType item_
                }
                break;
        case SelectionItem:
-               if (smart_mode_action->get_active()) {
+               if ( get_smart_mode() ) {
                        set_canvas_cursor ();
                }
                break;
@@ -2077,7 +2118,6 @@ Editor::leave_handler (ArdourCanvas::Item* item, GdkEvent*, ItemType item_type)
                        ArdourCanvas::SimpleRect *rect = dynamic_cast<ArdourCanvas::SimpleRect *> (item);
                        if (rect) {
                                rect->property_fill_color_rgba() = rv->get_fill_color();
-                               rect->property_outline_pixels() = 0;
                        }
                }
                set_canvas_cursor (current_canvas_cursor);
@@ -2226,11 +2266,12 @@ Editor::motion_handler (ArdourCanvas::Item* /*item*/, GdkEvent* event, bool from
 
        JoinObjectRangeState const old = _join_object_range_state;
        update_join_object_range_location (event->motion.x, event->motion.y);
-       if (_join_object_range_state != old) {
+
+       if (!_internal_editing && _join_object_range_state != old) {
                set_canvas_cursor ();
        }
 
-       if (_over_region_trim_target) {
+       if (!_internal_editing && _over_region_trim_target) {
                set_canvas_cursor_for_region_view (event->motion.x, entered_regionview);
        }
 
@@ -2307,12 +2348,13 @@ Editor::edit_control_point (ArdourCanvas::Item* item)
 }
 
 void
-Editor::edit_note (ArdourCanvas::Item* item)
+Editor::edit_notes (MidiRegionView::Selection const & s)
 {
-       ArdourCanvas::CanvasNoteEvent* e = dynamic_cast<ArdourCanvas::CanvasNoteEvent*> (item);
-       assert (e);
-
-       EditNoteDialog d (&e->region_view(), e);
+       if (s.empty ()) {
+               return;
+       }
+       
+       EditNoteDialog d (&(*s.begin())->region_view(), s);
        d.set_position (Gtk::WIN_POS_MOUSE);
        ensure_float (d);
 
@@ -2402,6 +2444,15 @@ Editor::cancel_selection ()
        clicked_selection = 0;
 }
 
+void
+Editor::cancel_time_selection ()
+{
+    for (TrackViewList::iterator i = track_views.begin(); i != track_views.end(); ++i) {
+               (*i)->hide_selection ();
+       }
+       selection->time.clear ();
+       clicked_selection = 0;
+}      
 
 void
 Editor::point_trim (GdkEvent* event, framepos_t new_bound)
@@ -2590,7 +2641,7 @@ Editor::add_region_drag (ArdourCanvas::Item* item, GdkEvent*, RegionView* region
        if (Config->get_edit_mode() == Splice) {
                _drags->add (new RegionSpliceDrag (this, item, region_view, selection->regions.by_layer()));
        } else {
-               RegionSelection s = get_equivalent_regions (selection->regions, ARDOUR::Properties::edit.property_id);
+               RegionSelection s = get_equivalent_regions (selection->regions, ARDOUR::Properties::select.property_id);
                _drags->add (new RegionMoveDrag (this, item, region_view, s.by_layer(), false, false));
        }
 
@@ -2609,7 +2660,7 @@ Editor::add_region_copy_drag (ArdourCanvas::Item* item, GdkEvent*, RegionView* r
 
        _region_motion_group->raise_to_top ();
 
-       RegionSelection s = get_equivalent_regions (selection->regions, ARDOUR::Properties::edit.property_id);
+       RegionSelection s = get_equivalent_regions (selection->regions, ARDOUR::Properties::select.property_id);
        _drags->add (new RegionMoveDrag (this, item, region_view, s.by_layer(), false, true));
 }
 
@@ -2626,7 +2677,7 @@ Editor::add_region_brush_drag (ArdourCanvas::Item* item, GdkEvent*, RegionView*
                return;
        }
 
-       RegionSelection s = get_equivalent_regions (selection->regions, ARDOUR::Properties::edit.property_id);
+       RegionSelection s = get_equivalent_regions (selection->regions, ARDOUR::Properties::select.property_id);
        _drags->add (new RegionMoveDrag (this, item, region_view, s.by_layer(), true, false));
 
        begin_reversible_command (Operations::drag_region_brush);
@@ -2761,7 +2812,7 @@ Editor::update_join_object_range_location (double /*x*/, double y)
           that we're over requires searching the playlist.
        */
 
-       if (!smart_mode_action->get_active() || (mouse_mode != MouseRange && mouse_mode != MouseObject)) {
+       if ( !get_smart_mode() ) {
                _join_object_range_state = JOIN_OBJECT_RANGE_NONE;
                return;
        }
@@ -2785,10 +2836,8 @@ Editor::update_join_object_range_location (double /*x*/, double y)
                        rtv->canvas_display()->w2i (cx, cy);
 
                        double const c = cy / (rtv->view()->child_height() - TimeAxisViewItem::NAME_HIGHLIGHT_SIZE);
-                       double d;
-                       double const f = modf (c, &d);
 
-                       _join_object_range_state = f < 0.5 ? JOIN_OBJECT_RANGE_RANGE : JOIN_OBJECT_RANGE_OBJECT;
+                       _join_object_range_state = c <= 0.5 ? JOIN_OBJECT_RANGE_RANGE : JOIN_OBJECT_RANGE_OBJECT;
                }
        }
 }