Remove double-nested reversible command when note editing
[ardour.git] / gtk2_ardour / editor_ops.cc
index 376dd3f08684a5d7349521faa7b4d1b7af5144f9..512648993c462e7ce869bf4a99936e01b92610b9 100644 (file)
@@ -28,6 +28,8 @@
 #include <map>
 #include <set>
 
+#include <gtkmm/messagedialog.h>
+
 #include "pbd/error.h"
 #include "pbd/basename.h"
 #include "pbd/pthread_utils.h"
 #include "pbd/whitespace.h"
 #include "pbd/stateful_diff_command.h"
 
-#include <gtkmm2ext/utils.h>
-#include <gtkmm2ext/choice.h>
-#include <gtkmm2ext/popup.h>
+#include "gtkmm2ext/utils.h"
+
+#include "widgets/choice.h"
+#include "widgets/popup.h"
+#include "widgets/prompter.h"
 
 #include "ardour/audio_track.h"
 #include "ardour/audioregion.h"
@@ -110,6 +114,7 @@ using namespace ARDOUR;
 using namespace PBD;
 using namespace Gtk;
 using namespace Gtkmm2ext;
+using namespace ArdourWidgets;
 using namespace Editing;
 using Gtkmm2ext::Keyboard;
 
@@ -625,9 +630,9 @@ Editor::nudge_backward_capture_offset ()
 }
 
 struct RegionSelectionPositionSorter {
-        bool operator() (RegionView* a, RegionView* b) {
-                return a->region()->position() < b->region()->position();
-        }
+       bool operator() (RegionView* a, RegionView* b) {
+               return a->region()->position() < b->region()->position();
+       }
 };
 
 void
@@ -1451,6 +1456,22 @@ Editor::scroll_tracks_up_line ()
        reset_y_origin (vertical_adjustment.get_value() - 60);
 }
 
+void
+Editor::select_topmost_track ()
+{
+       const double top_of_trackviews = vertical_adjustment.get_value();
+       for (TrackViewList::iterator t = track_views.begin(); t != track_views.end(); ++t) {
+               if ((*t)->hidden()) {
+                       continue;
+               }
+               std::pair<TimeAxisView*,double> res = (*t)->covers_y_position (top_of_trackviews);
+               if (res.first) {
+                       selection->set (*t);
+                       break;
+               }
+       }
+}
+
 bool
 Editor::scroll_down_one_track (bool skip_child_views)
 {
@@ -1750,7 +1771,51 @@ Editor::temporal_zoom_step_scale (bool zoom_out, double scale)
                        nspp /= 2.0;
                }
        }
-
+       
+       // ToDo:   encapsulate all of this into something like editor::get_session_extents() or editor::leftmost(), rightmost()
+       {
+               //ToDo: also incorporate automation regions (in case the session has no audio/midi but is just used for automating plugins or the like)
+               
+               //calculate the extents of all regions in every playlist
+               framecnt_t session_extent_start = 0;
+               framecnt_t session_extent_end = 0;
+               {
+                       boost::shared_ptr<RouteList> rl = _session->get_routes();
+                       for (RouteList::iterator r = rl->begin(); r != rl->end(); ++r) {
+                               boost::shared_ptr<Track> tr = boost::dynamic_pointer_cast<Track> (*r);
+                               if (tr) {
+                                       boost::shared_ptr<Playlist> pl = tr->playlist();
+                                       if (pl) {
+                                               pair<framepos_t, framepos_t> e;
+                                               e = pl->get_extent();
+                                               if (e.first < session_extent_start) {
+                                                       session_extent_start = e.first;
+                                               }
+                                               if (e.second > session_extent_end) {
+                                                       session_extent_end = e.second;
+                                               }
+                                       }
+                               }
+                       }
+               }
+               framecnt_t session_extents = session_extent_end - session_extent_start;
+               
+               //in a session with no regions, use the start/end markers to set max zoom
+               framecnt_t const session_length = _session->current_end_frame() - _session->current_start_frame ();
+               if ( session_length > session_extents )
+                       session_extents = session_length;
+                       
+               //in a session with no regions or start/end markers, use 2 minutes to set max zoom
+               framecnt_t const min_length = _session->nominal_frame_rate()*60*2;
+               if ( min_length > session_extents )
+                       session_extents = min_length;
+                       
+               //convert to samples-per-pixel and limit our zoom to this value
+               framecnt_t session_extents_pp = session_extents / _visible_canvas_width;
+               if (nspp > session_extents_pp)
+                       nspp = session_extents_pp;
+       }
+       
        temporal_zoom (nspp);
 }
 
@@ -2101,7 +2166,7 @@ Editor::choose_new_marker_name(string &name) {
                return true;
        }
 
-       ArdourPrompter dialog (true);
+       Prompter dialog (true);
 
        dialog.set_prompt (_("New Name:"));
 
@@ -2635,7 +2700,7 @@ Editor::play_with_preroll ()
                const framepos_t preroll = _session->preroll_samples (start);
 
                framepos_t ret = start;
-               
+
                if (start > preroll) {
                        start = start - preroll;
                }
@@ -2653,7 +2718,7 @@ Editor::play_with_preroll ()
                const framepos_t preroll = _session->preroll_samples (ph);
                framepos_t start;
                if (ph > preroll) {
-                       start = ph - preroll; 
+                       start = ph - preroll;
                } else {
                        start = 0;
                }
@@ -2670,6 +2735,11 @@ Editor::rec_with_preroll ()
        _session->request_preroll_record_trim (ph, preroll);
 }
 
+void
+Editor::rec_with_count_in ()
+{
+       _session->request_count_in_record ();
+}
 
 void
 Editor::play_location (Location& location)
@@ -3118,8 +3188,8 @@ Editor::separate_regions_between (const TimeSelection& ts)
                                if (!latest_regionviews.empty()) {
 
                                        rtv->view()->foreach_regionview (sigc::bind (
-                                                                                sigc::ptr_fun (add_if_covered),
-                                                                                &(*t), &new_selection));
+                                                                                    sigc::ptr_fun (add_if_covered),
+                                                                                    &(*t), &new_selection));
 
                                        if (!in_command) {
                                                begin_reversible_command (_("separate"));
@@ -3149,8 +3219,8 @@ Editor::separate_regions_between (const TimeSelection& ts)
 }
 
 struct PlaylistState {
-    boost::shared_ptr<Playlist> playlist;
-    XMLNode*  before;
+       boost::shared_ptr<Playlist> playlist;
+       XMLNode*  before;
 };
 
 /** Take tracks from get_tracks_for_range_action and cut any regions
@@ -3253,10 +3323,10 @@ Editor::separate_under_selected_regions ()
 
                boost::shared_ptr<Playlist> playlist = (*rl)->playlist();
 
-               if (!playlist) {
+               if (!playlist) {
                        // is this check necessary?
                        continue;
-               }
+               }
 
                vector<PlaylistState>::iterator i;
 
@@ -3548,9 +3618,9 @@ Editor::align_regions (RegionPoint what)
 }
 
 struct RegionSortByTime {
-    bool operator() (const RegionView* a, const RegionView* b) {
-           return a->region()->position() < b->region()->position();
-    }
+       bool operator() (const RegionView* a, const RegionView* b) {
+               return a->region()->position() < b->region()->position();
+       }
 };
 
 void
@@ -3832,26 +3902,26 @@ Editor::trim_to_region(bool forward)
 
                if (forward) {
 
-                   next_region = playlist->find_next_region (region->first_frame(), Start, 1);
+                       next_region = playlist->find_next_region (region->first_frame(), Start, 1);
 
-                   if (!next_region) {
-                       continue;
-                   }
+                       if (!next_region) {
+                               continue;
+                       }
 
-                   region->trim_end((framepos_t) ( (next_region->first_frame() - 1) * speed));
-                   arv->region_changed (PropertyChange (ARDOUR::Properties::length));
+                       region->trim_end((framepos_t) ( (next_region->first_frame() - 1) * speed));
+                       arv->region_changed (PropertyChange (ARDOUR::Properties::length));
                }
                else {
 
-                   next_region = playlist->find_next_region (region->first_frame(), Start, 0);
+                       next_region = playlist->find_next_region (region->first_frame(), Start, 0);
 
-                   if(!next_region){
-                       continue;
-                   }
+                       if(!next_region){
+                               continue;
+                       }
 
-                   region->trim_front((framepos_t) ((next_region->last_frame() + 1) * speed));
+                       region->trim_front((framepos_t) ((next_region->last_frame() + 1) * speed));
 
-                   arv->region_changed (ARDOUR::bounds_change);
+                       arv->region_changed (ARDOUR::bounds_change);
                }
 
                if (!in_command) {
@@ -3924,8 +3994,8 @@ Editor::freeze_route ()
 
        if (clicked_routeview->track()->has_external_redirects()) {
                MessageDialog d (string_compose (_("<b>%1</b>\n\nThis track has at least one send/insert/return as part of its signal flow.\n\n"
-                                                  "Freezing will only process the signal as far as the first send/insert/return."),
-                                                clicked_routeview->track()->name()), true, MESSAGE_INFO, BUTTONS_NONE, true);
+                                                  "Freezing will only process the signal as far as the first send/insert/return."),
+                                                clicked_routeview->track()->name()), true, MESSAGE_INFO, BUTTONS_NONE, true);
 
                d.add_button (_("Freeze anyway"), Gtk::RESPONSE_OK);
                d.add_button (_("Don't freeze"), Gtk::RESPONSE_CANCEL);
@@ -4122,8 +4192,9 @@ Editor::cut_copy (CutCopyOp op)
                }
        }
 
-       if ( op != Delete )  //"Delete" doesn't change copy/paste buf
+       if ( op != Delete ) { //"Delete" doesn't change copy/paste buf
                cut_buffer->clear ();
+       }
 
        if (entered_marker) {
 
@@ -4213,11 +4284,13 @@ struct AutomationRecord {
        const AutomationLine* line; ///< line this came from
        boost::shared_ptr<Evoral::ControlList> copy; ///< copied events for the cut buffer
 };
+
 struct PointsSelectionPositionSorter {
        bool operator() (ControlPoint* a, ControlPoint* b) {
                return (*(a->model()))->when < (*(b->model()))->when;
        }
 };
+
 /** Cut, copy or clear selected automation points.
  *  @param op Operation (Cut, Copy or Clear)
  */
@@ -4237,7 +4310,7 @@ Editor::cut_copy_points (Editing::CutCopyOp op, Evoral::Beats earliest, bool mid
 
        /* user could select points in any order */
        selection->points.sort(PointsSelectionPositionSorter ());
-       
+
        /* Go through all selected points, making an AutomationRecord for each distinct AutomationList */
        for (PointSelection::iterator sel_point = selection->points.begin(); sel_point != selection->points.end(); ++sel_point) {
                const AutomationLine&                   line = (*sel_point)->line();
@@ -4316,7 +4389,7 @@ Editor::cut_copy_points (Editing::CutCopyOp op, Evoral::Beats earliest, bool mid
                        boost::shared_ptr<AutomationList> al = line.the_list();
 
                        bool erase = true;
-                       
+
                        if (dynamic_cast<AudioRegionGainLine*> (&line)) {
                                /* removing of first and last gain point in region gain lines is prohibited*/
                                if (line.is_last_point (*(*sel_point)) || line.is_first_point (*(*sel_point))) {
@@ -4367,16 +4440,16 @@ Editor::cut_copy_midi (CutCopyOp op)
 }
 
 struct lt_playlist {
-    bool operator () (const PlaylistState& a, const PlaylistState& b) {
-           return a.playlist < b.playlist;
-    }
+       bool operator () (const PlaylistState& a, const PlaylistState& b) {
+               return a.playlist < b.playlist;
+       }
 };
 
 struct PlaylistMapping {
-    TimeAxisView* tv;
-    boost::shared_ptr<Playlist> pl;
+       TimeAxisView* tv;
+       boost::shared_ptr<Playlist> pl;
 
-    PlaylistMapping (TimeAxisView* tvp) : tv (tvp) {}
+       PlaylistMapping (TimeAxisView* tvp) : tv (tvp) {}
 };
 
 /** Remove `clicked_regionview' */
@@ -4440,10 +4513,10 @@ Editor::remove_selected_regions ()
 
                boost::shared_ptr<Playlist> playlist = (*rl)->playlist();
 
-               if (!playlist) {
+               if (!playlist) {
                        // is this check necessary?
                        continue;
-               }
+               }
 
                /* get_regions_from_selection_and_entered() guarantees that
                   the playlists involved are unique, so there is no need
@@ -4689,7 +4762,7 @@ Editor::cut_copy_ranges (CutCopyOp op)
 void
 Editor::paste (float times, bool from_context)
 {
-        DEBUG_TRACE (DEBUG::CutNPaste, "paste to preferred edit pos\n");
+       DEBUG_TRACE (DEBUG::CutNPaste, "paste to preferred edit pos\n");
        MusicFrame where (get_preferred_edit_position (EDIT_IGNORE_NONE, from_context), 0);
        paste_internal (where.frame, times, 0);
 }
@@ -4710,7 +4783,7 @@ Editor::mouse_paste ()
 void
 Editor::paste_internal (framepos_t position, float times, const int32_t sub_num)
 {
-        DEBUG_TRACE (DEBUG::CutNPaste, string_compose ("apparent paste position is %1\n", position));
+       DEBUG_TRACE (DEBUG::CutNPaste, string_compose ("apparent paste position is %1\n", position));
 
        if (cut_buffer->empty(internal_editing())) {
                return;
@@ -4718,7 +4791,7 @@ Editor::paste_internal (framepos_t position, float times, const int32_t sub_num)
 
        if (position == max_framepos) {
                position = get_preferred_edit_position();
-                DEBUG_TRACE (DEBUG::CutNPaste, string_compose ("preferred edit position is %1\n", position));
+               DEBUG_TRACE (DEBUG::CutNPaste, string_compose ("preferred edit position is %1\n", position));
        }
 
        if (position == last_paste_pos) {
@@ -4735,8 +4808,8 @@ Editor::paste_internal (framepos_t position, float times, const int32_t sub_num)
        TrackViewList ts;
        if (!selection->tracks.empty()) {
                /* If there is a track selection, paste into exactly those tracks and
-                  only those tracks.  This allows the user to be explicit and override
-                  the below "do the reasonable thing" logic. */
+                * only those tracks.  This allows the user to be explicit and override
+                * the below "do the reasonable thing" logic. */
                ts = selection->tracks.filter_to_unique_playlists ();
                sort_track_selection (ts);
        } else {
@@ -4800,8 +4873,8 @@ Editor::paste_internal (framepos_t position, float times, const int32_t sub_num)
            /* Only one line copied, and one automation track selected.  Do a
               "greedy" paste from one automation type to another. */
 
-           PasteContext ctx(paste_count, times, ItemCounts(), true);
-           ts.front()->paste (position, *cut_buffer, ctx, sub_num);
+               PasteContext ctx(paste_count, times, ItemCounts(), true);
+               ts.front()->paste (position, *cut_buffer, ctx, sub_num);
 
        } else {
 
@@ -4926,7 +4999,7 @@ Editor::reset_point_selection ()
 {
        for (PointSelection::iterator i = selection->points.begin(); i != selection->points.end(); ++i) {
                ARDOUR::AutomationList::iterator j = (*i)->model ();
-               (*j)->value = (*i)->line().the_list()->default_value ();
+               (*j)->value = (*i)->line().the_list()->descriptor ().normal;
        }
 }
 
@@ -5018,12 +5091,12 @@ Editor::remove_last_capture ()
 
        if (Config->get_verify_remove_last_capture()) {
                prompt  = _("Do you really want to destroy the last capture?"
-                           "\n(This is destructive and cannot be undone)");
+                           "\n(This is destructive and cannot be undone)");
 
                choices.push_back (_("No, do nothing."));
                choices.push_back (_("Yes, destroy it."));
 
-               Gtkmm2ext::Choice prompter (_("Destroy last capture"), prompt, choices);
+               Choice prompter (_("Destroy last capture"), prompt, choices);
 
                if (prompter.run () == 1) {
                        _session->remove_last_capture ();
@@ -5212,6 +5285,38 @@ Editor::adjust_region_gain (bool up)
        }
 }
 
+void
+Editor::reset_region_gain ()
+{
+       RegionSelection rs = get_regions_from_selection_and_entered ();
+
+       if (!_session || rs.empty()) {
+               return;
+       }
+
+       bool in_command = false;
+
+       for (RegionSelection::iterator r = rs.begin(); r != rs.end(); ++r) {
+               AudioRegionView* const arv = dynamic_cast<AudioRegionView*>(*r);
+               if (!arv) {
+                       continue;
+               }
+
+               arv->region()->clear_changes ();
+
+               arv->audio_region()->set_scale_amplitude (1.0f);
+
+               if (!in_command) {
+                               begin_reversible_command ("reset region gain");
+                               in_command = true;
+               }
+               _session->add_command (new StatefulDiffCommand (arv->region()));
+       }
+
+       if (in_command) {
+               commit_reversible_command ();
+       }
+}
 
 void
 Editor::reverse_region ()
@@ -5241,7 +5346,7 @@ Editor::strip_region_silence ()
 
        for (RegionSelection::iterator i = rs.begin(); i != rs.end(); ++i) {
                AudioRegionView* const arv = dynamic_cast<AudioRegionView*> (*i);
-               if (arv) {
+               if (arv) {
                        audio_only.push_back (arv);
                }
        }
@@ -5486,7 +5591,7 @@ Editor::insert_patch_change (bool from_context)
        MidiRegionView* first = dynamic_cast<MidiRegionView*> (rs.front ());
 
        Evoral::PatchChange<Evoral::Beats> empty (Evoral::Beats(), 0, 0, 0);
-        PatchChangeDialog d (0, _session, empty, first->instrument_info(), Gtk::Stock::ADD);
+       PatchChangeDialog d (0, _session, empty, first->instrument_info(), Gtk::Stock::ADD);
 
        if (d.run() == RESPONSE_CANCEL) {
                return;
@@ -5743,19 +5848,17 @@ Editor::toggle_region_lock_style ()
                return;
        }
 
-       bool inconsistent = false;
-       CheckMenuItem* cm = dynamic_cast<CheckMenuItem*> (
-               ActionManager::get_widget (X_("/Main/RegionMenu/RegionMenuPosition/toggle-region-lock-style")));
+       Glib::RefPtr<ToggleAction> a = Glib::RefPtr<ToggleAction>::cast_dynamic (_region_actions->get_action("toggle-region-lock-style"));
+       vector<Widget*> proxies = a->get_proxies();
+       Gtk::CheckMenuItem* cmi = dynamic_cast<Gtk::CheckMenuItem*> (proxies.front());
 
-       if (cm && cm->get_inconsistent()) {
-               inconsistent = true;
-       }
+       assert (cmi);
 
-       begin_reversible_command (_("region lock style"));
+       begin_reversible_command (_("toggle region lock style"));
 
        for (RegionSelection::iterator i = rs.begin(); i != rs.end(); ++i) {
                (*i)->region()->clear_changes ();
-               PositionLockStyle const ns = ((*i)->region()->position_lock_style() == AudioTime && !inconsistent) ? MusicTime : AudioTime;
+               PositionLockStyle const ns = ((*i)->region()->position_lock_style() == AudioTime && !cmi->get_inconsistent()) ? MusicTime : AudioTime;
                (*i)->region()->set_position_lock_style (ns);
                _session->add_command (new StatefulDiffCommand ((*i)->region()));
        }
@@ -6408,7 +6511,7 @@ Editor::set_auto_punch_range ()
                        set_punch_range (tpl->start(), now, _("Auto Punch In/Out"));
                        _session->config.set_punch_out(true);
                }
-       } else  {
+       } else  {
                if (_session->config.get_punch_out()) {
                        _session->config.set_punch_out(false);
                }
@@ -6707,12 +6810,13 @@ Editor::define_one_bar (framepos_t start, framepos_t end)
        XMLNode& before (_session->tempo_map().get_state());
 
        if (do_global) {
-               _session->tempo_map().change_initial_tempo (beats_per_minute, t.note_type());
+               _session->tempo_map().change_initial_tempo (beats_per_minute, t.note_type(), t.end_note_types_per_minute());
        } else if (t.frame() == start) {
-               _session->tempo_map().change_existing_tempo_at (start, beats_per_minute, t.note_type());
+               _session->tempo_map().change_existing_tempo_at (start, beats_per_minute, t.note_type(), t.end_note_types_per_minute());
        } else {
+               /* constant tempo */
                const Tempo tempo (beats_per_minute, t.note_type());
-               _session->tempo_map().add_tempo (tempo, 0.0, start, TempoSection::Constant, AudioTime);
+               _session->tempo_map().add_tempo (tempo, 0.0, start, AudioTime);
        }
 
        XMLNode& after (_session->tempo_map().get_state());
@@ -6988,10 +7092,12 @@ Editor::snap_regions_to_grid ()
                        used_playlists.push_back(pl);
                        pl->freeze();
                }
+               (*r)->region()->clear_changes ();
 
                MusicFrame start ((*r)->region()->first_frame (), 0);
                snap_to (start);
                (*r)->region()->set_position (start.frame, start.division);
+               _session->add_command(new StatefulDiffCommand ((*r)->region()));
        }
 
        while (used_playlists.size() > 0) {
@@ -7087,11 +7193,14 @@ Editor::close_region_gaps ()
 
                (*r)->region()->clear_changes ();
                (*r)->region()->trim_front( (position - pull_back_frames));
+
+               last_region->clear_changes ();
                last_region->trim_end( (position - pull_back_frames + crossfade_len));
 
                _session->add_command (new StatefulDiffCommand ((*r)->region()));
-               last_region = (*r)->region();
+               _session->add_command (new StatefulDiffCommand (last_region));
 
+               last_region = (*r)->region();
                idx++;
        }
 
@@ -7195,7 +7304,7 @@ Editor::playhead_forward_to_grid ()
 
        if (pos.frame < max_framepos - 1) {
                pos.frame += 2;
-               snap_to_internal (pos, RoundUpAlways, false);
+               snap_to_internal (pos, RoundUpAlways, false, true);
                _session->request_locate (pos.frame);
        }
 }
@@ -7212,7 +7321,7 @@ Editor::playhead_backward_to_grid ()
 
        if (pos.frame > 2) {
                pos.frame -= 2;
-               snap_to_internal (pos, RoundDownAlways, false);
+               snap_to_internal (pos, RoundDownAlways, false, true);
                _session->request_locate (pos.frame);
        }
 }
@@ -7476,6 +7585,11 @@ Editor::insert_time (
                        (*i)->clear_changes ();
                        (*i)->clear_owned_changes ();
 
+                       if (!in_command) {
+                               begin_reversible_command (_("insert time"));
+                               in_command = true;
+                       }
+
                        if (opt == SplitIntersected) {
                                /* non musical split */
                                (*i)->split (MusicFrame (pos, 0));
@@ -7483,10 +7597,6 @@ Editor::insert_time (
 
                        (*i)->shift (pos, frames, (opt == MoveIntersected), ignore_music_glue);
 
-                       if (!in_command) {
-                               begin_reversible_command (_("insert time"));
-                               in_command = true;
-                       }
                        vector<Command*> cmds;
                        (*i)->rdiff (cmds);
                        _session->add_commands (cmds);
@@ -7598,7 +7708,7 @@ Editor::do_remove_time ()
 
 void
 Editor::remove_time (framepos_t pos, framecnt_t frames, InsertTimeOption opt,
-                    bool ignore_music_glue, bool markers_too, bool glued_markers_too, bool locked_markers_too, bool tempo_too)
+                     bool ignore_music_glue, bool markers_too, bool glued_markers_too, bool locked_markers_too, bool tempo_too)
 {
        if (Config->get_edit_mode() == Lock) {
                error << (_("Cannot insert or delete time when in Lock edit.")) << endmsg;
@@ -7614,16 +7724,17 @@ Editor::remove_time (framepos_t pos, framecnt_t frames, InsertTimeOption opt,
 
                        XMLNode &before = pl->get_state();
 
+                       if (!in_command) {
+                               begin_reversible_command (_("remove time"));
+                               in_command = true;
+                       }
+
                        std::list<AudioRange> rl;
                        AudioRange ar(pos, pos+frames, 0);
                        rl.push_back(ar);
                        pl->cut (rl);
                        pl->shift (pos, -frames, true, ignore_music_glue);
 
-                       if (!in_command) {
-                               begin_reversible_command (_("remove time"));
-                               in_command = true;
-                       }
                        XMLNode &after = pl->get_state();
 
                        _session->add_command (new MementoCommand<Playlist> (*pl, &before, &after));
@@ -7736,32 +7847,31 @@ Editor::remove_time (framepos_t pos, framecnt_t frames, InsertTimeOption opt,
 void
 Editor::fit_selection ()
 {
-        if (!selection->tracks.empty()) {
-                fit_tracks (selection->tracks);
-        } else {
-                TrackViewList tvl;
-
-                /* no selected tracks - use tracks with selected regions */
+       if (!selection->tracks.empty()) {
+               fit_tracks (selection->tracks);
+       } else {
+               TrackViewList tvl;
 
-                if (!selection->regions.empty()) {
-                        for (RegionSelection::iterator r = selection->regions.begin(); r != selection->regions.end(); ++r) {
-                                tvl.push_back (&(*r)->get_time_axis_view ());
-                        }
+               /* no selected tracks - use tracks with selected regions */
 
-                        if (!tvl.empty()) {
-                                fit_tracks (tvl);
-                        }
-                } else if (internal_editing()) {
-                        /* no selected tracks, or regions, but in internal edit mode, so follow the mouse and use
-                           the entered track
-                        */
-                        if (entered_track) {
-                                tvl.push_back (entered_track);
-                                fit_tracks (tvl);
-                        }
-                }
-        }
+               if (!selection->regions.empty()) {
+                       for (RegionSelection::iterator r = selection->regions.begin(); r != selection->regions.end(); ++r) {
+                               tvl.push_back (&(*r)->get_time_axis_view ());
+                       }
 
+                       if (!tvl.empty()) {
+                               fit_tracks (tvl);
+                       }
+               } else if (internal_editing()) {
+                       /* no selected tracks, or regions, but in internal edit mode, so follow the mouse and use
+                        * the entered track
+                        */
+                       if (entered_track) {
+                               tvl.push_back (entered_track);
+                               fit_tracks (tvl);
+                       }
+               }
+       }
 }
 
 void
@@ -7785,11 +7895,11 @@ Editor::fit_tracks (TrackViewList & tracks)
        }
 
        /* compute the per-track height from:
-
-          total canvas visible height -
-                 height that will be taken by visible children of selected
-                 tracks - height of the ruler/hscroll area
-       */
+        *
+        * total canvas visible height
+        *  - height that will be taken by visible children of selected tracks
+         - height of the ruler/hscroll area
+        */
        uint32_t h = (uint32_t) floor ((trackviews_height() - child_heights) / visible_tracks);
        double first_y_pos = DBL_MAX;
 
@@ -7902,7 +8012,7 @@ Editor::start_visual_state_op (uint32_t n)
 void
 Editor::cancel_visual_state_op (uint32_t n)
 {
-        goto_visual_state (n);
+       goto_visual_state (n);
 }
 
 void