fix ppc builds
[ardour.git] / gtk2_ardour / editor_ops.cc
index 55d38f3a884e9da23d7f2346a77a30eee84cbc22..a6079cac90b698f304ebabc2c561c53378511e2d 100644 (file)
@@ -1921,7 +1921,7 @@ Editor::temporal_zoom_region (bool both_axes)
 
 
 bool
-Editor::get_selection_extents ( framepos_t &start, framepos_t &end )
+Editor::get_selection_extents (framepos_t &start, framepos_t &end) const
 {
        start = max_framepos;
        end = 0;
@@ -2782,7 +2782,7 @@ Editor::rename_region ()
                return;
        }
 
-       ArdourDialog d (*this, _("Rename Region"), true, false);
+       ArdourDialog d (_("Rename Region"), true, false);
        Entry entry;
        Label label (_("New name:"));
        HBox hbox;
@@ -4567,7 +4567,7 @@ Editor::cut_copy_regions (CutCopyOp op, RegionSelection& rs)
 
                list<boost::shared_ptr<Playlist> > foo;
 
-               /* the pmap is in the same order as the tracks in which selected regions occured */
+               /* the pmap is in the same order as the tracks in which selected regions occurred */
 
                for (vector<PlaylistMapping>::iterator i = pmap.begin(); i != pmap.end(); ++i) {
                        if ((*i).pl) {
@@ -4811,18 +4811,9 @@ Editor::duplicate_selection (float times)
        }
 
        boost::shared_ptr<Playlist> playlist;
-       vector<boost::shared_ptr<Region> > new_regions;
-       vector<boost::shared_ptr<Region> >::iterator ri;
-
-       create_region_from_selection (new_regions);
-
-       if (new_regions.empty()) {
-               return;
-       }
-
-       ri = new_regions.begin();
 
        TrackViewList ts = selection->tracks.filter_to_unique_playlists ();
+
        bool in_command = false;
 
        for (TrackViewList::iterator i = ts.begin(); i != ts.end(); ++i) {
@@ -4830,27 +4821,34 @@ Editor::duplicate_selection (float times)
                        continue;
                }
                playlist->clear_changes ();
-               framepos_t end;
+
                if (clicked_selection) {
-                       end = selection->time[clicked_selection].end;
+                       playlist->duplicate_range (selection->time[clicked_selection], times);
                } else {
-                       end = selection->time.end_frame();
+                       playlist->duplicate_ranges (selection->time, times);
                }
-               playlist->duplicate (*ri, end + 1, times);
 
                if (!in_command) {
-                       begin_reversible_command (_("duplicate selection"));
+                       begin_reversible_command (_("duplicate range selection"));
                        in_command = true;
                }
                _session->add_command (new StatefulDiffCommand (playlist));
 
-               ++ri;
-               if (ri == new_regions.end()) {
-                       --ri;
-               }
        }
 
        if (in_command) {
+               // now "move" range selection to after the current range selection
+               framecnt_t distance = 0;
+
+               if (clicked_selection) {
+                       distance = selection->time[clicked_selection].end -
+                                  selection->time[clicked_selection].start;
+               } else {
+                       distance = selection->time.end_frame() - selection->time.start();
+               }
+
+               selection->move_time (distance);
+
                commit_reversible_command ();
        }
 }
@@ -5162,12 +5160,13 @@ Editor::strip_region_silence ()
        StripSilenceDialog d (_session, audio_only);
        int const r = d.run ();
 
-        d.drop_rects ();
+       d.drop_rects ();
 
-        if (r == Gtk::RESPONSE_OK) {
-                ARDOUR::AudioIntervalMap silences;
-                d.silences (silences);
+       if (r == Gtk::RESPONSE_OK) {
+               ARDOUR::AudioIntervalMap silences;
+               d.silences (silences);
                StripSilence s (*_session, silences, d.fade_length());
+
                apply_filter (s, _("strip silence"), &d);
        }
 }
@@ -5442,6 +5441,11 @@ Editor::apply_filter (Filter& filter, string command, ProgressReporter* progress
                                playlist->clear_changes ();
                                playlist->clear_owned_changes ();
 
+                               if (!in_command) {
+                                       begin_reversible_command (command);
+                                       in_command = true;
+                               }
+
                                if (filter.results.empty ()) {
 
                                        /* no regions returned; remove the old one */
@@ -5462,14 +5466,10 @@ Editor::apply_filter (Filter& filter, string command, ProgressReporter* progress
                                        }
 
                                }
+
                                /* We might have removed regions, which alters other regions' layering_index,
                                   so we need to do a recursive diff here.
                                */
-
-                               if (!in_command) {
-                                       begin_reversible_command (command);
-                                       in_command = true;
-                               }
                                vector<Command*> cmds;
                                playlist->rdiff (cmds);
                                _session->add_commands (cmds);
@@ -6581,7 +6581,8 @@ Editor::split_region_at_transients ()
 
                boost::shared_ptr<AudioRegion> ar = boost::dynamic_pointer_cast<AudioRegion> ((*i)->region());
 
-               if (ar && (ar->get_transients (positions) == 0)) {
+               if (ar) {
+                       ar->transients (positions);
                        split_region_at_points ((*i)->region(), positions, true);
                        positions.clear ();
                }
@@ -6610,7 +6611,6 @@ Editor::split_region_at_points (boost::shared_ptr<Region> r, AnalysisFeatureList
                return;
        }
 
-
        if (positions.size() > 20 && can_ferret) {
                std::string msgstr = string_compose (_("You are about to split\n%1\ninto %2 pieces.\nThis could take a long time."), r->name(), positions.size() + 1);
                MessageDialog msg (msgstr,
@@ -6663,27 +6663,28 @@ Editor::split_region_at_points (boost::shared_ptr<Region> r, AnalysisFeatureList
 
        framepos_t pos = 0;
 
+       framepos_t rstart = r->first_frame ();
+       framepos_t rend = r->last_frame ();
+
        while (x != positions.end()) {
 
                /* deal with positons that are out of scope of present region bounds */
-               if (*x <= 0 || *x > r->length()) {
+               if (*x <= rstart || *x > rend) {
                        ++x;
                        continue;
                }
 
-               /* file start = original start + how far we from the initial position ?
-                */
+               /* file start = original start + how far we from the initial position ?  */
 
                framepos_t file_start = r->start() + pos;
 
-               /* length = next position - current position
-                */
+               /* length = next position - current position */
 
-               framepos_t len = (*x) - pos;
+               framepos_t len = (*x) - pos - rstart;
 
                /* XXX we do we really want to allow even single-sample regions?
-                  shouldn't we have some kind of lower limit on region size?
-               */
+                * shouldn't we have some kind of lower limit on region size?
+                */
 
                if (len <= 0) {
                        break;
@@ -6703,14 +6704,15 @@ Editor::split_region_at_points (boost::shared_ptr<Region> r, AnalysisFeatureList
                plist.add (ARDOUR::Properties::length, len);
                plist.add (ARDOUR::Properties::name, new_name);
                plist.add (ARDOUR::Properties::layer, 0);
+               // TODO set transients_offset
 
                boost::shared_ptr<Region> nr = RegionFactory::create (r->sources(), plist, false);
                /* because we set annouce to false, manually add the new region to the
-                  RegionFactory map
-               */
+                * RegionFactory map
+                */
                RegionFactory::map_add (nr);
 
-               pl->add_region (nr, r->position() + pos);
+               pl->add_region (nr, rstart + pos);
 
                if (select_new) {
                        new_regions.push_front(nr);
@@ -6780,8 +6782,7 @@ Editor::place_transient()
        begin_reversible_command (_("place transient"));
 
        for (RegionSelection::iterator r = rs.begin(); r != rs.end(); ++r) {
-               framepos_t position = (*r)->region()->position();
-               (*r)->region()->add_transient(where - position);
+               (*r)->region()->add_transient(where);
        }
 
        commit_reversible_command ();
@@ -7097,6 +7098,7 @@ Editor::remove_tracks ()
 bool
 Editor::idle_remove_tracks ()
 {
+       Session::StateProtector sp (_session);
        _remove_tracks ();
        return false; /* do not call again */
 }
@@ -7200,12 +7202,17 @@ edit your ardour.rc file to set the\n\
        }
 
        {
-               Session::StateProtector sp (_session);
                DisplaySuspender ds;
+               boost::shared_ptr<RouteList> rl (new RouteList);
                for (vector<boost::shared_ptr<Route> >::iterator x = routes.begin(); x != routes.end(); ++x) {
-                       _session->remove_route (*x);
+                       rl->push_back (*x);
                }
+               _session->remove_routes (rl);
        }
+       /* TrackSelection and RouteList leave scope,
+        * destructors are called,
+        * diskstream drops references, save_state is called (again for every track)
+        */
 }
 
 void
@@ -7226,12 +7233,10 @@ Editor::do_insert_time ()
                return;
        }
 
-       InsertTimeOption opt = d.intersected_region_action ();
-
        insert_time (
-               get_preferred_edit_position(),
+               get_preferred_edit_position (EDIT_IGNORE_MOUSE),
                d.distance(),
-               opt,
+               d.intersected_region_action (),
                d.all_playlists(),
                d.move_glued(),
                d.move_markers(),
@@ -7429,7 +7434,7 @@ Editor::remove_time (framepos_t pos, framecnt_t frames, InsertTimeOption opt,
                        pl->shift (pos, -frames, true, ignore_music_glue);
 
                        if (!in_command) {
-                               begin_reversible_command (_("cut time"));
+                               begin_reversible_command (_("remove time"));
                                in_command = true;
                        }
                        XMLNode &after = pl->get_state();
@@ -7441,7 +7446,7 @@ Editor::remove_time (framepos_t pos, framecnt_t frames, InsertTimeOption opt,
                RouteTimeAxisView* rtav = dynamic_cast<RouteTimeAxisView*> (*x);
                if (rtav) {
                        if (!in_command) {
-                               begin_reversible_command (_("cut time"));
+                               begin_reversible_command (_("remove time"));
                                in_command = true;
                        }
                        rtav->route ()->shift (pos, -frames);
@@ -7514,7 +7519,7 @@ Editor::remove_time (framepos_t pos, framecnt_t frames, InsertTimeOption opt,
 
                if (moved) {
                        if (!in_command) {
-                               begin_reversible_command (_("cut time"));
+                               begin_reversible_command (_("remove time"));
                                in_command = true;
                        }
                        XMLNode& after (_session->locations()->get_state());
@@ -7601,7 +7606,7 @@ Editor::fit_tracks (TrackViewList & tracks)
        double first_y_pos = DBL_MAX;
 
        if (h < TimeAxisView::preset_height (HeightSmall)) {
-               MessageDialog msg (*this, _("There are too many tracks to fit in the current window"));
+               MessageDialog msg (_("There are too many tracks to fit in the current window"));
                /* too small to be displayed */
                return;
        }