Restore snap when switching to/from internal.
[ardour.git] / gtk2_ardour / midi_region_view.cc
index 503f2302c317695b58d5a74454d7d72e3cdec69f..330a2204bfd9a4c3bc4a07dd95280ad50f658fe4 100644 (file)
 
 #include <sigc++/signal.h>
 
+#include "midi++/midnam_patch.h"
+
 #include "pbd/memento_command.h"
 #include "pbd/stateful_diff_command.h"
 
 #include "ardour/midi_model.h"
-#include "ardour/midi_patch_manager.h"
 #include "ardour/midi_region.h"
 #include "ardour/midi_source.h"
 #include "ardour/midi_track.h"
@@ -39,7 +40,6 @@
 #include "ardour/session.h"
 
 #include "evoral/Parameter.hpp"
-#include "evoral/MIDIParameters.hpp"
 #include "evoral/MIDIEvent.hpp"
 #include "evoral/Control.hpp"
 #include "evoral/midi_util.h"
@@ -67,6 +67,7 @@
 #include "midi_velocity_dialog.h"
 #include "mouse_cursors.h"
 #include "note_player.h"
+#include "paste_context.h"
 #include "public_editor.h"
 #include "route_time_axis.h"
 #include "rgb_macros.h"
@@ -85,6 +86,7 @@
 using namespace ARDOUR;
 using namespace PBD;
 using namespace Editing;
+using namespace std;
 using Gtkmm2ext::Keyboard;
 
 PBD::Signal1<void, MidiRegionView *> MidiRegionView::SelectionCleared;
@@ -118,6 +120,8 @@ MidiRegionView::MidiRegionView (ArdourCanvas::Container*      parent,
        , _no_sound_notes (false)
        , _last_event_x (0)
        , _last_event_y (0)
+       , _grabbed_keyboard (false)
+       , _entered (false)
        , pre_enter_cursor (0)
        , pre_press_cursor (0)
        , pre_note_enter_cursor (0)
@@ -131,6 +135,9 @@ MidiRegionView::MidiRegionView (ArdourCanvas::Container*      parent,
        connect_to_diskstream ();
 
        SelectionCleared.connect (_selection_cleared_connection, invalidator (*this), boost::bind (&MidiRegionView::selection_cleared, this, _1), gui_context ());
+
+       PublicEditor& editor (trackview.editor());
+       editor.get_selection().ClearMidiNoteSelection.connect (_clear_midi_selection_connection, invalidator (*this), boost::bind (&MidiRegionView::clear_midi_selection, this), gui_context ());
 }
 
 MidiRegionView::MidiRegionView (ArdourCanvas::Container*      parent,
@@ -138,8 +145,9 @@ MidiRegionView::MidiRegionView (ArdourCanvas::Container*      parent,
                                 boost::shared_ptr<MidiRegion> r,
                                 double                        spu,
                                 uint32_t                      basic_color,
+                                bool                          recording,
                                 TimeAxisViewItem::Visibility  visibility)
-       : RegionView (parent, tv, r, spu, basic_color, false, visibility)
+       : RegionView (parent, tv, r, spu, basic_color, recording, visibility)
        , _current_range_min(0)
        , _current_range_max(0)
        , _region_relative_time_converter(r->session().tempo_map(), r->position())
@@ -161,6 +169,8 @@ MidiRegionView::MidiRegionView (ArdourCanvas::Container*      parent,
        , _no_sound_notes (false)
        , _last_event_x (0)
        , _last_event_y (0)
+       , _grabbed_keyboard (false)
+       , _entered (false)
        , pre_enter_cursor (0)
        , pre_press_cursor (0)
        , pre_note_enter_cursor (0)
@@ -174,6 +184,9 @@ MidiRegionView::MidiRegionView (ArdourCanvas::Container*      parent,
        connect_to_diskstream ();
 
        SelectionCleared.connect (_selection_cleared_connection, invalidator (*this), boost::bind (&MidiRegionView::selection_cleared, this, _1), gui_context ());
+
+       PublicEditor& editor (trackview.editor());
+       editor.get_selection().ClearMidiNoteSelection.connect (_clear_midi_selection_connection, invalidator (*this), boost::bind (&MidiRegionView::clear_midi_selection, this), gui_context ());
 }
 
 void
@@ -210,6 +223,8 @@ MidiRegionView::MidiRegionView (const MidiRegionView& other)
        , _no_sound_notes (false)
        , _last_event_x (0)
        , _last_event_y (0)
+       , _grabbed_keyboard (false)
+       , _entered (false)
        , pre_enter_cursor (0)
        , pre_press_cursor (0)
        , pre_note_enter_cursor (0)
@@ -241,6 +256,8 @@ MidiRegionView::MidiRegionView (const MidiRegionView& other, boost::shared_ptr<M
        , _no_sound_notes (false)
        , _last_event_x (0)
        , _last_event_y (0)
+       , _grabbed_keyboard (false)
+       , _entered (false)
        , pre_enter_cursor (0)
        , pre_press_cursor (0)
        , pre_note_enter_cursor (0)
@@ -259,11 +276,13 @@ MidiRegionView::init (bool wfd)
                                           gui_context());
        
        if (wfd) {
-               midi_region()->midi_source(0)->load_model();
+               Glib::Threads::Mutex::Lock lm(midi_region()->midi_source(0)->mutex());
+               midi_region()->midi_source(0)->load_model(lm);
        }
 
        _model = midi_region()->midi_source(0)->model();
        _enable_display = false;
+       _fill_color_name = "midi frame base";
 
        RegionView::init (false);
 
@@ -298,10 +317,17 @@ MidiRegionView::init (bool wfd)
                                               boost::bind (&MidiRegionView::snap_changed, this),
                                               gui_context());
 
+       trackview.editor().MouseModeChanged.connect(_mouse_mode_connection, invalidator (*this),
+                                                   boost::bind (&MidiRegionView::mouse_mode_changed, this),
+                                                   gui_context ());
+
        Config->ParameterChanged.connect (*this, invalidator (*this), boost::bind (&MidiRegionView::parameter_changed, this, _1), gui_context());
        connect_to_diskstream ();
 
        SelectionCleared.connect (_selection_cleared_connection, invalidator (*this), boost::bind (&MidiRegionView::selection_cleared, this, _1), gui_context ());
+
+       PublicEditor& editor (trackview.editor());
+       editor.get_selection().ClearMidiNoteSelection.connect (_clear_midi_selection_connection, invalidator (*this), boost::bind (&MidiRegionView::clear_midi_selection, this), gui_context ());
 }
 
 InstrumentInfo&
@@ -329,42 +355,32 @@ MidiRegionView::connect_to_diskstream ()
 bool
 MidiRegionView::canvas_group_event(GdkEvent* ev)
 {
-       if (in_destructor) {
+       if (in_destructor || _recregion) {
                return false;
        }
 
+       if (!trackview.editor().internal_editing()) {
+               // not in internal edit mode, so just act like a normal region
+               return RegionView::canvas_group_event (ev);
+       }
+
        bool r;
 
        switch (ev->type) {
        case GDK_ENTER_NOTIFY:
-       case GDK_LEAVE_NOTIFY:
                _last_event_x = ev->crossing.x;
                _last_event_y = ev->crossing.y;
-               break;
-       case GDK_MOTION_NOTIFY:
-               _last_event_x = ev->motion.x;
-               _last_event_y = ev->motion.y;
-               break;
-       default:
-               break;
-       }
-
-       if (ev->type == GDK_2BUTTON_PRESS) {
-               // cannot use double-click to exit internal mode if single-click is being used
-               MouseMode m = trackview.editor().current_mouse_mode();
-
-               if ((m != MouseObject || !Keyboard::modifier_state_contains (ev->button.state, Keyboard::insert_note_modifier())) && (m != MouseDraw)) {
-                       return trackview.editor().toggle_internal_editing_from_double_click (ev);
-               }
-       }
+               enter_notify(&ev->crossing);
+               // set entered_regionview (among other things)
+               return RegionView::canvas_group_event (ev);
 
-       if ((!trackview.editor().internal_editing() && trackview.editor().current_mouse_mode() != MouseGain) ||
-           (trackview.editor().current_mouse_mode() == MouseTimeFX)) {
-               // handle non-internal-edit/non-draw modes elsewhere
+       case GDK_LEAVE_NOTIFY:
+               _last_event_x = ev->crossing.x;
+               _last_event_y = ev->crossing.y;
+               leave_notify(&ev->crossing);
+               // reset entered_regionview (among other things)
                return RegionView::canvas_group_event (ev);
-       }
 
-       switch (ev->type) {
        case GDK_SCROLL:
                if (scroll (&ev->scroll)) {
                        return true;
@@ -386,90 +402,77 @@ MidiRegionView::canvas_group_event(GdkEvent* ev)
                _note_player = 0;
                return r;
 
-       case GDK_ENTER_NOTIFY:
-               // set entered_regionview (among other things)
-               trackview.editor().canvas_region_view_event (ev, group, this);
-               return enter_notify (&ev->crossing);
-
-       case GDK_LEAVE_NOTIFY:
-               // reset entered_regionview (among other things)
-               trackview.editor().canvas_region_view_event (ev, group, this);
-               return leave_notify (&ev->crossing);
-
        case GDK_MOTION_NOTIFY:
+               _last_event_x = ev->motion.x;
+               _last_event_y = ev->motion.y;
                return motion (&ev->motion);
 
        default:
                break;
        }
 
-       return trackview.editor().canvas_region_view_event (ev, group, this);
+       return RegionView::canvas_group_event (ev);
 }
 
 bool
 MidiRegionView::enter_notify (GdkEventCrossing* ev)
 {
-       trackview.editor().MouseModeChanged.connect (
-               _mouse_mode_connection, invalidator (*this), boost::bind (&MidiRegionView::mouse_mode_changed, this), gui_context ()
-               );
-
-       if (trackview.editor().current_mouse_mode() == MouseDraw && _mouse_state != AddDragging) {
-               create_ghost_note (ev->x, ev->y);
-       }
-
-       if (!trackview.editor().internal_editing()) {
-               Keyboard::magic_widget_drop_focus();
-       } else {
-               Keyboard::magic_widget_grab_focus();
-               group->grab_focus();
-       }
-
-       // if current operation is non-operational in a midi region, change the cursor to so indicate
-       if (trackview.editor().current_mouse_mode() == MouseGain) {
-               Editor* editor = dynamic_cast<Editor *> (&trackview.editor());
-               pre_enter_cursor = editor->get_canvas_cursor();
-               editor->set_canvas_cursor(editor->cursors()->timebar);
-       }
+       enter_internal();
 
+       _entered = true;
        return false;
 }
 
 bool
 MidiRegionView::leave_notify (GdkEventCrossing*)
 {
-       _mouse_mode_connection.disconnect ();
+       leave_internal();
 
-       trackview.editor().verbose_cursor()->hide ();
-       remove_ghost_note ();
+       _entered = false;
+       return false;
+}
 
-       if (trackview.editor().internal_editing()) {
-               Keyboard::magic_widget_drop_focus();
+void
+MidiRegionView::mouse_mode_changed ()
+{
+       // Adjust frame colour (become more transparent for internal tools)
+       set_frame_color();
+
+       if (_entered) {
+               if (trackview.editor().internal_editing()) {
+                       // Switched in to internal editing mode while entered
+                       enter_internal();
+               } else {
+                       // Switched out of internal editing mode while entered
+                       leave_internal();
+               }
        }
+}
 
-       if (pre_enter_cursor) {
-               Editor* editor = dynamic_cast<Editor *> (&trackview.editor());
-               editor->set_canvas_cursor(pre_enter_cursor);
-               pre_enter_cursor = 0;
+void
+MidiRegionView::enter_internal()
+{
+       if (trackview.editor().current_mouse_mode() == MouseDraw && _mouse_state != AddDragging) {
+               // Show ghost note under pencil
+               create_ghost_note(_last_event_x, _last_event_y);
        }
 
-       return false;
+       if (!_selection.empty()) {
+               // Grab keyboard for moving selected notes with arrow keys
+               Keyboard::magic_widget_grab_focus();
+               _grabbed_keyboard = true;
+       }
 }
 
 void
-MidiRegionView::mouse_mode_changed ()
+MidiRegionView::leave_internal()
 {
-       if (trackview.editor().current_mouse_mode() == MouseDraw && trackview.editor().internal_editing()) {
-               create_ghost_note (_last_event_x, _last_event_y);
-       } else {
-               remove_ghost_note ();
-               trackview.editor().verbose_cursor()->hide ();
-       }
+       trackview.editor().verbose_cursor()->hide ();
+       remove_ghost_note ();
 
-       if (!trackview.editor().internal_editing()) {
+       if (_grabbed_keyboard) {
                Keyboard::magic_widget_drop_focus();
-       } else {
-               Keyboard::magic_widget_grab_focus();
-               group->grab_focus();
+               _grabbed_keyboard = false;
        }
 }
 
@@ -483,7 +486,7 @@ MidiRegionView::button_press (GdkEventButton* ev)
        Editor* editor = dynamic_cast<Editor *> (&trackview.editor());
        MouseMode m = editor->current_mouse_mode();
 
-       if (m == MouseObject && Keyboard::modifier_state_contains (ev->state, Keyboard::insert_note_modifier())) {
+       if (m == MouseContent && Keyboard::modifier_state_contains (ev->state, Keyboard::insert_note_modifier())) {
                pre_press_cursor = editor->get_canvas_cursor ();
                editor->set_canvas_cursor (editor->cursors()->midi_pencil);
        }
@@ -532,7 +535,7 @@ MidiRegionView::button_release (GdkEventButton* ev)
                        clear_selection ();
                        break;
 
-               case MouseObject:
+               case MouseContent:
                case MouseTimeFX:
                        {
                                clear_selection();
@@ -545,17 +548,12 @@ MidiRegionView::button_release (GdkEventButton* ev)
                                        event_y = ev->y;
                                        group->canvas_to_item (event_x, event_y);
 
-                                       bool success;
-                                       Evoral::MusicalTime beats = editor.get_grid_type_as_beats (success, editor.pixel_to_sample (event_x));
-
-                                       if (!success) {
-                                               beats = 1;
-                                       }
+                                       Evoral::MusicalTime beats = get_grid_beats(editor.pixel_to_sample(event_x));
 
                                        /* Shorten the length by 1 tick so that we can add a new note at the next
                                           grid snap without it overlapping this one.
                                        */
-                                       beats -= 1.0 / Timecode::BBT_Time::ticks_per_beat;
+                                       beats -= Evoral::MusicalTime::tick();
 
                                        create_note_at (editor.pixel_to_sample (event_x), event_y, beats, true);
                                }
@@ -564,17 +562,12 @@ MidiRegionView::button_release (GdkEventButton* ev)
                        }
                case MouseDraw:
                        {
-                               bool success;
-                               Evoral::MusicalTime beats = editor.get_grid_type_as_beats (success, editor.pixel_to_sample (event_x));
-
-                               if (!success) {
-                                       beats = 1;
-                               }
+                               Evoral::MusicalTime beats = get_grid_beats(editor.pixel_to_sample(event_x));
 
                                /* Shorten the length by 1 tick so that we can add a new note at the next
                                   grid snap without it overlapping this one.
                                */
-                               beats -= 1.0 / Timecode::BBT_Time::ticks_per_beat;
+                               beats -= Evoral::MusicalTime::tick();
                                
                                create_note_at (editor.pixel_to_sample (event_x), event_y, beats, true);
 
@@ -607,18 +600,18 @@ MidiRegionView::motion (GdkEventMotion* ev)
 {
        PublicEditor& editor = trackview.editor ();
 
-       if (!_ghost_note && editor.current_mouse_mode() == MouseObject &&
+       if (!_ghost_note && editor.current_mouse_mode() == MouseContent &&
            Keyboard::modifier_state_contains (ev->state, Keyboard::insert_note_modifier()) &&
            _mouse_state != AddDragging) {
 
                create_ghost_note (ev->x, ev->y);
 
-       } else if (_ghost_note && editor.current_mouse_mode() == MouseObject &&
+       } else if (_ghost_note && editor.current_mouse_mode() == MouseContent &&
                   Keyboard::modifier_state_contains (ev->state, Keyboard::insert_note_modifier())) {
 
                update_ghost_note (ev->x, ev->y);
 
-       } else if (_ghost_note && editor.current_mouse_mode() == MouseObject) {
+       } else if (_ghost_note && editor.current_mouse_mode() == MouseContent) {
 
                remove_ghost_note ();
                editor.verbose_cursor()->hide ();
@@ -641,15 +634,17 @@ MidiRegionView::motion (GdkEventMotion* ev)
                        
                        MouseMode m = editor.current_mouse_mode();
                        
-                       if (m == MouseDraw || (m == MouseObject && Keyboard::modifier_state_contains (ev->state, Keyboard::insert_note_modifier()))) {
+                       if (m == MouseDraw || (m == MouseContent && Keyboard::modifier_state_contains (ev->state, Keyboard::insert_note_modifier()))) {
                                editor.drags()->set (new NoteCreateDrag (dynamic_cast<Editor *> (&editor), group, this), (GdkEvent *) ev);
                                _mouse_state = AddDragging;
                                remove_ghost_note ();
                                editor.verbose_cursor()->hide ();
                                return true;
-                       } else if (m == MouseObject) {
+                       } else if (m == MouseContent) {
                                editor.drags()->set (new MidiRubberbandSelectDrag (dynamic_cast<Editor *> (&editor), this), (GdkEvent *) ev);
-                               clear_selection ();
+                               if (!Keyboard::modifier_state_equals (ev->state, Keyboard::TertiaryModifier)) {
+                                       clear_selection ();
+                               }
                                _mouse_state = SelectRectDragging;
                                return true;
                        } else if (m == MouseRange) {
@@ -738,7 +733,7 @@ MidiRegionView::key_press (GdkEventKey* ev)
                bool shorter = Keyboard::modifier_state_contains (ev->state, Keyboard::PrimaryModifier);
                bool fine = Keyboard::modifier_state_contains (ev->state, Keyboard::SecondaryModifier);
 
-               change_note_lengths (fine, shorter, 0.0, start, end);
+               change_note_lengths (fine, shorter, Evoral::MusicalTime(), start, end);
 
                return true;
 
@@ -799,14 +794,16 @@ MidiRegionView::key_press (GdkEventKey* ev)
                }
                return true;
 
-       } else if (ev->keyval == GDK_Left && unmodified) {
+       } else if (ev->keyval == GDK_Left) {
 
-               nudge_notes (false);
+               bool fine = !Keyboard::modifier_state_contains (ev->state, Keyboard::SecondaryModifier);
+               nudge_notes (false, fine);
                return true;
 
-       } else if (ev->keyval == GDK_Right && unmodified) {
+       } else if (ev->keyval == GDK_Right) {
 
-               nudge_notes (true);
+               bool fine = !Keyboard::modifier_state_contains (ev->state, Keyboard::SecondaryModifier);
+               nudge_notes (true, fine);
                return true;
 
        } else if (ev->keyval == GDK_c && unmodified) {
@@ -919,7 +916,7 @@ MidiRegionView::show_list_editor ()
  * \param snap_t true to snap t to the grid, otherwise false.
  */
 void
-MidiRegionView::create_note_at (framepos_t t, double y, double length, bool snap_t)
+MidiRegionView::create_note_at (framepos_t t, double y, Evoral::MusicalTime length, bool snap_t)
 {
        if (length < 2 * DBL_EPSILON) {
                return;
@@ -1531,7 +1528,7 @@ MidiRegionView::end_write()
 /** Resolve an active MIDI note (while recording).
  */
 void
-MidiRegionView::resolve_note(uint8_t note, double end_time)
+MidiRegionView::resolve_note(uint8_t note, Evoral::MusicalTime end_time)
 {
        if (midi_view()->note_mode() != Sustained) {
                return;
@@ -1564,7 +1561,8 @@ MidiRegionView::extend_active_notes()
 
        for (unsigned i=0; i < 128; ++i) {
                if (_active_notes[i]) {
-                       _active_notes[i]->set_x1 (trackview.editor().sample_to_pixel(_region->length()));
+                       _active_notes[i]->set_x1(
+                               trackview.editor().sample_to_pixel(_region->position() + _region->length()));
                }
        }
 }
@@ -1670,7 +1668,7 @@ MidiRegionView::update_note (Note* ev, bool update_ghost_regions)
 
        ev->set_y1 (y0 + std::max(1., floor(midi_stream_view()->note_height()) - 1));
 
-       if (note->length() == 0) {
+       if (!note->length()) {
                if (_active_notes && note->note() < 128) {
                        // If this note is already active there's a stuck note,
                        // finish the old note rectangle
@@ -1866,13 +1864,13 @@ MidiRegionView::patch_change_to_patch_key (MidiModel::PatchChangePtr p)
 
 /// Return true iff @p pc applies to the given time on the given channel.
 static bool
-patch_applies (const ARDOUR::MidiModel::constPatchChangePtr pc, double time, uint8_t channel)
+patch_applies (const ARDOUR::MidiModel::constPatchChangePtr pc, Evoral::MusicalTime time, uint8_t channel)
 {
        return pc->time() <= time && pc->channel() == channel;
 }
        
 void 
-MidiRegionView::get_patch_key_at (double time, uint8_t channel, MIDI::Name::PatchPrimaryKey& key) const
+MidiRegionView::get_patch_key_at (Evoral::MusicalTime time, uint8_t channel, MIDI::Name::PatchPrimaryKey& key) const
 {
        // The earliest event not before time
        MidiModel::PatchChanges::iterator i = _model->patch_change_lower_bound (time);
@@ -1885,15 +1883,11 @@ MidiRegionView::get_patch_key_at (double time, uint8_t channel, MIDI::Name::Patc
        }
 
        if (i != _model->patch_changes().end() && patch_applies(*i, time, channel)) {
-               key.bank_number    = (*i)->bank();
-               key.program_number = (*i)->program ();
+               key.set_bank((*i)->bank());
+               key.set_program((*i)->program ());
        } else {
-               key.bank_number = key.program_number = 0;
-       }
-
-       if (!key.is_sane()) {
-               error << string_compose(_("insane MIDI patch key %1:%2"),
-                                       key.bank_number, key.program_number) << endmsg;
+               key.set_bank(0);
+               key.set_program(0);
        }
 }
 
@@ -1902,11 +1896,11 @@ MidiRegionView::change_patch_change (PatchChange& pc, const MIDI::Name::PatchPri
 {
        MidiModel::PatchChangeDiffCommand* c = _model->new_patch_change_diff_command (_("alter patch change"));
 
-       if (pc.patch()->program() != new_patch.program_number) {
-               c->change_program (pc.patch (), new_patch.program_number);
+       if (pc.patch()->program() != new_patch.program()) {
+               c->change_program (pc.patch (), new_patch.program());
        }
 
-       int const new_bank = new_patch.bank_number;
+       int const new_bank = new_patch.bank();
        if (pc.patch()->bank() != new_bank) {
                c->change_bank (pc.patch (), new_bank);
        }
@@ -1992,47 +1986,15 @@ MidiRegionView::delete_patch_change (PatchChange* pc)
 }
 
 void
-MidiRegionView::previous_patch (PatchChange& patch)
-{
-       if (patch.patch()->program() < 127) {
-               MIDI::Name::PatchPrimaryKey key = patch_change_to_patch_key (patch.patch());
-               key.program_number++;
-               change_patch_change (patch, key);
-       }
-}
-
-void
-MidiRegionView::next_patch (PatchChange& patch)
-{
-       if (patch.patch()->program() > 0) {
-               MIDI::Name::PatchPrimaryKey key = patch_change_to_patch_key (patch.patch());
-               key.program_number--;
-               change_patch_change (patch, key);
-       }
-}
-
-void
-MidiRegionView::next_bank (PatchChange& patch)
+MidiRegionView::step_patch (PatchChange& patch, bool bank, int delta)
 {
-       if (patch.patch()->program() < 127) {
-               MIDI::Name::PatchPrimaryKey key = patch_change_to_patch_key (patch.patch());
-               if (key.bank_number > 0) {
-                       key.bank_number--;
-                       change_patch_change (patch, key);
-               }
-       }
-}
-
-void
-MidiRegionView::previous_bank (PatchChange& patch)
-{
-       if (patch.patch()->program() > 0) {
-               MIDI::Name::PatchPrimaryKey key = patch_change_to_patch_key (patch.patch());
-               if (key.bank_number < 127) {
-                       key.bank_number++;
-                       change_patch_change (patch, key);
-               }
+       MIDI::Name::PatchPrimaryKey key = patch_change_to_patch_key(patch.patch());
+       if (bank) {
+               key.set_bank(key.bank() + delta);
+       } else {
+               key.set_program(key.program() + delta);
        }
+       change_patch_change(patch, key);
 }
 
 void
@@ -2093,6 +2055,12 @@ MidiRegionView::clear_selection_except (NoteBase* ev, bool signal)
                }
        }
 
+       if (!ev && _entered) {
+               // Clearing selection entirely, ungrab keyboard
+               Keyboard::magic_widget_drop_focus();
+               _grabbed_keyboard = false;
+       }
+
        /* this does not change the status of this regionview w.r.t the editor
           selection.
        */
@@ -2105,6 +2073,8 @@ MidiRegionView::clear_selection_except (NoteBase* ev, bool signal)
 void
 MidiRegionView::unique_select(NoteBase* ev)
 {
+       const bool selection_was_empty = _selection.empty();
+
        clear_selection_except (ev);
 
        /* don't bother with checking to see if we should remove this
@@ -2115,6 +2085,11 @@ MidiRegionView::unique_select(NoteBase* ev)
 
        if (!ev->selected()) {
                add_to_selection (ev);
+               if (selection_was_empty && _entered) {
+                       // Grab keyboard for moving notes with arrow keys
+                       Keyboard::magic_widget_grab_focus();
+                       _grabbed_keyboard = true;
+               }
        }
 }
 
@@ -2270,7 +2245,7 @@ MidiRegionView::note_selected (NoteBase* ev, bool add, bool extend)
                /* find end of latest note selected, select all between that and the start of "ev" */
 
                Evoral::MusicalTime earliest = Evoral::MaxMusicalTime;
-               Evoral::MusicalTime latest = 0;
+               Evoral::MusicalTime latest   = Evoral::MusicalTime();
 
                for (Selection::iterator i = _selection.begin(); i != _selection.end(); ++i) {
                        if ((*i)->note()->end_time() > latest) {
@@ -2386,6 +2361,11 @@ MidiRegionView::remove_from_selection (NoteBase* ev)
 
        if (i != _selection.end()) {
                _selection.erase (i);
+               if (_selection.empty() && _grabbed_keyboard) {
+                       // Ungrab keyboard
+                       Keyboard::magic_widget_drop_focus();
+                       _grabbed_keyboard = false;
+               }
        }
 
        ev->set_selected (false);
@@ -2400,18 +2380,19 @@ MidiRegionView::remove_from_selection (NoteBase* ev)
 void
 MidiRegionView::add_to_selection (NoteBase* ev)
 {
-       bool add_mrv_selection = false;
-
-       if (_selection.empty()) {
-               add_mrv_selection = true;
-       }
+       const bool selection_was_empty = _selection.empty();
 
        if (_selection.insert (ev).second) {
                ev->set_selected (true);
                start_playing_midi_note ((ev)->note());
+               if (selection_was_empty && _entered) {
+                       // Grab keyboard for moving notes with arrow keys
+                       Keyboard::magic_widget_grab_focus();
+                       _grabbed_keyboard = true;
+               }
        }
 
-       if (add_mrv_selection) {
+       if (selection_was_empty) {
                PublicEditor& editor (trackview.editor());
                editor.get_selection().add (this);
        }
@@ -2431,7 +2412,7 @@ MidiRegionView::move_selection(double dx, double dy, double cumulative_dy)
        }
 
        for (Selection::iterator i = _selection.begin(); i != _selection.end(); ++i) {
-               if (Evoral::musical_time_equal ((*i)->note()->time(), earliest)) {
+               if ((*i)->note()->time() == earliest) {
                        to_play.push_back ((*i)->note());
                }
                (*i)->move_event(dx, dy);
@@ -2558,7 +2539,7 @@ MidiRegionView::get_end_position_pixels()
 }
 
 framepos_t
-MidiRegionView::source_beats_to_absolute_frames(double beats) const
+MidiRegionView::source_beats_to_absolute_frames(Evoral::MusicalTime beats) const
 {
        /* the time converter will return the frame corresponding to `beats'
           relative to the start of the source. The start of the source
@@ -2568,7 +2549,7 @@ MidiRegionView::source_beats_to_absolute_frames(double beats) const
        return  source_start +  _source_relative_time_converter.to (beats);
 }
 
-double
+Evoral::MusicalTime
 MidiRegionView::absolute_frames_to_source_beats(framepos_t frames) const
 {
        /* the `frames' argument needs to be converted into a frame count
@@ -2580,12 +2561,12 @@ MidiRegionView::absolute_frames_to_source_beats(framepos_t frames) const
 }
 
 framepos_t
-MidiRegionView::region_beats_to_region_frames(double beats) const
+MidiRegionView::region_beats_to_region_frames(Evoral::MusicalTime beats) const
 {
        return _region_relative_time_converter.to(beats);
 }
 
-double
+Evoral::MusicalTime
 MidiRegionView::region_frames_to_region_beats(framepos_t frames) const
 {
        return _region_relative_time_converter.from(frames);
@@ -2610,7 +2591,7 @@ MidiRegionView::begin_resizing (bool /*at_front*/)
 
                        // calculate the colors: get the color settings
                        uint32_t fill_color = UINT_RGBA_CHANGE_A(
-                               ARDOUR_UI::config()->get_MidiNoteSelected(),
+                               ARDOUR_UI::config()->color ("midi note selected"),
                                128);
 
                        // make the resize preview notes more transparent and bright
@@ -2623,7 +2604,7 @@ MidiRegionView::begin_resizing (bool /*at_front*/)
                                0.85));
 
                        resize_rect->set_outline_color (NoteBase::calculate_outline (
-                                                               ARDOUR_UI::config()->get_MidiNoteSelected()));
+                                                               ARDOUR_UI::config()->color ("midi note selected")));
 
                        resize_data->resize_rect = resize_rect;
                        _resize_data.push_back(resize_data);
@@ -2682,30 +2663,23 @@ MidiRegionView::update_resizing (NoteBase* primary, bool at_front, double delta_
                }
 
                if (!cursor_set) {
-                       double beats;
-
-                       beats = snap_pixel_to_sample (current_x);
-                       beats = region_frames_to_region_beats (beats);
-
-                       double len;
+                       const double        snapped_x = snap_pixel_to_sample (current_x);
+                       Evoral::MusicalTime beats     = region_frames_to_region_beats (snapped_x);
+                       Evoral::MusicalTime len       = Evoral::MusicalTime();
 
                        if (at_front) {
                                if (beats < canvas_note->note()->end_time()) {
                                        len = canvas_note->note()->time() - beats;
                                        len += canvas_note->note()->length();
-                               } else {
-                                       len = 0;
                                }
                        } else {
                                if (beats >= canvas_note->note()->time()) {
                                        len = beats - canvas_note->note()->time();
-                               } else {
-                                       len = 0;
                                }
                        }
 
                        char buf[16];
-                       snprintf (buf, sizeof (buf), "%.3g beats", len);
+                       snprintf (buf, sizeof (buf), "%.3g beats", len.to_double());
                        show_verbose_cursor (buf, 0, 0);
 
                        cursor_set = true;
@@ -2758,24 +2732,23 @@ MidiRegionView::commit_resizing (NoteBase* primary, bool at_front, double delta_
                current_x = snap_pixel_to_sample (current_x) + _region->start ();
 
                /* and then to beats */
-               current_x = region_frames_to_region_beats (current_x);
+               const Evoral::MusicalTime x_beats = region_frames_to_region_beats (current_x);
 
-               if (at_front && current_x < canvas_note->note()->end_time()) {
-                       note_diff_add_change (canvas_note, MidiModel::NoteDiffCommand::StartTime, current_x);
+               if (at_front && x_beats < canvas_note->note()->end_time()) {
+                       note_diff_add_change (canvas_note, MidiModel::NoteDiffCommand::StartTime, x_beats);
 
-                       double len = canvas_note->note()->time() - current_x;
+                       Evoral::MusicalTime len = canvas_note->note()->time() - x_beats;
                        len += canvas_note->note()->length();
 
-                       if (len > 0) {
-                               /* XXX convert to beats */
+                       if (!!len) {
                                note_diff_add_change (canvas_note, MidiModel::NoteDiffCommand::Length, len);
                        }
                }
 
                if (!at_front) {
-                       double len = current_x - canvas_note->note()->time();
+                       const Evoral::MusicalTime len = x_beats - canvas_note->note()->time();
 
-                       if (len > 0) {
+                       if (!!len) {
                                /* XXX convert to beats */
                                note_diff_add_change (canvas_note, MidiModel::NoteDiffCommand::Length, len);
                        }
@@ -2837,8 +2810,8 @@ MidiRegionView::trim_note (NoteBase* event, Evoral::MusicalTime front_delta, Evo
 {
        bool change_start = false;
        bool change_length = false;
-       Evoral::MusicalTime new_start = 0;
-       Evoral::MusicalTime new_length = 0;
+       Evoral::MusicalTime new_start;
+       Evoral::MusicalTime new_length;
 
        /* NOTE: the semantics of the two delta arguments are slightly subtle:
 
@@ -2849,11 +2822,11 @@ MidiRegionView::trim_note (NoteBase* event, Evoral::MusicalTime front_delta, Evo
           if negative - move the end of the note earlier in time (shortening it)
        */
 
-       if (front_delta) {
+       if (!!front_delta) {
                if (front_delta < 0) {
 
                        if (event->note()->time() < -front_delta) {
-                               new_start = 0;
+                               new_start = Evoral::MusicalTime();
                        } else {
                                new_start = event->note()->time() + front_delta; // moves earlier
                        }
@@ -2881,7 +2854,7 @@ MidiRegionView::trim_note (NoteBase* event, Evoral::MusicalTime front_delta, Evo
 
        }
 
-       if (end_delta) {
+       if (!!end_delta) {
                bool can_change = true;
                if (end_delta < 0) {
                        if (event->note()->length() < -end_delta) {
@@ -2934,7 +2907,7 @@ MidiRegionView::change_note_time (NoteBase* event, Evoral::MusicalTime delta, bo
        if (relative) {
                if (delta < 0.0) {
                        if (event->note()->time() < -delta) {
-                               new_time = 0;
+                               new_time = Evoral::MusicalTime();
                        } else {
                                new_time = event->note()->time() + delta;
                        }
@@ -3063,18 +3036,12 @@ MidiRegionView::transpose (bool up, bool fine, bool allow_smush)
 void
 MidiRegionView::change_note_lengths (bool fine, bool shorter, Evoral::MusicalTime delta, bool start, bool end)
 {
-       if (delta == 0.0) {
+       if (!delta) {
                if (fine) {
-                       delta = 1.0/128.0;
+                       delta = Evoral::MusicalTime(1.0/128.0);
                } else {
                        /* grab the current grid distance */
-                       bool success;
-                       delta = trackview.editor().get_grid_type_as_beats (success, _region->position());
-                       if (!success) {
-                               /* XXX cannot get grid type as beats ... should always be possible ... FIX ME */
-                               error << string_compose (_("programming error: %1"), "Grid type not available as beats - TO BE FIXED") << endmsg;
-                               return;
-                       }
+                       delta = get_grid_beats(_region->position());
                }
        }
 
@@ -3090,7 +3057,9 @@ MidiRegionView::change_note_lengths (bool fine, bool shorter, Evoral::MusicalTim
 
                /* note the negation of the delta for start */
 
-               trim_note (*i, (start ? -delta : 0), (end ? delta : 0));
+               trim_note (*i,
+                          (start ? -delta : Evoral::MusicalTime()),
+                          (end   ? delta  : Evoral::MusicalTime()));
                i = next;
        }
 
@@ -3099,7 +3068,7 @@ MidiRegionView::change_note_lengths (bool fine, bool shorter, Evoral::MusicalTim
 }
 
 void
-MidiRegionView::nudge_notes (bool forward)
+MidiRegionView::nudge_notes (bool forward, bool fine)
 {
        if (_selection.empty()) {
                return;
@@ -3110,15 +3079,21 @@ MidiRegionView::nudge_notes (bool forward)
           into a vector and sort before using the first one.
        */
 
-       framepos_t ref_point = source_beats_to_absolute_frames ((*(_selection.begin()))->note()->time());
-       framepos_t unused;
-       framecnt_t distance;
+       const framepos_t    ref_point = source_beats_to_absolute_frames ((*(_selection.begin()))->note()->time());
+       Evoral::MusicalTime delta;
+
+       if (!fine) {
 
-       if (trackview.editor().snap_mode() == Editing::SnapOff) {
+               /* non-fine, move by 1 bar regardless of snap */
+               delta = Evoral::MusicalTime(trackview.session()->tempo_map().meter_at(ref_point).divisions_per_bar());
+
+       } else if (trackview.editor().snap_mode() == Editing::SnapOff) {
 
                /* grid is off - use nudge distance */
 
-               distance = trackview.editor().get_nudge_distance (ref_point, unused);
+               framepos_t       unused;
+               const framecnt_t distance = trackview.editor().get_nudge_distance (ref_point, unused);
+               delta = region_frames_to_region_beats (fabs ((double)distance));
 
        } else {
 
@@ -3138,15 +3113,14 @@ MidiRegionView::nudge_notes (bool forward)
                }
 
                trackview.editor().snap_to (next_pos, (forward ? RoundUpAlways : RoundDownAlways), false);
-               distance = ref_point - next_pos;
+               const framecnt_t distance = ref_point - next_pos;
+               delta = region_frames_to_region_beats (fabs ((double)distance));
        }
 
-       if (distance == 0) {
+       if (!delta) {
                return;
        }
 
-       Evoral::MusicalTime delta = region_frames_to_region_beats (fabs ((double)distance));
-
        if (!forward) {
                delta = -delta;
        }
@@ -3252,7 +3226,7 @@ MidiRegionView::note_mouse_position (float x_fraction, float /*y_fraction*/, boo
 {
        Editor* editor = dynamic_cast<Editor*>(&trackview.editor());
        Editing::MouseMode mm = editor->current_mouse_mode();
-       bool trimmable = (mm == MouseObject || mm == MouseTimeFX || mm == MouseDraw);
+       bool trimmable = (mm == MouseContent || mm == MouseTimeFX || mm == MouseDraw);
 
        if (can_set_cursor) {
                if (trimmable && x_fraction > 0.0 && x_fraction < 0.2) {
@@ -3265,30 +3239,18 @@ MidiRegionView::note_mouse_position (float x_fraction, float /*y_fraction*/, boo
        }
 }
 
-void
-MidiRegionView::set_frame_color()
+uint32_t
+MidiRegionView::get_fill_color() const
 {
-       uint32_t f;
-
-       TimeAxisViewItem::set_frame_color ();
-
-       if (!frame) {
-               return;
-       }
-
+       const std::string mod_name = (_dragging ? "dragging region" :
+                                     trackview.editor().internal_editing() ? "editable region" :
+                                     "midi frame base");
        if (_selected) {
-               f = ARDOUR_UI::config()->get_SelectedFrameBase();
-       } else if (high_enough_for_name) {
-               f= ARDOUR_UI::config()->get_MidiFrameBase();
-       } else {
-               f = fill_color;
-       }
-
-       if (!rect_visible) {
-               f = UINT_RGBA_CHANGE_A (f, 80);
+               return ARDOUR_UI::config()->color_mod ("selected region base", mod_name);
+       } else if (high_enough_for_name || !ARDOUR_UI::config()->get_color_regions_using_track_color()) {
+               return ARDOUR_UI::config()->color_mod ("midi frame base", mod_name);
        }
-
-       frame->set_fill_color (f);
+       return ARDOUR_UI::config()->color_mod (fill_color, mod_name);
 }
 
 void
@@ -3376,29 +3338,22 @@ MidiRegionView::selection_as_cut_buffer () const
 
 /** This method handles undo */
 bool
-MidiRegionView::paste (framepos_t pos, unsigned paste_count, float times, const ::Selection& selection, ItemCounts& counts)
+MidiRegionView::paste (framepos_t pos, const ::Selection& selection, PasteContext& ctx)
 {
-       // Get our set of notes from the selection
-       MidiNoteSelection::const_iterator m = selection.midi_notes.get_nth(counts.n_notes());
-       if (m == selection.midi_notes.end()) {
-               return false;
+       // Paste notes, if available
+       MidiNoteSelection::const_iterator m = selection.midi_notes.get_nth(ctx.counts.n_notes());
+       if (m != selection.midi_notes.end()) {
+               ctx.counts.increase_n_notes();
+               paste_internal(pos, ctx.count, ctx.times, **m);
        }
-       counts.increase_n_notes();
-
-       trackview.session()->begin_reversible_command (Operations::paste);
 
-       // Paste notes
-       paste_internal(pos, paste_count, times, **m);
-
-       // Paste control points to automation children
+       // Paste control points to automation children, if available
        typedef RouteTimeAxisView::AutomationTracks ATracks;
        const ATracks& atracks = midi_view()->automation_tracks();
        for (ATracks::const_iterator a = atracks.begin(); a != atracks.end(); ++a) {
-               a->second->paste(pos, paste_count, times, selection, counts);
+               a->second->paste(pos, selection, ctx);
        }
 
-       trackview.session()->commit_reversible_command ();
-
        return true;
 }
 
@@ -3410,24 +3365,16 @@ MidiRegionView::paste_internal (framepos_t pos, unsigned paste_count, float time
                return;
        }
 
-       PublicEditor& editor = trackview.editor ();
-
        start_note_diff_command (_("paste"));
 
-       /* get snap duration, default to 1 beat if not snapped to anything musical */
-       bool   success    = true;
-       double snap_beats = editor.get_grid_type_as_beats(success, pos);
-       if (!success) {
-               snap_beats = 1.0;
-       }
-
+       const Evoral::MusicalTime snap_beats    = get_grid_beats(pos);
        const Evoral::MusicalTime first_time    = (*mcb.notes().begin())->time();
        const Evoral::MusicalTime last_time     = (*mcb.notes().rbegin())->end_time();
        const Evoral::MusicalTime duration      = last_time - first_time;
-       const Evoral::MusicalTime snap_duration = ceil(duration / snap_beats) * snap_beats;
-       const Evoral::MusicalTime paste_offset  = paste_count * snap_duration;
+       const Evoral::MusicalTime snap_duration = duration.snap_to(snap_beats);
+       const Evoral::MusicalTime paste_offset  = snap_duration * paste_count;
        const Evoral::MusicalTime pos_beats     = absolute_frames_to_source_beats(pos) + paste_offset;
-       Evoral::MusicalTime       end_point     = 0;
+       Evoral::MusicalTime       end_point     = Evoral::MusicalTime();
 
        DEBUG_TRACE (DEBUG::CutNPaste, string_compose ("Paste data spans from %1 to %2 (%3) ; paste pos beats = %4 (based on %5 - %6)\n",
                                                       first_time,
@@ -3585,6 +3532,8 @@ MidiRegionView::selection_as_notelist (Notes& selected, bool allow_all_if_none_s
 void
 MidiRegionView::update_ghost_note (double x, double y)
 {
+       x = std::max(0.0, x);
+
        MidiTimeAxisView* const mtv = dynamic_cast<MidiTimeAxisView*>(&trackview);
 
        _last_ghost_x = x;
@@ -3601,18 +3550,14 @@ MidiRegionView::update_ghost_note (double x, double y)
        /* use region_frames... because we are converting a delta within the region
        */
         
-       bool success;
-       double length = editor.get_grid_type_as_beats (success, unsnapped_frame);
-
-       if (!success) {
-               length = 1;
-       }
+       const Evoral::MusicalTime length = get_grid_beats(unsnapped_frame);
 
        /* note that this sets the time of the ghost note in beats relative to
           the start of the source; that is how all note times are stored.
        */
        _ghost_note->note()->set_time (
-               std::max(0.0, absolute_frames_to_source_beats (f + _region->position ())));
+               std::max(Evoral::MusicalTime(),
+                        absolute_frames_to_source_beats (f + _region->position ())));
        _ghost_note->note()->set_length (length);
        _ghost_note->note()->set_note (midi_stream_view()->y_to_note (y));
        _ghost_note->note()->set_channel (mtv->get_channel_for_add ());
@@ -3632,13 +3577,9 @@ MidiRegionView::create_ghost_note (double x, double y)
        _ghost_note = new Note (*this, _note_group, g);
        _ghost_note->set_ignore_events (true);
        _ghost_note->set_outline_color (0x000000aa);
-       if (x < 0) { x = 0; }
        update_ghost_note (x, y);
        _ghost_note->show ();
 
-       _last_ghost_x = x;
-       _last_ghost_y = y;
-
        show_verbose_cursor (_ghost_note->note ());
 }
 
@@ -3668,6 +3609,8 @@ MidiRegionView::drop_down_keys ()
 void
 MidiRegionView::maybe_select_by_position (GdkEventButton* ev, double /*x*/, double y)
 {
+       /* XXX: This is dead code.  What was it for? */
+
        double note = midi_stream_view()->y_to_note(y);
        Events e;
        MidiTimeAxisView* const mtv = dynamic_cast<MidiTimeAxisView*>(&trackview);
@@ -3789,8 +3732,6 @@ MidiRegionView::data_recorded (boost::weak_ptr<MidiSource> w)
 
        boost::shared_ptr<MidiBuffer> buf = mtv->midi_track()->get_gui_feed_buffer ();
 
-       BeatsFramesConverter converter (trackview.session()->tempo_map(), mtv->midi_track()->get_capture_start_frame (0));
-
        framepos_t back = max_framepos;
 
        for (MidiBuffer::iterator i = buf->begin(); i != buf->end(); ++i) {
@@ -3804,16 +3745,12 @@ MidiRegionView::data_recorded (boost::weak_ptr<MidiSource> w)
                        }
                }
 
-               /* ev.time() is in session frames, so (ev.time() - converter.origin_b()) is
-                  frames from the start of the source, and so time_beats is in terms of the
-                  source.
-               */
-
-               Evoral::MusicalTime const time_beats = converter.from (ev.time () - converter.origin_b ());
+               /* convert from session frames to source beats */
+               Evoral::MusicalTime const time_beats = _source_relative_time_converter.from(ev.time());
 
                if (ev.type() == MIDI_CMD_NOTE_ON) {
                        boost::shared_ptr<NoteType> note (
-                               new NoteType (ev.channel(), time_beats, 0, ev.note(), ev.velocity()));
+                               new NoteType (ev.channel(), time_beats, Evoral::MusicalTime(), ev.note(), ev.velocity()));
 
                        add_note (note, true);
 
@@ -3906,8 +3843,8 @@ MidiRegionView::show_verbose_cursor (boost::shared_ptr<NoteType> n) const
                        get_patch_key_at(n->time(), n->channel(), patch_key);
                        name = device_names->note_name(mtv->gui_property(X_("midnam-custom-device-mode")),
                                                       n->channel(),
-                                                      patch_key.bank_number,
-                                                      patch_key.program_number,
+                                                      patch_key.bank(),
+                                                      patch_key.program(),
                                                       n->note());
                }
        }
@@ -3939,13 +3876,8 @@ MidiRegionView::snap_frame_to_grid_underneath (framepos_t p, framecnt_t& grid_fr
 {
        PublicEditor& editor = trackview.editor ();
        
-       bool success;
-       Evoral::MusicalTime grid_beats = editor.get_grid_type_as_beats (success, p);
+       const Evoral::MusicalTime grid_beats = get_grid_beats(p);
 
-       if (!success) {
-               grid_beats = 1;
-       }
-       
        grid_frames = region_beats_to_region_frames (grid_beats);
 
        /* Hack so that we always snap to the note that we are over, instead of snapping
@@ -3993,3 +3925,15 @@ MidiRegionView::get_selected_channels () const
        return rtav->midi_track()->get_playback_channel_mask();
 }
 
+
+Evoral::MusicalTime
+MidiRegionView::get_grid_beats(framepos_t pos) const
+{
+       PublicEditor&       editor  = trackview.editor();
+       bool                success = false;
+       Evoral::MusicalTime beats   = editor.get_grid_type_as_beats(success, pos);
+       if (!success) {
+               beats = Evoral::MusicalTime(1);
+       }
+       return beats;
+}