store void pointers to processor UIs in Processors, and reset ProcessorWindowProxy...
[ardour.git] / gtk2_ardour / processor_box.cc
index de4af60136465e048f4cd01cda1affcc0ea9ddcf..7dc2f4f25f4013b29b07113f64f568b0ea6eb5a2 100644 (file)
 #include <gtkmm2ext/utils.h>
 #include <gtkmm2ext/choice.h>
 #include <gtkmm2ext/utils.h>
-#include <gtkmm2ext/stop_signal.h>
 #include <gtkmm2ext/doi.h>
 
 #include "ardour/amp.h"
 #include "ardour/ardour.h"
-#include "ardour/audio_diskstream.h"
 #include "ardour/audio_track.h"
 #include "ardour/audioengine.h"
 #include "ardour/internal_send.h"
+#include "ardour/internal_return.h"
 #include "ardour/ladspa_plugin.h"
 #include "ardour/meter.h"
 #include "ardour/plugin_insert.h"
@@ -55,6 +54,7 @@
 #include "ardour/route.h"
 #include "ardour/send.h"
 #include "ardour/session.h"
+#include "ardour/dB.h"
 
 #include "actions.h"
 #include "ardour_dialog.h"
@@ -66,6 +66,7 @@
 #include "mixer_strip.h"
 #include "plugin_selector.h"
 #include "plugin_ui.h"
+#include "port_insert_ui.h"
 #include "processor_box.h"
 #include "public_editor.h"
 #include "return_ui.h"
@@ -89,26 +90,48 @@ using namespace Gtkmm2ext;
 ProcessorBox* ProcessorBox::_current_processor_box = 0;
 RefPtr<Action> ProcessorBox::paste_action;
 RefPtr<Action> ProcessorBox::cut_action;
+RefPtr<Action> ProcessorBox::rename_action;
+RefPtr<Action> ProcessorBox::edit_action;
 Glib::RefPtr<Gdk::Pixbuf> SendProcessorEntry::_slider;
 
 ProcessorEntry::ProcessorEntry (boost::shared_ptr<Processor> p, Width w)
-       : _processor (p)
+       : _position (PreFader)
+       , _processor (p)
        , _width (w)
+       , _visual_state (Gtk::STATE_NORMAL)
 {
        _hbox.pack_start (_active, false, false);
        _event_box.add (_name);
        _hbox.pack_start (_event_box, true, true);
        _vbox.pack_start (_hbox);
+       _frame.add (_vbox);
+
+       /* without this, the border is mis-drawn on some systems */
+       _vbox.set_border_width (1);
 
        _name.set_alignment (0, 0.5);
        _name.set_text (name ());
        _name.set_padding (2, 2);
-       
+
+       if (boost::dynamic_pointer_cast<Amp> (p)) {
+               /* Fader processor gets a special look */
+               _event_box.set_name ("ProcessorFader");
+               _frame.set_name ("ProcessorFaderFrame");
+               _name.set_padding (2, 4);
+       }
+
        _active.set_active (_processor->active ());
        _active.signal_toggled().connect (sigc::mem_fun (*this, &ProcessorEntry::active_toggled));
+
+       _frame.show ();
+       _vbox.show ();
+       _hbox.show ();
+       _event_box.show ();
+       _name.show ();
+       _active.show ();
        
-       _processor->ActiveChanged.connect (active_connection, boost::bind (&ProcessorEntry::processor_active_changed, this), gui_context());
-       _processor->PropertyChanged.connect (name_connection, ui_bind (&ProcessorEntry::processor_property_changed, this, _1), gui_context());
+       _processor->ActiveChanged.connect (active_connection, invalidator (*this), boost::bind (&ProcessorEntry::processor_active_changed, this), gui_context());
+       _processor->PropertyChanged.connect (name_connection, invalidator (*this), ui_bind (&ProcessorEntry::processor_property_changed, this, _1), gui_context());
 }
 
 EventBox&
@@ -120,7 +143,7 @@ ProcessorEntry::action_widget ()
 Gtk::Widget&
 ProcessorEntry::widget ()
 {
-       return _vbox;
+       return _frame;
 }
 
 string
@@ -129,6 +152,66 @@ ProcessorEntry::drag_text () const
        return name ();
 }
 
+void
+ProcessorEntry::set_visual_state (Gtk::StateType t)
+{
+       _visual_state = t;
+       setup_visuals ();
+}
+
+void
+ProcessorEntry::set_position (Position p)
+{
+       _position = p;
+       setup_visuals ();
+}
+
+void
+ProcessorEntry::setup_visuals ()
+{
+       switch (_position) {
+       case PreFader:
+               _event_box.set_name ("ProcessorPreFader");
+               if (_visual_state == Gtk::STATE_NORMAL) {
+                       _frame.set_name ("ProcessorPreFaderFrame");
+               }
+               break;
+
+       case Fader:
+               _event_box.set_name ("ProcessorFader");
+               if (_visual_state == Gtk::STATE_NORMAL) {
+                       _frame.set_name ("ProcessorFaderFrame");
+               }
+               break;
+
+       case PostFader:
+               _event_box.set_name ("ProcessorPostFader");
+               if (_visual_state == Gtk::STATE_NORMAL) {
+                       _frame.set_name ("ProcessorPostFaderFrame");
+               }
+               break;
+       }
+
+       switch (_visual_state) {
+       case Gtk::STATE_NORMAL:
+               /* _frame has been set up above */
+               _event_box.set_state (Gtk::STATE_NORMAL);
+               break;
+       case Gtk::STATE_SELECTED:
+               _frame.set_name ("ProcessorFrameSelected");
+               /* don't change the background of the box when it is selected */
+               _event_box.set_state (Gtk::STATE_NORMAL);
+               break;
+       case Gtk::STATE_ACTIVE:
+               _frame.set_name ("ProcessorFrameActiveSend");
+               _event_box.set_state (Gtk::STATE_ACTIVE);
+               break;
+       default:
+               break;
+       }
+}
+       
+
 boost::shared_ptr<Processor>
 ProcessorEntry::processor () const
 {
@@ -177,10 +260,6 @@ ProcessorEntry::name () const
        boost::shared_ptr<Send> send;
        string name_display;
        
-       if (!_processor->active()) {
-               name_display = " (";
-       }
-       
        if ((send = boost::dynamic_pointer_cast<Send> (_processor)) != 0 &&
            !boost::dynamic_pointer_cast<InternalSend>(_processor)) {
                
@@ -214,25 +293,25 @@ ProcessorEntry::name () const
                
        }
        
-       if (!_processor->active()) {
-               name_display += ')';
-       }
-       
        return name_display;
 }
 
 SendProcessorEntry::SendProcessorEntry (boost::shared_ptr<Send> s, Width w)
        : ProcessorEntry (s, w),
          _send (s),
-         _adjustment (0, 0, 1, 0.01, 0.1),
+         /* set the adjustment to a gain of 0dB so that the fader's default value is right */
+         _adjustment (0.781787, 0, 1, 0.01, 0.1),
          _fader (_slider, &_adjustment, 0, false),
          _ignore_gain_change (false)
 {
+       _fader.set_name ("SendFader");
        _fader.set_controllable (_send->amp()->gain_control ());
        _vbox.pack_start (_fader);
 
+       _fader.show ();
+
        _adjustment.signal_value_changed().connect (sigc::mem_fun (*this, &SendProcessorEntry::gain_adjusted));
-       _send->amp()->gain_control()->Changed.connect (send_gain_connection, boost::bind (&SendProcessorEntry::show_gain, this), gui_context());
+       _send->amp()->gain_control()->Changed.connect (send_gain_connection, invalidator (*this), boost::bind (&SendProcessorEntry::show_gain, this), gui_context());
        show_gain ();
 }
 
@@ -254,6 +333,12 @@ SendProcessorEntry::show_gain ()
                _ignore_gain_change = true;
                _adjustment.set_value (value);
                _ignore_gain_change = false;
+
+               stringstream s;
+               s.precision (1);
+               s.setf (ios::fixed, ios::floatfield);
+               s << accurate_coefficient_to_dB (_send->amp()->gain ()) << _("dB");
+               _fader.set_tooltip_text (s.str ());
        }
 }
 
@@ -273,6 +358,82 @@ SendProcessorEntry::set_pixel_width (int p)
        _fader.set_fader_length (p);
 }
 
+PluginInsertProcessorEntry::PluginInsertProcessorEntry (boost::shared_ptr<ARDOUR::PluginInsert> p, Width w)
+       : ProcessorEntry (p, w)
+       , _plugin_insert (p)
+{
+       p->SplittingChanged.connect (
+               _splitting_connection, invalidator (*this), ui_bind (&PluginInsertProcessorEntry::plugin_insert_splitting_changed, this), gui_context()
+               );
+
+       _splitting_icon.set_size_request (-1, 12);
+
+       _vbox.pack_start (_splitting_icon);
+       _vbox.reorder_child (_splitting_icon, 0);
+
+       plugin_insert_splitting_changed ();
+}
+
+void
+PluginInsertProcessorEntry::plugin_insert_splitting_changed ()
+{
+       if (_plugin_insert->splitting ()) {
+               _splitting_icon.show ();
+       } else {
+               _splitting_icon.hide ();
+       }
+}
+
+void
+PluginInsertProcessorEntry::setup_visuals ()
+{
+       switch (_position) {
+       case PreFader:
+               _splitting_icon.set_name ("ProcessorPreFader");
+               break;
+
+       case Fader:
+               _splitting_icon.set_name ("ProcessorFader");
+               break;
+
+       case PostFader:
+               _splitting_icon.set_name ("ProcessorPostFader");
+               break;
+       }
+
+       ProcessorEntry::setup_visuals ();
+}
+
+bool
+PluginInsertProcessorEntry::SplittingIcon::on_expose_event (GdkEventExpose* ev)
+{
+       cairo_t* cr = gdk_cairo_create (get_window()->gobj());
+
+       cairo_set_line_width (cr, 1);
+
+       double const width = ev->area.width;
+       double const height = ev->area.height;
+
+       Gdk::Color const bg = get_style()->get_bg (STATE_NORMAL);
+       cairo_set_source_rgb (cr, bg.get_red_p (), bg.get_green_p (), bg.get_blue_p ());
+       
+       cairo_rectangle (cr, 0, 0, width, height);
+       cairo_fill (cr);
+
+       Gdk::Color const fg = get_style()->get_fg (STATE_NORMAL);
+       cairo_set_source_rgb (cr, fg.get_red_p (), fg.get_green_p (), fg.get_blue_p ());
+
+       cairo_move_to (cr, width * 0.3, height);
+       cairo_line_to (cr, width * 0.3, height * 0.5);
+       cairo_line_to (cr, width * 0.7, height * 0.5);
+       cairo_line_to (cr, width * 0.7, height);
+       cairo_move_to (cr, width * 0.5, height * 0.5);
+       cairo_line_to (cr, width * 0.5, 0);
+       cairo_stroke (cr);
+
+       return true;
+}
+
 ProcessorBox::ProcessorBox (ARDOUR::Session* sess, boost::function<PluginSelector*()> get_plugin_selector,
                            RouteRedirectSelection& rsel, MixerStrip* parent, bool owner_is_mixer)
        : _parent_strip (parent)
@@ -294,9 +455,10 @@ ProcessorBox::ProcessorBox (ARDOUR::Session* sess, boost::function<PluginSelecto
        pack_start (processor_scroller, true, true);
 
        processor_display.set_flags (CAN_FOCUS);
-       processor_display.set_name ("ProcessorSelector");
+       processor_display.set_name ("ProcessorList");
        processor_display.set_size_request (48, -1);
        processor_display.set_data ("processorbox", this);
+       processor_display.set_spacing (2);
 
        processor_display.signal_enter_notify_event().connect (sigc::mem_fun(*this, &ProcessorBox::enter_notify), false);
        processor_display.signal_leave_notify_event().connect (sigc::mem_fun(*this, &ProcessorBox::leave_notify), false);
@@ -310,6 +472,15 @@ ProcessorBox::ProcessorBox (ARDOUR::Session* sess, boost::function<PluginSelecto
        processor_display.Reordered.connect (sigc::mem_fun (*this, &ProcessorBox::reordered));
        processor_display.DropFromAnotherBox.connect (sigc::mem_fun (*this, &ProcessorBox::object_drop));
        processor_display.SelectionChanged.connect (sigc::mem_fun (*this, &ProcessorBox::selection_changed));
+
+       processor_scroller.show ();
+       processor_display.show ();
+
+       if (parent) {
+               parent->DeliveryChanged.connect (
+                       _mixer_strip_connections, invalidator (*this), ui_bind (&ProcessorBox::mixer_strip_delivery_changed, this, _1), gui_context ()
+                       );
+       }
 }
 
 ProcessorBox::~ProcessorBox ()
@@ -323,15 +494,23 @@ ProcessorBox::set_route (boost::shared_ptr<Route> r)
                return;
        }
        
-       connections.drop_connections();
+       _route_connections.drop_connections();
 
        /* new route: any existing block on processor redisplay must be meaningless */
        no_processor_redisplay = false;
        _route = r;
 
-       _route->processors_changed.connect (connections, ui_bind (&ProcessorBox::route_processors_changed, this, _1), gui_context());
-       _route->DropReferences.connect (connections, boost::bind (&ProcessorBox::route_going_away, this), gui_context());
-       _route->PropertyChanged.connect (connections, ui_bind (&ProcessorBox::route_property_changed, this, _1), gui_context());
+       _route->processors_changed.connect (
+               _route_connections, invalidator (*this), ui_bind (&ProcessorBox::route_processors_changed, this, _1), gui_context()
+               );
+       
+       _route->DropReferences.connect (
+               _route_connections, invalidator (*this), boost::bind (&ProcessorBox::route_going_away, this), gui_context()
+               );
+       
+       _route->PropertyChanged.connect (
+               _route_connections, invalidator (*this), ui_bind (&ProcessorBox::route_property_changed, this, _1), gui_context()
+               );
 
        redisplay_processors ();
 }
@@ -401,28 +580,6 @@ ProcessorBox::set_width (Width w)
        redisplay_processors ();
 }
 
-void
-ProcessorBox::remove_processor_gui (boost::shared_ptr<Processor> processor)
-{
-       boost::shared_ptr<Send> send;
-       boost::shared_ptr<Return> retrn;
-       boost::shared_ptr<PortInsert> port_insert;
-
-       if ((port_insert = boost::dynamic_pointer_cast<PortInsert> (processor)) != 0) {
-               PortInsertUI *io_selector = reinterpret_cast<PortInsertUI *> (port_insert->get_gui());
-               port_insert->set_gui (0);
-               delete io_selector;
-       } else if ((send = boost::dynamic_pointer_cast<Send> (processor)) != 0) {
-               SendUIWindow *sui = reinterpret_cast<SendUIWindow*> (send->get_gui());
-               send->set_gui (0);
-               delete sui;
-       } else if ((retrn = boost::dynamic_pointer_cast<Return> (processor)) != 0) {
-               ReturnUIWindow *rui = reinterpret_cast<ReturnUIWindow*> (retrn->get_gui());
-               retrn->set_gui (0);
-               delete rui;
-       }
-}
-
 void
 ProcessorBox::build_send_action_menu ()
 {
@@ -544,7 +701,7 @@ ProcessorBox::processor_key_release_event (GdkEventKey *ev)
                int x, y;
                processor_display.get_pointer (x, y);
 
-               pair<ProcessorEntry *, int> const pointer = processor_display.get_child_at_position (x, y);
+               pair<ProcessorEntry *, double> const pointer = processor_display.get_child_at_position (y);
 
                if (pointer.first) {
                        targets.push_back (pointer.first->processor ());
@@ -635,7 +792,7 @@ ProcessorBox::processor_button_press_event (GdkEventButton *ev, ProcessorEntry*
 
                if (_session->engine().connected()) {
                        /* XXX giving an error message here is hard, because we may be in the midst of a button press */
-                       edit_processor (processor);
+                       toggle_edit_processor (processor);
                }
                ret = true;
 
@@ -714,17 +871,20 @@ ProcessorBox::build_processor_menu ()
 {
        processor_menu = dynamic_cast<Gtk::Menu*>(ActionManager::get_widget("/processormenu") );
        processor_menu->set_name ("ArdourContextMenu");
-
-       show_all_children();
-
        return processor_menu;
 }
 
 void
 ProcessorBox::selection_changed ()
 {
-       bool sensitive = (processor_display.selection().empty()) ? false : true;
+       bool const sensitive = (processor_display.selection().empty()) ? false : true;
        ActionManager::set_sensitive (ActionManager::plugin_selection_sensitive_actions, sensitive);
+       edit_action->set_sensitive (one_processor_can_be_edited ());
+
+       /* disallow rename for multiple selections and for plugin inserts */
+       rename_action->set_sensitive (
+               processor_display.selection().size() == 1 && boost::dynamic_pointer_cast<PluginInsert> (processor_display.selection().front()->processor()) == 0
+               );
 }
 
 void
@@ -745,7 +905,8 @@ ProcessorBox::choose_plugin ()
        _get_plugin_selector()->set_interested_object (*this);
 }
 
-void
+/** @return true if an error occurred, otherwise false */
+bool
 ProcessorBox::use_plugins (const SelectedPlugins& plugins)
 {
        for (SelectedPlugins::const_iterator p = plugins.begin(); p != plugins.end(); ++p) {
@@ -760,6 +921,7 @@ ProcessorBox::use_plugins (const SelectedPlugins& plugins)
 
                if (_route->add_processor (processor, _placement, &err_streams)) {
                        weird_plugin_dialog (**p, err_streams);
+                       return true;
                        // XXX SHAREDPTR delete plugin here .. do we even need to care?
                } else {
 
@@ -768,12 +930,14 @@ ProcessorBox::use_plugins (const SelectedPlugins& plugins)
                        }
                }
        }
+
+       return false;
 }
 
 void
 ProcessorBox::weird_plugin_dialog (Plugin& p, Route::ProcessorStreams streams)
 {
-       ArdourDialog dialog (_("ardour: weird plugin dialog"));
+       ArdourDialog dialog (_("Plugin Incompatibility"));
        Label label;
 
        string text = string_compose(_("You attempted to add the plugin \"%1\" at index %2.\n"),
@@ -784,18 +948,22 @@ ProcessorBox::weird_plugin_dialog (Plugin& p, Route::ProcessorStreams streams)
 
        text += _("\nThis plugin has:\n");
        if (has_midi) {
-               text += string_compose("\t%1 ", p.get_info()->n_inputs.n_midi()) + _("MIDI input(s)\n");
+               uint32_t const n = p.get_info()->n_inputs.n_midi ();
+               text += string_compose (ngettext ("\t%1 MIDI input", "\t%1 MIDI inputs", n), n);
        }
        if (has_audio) {
-               text += string_compose("\t%1 ", p.get_info()->n_inputs.n_audio()) + _("audio input(s)\n");
+               uint32_t const n = p.get_info()->n_inputs.n_audio ();
+               text += string_compose (ngettext ("\t%1 audio input", "\t%1 audio inputs", n), n);
        }
 
        text += _("\nBut at the insertion point, there are:\n");
        if (has_midi) {
-               text += string_compose("\t%1 ", streams.count.n_midi()) + _("MIDI channel(s)\n");
+               uint32_t const n = streams.count.n_midi ();
+               text += string_compose (ngettext ("\t%1 MIDI channel\n", "\t%1 MIDI channels\n", n), n);
        }
        if (has_audio) {
-               text += string_compose("\t%1 ", streams.count.n_audio()) + _("audio channel(s)\n");
+               uint32_t const n = streams.count.n_audio ();
+               text += string_compose (ngettext ("\t%1 audio channel\n", "\t%1 audio channels\n", n), n);
        }
 
        text += string_compose (_("\n%1 is unable to insert this plugin here.\n"), PROGRAM_NAME);
@@ -815,14 +983,15 @@ ProcessorBox::weird_plugin_dialog (Plugin& p, Route::ProcessorStreams streams)
 void
 ProcessorBox::choose_insert ()
 {
-       boost::shared_ptr<Processor> processor (new PortInsert (*_session, _route->mute_master()));
+       boost::shared_ptr<Processor> processor (new PortInsert (*_session, _route->pannable(), _route->mute_master()));
        _route->add_processor (processor, _placement);
 }
 
+/* Caller must not hold process lock */
 void
 ProcessorBox::choose_send ()
 {
-       boost::shared_ptr<Send> send (new Send (*_session, _route->mute_master()));
+       boost::shared_ptr<Send> send (new Send (*_session, _route->pannable(), _route->mute_master()));
 
        /* make an educated guess at the initial number of outputs for the send */
        ChanCount outs = (_session->master_out())
@@ -831,6 +1000,7 @@ ProcessorBox::choose_send ()
 
        /* XXX need processor lock on route */
        try {
+               Glib::Mutex::Lock lm (AudioEngine::instance()->process_lock());
                send->output()->ensure_io (outs, false, this);
        } catch (AudioEngine::PortRegistrationFailure& err) {
                error << string_compose (_("Cannot set up new send: %1"), err.what()) << endmsg;
@@ -845,7 +1015,7 @@ ProcessorBox::choose_send ()
         */
 
        IOSelectorWindow *ios = new IOSelectorWindow (_session, send->output(), true);
-       ios->show_all ();
+       ios->show ();
 
        /* keep a reference to the send so it doesn't get deleted while
           the IOSelectorWindow is doing its stuff
@@ -957,7 +1127,89 @@ ProcessorBox::redisplay_processors ()
 
        _route->foreach_processor (sigc::mem_fun (*this, &ProcessorBox::add_processor_to_display));
 
-       build_processor_tooltip (processor_eventbox, _("Inserts, sends & plugins:"));
+       for (list<ProcessorWindowProxy*>::iterator i = _processor_window_proxies.begin(); i != _processor_window_proxies.end(); ++i) {
+               (*i)->marked = false;
+       }
+               
+       _route->foreach_processor (sigc::mem_fun (*this, &ProcessorBox::maybe_add_processor_to_ui_list));
+
+       /* trim dead wood from the processor window proxy list */
+
+       list<ProcessorWindowProxy*>::iterator i = _processor_window_proxies.begin();
+       while (i != _processor_window_proxies.end()) {
+               list<ProcessorWindowProxy*>::iterator j = i;
+               ++j;
+
+               if (!(*i)->marked) {
+                       ARDOUR_UI::instance()->remove_window_proxy (*i);
+                       delete *i;
+                       _processor_window_proxies.erase (i);
+               }
+
+               i = j;
+       }
+
+       setup_entry_positions ();
+}
+
+/** Add a ProcessorWindowProxy for a processor to our list, if that processor does
+ *  not already have one.
+ */
+void
+ProcessorBox::maybe_add_processor_to_ui_list (boost::weak_ptr<Processor> w)
+{
+       boost::shared_ptr<Processor> p = w.lock ();
+       if (!p) {
+               return;
+       }
+
+       list<ProcessorWindowProxy*>::iterator i = _processor_window_proxies.begin ();
+       while (i != _processor_window_proxies.end()) {
+
+               boost::shared_ptr<Processor> t = (*i)->processor().lock ();
+               
+               if (p == t) {
+                       /* this processor is already on the list; done */
+                       (*i)->marked = true;
+                       return;
+               }
+
+               ++i;
+       }
+
+       /* not on the list; add it */
+
+       string loc;
+       if (_parent_strip) {
+               if (_parent_strip->mixer_owned()) {
+                       loc = X_("M");
+               } else {
+                       loc = X_("R");
+               }
+       } else {
+               loc = X_("P");
+       }
+       
+       ProcessorWindowProxy* wp = new ProcessorWindowProxy (
+               string_compose ("%1-%2-%3", loc, _route->id(), p->id()),
+               _session->extra_xml (X_("UI")),
+               this,
+               w);
+       
+       wp->marked = true;
+
+        /* if the processor already has an existing UI, 
+           note that so that we don't recreate it
+        */
+        
+        void* existing_ui = p->get_ui ();
+
+        if (existing_ui) {
+                wp->set (static_cast<Gtk::Window*>(existing_ui));
+        }
+
+       _processor_window_proxies.push_back (wp);
+       ARDOUR_UI::instance()->add_window_proxy (wp);
 }
 
 void
@@ -970,12 +1222,16 @@ ProcessorBox::add_processor_to_display (boost::weak_ptr<Processor> p)
        }
 
        boost::shared_ptr<Send> send = boost::dynamic_pointer_cast<Send> (processor);
+       boost::shared_ptr<PluginInsert> plugin_insert = boost::dynamic_pointer_cast<PluginInsert> (processor);
        ProcessorEntry* e = 0;
        if (send) {
                e = new SendProcessorEntry (send, _width);
+       } else if (plugin_insert) {
+               e = new PluginInsertProcessorEntry (plugin_insert, _width);
        } else {
                e = new ProcessorEntry (processor, _width);
        }
+       
        e->set_pixel_width (get_allocation().get_width());
        processor_display.add_child (e);
 }
@@ -999,6 +1255,27 @@ void
 ProcessorBox::reordered ()
 {
        compute_processor_sort_keys ();
+       setup_entry_positions ();
+}
+
+void
+ProcessorBox::setup_entry_positions ()
+{
+       list<ProcessorEntry*> children = processor_display.children ();
+       bool pre_fader = true;
+       
+       for (list<ProcessorEntry*>::iterator i = children.begin(); i != children.end(); ++i) {
+               if (boost::dynamic_pointer_cast<Amp>((*i)->processor())) {
+                       pre_fader = false;
+                       (*i)->set_position (ProcessorEntry::Fader);
+               } else {
+                       if (pre_fader) {
+                               (*i)->set_position (ProcessorEntry::PreFader);
+                       } else {
+                               (*i)->set_position (ProcessorEntry::PostFader);
+                       }
+               }
+       }
 }
 
 void
@@ -1012,32 +1289,42 @@ ProcessorBox::compute_processor_sort_keys ()
        }
 
        if (_route->reorder_processors (our_processors)) {
+               /* Reorder failed, so report this to the user.  As far as I can see this must be done
+                  in an idle handler: it seems that the redisplay_processors() that happens below destroys
+                  widgets that were involved in the drag-and-drop on the processor list, which causes problems
+                  when the drag is torn down after this handler function is finished.
+               */
+               Glib::signal_idle().connect_once (sigc::mem_fun (*this, &ProcessorBox::report_failed_reorder));
+       }
+}
 
-               /* reorder failed, so redisplay */
-
-               redisplay_processors ();
-
-               /* now tell them about the problem */
-
-               ArdourDialog dialog (_("ardour: weird plugin dialog"));
-               Label label;
-
-               label.set_text (_("\
+void
+ProcessorBox::report_failed_reorder ()
+{
+       /* reorder failed, so redisplay */
+       
+       redisplay_processors ();
+       
+       /* now tell them about the problem */
+       
+       ArdourDialog dialog (_("Plugin Incompatibility"));
+       Label label;
+       
+       label.set_text (_("\
 You cannot reorder these plugins/sends/inserts\n\
 in that way because the inputs and\n\
 outputs will not work correctly."));
 
-               dialog.get_vbox()->set_border_width (12);
-               dialog.get_vbox()->pack_start (label);
-               dialog.add_button (Stock::OK, RESPONSE_ACCEPT);
-
-               dialog.set_name (X_("PluginIODialog"));
-               dialog.set_position (Gtk::WIN_POS_MOUSE);
-               dialog.set_modal (true);
-               dialog.show_all ();
-
-               dialog.run ();
-       }
+       dialog.get_vbox()->set_border_width (12);
+       dialog.get_vbox()->pack_start (label);
+       dialog.add_button (Stock::OK, RESPONSE_ACCEPT);
+       
+       dialog.set_name (X_("PluginIODialog"));
+       dialog.set_position (Gtk::WIN_POS_MOUSE);
+       dialog.set_modal (true);
+       dialog.show_all ();
+       
+       dialog.run ();
 }
 
 void
@@ -1102,10 +1389,10 @@ ProcessorBox::cut_processors (const ProcSelection& to_be_removed)
                    (boost::dynamic_pointer_cast<Send>((*i)) != 0) ||
                    (boost::dynamic_pointer_cast<Return>((*i)) != 0)) {
 
-                       void* gui = (*i)->get_gui ();
+                       Window* w = get_processor_ui (*i);
 
-                       if (gui) {
-                               static_cast<Gtk::Widget*>(gui)->hide ();
+                       if (w) {
+                               w->hide ();
                        }
 
                        XMLNode& child ((*i)->get_state());
@@ -1174,10 +1461,10 @@ ProcessorBox::delete_processors (const ProcSelection& targets)
 
        for (ProcSelection::const_iterator i = targets.begin(); i != targets.end(); ++i) {
 
-               void* gui = (*i)->get_gui ();
+               Window* w = get_processor_ui (*i);
 
-               if (gui) {
-                       static_cast<Gtk::Widget*>(gui)->hide ();
+               if (w) {
+                       w->hide ();
                }
 
                _route->remove_processor(*i);
@@ -1195,10 +1482,10 @@ ProcessorBox::delete_dragged_processors (const list<boost::shared_ptr<Processor>
        no_processor_redisplay = true;
        for (x = procs.begin(); x != procs.end(); ++x) {
 
-               void* gui = (*x)->get_gui ();
+               Window* w = get_processor_ui (*x);
 
-               if (gui) {
-                       static_cast<Gtk::Widget*>(gui)->hide ();
+               if (w) {
+                       w->hide ();
                }
 
                _route->remove_processor(*x);
@@ -1244,11 +1531,27 @@ ProcessorBox::rename_processor (boost::shared_ptr<Processor> processor)
        case Gtk::RESPONSE_ACCEPT:
                name_prompter.get_result (result);
                if (result.length()) {
-                       if (_session->route_by_name (result)) {
-                               ARDOUR_UI::instance()->popup_error (_("A track already exists with that name."));
-                               return;
-                       }
-                       processor->set_name (result);
+
+                       int tries = 0;
+                       string test = result;
+
+                       while (tries < 100) {
+                               if (_session->io_name_is_legal (test)) {
+                                       result = test;
+                                       break;
+                               }
+                               tries++;
+
+                               test = string_compose ("%1-%2", result, tries);
+                       }
+
+                       if (tries < 100) {
+                               processor->set_name (result);
+                       } else {
+                               /* unlikely! */
+                               ARDOUR_UI::instance()->popup_error
+                                       (string_compose (_("At least 100 IO objects exist with a name like %1 - name not changed"), result));
+                       }
                }
                break;
        }
@@ -1305,7 +1608,7 @@ ProcessorBox::paste_processor_state (const XMLNodeList& nlist, boost::shared_ptr
 
                                XMLNode n (**niter);
                                Send::make_unique (n, *_session);
-                                Send* s = new Send (*_session, _route->mute_master());
+                                Send* s = new Send (*_session, _route->pannable(), _route->mute_master());
                                 if (s->set_state (n, Stateful::loading_state_version)) {
                                         delete s;
                                         return;
@@ -1332,7 +1635,8 @@ ProcessorBox::paste_processor_state (const XMLNodeList& nlist, boost::shared_ptr
                                   is a plugin.
                                */
 
-                               p.reset (new PluginInsert (*_session, **niter));
+                               p.reset (new PluginInsert (*_session));
+                                p->set_state (**niter, Stateful::current_state_version);
                        }
 
                        copies.push_back (p);
@@ -1446,10 +1750,43 @@ ProcessorBox::clear_processors (Placement p)
        }
 }
 
+bool
+ProcessorBox::processor_can_be_edited (boost::shared_ptr<Processor> processor)
+{
+       boost::shared_ptr<AudioTrack> at = boost::dynamic_pointer_cast<AudioTrack> (_route);
+       if (at && at->freeze_state() == AudioTrack::Frozen) {
+               return false;
+       }
+
+       if (
+               boost::dynamic_pointer_cast<Send> (processor) ||
+               boost::dynamic_pointer_cast<Return> (processor) ||
+               boost::dynamic_pointer_cast<PluginInsert> (processor) ||
+               boost::dynamic_pointer_cast<PortInsert> (processor)
+               ) {
+               return true;
+       }
+
+       return false;
+}
+
+bool
+ProcessorBox::one_processor_can_be_edited ()
+{
+       list<ProcessorEntry*> selection = processor_display.selection ();
+       list<ProcessorEntry*>::iterator i = selection.begin();
+       while (i != selection.end() && processor_can_be_edited ((*i)->processor()) == false) {
+               ++i;
+       }
+
+       return (i != selection.end());
+}
+
 void
-ProcessorBox::edit_processor (boost::shared_ptr<Processor> processor)
+ProcessorBox::toggle_edit_processor (boost::shared_ptr<Processor> processor)
 {
        boost::shared_ptr<Send> send;
+       boost::shared_ptr<InternalSend> internal_send;
        boost::shared_ptr<Return> retrn;
        boost::shared_ptr<PluginInsert> plugin_insert;
        boost::shared_ptr<PortInsert> port_insert;
@@ -1462,33 +1799,40 @@ ProcessorBox::edit_processor (boost::shared_ptr<Processor> processor)
                }
        }
 
-       if ((send = boost::dynamic_pointer_cast<Send> (processor)) != 0) {
+       if (boost::dynamic_pointer_cast<Amp> (processor)) {
+
+               _parent_strip->revert_to_default_display ();
+               
+       } else if ((internal_send = boost::dynamic_pointer_cast<InternalSend> (processor)) != 0) {
 
                if (!_session->engine().connected()) {
                        return;
                }
 
-#ifdef OLD_SEND_EDITING
-               SendUIWindow *send_ui;
+               if (_parent_strip) {
+                       if (boost::dynamic_pointer_cast<Send> (_parent_strip->current_delivery()) == internal_send) {
+                               _parent_strip->revert_to_default_display ();
+                       } else {
+                               _parent_strip->show_send (internal_send);
+                       }
+               }
 
-               if (send->get_gui() == 0) {
-                       send_ui = new SendUIWindow (send, _session);
-                       send_ui->set_title (send->name());
-                       send->set_gui (send_ui);
+       } else if ((send = boost::dynamic_pointer_cast<Send> (processor)) != 0) {
 
-               } else {
-                       send_ui = reinterpret_cast<SendUIWindow *> (send->get_gui());
+               if (!_session->engine().connected()) {
+                       return;
                }
 
-               gidget = send_ui;
-#else
-               if (_parent_strip) {
-                       _parent_strip->show_send (send);
-               }
-#endif
+               SendUIWindow* w = new SendUIWindow (send, _session);
+               w->show ();
 
        } else if ((retrn = boost::dynamic_pointer_cast<Return> (processor)) != 0) {
 
+                if (boost::dynamic_pointer_cast<InternalReturn> (retrn)) {
+                        /* no GUI for these */
+                        return;
+                }
+
                if (!_session->engine().connected()) {
                        return;
                }
@@ -1496,15 +1840,16 @@ ProcessorBox::edit_processor (boost::shared_ptr<Processor> processor)
                boost::shared_ptr<Return> retrn = boost::dynamic_pointer_cast<Return> (processor);
 
                ReturnUIWindow *return_ui;
+               Window* w = get_processor_ui (retrn);
 
-               if (retrn->get_gui() == 0) {
+               if (w == 0) {
 
                        return_ui = new ReturnUIWindow (retrn, _session);
                        return_ui->set_title (retrn->name ());
-                       send->set_gui (return_ui);
+                       set_processor_ui (send, return_ui);
 
                } else {
-                       return_ui = reinterpret_cast<ReturnUIWindow *> (retrn->get_gui());
+                       return_ui = dynamic_cast<ReturnUIWindow *> (w);
                }
 
                gidget = return_ui;
@@ -1518,14 +1863,16 @@ ProcessorBox::edit_processor (boost::shared_ptr<Processor> processor)
                Container* toplevel = get_toplevel();
                Window* win = dynamic_cast<Gtk::Window*>(toplevel);
 
-               if (plugin_insert->get_gui() == 0) {
+               Window* w = get_processor_ui (plugin_insert);
+
+               if (w == 0) {
 
                        plugin_ui = new PluginUIWindow (win, plugin_insert);
                        plugin_ui->set_title (generate_processor_title (plugin_insert));
-                       plugin_insert->set_gui (plugin_ui);
+                       set_processor_ui (plugin_insert, plugin_ui);
 
                } else {
-                       plugin_ui = reinterpret_cast<PluginUIWindow *> (plugin_insert->get_gui());
+                       plugin_ui = dynamic_cast<PluginUIWindow *> (w);
                        plugin_ui->set_parent (win);
                }
 
@@ -1541,12 +1888,14 @@ ProcessorBox::edit_processor (boost::shared_ptr<Processor> processor)
 
                PortInsertWindow *io_selector;
 
-               if (port_insert->get_gui() == 0) {
+               Window* w = get_processor_ui (port_insert);
+
+               if (w == 0) {
                        io_selector = new PortInsertWindow (_session, port_insert);
-                       port_insert->set_gui (io_selector);
+                       set_processor_ui (port_insert, io_selector);
 
                } else {
-                       io_selector = reinterpret_cast<PortInsertWindow *> (port_insert->get_gui());
+                       io_selector = dynamic_cast<PortInsertWindow *> (w);
                }
 
                gidget = io_selector;
@@ -1554,7 +1903,7 @@ ProcessorBox::edit_processor (boost::shared_ptr<Processor> processor)
 
        if (gidget) {
                if (gidget->is_visible()) {
-                       gidget->get_window()->raise ();
+                       gidget->hide ();
                } else {
                        gidget->show_all ();
                        gidget->present ();
@@ -1602,9 +1951,8 @@ ProcessorBox::register_actions ()
 
        paste_action = ActionManager::register_action (popup_act_grp, X_("paste"), _("Paste"),
                        sigc::ptr_fun (ProcessorBox::rb_paste));
-       act = ActionManager::register_action (popup_act_grp, X_("rename"), _("Rename"),
+       rename_action = ActionManager::register_action (popup_act_grp, X_("rename"), _("Rename"),
                        sigc::ptr_fun (ProcessorBox::rb_rename));
-       ActionManager::plugin_selection_sensitive_actions.push_back(act);
        ActionManager::register_action (popup_act_grp, X_("selectall"), _("Select All"),
                        sigc::ptr_fun (ProcessorBox::rb_select_all));
        ActionManager::register_action (popup_act_grp, X_("deselectall"), _("Deselect All"),
@@ -1620,9 +1968,8 @@ ProcessorBox::register_actions ()
                                        sigc::ptr_fun (ProcessorBox::rb_ab_plugins));
 
        /* show editors */
-       act = ActionManager::register_action (popup_act_grp, X_("edit"), _("Edit"),
-                                             sigc::ptr_fun (ProcessorBox::rb_edit));
-       ActionManager::plugin_selection_sensitive_actions.push_back(act);
+       edit_action = ActionManager::register_action (popup_act_grp, X_("edit"), _("Edit..."),
+                                                     sigc::ptr_fun (ProcessorBox::rb_edit));
 
        ActionManager::add_action_group (popup_act_grp);
 }
@@ -1800,7 +2147,7 @@ ProcessorBox::rb_edit ()
                return;
        }
 
-       _current_processor_box->for_selected_processors (&ProcessorBox::edit_processor);
+       _current_processor_box->for_selected_processors (&ProcessorBox::toggle_edit_processor);
 }
 
 void
@@ -1822,18 +2169,18 @@ ProcessorBox::route_property_changed (const PropertyChange& what_changed)
 
                processor = (*iter)->processor ();
 
-               void* gui = processor->get_gui();
+               Window* w = get_processor_ui (processor);
 
-               if (!gui) {
+               if (!w) {
                        continue;
                }
 
                /* rename editor windows for sends and plugins */
 
                if ((send = boost::dynamic_pointer_cast<Send> (processor)) != 0) {
-                       static_cast<Window*>(gui)->set_title (send->name ());
+                       w->set_title (send->name ());
                } else if ((plugin_insert = boost::dynamic_pointer_cast<PluginInsert> (processor)) != 0) {
-                       static_cast<Window*>(gui)->set_title (generate_processor_title (plugin_insert));
+                       w->set_title (generate_processor_title (plugin_insert));
                }
        }
 }
@@ -1866,3 +2213,101 @@ ProcessorBox::on_size_allocate (Allocation& a)
                (*i)->set_pixel_width (a.get_width ());
        }
 }
+
+/** @param p Processor.
+ *  @return the UI window for \a p.
+ */
+Window *
+ProcessorBox::get_processor_ui (boost::shared_ptr<Processor> p) const
+{
+       list<ProcessorWindowProxy*>::const_iterator i = _processor_window_proxies.begin ();
+       while (i != _processor_window_proxies.end()) {
+               boost::shared_ptr<Processor> t = (*i)->processor().lock ();
+               if (t && t == p) {
+                       return (*i)->get ();
+               }
+
+               ++i;
+       }
+
+       /* we shouldn't get here, because the ProcessorUIList should always contain
+          an entry for each processor.
+       */
+       assert (false);
+       return 0;
+}
+
+/** Make a note of the UI window that a processor is using.
+ *  @param p Processor.
+ *  @param w UI window.
+ */
+void
+ProcessorBox::set_processor_ui (boost::shared_ptr<Processor> p, Gtk::Window* w)
+{
+       list<ProcessorWindowProxy*>::iterator i = _processor_window_proxies.begin ();
+        
+        p->set_ui (w);
+        
+       while (i != _processor_window_proxies.end()) {
+               boost::shared_ptr<Processor> t = (*i)->processor().lock ();
+               if (t && t == p) {
+                       (*i)->set (w);
+                       return;
+               }
+
+               ++i;
+       }
+
+       /* we shouldn't get here, because the ProcessorUIList should always contain
+          an entry for each processor.
+       */
+       assert (false);
+}
+
+void
+ProcessorBox::mixer_strip_delivery_changed (boost::weak_ptr<Delivery> w)
+{
+       boost::shared_ptr<Delivery> d = w.lock ();
+       if (!d) {
+               return;
+       }
+
+       list<ProcessorEntry*> children = processor_display.children ();
+       list<ProcessorEntry*>::const_iterator i = children.begin();
+       while (i != children.end() && (*i)->processor() != d) {
+               ++i;
+       }
+
+       if (i == children.end()) {
+               processor_display.set_active (0);
+       } else {
+               processor_display.set_active (*i);
+       }
+}
+
+ProcessorWindowProxy::ProcessorWindowProxy (
+       string const & name,
+       XMLNode const * node,
+       ProcessorBox* box,
+       boost::weak_ptr<Processor> processor
+       )
+       : WindowProxy<Gtk::Window> (name, node)
+       , marked (false)
+       , _processor_box (box)
+       , _processor (processor)
+{
+
+}
+
+
+void
+ProcessorWindowProxy::show ()
+{
+       boost::shared_ptr<Processor> p = _processor.lock ();
+       if (!p) {
+               return;
+       }
+
+       _processor_box->toggle_edit_processor (p);
+}
+